From 81ae4974e35aa8ca408abd6238eb768f5c948287 Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Fri, 8 Feb 2019 15:18:26 +0330 Subject: [PATCH 1/6] [ci] Add a Void Linux bot https://voidlinux.org/ is yet another and different distro written from scratch, thus completely eligible to have a bot here! Seriously however not that useful yet however but I will try to overload it other tasks later, like our other bots. No test yet also, couldn't install cairo-devel, will try to fix that later. Their harfbuzz package source: https://github.com/void-linux/void-packages/blob/master/srcpkgs/harfbuzz/template --- .circleci/config.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index ca73f81ef..82e77e5f1 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -63,13 +63,21 @@ jobs: - image: base/devel steps: - checkout - - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip + - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip make - run: pip install flake8 fonttools - run: flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics # C??FLAGS are not needed for a regular build - run: ./autogen.sh --with-freetype --with-glib --with-gobject --with-cairo --with-icu --with-graphite2 - run: make -j32 CPPFLAGS="-Werror" - run: make check CPPFLAGS="-Werror" || .ci/fail.sh + + void-notest: + docker: + - image: voidlinux/voidlinux + steps: + - checkout + - run: xbps-install -Suy freetype gettext gcc glib graphite pkg-config ragel libtool autoconf automake make + - run: ./autogen.sh && make -j32 && make check clang-O3-O0: docker: @@ -307,6 +315,7 @@ workflows: # autotools based builds - alpine-O3-NOMMAP - archlinux-py3-all + - void-notest - gcc-valgrind - clang-O3-O0 - clang-everything From 84694af723bde07cf3231ed2d2e193123f5f73ed Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Fri, 8 Feb 2019 15:30:17 +0330 Subject: [PATCH 2/6] [ci] Disable the just added bot Doesn't play well with CircleCI apparently https://circleci.com/gh/harfbuzz/harfbuzz/74289 --- .circleci/config.yml | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 82e77e5f1..8394cbf73 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -70,14 +70,15 @@ jobs: - run: ./autogen.sh --with-freetype --with-glib --with-gobject --with-cairo --with-icu --with-graphite2 - run: make -j32 CPPFLAGS="-Werror" - run: make check CPPFLAGS="-Werror" || .ci/fail.sh - - void-notest: - docker: - - image: voidlinux/voidlinux - steps: - - checkout - - run: xbps-install -Suy freetype gettext gcc glib graphite pkg-config ragel libtool autoconf automake make - - run: ./autogen.sh && make -j32 && make check + + ## Doesn't play well with CircleCI apparently + #void-notest: + # docker: + # - image: voidlinux/voidlinux + # steps: + # - checkout + # - run: xbps-install -Suy freetype gettext gcc glib graphite pkg-config ragel libtool autoconf automake make + # - run: ./autogen.sh && make -j32 && make check clang-O3-O0: docker: @@ -315,7 +316,7 @@ workflows: # autotools based builds - alpine-O3-NOMMAP - archlinux-py3-all - - void-notest + #- void-notest - gcc-valgrind - clang-O3-O0 - clang-everything From 02294349618037f59b32834b49880ca75ed96261 Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Sat, 9 Feb 2019 16:33:28 +0330 Subject: [PATCH 3/6] [ci] Speculative fix for Alpine and ArchLinux bots --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 8394cbf73..4fb05c307 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -52,7 +52,7 @@ jobs: - image: alpine steps: - checkout - - run: apk update && apk add ragel make pkgconfig libtool autoconf automake gettext gcc g++ glib-dev freetype-dev cairo-dev + - run: apk update && apk add ragel make pkgconfig libtool autoconf automake gettext gcc g++ glib-dev freetype-dev cairo-dev python # C??FLAGS are not needed for a regular build - run: CFLAGS="-O3" CXXFLAGS="-O3 -DHB_NO_MMAP" ./autogen.sh - run: make -j32 @@ -60,7 +60,7 @@ jobs: archlinux-py3-all: docker: - - image: base/devel + - image: archlinux/base steps: - checkout - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip make From 8f4eb919bd0498e997852aa39656adc4c65b3f0e Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Sat, 9 Feb 2019 16:58:02 +0330 Subject: [PATCH 4/6] [ci] Install 'which' in ArchLinux bot --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 4fb05c307..e18cf602d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -63,7 +63,7 @@ jobs: - image: archlinux/base steps: - checkout - - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip make + - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip make which - run: pip install flake8 fonttools - run: flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics # C??FLAGS are not needed for a regular build From f55e7bf5835c59e478d6a448327d53027c4e9f4a Mon Sep 17 00:00:00 2001 From: Ebrahim Byagowi Date: Sun, 10 Feb 2019 01:08:05 +0330 Subject: [PATCH 5/6] [ci] Install 'base-devel' on ArchLinux CI bot --- .circleci/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index e18cf602d..e05f4bc5d 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -63,7 +63,7 @@ jobs: - image: archlinux/base steps: - checkout - - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip make which + - run: pacman --noconfirm -Syu freetype2 cairo icu gettext gobject-introspection gcc gcc-libs glib2 graphite pkg-config ragel python python-pip make which base-devel - run: pip install flake8 fonttools - run: flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics # C??FLAGS are not needed for a regular build From fdfa3d29b7c347b5038f4f9148428c80dde462ae Mon Sep 17 00:00:00 2001 From: Ken <21211439+kencu@users.noreply.github.com> Date: Sun, 10 Feb 2019 23:46:05 -0800 Subject: [PATCH 6/6] hb-coretext.cc: remove TARGET_OS_MAC from test (#1578) it is always true when building on APPLE systems and this file only builds on APPLE systems --- src/hb-coretext.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/hb-coretext.cc b/src/hb-coretext.cc index 6d0015151..598930678 100644 --- a/src/hb-coretext.cc +++ b/src/hb-coretext.cc @@ -171,7 +171,7 @@ create_ct_font (CGFontRef cg_font, CGFloat font_size) if (CFStringHasPrefix (cg_postscript_name, CFSTR (".SFNSText")) || CFStringHasPrefix (cg_postscript_name, CFSTR (".SFNSDisplay"))) { -#if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1080 +#if !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1080 # define kCTFontUIFontSystem kCTFontSystemFontType # define kCTFontUIFontEmphasizedSystem kCTFontEmphasizedSystemFontType #endif @@ -214,7 +214,7 @@ create_ct_font (CGFontRef cg_font, CGFloat font_size) } CFURLRef original_url = nullptr; -#if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1060 +#if !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1060 ATSFontRef atsFont; FSRef fsref; OSStatus status; @@ -244,7 +244,7 @@ create_ct_font (CGFontRef cg_font, CGFloat font_size) * process in Blink. This can be detected by the new file URL location * that the newly found font points to. */ CFURLRef new_url = nullptr; -#if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1060 +#if !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1060 atsFont = CTFontGetPlatformFont (new_ct_font, NULL); status = ATSFontGetFileReference (atsFont, &fsref); if (status == noErr) @@ -711,7 +711,7 @@ resize_and_retry: /* What's the iOS equivalent of this check? * The symbols was introduced in iOS 7.0. * At any rate, our fallback is safe and works fine. */ -#if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1090 +#if !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1090 # define kCTLanguageAttributeName CFSTR ("NSLanguage") #endif CFStringRef lang = CFStringCreateWithCStringNoCopy (kCFAllocatorDefault, @@ -783,7 +783,7 @@ resize_and_retry: int level = HB_DIRECTION_IS_FORWARD (buffer->props.direction) ? 0 : 1; CFNumberRef level_number = CFNumberCreate (kCFAllocatorDefault, kCFNumberIntType, &level); -#if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1060 +#if !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE) && MAC_OS_X_VERSION_MIN_REQUIRED < 1060 extern const CFStringRef kCTTypesetterOptionForcedEmbeddingLevel; #endif CFDictionaryRef options = CFDictionaryCreate (kCFAllocatorDefault,