Fix undefined behavior in cmp function

Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93274
9 years ago · 255df68012
parent fcf9e61bad
commit 255df68012
1 changed files with 2 additions and 1 deletions
--- a/src/hb-ot-map-private.hh
+++ b/src/hb-ot-map-private.hh
@ -203,7 +203,8 @@ struct hb_ot_map_builder_t
    unsigned int stage[2]; /* GSUB/GPOS */

    static int cmp (const feature_info_t *a, const feature_info_t *b)
-    { return (a->tag != b->tag) ?  (a->tag < b->tag ? -1 : 1) : (a->seq < b->seq ? -1 : 1); }
+    { return (a->tag != b->tag) ?  (a->tag < b->tag ? -1 : 1) :
+	     (a->seq < b->seq ? -1 : a->seq > b->seq ? 1 : 0); }
  };

  struct stage_info_t {