grpc/include at 34a0318dbf2407caf5f3cdd7857b487aba3f5e7f - grpc

The C based gRPC (C++, Python, Ruby, Objective-C, PHP, C#) https://grpc.io/

Tag: Branch: Tree: 34a0318dbf

Tanvi Jagtap 4c9db803a2 [Gpr_To_Absl_Logging] Fixing bugs (#36961 ) ### Problem 1 Context : gpr_log() internally calls gpr_log_message() . gpr_log_message() may either call gpr_default_log() or a user provided logging function. gpr_default_log() uses absl LOG. This is the default. Most users will log this way. For the small percentage of users who have customized the logging function, gpr_log will log to custom this function. Problem : We have converted half the instances of gpr_log to absl LOG(). For users who use the defaults - there will be no issue. For the users who use a customized logging function 1. All the absl LOGs will log to the absl log sink. 2. All the gpr_log statements will log via this user provided function. This is in-consistent behaviour and will cause confusion and difficulty in debugging. Solution: All logs should go to the same sink. So we decided to make gpr_set_log_function a no op in this release. The function will be deleted in the next release. https://github.com/grpc/proposal/pull/425 ### Problem 2 Context : gpr_should_log is used to avoid computing expensive stuff for logging if the log is not going to be visible. Problem : gpr_should_log was referencing the GRPC_VERBOSITY flag and values set by gpr_set_log_verbosity . However, actual logging happens based on the absl settings. This is incorrect. Because if the old settings are not honoured, they should not be checked and no decision in code should be made based on settings which are not going to get used. Solution : Given the above changes in Problem 1, since all custom logging is disabled, all logging from gRPC with honour the absl LOG settings. Hence we modified the gpr_should_log function to refer to absl settings. ### Problem 3 We still have the issue of php using a custom log sink. We will address this in a separate PR. ### Problem 4 Tests related to test/core/end2end/tests/no_logging.cc are broken . These will be fixed in another PR. Closes #36961 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36961 from tanvi-jagtap:fix_gpr_should_log `70c3224af1` PiperOrigin-RevId: 645096418		5 months ago
..
grpc	[Gpr_To_Absl_Logging] Fixing bugs (#36961 )	5 months ago
grpc++	[clang-format] Remove requirement that port_platform.h is at the top (#36278 )	8 months ago
grpcpp	[Release] Bump version to 1.66.0-dev (on master branch) (#36892 )	5 months ago