/* * * Copyright 2017 gRPC authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. * */ #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include #include "test/cpp/util/subprocess.h" #include "test/cpp/util/test_config.h" #include "src/core/ext/filters/client_channel/client_channel.h" #include "src/core/ext/filters/client_channel/resolver.h" #include "src/core/ext/filters/client_channel/resolver/dns/c_ares/grpc_ares_wrapper.h" #include "src/core/ext/filters/client_channel/resolver_registry.h" #include "src/core/ext/filters/client_channel/server_address.h" #include "src/core/lib/channel/channel_args.h" #include "src/core/lib/gpr/env.h" #include "src/core/lib/gpr/host_port.h" #include "src/core/lib/gpr/string.h" #include "src/core/lib/gprpp/orphanable.h" #include "src/core/lib/iomgr/combiner.h" #include "src/core/lib/iomgr/executor.h" #include "src/core/lib/iomgr/iomgr.h" #include "src/core/lib/iomgr/resolve_address.h" #include "src/core/lib/iomgr/sockaddr_utils.h" #include "test/core/util/port.h" #include "test/core/util/test_config.h" // TODO: pull in different headers when enabling this // test on windows. Also set BAD_SOCKET_RETURN_VAL // to INVALID_SOCKET on windows. #ifdef GPR_WINDOWS #include "src/core/lib/iomgr/sockaddr_windows.h" #include "src/core/lib/iomgr/socket_windows.h" #include "src/core/lib/iomgr/tcp_windows.h" #define BAD_SOCKET_RETURN_VAL INVALID_SOCKET #else #include "src/core/lib/iomgr/sockaddr_posix.h" #define BAD_SOCKET_RETURN_VAL -1 #endif using grpc::SubProcess; using std::vector; using testing::UnorderedElementsAreArray; // Hack copied from "test/cpp/end2end/server_crash_test_client.cc"! // In some distros, gflags is in the namespace google, and in some others, // in gflags. This hack is enabling us to find both. namespace google {} namespace gflags {} using namespace google; using namespace gflags; DEFINE_string(target_name, "", "Target name to resolve."); DEFINE_string(expected_addrs, "", "List of expected backend or balancer addresses in the form " "',;,;...'. " "'is_balancer' should be bool, i.e. true or false."); DEFINE_string(expected_chosen_service_config, "", "Expected service config json string that gets chosen (no " "whitespace). Empty for none."); DEFINE_string( local_dns_server_address, "", "Optional. This address is placed as the uri authority if present."); DEFINE_string( enable_srv_queries, "", "Whether or not to enable SRV queries for the ares resolver instance." "It would be better if this arg could be bool, but the way that we " "generate " "the python script runner doesn't allow us to pass a gflags bool to this " "binary."); DEFINE_string( enable_txt_queries, "", "Whether or not to enable TXT queries for the ares resolver instance." "It would be better if this arg could be bool, but the way that we " "generate " "the python script runner doesn't allow us to pass a gflags bool to this " "binary."); DEFINE_string(expected_lb_policy, "", "Expected lb policy name that appears in resolver result channel " "arg. Empty for none."); namespace { class GrpcLBAddress final { public: GrpcLBAddress(std::string address, bool is_balancer) : is_balancer(is_balancer), address(std::move(address)) {} bool operator==(const GrpcLBAddress& other) const { return this->is_balancer == other.is_balancer && this->address == other.address; } bool operator!=(const GrpcLBAddress& other) const { return !(*this == other); } bool is_balancer; std::string address; }; vector ParseExpectedAddrs(std::string expected_addrs) { std::vector out; while (expected_addrs.size() != 0) { // get the next , (v4 or v6) size_t next_comma = expected_addrs.find(','); if (next_comma == std::string::npos) { gpr_log(GPR_ERROR, "Missing ','. Expected_addrs arg should be a semicolon-separated " "list of , pairs. Left-to-be-parsed arg is |%s|", expected_addrs.c_str()); abort(); } std::string next_addr = expected_addrs.substr(0, next_comma); expected_addrs = expected_addrs.substr(next_comma + 1, std::string::npos); // get the next is_balancer 'bool' associated with this address size_t next_semicolon = expected_addrs.find(';'); bool is_balancer = gpr_is_true(expected_addrs.substr(0, next_semicolon).c_str()); out.emplace_back(GrpcLBAddress(next_addr, is_balancer)); if (next_semicolon == std::string::npos) { break; } expected_addrs = expected_addrs.substr(next_semicolon + 1, std::string::npos); } if (out.size() == 0) { gpr_log(GPR_ERROR, "expected_addrs arg should be a semicolon-separated list of " ", pairs"); abort(); } return out; } gpr_timespec TestDeadline(void) { return grpc_timeout_seconds_to_deadline(100); } struct ArgsStruct { gpr_event ev; gpr_atm done_atm; gpr_mu* mu; grpc_pollset* pollset; grpc_pollset_set* pollset_set; grpc_combiner* lock; grpc_channel_args* channel_args; vector expected_addrs; std::string expected_service_config_string; std::string expected_lb_policy; }; void ArgsInit(ArgsStruct* args) { gpr_event_init(&args->ev); args->pollset = (grpc_pollset*)gpr_zalloc(grpc_pollset_size()); grpc_pollset_init(args->pollset, &args->mu); args->pollset_set = grpc_pollset_set_create(); grpc_pollset_set_add_pollset(args->pollset_set, args->pollset); args->lock = grpc_combiner_create(); gpr_atm_rel_store(&args->done_atm, 0); args->channel_args = nullptr; } void DoNothing(void* arg, grpc_error* error) {} void ArgsFinish(ArgsStruct* args) { GPR_ASSERT(gpr_event_wait(&args->ev, TestDeadline())); grpc_pollset_set_del_pollset(args->pollset_set, args->pollset); grpc_pollset_set_destroy(args->pollset_set); grpc_closure DoNothing_cb; GRPC_CLOSURE_INIT(&DoNothing_cb, DoNothing, nullptr, grpc_schedule_on_exec_ctx); grpc_pollset_shutdown(args->pollset, &DoNothing_cb); // exec_ctx needs to be flushed before calling grpc_pollset_destroy() grpc_channel_args_destroy(args->channel_args); grpc_core::ExecCtx::Get()->Flush(); grpc_pollset_destroy(args->pollset); gpr_free(args->pollset); GRPC_COMBINER_UNREF(args->lock, nullptr); } gpr_timespec NSecondDeadline(int seconds) { return gpr_time_add(gpr_now(GPR_CLOCK_REALTIME), gpr_time_from_seconds(seconds, GPR_TIMESPAN)); } void PollPollsetUntilRequestDone(ArgsStruct* args) { gpr_timespec deadline = NSecondDeadline(10); while (true) { bool done = gpr_atm_acq_load(&args->done_atm) != 0; if (done) { break; } gpr_timespec time_left = gpr_time_sub(deadline, gpr_now(GPR_CLOCK_REALTIME)); gpr_log(GPR_DEBUG, "done=%d, time_left=%" PRId64 ".%09d", done, time_left.tv_sec, time_left.tv_nsec); GPR_ASSERT(gpr_time_cmp(time_left, gpr_time_0(GPR_TIMESPAN)) >= 0); grpc_pollset_worker* worker = nullptr; grpc_core::ExecCtx exec_ctx; gpr_mu_lock(args->mu); GRPC_LOG_IF_ERROR("pollset_work", grpc_pollset_work(args->pollset, &worker, grpc_timespec_to_millis_round_up( NSecondDeadline(1)))); gpr_mu_unlock(args->mu); } gpr_event_set(&args->ev, (void*)1); } void CheckServiceConfigResultLocked(const char* service_config_json, ArgsStruct* args) { if (args->expected_service_config_string != "") { GPR_ASSERT(service_config_json != nullptr); EXPECT_EQ(service_config_json, args->expected_service_config_string); } else { GPR_ASSERT(service_config_json == nullptr); } } void CheckLBPolicyResultLocked(const grpc_channel_args* channel_args, ArgsStruct* args) { const grpc_arg* lb_policy_arg = grpc_channel_args_find(channel_args, GRPC_ARG_LB_POLICY_NAME); if (args->expected_lb_policy != "") { GPR_ASSERT(lb_policy_arg != nullptr); GPR_ASSERT(lb_policy_arg->type == GRPC_ARG_STRING); EXPECT_EQ(lb_policy_arg->value.string, args->expected_lb_policy); } else { GPR_ASSERT(lb_policy_arg == nullptr); } } #ifdef GPR_WINDOWS void OpenAndCloseSocketsStressLoop(int dummy_port, gpr_event* done_ev) { sockaddr_in6 addr; memset(&addr, 0, sizeof(addr)); addr.sin6_family = AF_INET6; addr.sin6_port = htons(dummy_port); ((char*)&addr.sin6_addr)[15] = 1; for (;;) { if (gpr_event_get(done_ev)) { return; } std::vector sockets; for (size_t i = 0; i < 50; i++) { SOCKET s = WSASocket(AF_INET6, SOCK_STREAM, IPPROTO_TCP, nullptr, 0, WSA_FLAG_OVERLAPPED); ASSERT_TRUE(s != BAD_SOCKET_RETURN_VAL) << "Failed to create TCP ipv6 socket"; gpr_log(GPR_DEBUG, "Opened socket: %d", s); char val = 1; ASSERT_TRUE(setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)) != SOCKET_ERROR) << "Failed to set socketopt reuseaddr. WSA error: " + std::to_string(WSAGetLastError()); ASSERT_TRUE(grpc_tcp_set_non_block(s) == GRPC_ERROR_NONE) << "Failed to set socket non-blocking"; ASSERT_TRUE(bind(s, (const sockaddr*)&addr, sizeof(addr)) != SOCKET_ERROR) << "Failed to bind socket " + std::to_string(s) + " to [::1]:" + std::to_string(dummy_port) + ". WSA error: " + std::to_string(WSAGetLastError()); ASSERT_TRUE(listen(s, 1) != SOCKET_ERROR) << "Failed to listen on socket " + std::to_string(s) + ". WSA error: " + std::to_string(WSAGetLastError()); sockets.push_back(s); } // Do a non-blocking accept followed by a close on all of those sockets. // Do this in a separate loop to try to induce a time window to hit races. for (size_t i = 0; i < sockets.size(); i++) { gpr_log(GPR_DEBUG, "non-blocking accept then close on %d", sockets[i]); ASSERT_TRUE(accept(sockets[i], nullptr, nullptr) == INVALID_SOCKET) << "Accept on dummy socket unexpectedly accepted actual connection."; ASSERT_TRUE(WSAGetLastError() == WSAEWOULDBLOCK) << "OpenAndCloseSocketsStressLoop accept on socket " + std::to_string(sockets[i]) + " failed in " "an unexpected way. " "WSA error: " + std::to_string(WSAGetLastError()) + ". Socket use-after-close bugs are likely."; ASSERT_TRUE(closesocket(sockets[i]) != SOCKET_ERROR) << "Failed to close socket: " + std::to_string(sockets[i]) + ". WSA error: " + std::to_string(WSAGetLastError()); } } return; } #else void OpenAndCloseSocketsStressLoop(int dummy_port, gpr_event* done_ev) { // The goal of this loop is to catch socket // "use after close" bugs within the c-ares resolver by acting // like some separate thread doing I/O. // It's goal is to try to hit race conditions whereby: // 1) The c-ares resolver closes a socket. // 2) This loop opens a socket with (coincidentally) the same handle. // 3) the c-ares resolver mistakenly uses that same socket without // realizing that its closed. // 4) This loop performs an operation on that socket that should // succeed but instead fails because of what the c-ares // resolver did in the meantime. sockaddr_in6 addr; memset(&addr, 0, sizeof(addr)); addr.sin6_family = AF_INET6; addr.sin6_port = htons(dummy_port); ((char*)&addr.sin6_addr)[15] = 1; for (;;) { if (gpr_event_get(done_ev)) { return; } std::vector sockets; // First open a bunch of sockets, bind and listen // '50' is an arbitrary number that, experimentally, // has a good chance of catching bugs. for (size_t i = 0; i < 50; i++) { int s = socket(AF_INET6, SOCK_STREAM, 0); int val = 1; ASSERT_TRUE(setsockopt(s, SOL_SOCKET, SO_REUSEPORT, &val, sizeof(val)) == 0) << "Failed to set socketopt reuseport"; ASSERT_TRUE(setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &val, sizeof(val)) == 0) << "Failed to set socket reuseaddr"; ASSERT_TRUE(fcntl(s, F_SETFL, O_NONBLOCK) == 0) << "Failed to set socket non-blocking"; ASSERT_TRUE(s != BAD_SOCKET_RETURN_VAL) << "Failed to create TCP ipv6 socket"; gpr_log(GPR_DEBUG, "Opened fd: %d", s); ASSERT_TRUE(bind(s, (const sockaddr*)&addr, sizeof(addr)) == 0) << "Failed to bind socket " + std::to_string(s) + " to [::1]:" + std::to_string(dummy_port) + ". errno: " + std::to_string(errno); ASSERT_TRUE(listen(s, 1) == 0) << "Failed to listen on socket " + std::to_string(s) + ". errno: " + std::to_string(errno); sockets.push_back(s); } // Do a non-blocking accept followed by a close on all of those sockets. // Do this in a separate loop to try to induce a time window to hit races. for (size_t i = 0; i < sockets.size(); i++) { gpr_log(GPR_DEBUG, "non-blocking accept then close on %d", sockets[i]); if (accept(sockets[i], nullptr, nullptr)) { // If e.g. a "shutdown" was called on this fd from another thread, // then this accept call should fail with an unexpected error. ASSERT_TRUE(errno == EAGAIN || errno == EWOULDBLOCK) << "OpenAndCloseSocketsStressLoop accept on socket " + std::to_string(sockets[i]) + " failed in " "an unexpected way. " "errno: " + std::to_string(errno) + ". Socket use-after-close bugs are likely."; } ASSERT_TRUE(close(sockets[i]) == 0) << "Failed to close socket: " + std::to_string(sockets[i]) + ". errno: " + std::to_string(errno); } } } #endif class ResultHandler : public grpc_core::Resolver::ResultHandler { public: static grpc_core::UniquePtr Create( ArgsStruct* args) { return grpc_core::UniquePtr( grpc_core::New(args)); } explicit ResultHandler(ArgsStruct* args) : args_(args) {} void ReturnResult(grpc_core::Resolver::Result result) override { CheckResult(result); gpr_atm_rel_store(&args_->done_atm, 1); gpr_mu_lock(args_->mu); GRPC_LOG_IF_ERROR("pollset_kick", grpc_pollset_kick(args_->pollset, nullptr)); gpr_mu_unlock(args_->mu); } void ReturnError(grpc_error* error) override { gpr_log(GPR_ERROR, "resolver returned error: %s", grpc_error_string(error)); GPR_ASSERT(false); } virtual void CheckResult(const grpc_core::Resolver::Result& result) {} protected: ArgsStruct* args_struct() const { return args_; } private: ArgsStruct* args_; }; class CheckingResultHandler : public ResultHandler { public: static grpc_core::UniquePtr Create( ArgsStruct* args) { return grpc_core::UniquePtr( grpc_core::New(args)); } explicit CheckingResultHandler(ArgsStruct* args) : ResultHandler(args) {} void CheckResult(const grpc_core::Resolver::Result& result) override { ArgsStruct* args = args_struct(); gpr_log(GPR_INFO, "num addrs found: %" PRIdPTR ". expected %" PRIdPTR, result.addresses.size(), args->expected_addrs.size()); GPR_ASSERT(result.addresses.size() == args->expected_addrs.size()); std::vector found_lb_addrs; for (size_t i = 0; i < result.addresses.size(); i++) { const grpc_core::ServerAddress& addr = result.addresses[i]; char* str; grpc_sockaddr_to_string(&str, &addr.address(), 1 /* normalize */); gpr_log(GPR_INFO, "%s", str); found_lb_addrs.emplace_back( GrpcLBAddress(std::string(str), addr.IsBalancer())); gpr_free(str); } if (args->expected_addrs.size() != found_lb_addrs.size()) { gpr_log(GPR_DEBUG, "found lb addrs size is: %" PRIdPTR ". expected addrs size is %" PRIdPTR, found_lb_addrs.size(), args->expected_addrs.size()); abort(); } EXPECT_THAT(args->expected_addrs, UnorderedElementsAreArray(found_lb_addrs)); const char* service_config_json = result.service_config == nullptr ? nullptr : result.service_config->service_config_json(); CheckServiceConfigResultLocked(service_config_json, args); if (args->expected_service_config_string == "") { CheckLBPolicyResultLocked(result.args, args); } } }; void RunResolvesRelevantRecordsTest( grpc_core::UniquePtr ( *CreateResultHandler)(ArgsStruct* args)) { grpc_core::ExecCtx exec_ctx; ArgsStruct args; ArgsInit(&args); args.expected_addrs = ParseExpectedAddrs(FLAGS_expected_addrs); args.expected_service_config_string = FLAGS_expected_chosen_service_config; args.expected_lb_policy = FLAGS_expected_lb_policy; // maybe build the address with an authority char* whole_uri = nullptr; GPR_ASSERT(gpr_asprintf(&whole_uri, "dns://%s/%s", FLAGS_local_dns_server_address.c_str(), FLAGS_target_name.c_str())); gpr_log(GPR_DEBUG, "resolver_component_test: --enable_srv_queries: %s", FLAGS_enable_srv_queries.c_str()); grpc_channel_args* resolver_args = nullptr; // By default, SRV queries are disabled, so tests that expect no SRV query // should avoid setting any channel arg. Test cases that do rely on the SRV // query must explicitly enable SRV though. if (FLAGS_enable_srv_queries == "True") { grpc_arg srv_queries_arg = grpc_channel_arg_integer_create( const_cast(GRPC_ARG_DNS_ENABLE_SRV_QUERIES), true); resolver_args = grpc_channel_args_copy_and_add(nullptr, &srv_queries_arg, 1); } else if (FLAGS_enable_srv_queries != "False") { gpr_log(GPR_DEBUG, "Invalid value for --enable_srv_queries."); abort(); } gpr_log(GPR_DEBUG, "resolver_component_test: --enable_txt_queries: %s", FLAGS_enable_txt_queries.c_str()); // By default, TXT queries are disabled, so tests that expect no TXT query // should avoid setting any channel arg. Test cases that do rely on the TXT // query must explicitly enable TXT though. if (FLAGS_enable_txt_queries == "True") { // Unlike SRV queries, there isn't a channel arg specific to TXT records. // Rather, we use the resolver-agnostic "service config" resolution option, // for which c-ares has its own specific default value, which isn't // necessarily shared by other resolvers. grpc_arg txt_queries_arg = grpc_channel_arg_integer_create( const_cast(GRPC_ARG_SERVICE_CONFIG_DISABLE_RESOLUTION), false); grpc_channel_args* tmp_args = grpc_channel_args_copy_and_add(resolver_args, &txt_queries_arg, 1); grpc_channel_args_destroy(resolver_args); resolver_args = tmp_args; } else if (FLAGS_enable_txt_queries != "False") { gpr_log(GPR_DEBUG, "Invalid value for --enable_txt_queries."); abort(); } // create resolver and resolve grpc_core::OrphanablePtr resolver = grpc_core::ResolverRegistry::CreateResolver(whole_uri, resolver_args, args.pollset_set, args.lock, CreateResultHandler(&args)); grpc_channel_args_destroy(resolver_args); gpr_free(whole_uri); resolver->StartLocked(); grpc_core::ExecCtx::Get()->Flush(); PollPollsetUntilRequestDone(&args); ArgsFinish(&args); } TEST(ResolverComponentTest, TestResolvesRelevantRecords) { RunResolvesRelevantRecordsTest(CheckingResultHandler::Create); } TEST(ResolverComponentTest, TestResolvesRelevantRecordsWithConcurrentFdStress) { // Start up background stress thread int dummy_port = grpc_pick_unused_port_or_die(); gpr_event done_ev; gpr_event_init(&done_ev); std::thread socket_stress_thread(OpenAndCloseSocketsStressLoop, dummy_port, &done_ev); // Run the resolver test RunResolvesRelevantRecordsTest(ResultHandler::Create); // Shutdown and join stress thread gpr_event_set(&done_ev, (void*)1); socket_stress_thread.join(); } } // namespace int main(int argc, char** argv) { grpc_init(); grpc::testing::TestEnvironment env(argc, argv); ::testing::InitGoogleTest(&argc, argv); ParseCommandLineFlags(&argc, &argv, true); if (FLAGS_target_name == "") { gpr_log(GPR_ERROR, "Missing target_name param."); abort(); } if (FLAGS_local_dns_server_address != "") { gpr_log(GPR_INFO, "Specifying authority in uris to: %s", FLAGS_local_dns_server_address.c_str()); } auto result = RUN_ALL_TESTS(); grpc_shutdown(); return result; }