Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

55846 Commits

298 Branches

385 Tags

1.4 GiB

Tag: Branch: Tree: fcb6d06e01

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Craig Tiller	ec7e4e2a96	[call-v3] Separate out the CallState class from CallFilters (#37003 ) At the same time, inline all state machine functions and move the trace to its own (debug-only) trace var. Before: ``` ---------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations ---------------------------------------------------------------------------------------------------- grpc_core::BM_UnaryWithSpawnPerEnd<CallSpineFixture> 1171 ns 1171 ns 2373821 grpc_core::BM_UnaryWithSpawnPerOp<CallSpineFixture> 1326 ns 1326 ns 2124026 grpc_core::BM_ClientToServerStreaming<CallSpineFixture> 256 ns 256 ns 10512990 grpc_core::BM_UnaryWithSpawnPerEnd<ForwardCallFixture> 2957 ns 2957 ns 949121 grpc_core::BM_UnaryWithSpawnPerOp<ForwardCallFixture> 3172 ns 3172 ns 882463 grpc_core::BM_ClientToServerStreaming<ForwardCallFixture> 500 ns 500 ns 5765914 ``` After: ``` ---------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations ---------------------------------------------------------------------------------------------------- grpc_core::BM_UnaryWithSpawnPerEnd<CallSpineFixture> 1102 ns 1102 ns 2511682 grpc_core::BM_UnaryWithSpawnPerOp<CallSpineFixture> 1263 ns 1263 ns 2264222 grpc_core::BM_ClientToServerStreaming<CallSpineFixture> 252 ns 252 ns 11090774 grpc_core::BM_UnaryWithSpawnPerEnd<ForwardCallFixture> 2855 ns 2855 ns 987991 grpc_core::BM_UnaryWithSpawnPerOp<ForwardCallFixture> 3082 ns 3081 ns 901020 grpc_core::BM_ClientToServerStreaming<ForwardCallFixture> 490 ns 490 ns 5675073 ``` Closes #37003 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37003 from ctiller:excise-the-thing `ab3943e828` PiperOrigin-RevId: 646493946	8 months ago
AJ Heller	c9fdef1317	[logging] Centralize configuration for trace flags (#36576 ) All TraceFlags are now configured in `src/core/lib/debug/trace_flags.yaml`. The format is: ``` my_flag: default: false # the default value; default=false description: Some Description debug_only: false # debug_only flags only work in debug builds; default=false internal: false # internal flags will not show up in documentation; default=false ``` To regenerate the trace flag source code, run `tools/codegen/core/gen_trace_flags.py` (requires mako). This script is also run when sanity checking. This PR also adds two new features: ### Glob-based flag configuration Trace flag configuration now supports `?` (single wildcard character) and `` (one or more wildcard characters). For example, using `GRPC_TRACE='event_engine'` will enable all flags that match that glob. It expands to: * event_engine * event_engine_client_channel_resolver * event_engine_dns * event_engine_endpoint * event_engine_endpoint_data * event_engine_poller ### A cleaner trace-logging macro in abseil logging format If your goal is only to add log statements when the `fault_injection_filter` trace flag is enabled, you can use the macro: ``` GRPC_TRACE_LOG(fault_injection, INFO) << "Filtered:" << 42; ``` When the trace flag is enabled, the the log will show something like this: ``` I0000 00:00:1715733657.430042 16 file.cc:174] Filtered:42 ``` ---- Note: just like with the gpr_log to abseil logging conversion, the pre-existing trace logging usages can be replaced with the new tracing macro across multiple PRs. Closes #36576 PiperOrigin-RevId: 641295215	9 months ago

Craig Tiller

ec7e4e2a96

[call-v3] Separate out the CallState class from CallFilters (#37003 )

At the same time, inline all state machine functions and move the trace to its own (debug-only) trace var.

Before:
```
----------------------------------------------------------------------------------------------------
Benchmark                                                          Time             CPU   Iterations
----------------------------------------------------------------------------------------------------
grpc_core::BM_UnaryWithSpawnPerEnd<CallSpineFixture>            1171 ns         1171 ns      2373821
grpc_core::BM_UnaryWithSpawnPerOp<CallSpineFixture>             1326 ns         1326 ns      2124026
grpc_core::BM_ClientToServerStreaming<CallSpineFixture>          256 ns          256 ns     10512990
grpc_core::BM_UnaryWithSpawnPerEnd<ForwardCallFixture>          2957 ns         2957 ns       949121
grpc_core::BM_UnaryWithSpawnPerOp<ForwardCallFixture>           3172 ns         3172 ns       882463
grpc_core::BM_ClientToServerStreaming<ForwardCallFixture>        500 ns          500 ns      5765914
```

After:
```
----------------------------------------------------------------------------------------------------
Benchmark                                                          Time             CPU   Iterations
----------------------------------------------------------------------------------------------------
grpc_core::BM_UnaryWithSpawnPerEnd<CallSpineFixture>            1102 ns         1102 ns      2511682
grpc_core::BM_UnaryWithSpawnPerOp<CallSpineFixture>             1263 ns         1263 ns      2264222
grpc_core::BM_ClientToServerStreaming<CallSpineFixture>          252 ns          252 ns     11090774
grpc_core::BM_UnaryWithSpawnPerEnd<ForwardCallFixture>          2855 ns         2855 ns       987991
grpc_core::BM_UnaryWithSpawnPerOp<ForwardCallFixture>           3082 ns         3081 ns       901020
grpc_core::BM_ClientToServerStreaming<ForwardCallFixture>        490 ns          490 ns      5675073
```

Closes #37003

COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37003 from ctiller:excise-the-thing ab3943e828
PiperOrigin-RevId: 646493946

8 months ago

AJ Heller

c9fdef1317

[logging] Centralize configuration for trace flags (#36576 )

All TraceFlags are now configured in `src/core/lib/debug/trace_flags.yaml`. The format is:

```
my_flag:
  default: false                   # the default value; default=false
  description: Some Description
  debug_only: false                # debug_only flags only work in debug builds; default=false
  internal: false                  # internal flags will not show up in documentation; default=false
```

To regenerate the trace flag source code, run `tools/codegen/core/gen_trace_flags.py` (requires mako). This script is also run when sanity checking.

This PR also adds two new features:

### Glob-based flag configuration

Trace flag configuration now supports `?` (single wildcard character) and `*` (one or more wildcard characters).  For example, using `GRPC_TRACE='event_engine*'` will enable all flags that match that glob. It expands to:

* event_engine
* event_engine_client_channel_resolver
* event_engine_dns
* event_engine_endpoint
* event_engine_endpoint_data
* event_engine_poller

### A cleaner trace-logging macro in abseil logging format

If your goal is only to add log statements when the `fault_injection_filter` trace flag is enabled, you can use the macro:

```
GRPC_TRACE_LOG(fault_injection, INFO) << "Filtered:" << 42;
```

When the trace flag is enabled, the the log will show something like this:
```
I0000 00:00:1715733657.430042      16 file.cc:174] Filtered:42
```

----

Note: just like with the gpr_log to abseil logging conversion, the pre-existing trace logging usages can be replaced with the new tracing macro across multiple PRs.

Closes #36576

PiperOrigin-RevId: 641295215

9 months ago

2 Commits (fcb6d06e01723246ca8ed5e32ca75838bd6f1b5f)