Mark D. Roth
f4edc883ab
service config API: use absl::Status instead of grpc_error ( #30321 )
...
* service config API: use absl::Status instead of grpc_error
* Automated change: Fix sanity tests
* add missing build deps
* attempt to work around build breakage on older compilers
* trying the work-around in more spots
* more work-arounds
* more workarounds
* Automated change: Fix sanity tests
* work around another compiler problem
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2 years ago
Craig Tiller
d304712f64
[channel_args] Spread grpc_core::ChannelArgs through client channel code ( #30008 )
...
* [channel_args] Spread grpc_core::ChannelArgs through client channel code
* progress
* progress
* grpc compiles
* uniqueptr+compiles
* fix
* fix
* fix
* fix
* fix
* fix
* fixes
* fix
* fix
* fixes
* fix-lb
* fix
* fix up arg construction
* fix
* fix
* fix
* fix
* move to const& to save bytes
* fix
* fix
* progress
* review feedback
* fix
* fix
* fixes
* fixes
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* debug-helper
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Esun Kim
c6ebbb5482
Added GRPC_ERROR_IS_NONE ( #29937 )
...
* Added GRPC_ERROR_IS_NONE
* Convert
* Fix
3 years ago
AJ Heller
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
Craig Tiller
87acbadba1
Third attempt: Convert client_auth_filter to promises ( #28968 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* Revert "Revert "Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )" (#28952 )" (#28967 )"
This reverts commit 0f73576b17
.
* fix potential memory leak
* Fix behavior if >1 pending request
* fix
* fix nullptr access
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
0f73576b17
Revert "Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )" ( #28967 )
...
This reverts commit 235098de22
.
3 years ago
Craig Tiller
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
235098de22
Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )
...
* Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )"
This reverts commit 5bfe38f10f
.
* fix
3 years ago
Craig Tiller
5bfe38f10f
Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )
...
This reverts commit cadce47ebf
.
3 years ago
Craig Tiller
cadce47ebf
Convert client_auth_filter to promises ( #28767 )
...
* Convert client_auth_filter to promises
* outline
* x
* x
* fixes
* remove-spam
* Async sequences over iterators
* iterate
* better semantics
* fix
* clang-tidy
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* progress
* progress
* progress
* progress
* credentials_test passes
* Automated change: Fix sanity tests
* Make Activity more of an interface
Move mutex and wakeup logic into a new class between PromiseActivity<>
and Activity (so that the sharing can persist), but make Activity closer
to a pure interface, so that whilst we migrate code we can implement
better fakes without forcing allocation.
* fixes
* Automated change: Fix sanity tests
* fixes
* test the awful failure
* x
* fix typo
* fix race
* 4.9
* x
* review feedback
* review feedback
* Automated change: Fix sanity tests
* review feedback
* replace AuthMetadataContext interface with GetRequestMetadataArgs struct
* Automated change: Fix sanity tests
* fix merge
* Fixup
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
AJ Heller
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
AJ Heller
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
.
3 years ago
AJ Heller
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
AJ Heller
40f2c2a4e1
Upgrade googletest ( #27287 )
3 years ago
yihuaz
b458db9246
Eliminate gRPC insecure build ( #25586 )
...
* force submit
* fix test error
* remove is_client from local tsi and its callsites
* fix too_many_pings_test
* add missing dep
3 years ago
Craig Tiller
55b365f287
Move resolver code around a little ( #27846 )
...
* move service config
* service config should not depend on grpc_base
* move resolver, deal with fallout
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* review feedback
* review feedback
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix vis
* fix
* fixes
* Automated change: Fix sanity tests
* visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Mark D. Roth
6339b03ada
Revert "Revert "start splitting up xds_end2end_test ( #27702 )" ( #27725 )" ( #27726 )
...
This reverts commit 9177c5324a
.
3 years ago
Mark D. Roth
9177c5324a
Revert "start splitting up xds_end2end_test ( #27702 )" ( #27725 )
...
This reverts commit 69a978231b
.
3 years ago
Mark D. Roth
69a978231b
start splitting up xds_end2end_test ( #27702 )
...
* move test xDS server to its own library
* move xds_end2end_test to xds subdir, and refactor CountedService
* add TODO
* fix sanity
3 years ago
Mark D. Roth
2b813d2bff
grpclb: implement subchannel caching ( #27657 )
...
* grpclb: implement subchannel caching
* code review changes
* fix clang tidy
* code review changes
3 years ago
Yash Tibrewal
a61bb8ed5b
Move service config code out of client_client to its own target ( #27683 )
...
* Move service config code out of client_client to its own target
* Fix BUILD
* Fix test build
* Reviewer comments
* Reviewer comments
* Automated change: Fix sanity tests
* Reviewer comments
Co-authored-by: yashykt <yashykt@users.noreply.github.com>
3 years ago
Mark D. Roth
3d83dd3776
Revert "Revert "centralize handling of channel's default authority ( #27544 )" ( #27616 )" ( #27624 )
...
This reverts commit 0611f7c9b3
.
3 years ago
Mark D. Roth
0611f7c9b3
Revert "centralize handling of channel's default authority ( #27544 )" ( #27616 )
...
This reverts commit f0a0628795
.
3 years ago
Mark D. Roth
f0a0628795
centralize handling of channel's default authority ( #27544 )
...
* centralize handling of channel's default authority
* clang-format
* fix backup poller bug
3 years ago
Craig Tiller
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
AJ Heller
6ba4a92af7
Reorder gtest/gmock headers ( #27070 )
...
Per the style guide (or spirit thereof), these should be placed with the other external/third_party headers.
3 years ago
AJ Heller
58f8f5ced3
Add macro to define gtest death_test_style using an older syntax ( #27042 )
...
This temporarily unblocks a related gtest upgrade. The ultimate goal is
to upgraade our gtest dependencies, but I don't have the cycles to
manage a potentially messy migration until at least next week. This PR
is coordinated with an internal change.
3 years ago
Tamir Duberstein
013e67a029
Deprecate grpc{_core,::internal}::WaitUntil ( #26866 )
...
It is not possible for such a function to be implemented in a way that
is understood by annotalysis. Mark it deprecated and replace instances
of its use with direct mutex/condvar usage.
Add a bunch of missing thread safety annotations while I'm here.
3 years ago
Mark D. Roth
6b71ec3704
LB policy API improvements ( #26481 )
...
* LB policy API improvements
* clang-format
* fix build
* a bit more cleanup
* use absl::variant<> for pick result
* fix retry_lb_drop test
* clang-format
* fix grpclb_end2end_test
* fix xds_end2end_test
* try to make variant code a bit cleaner
* clang-format
* fix memory leak
* fix build
* clang-format
* fix error refcount bug
* remove PickResult factory functions
* clang-format
* add ctors to structs
* clang-format
* fix clang-tidy
* update comments
* move LB recv_trailing_metadata callback instead of copying it
* use Match() instead of providing PickResult::Handle()
* don't use Match() for now, since it breaks lock annotations
* update retry_lb_fail test
3 years ago
Mark D. Roth
4c40ee3f78
move parse_address and sockaddr_utils out of iomgr directory ( #26077 )
...
* move parse_address and sockaddr_utils out of iomgr directory
* clang-format
* fix python
* fix for import
* fix build file for import
4 years ago
Esun Kim
ca945a58e9
Introduced grpc_error_handle ( #25902 )
...
- Define grpc_error_handle
- Replace grpc_error* with grpc_error_handle
4 years ago
Esun Kim
a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr ( #25628 )
4 years ago
Esun Kim
377fe6095a
Upgrade clang-tidy and clang-format to 11 ( #25590 )
...
* Upgrade clang-tidy and clang-format to 11
* Reformat code
* Fix abseil-string-find-str-contains
* Fix modernize-make-unique
4 years ago
Esun Kim
6468d8a69d
Make grpcpp/mutex compatible absl/mutex
4 years ago
AJ Heller
880a854f0e
Convert URI parser to C++ #24701
4 years ago
yang-g
8456e2138a
Check localhost is resolved to ipv4 or ipv6 and update test accordingly.
4 years ago
Mark D. Roth
b62d5c7eaa
Allow channel args to modify service config parsing behavior.
4 years ago
Mark D. Roth
bd73844208
Move parse_address library from client_channel to iomgr.
4 years ago
Mark D. Roth
c35a37d6c2
Remove TargetAuthorityTable in favor of a per-address channel arg.
4 years ago
Vijay Pai
d03daab509
Remove unused variable (fixes builder error)
4 years ago
Muxi Yan
232756e7bf
Remove unnecessary RPC
4 years ago
Muxi Yan
fa28bab456
Address comments
4 years ago
Muxi Yan
ec2cd96426
Address comments
4 years ago
Muxi Yan
3f684093d7
Add test for the new config field
4 years ago
Mark D. Roth
9404f66f70
Replace most uses of gpr_asprintf() with absl calls.
4 years ago
Esun Kim
165ee5007a
Replaced grpc::string with std::string
4 years ago
Mark D. Roth
581751b65b
xds: When listener does not exist, put channel in TRANSIENT_FAILURE.
5 years ago
Mark D. Roth
0324afa89e
grpclb: Add test showing that backend status is returned to client.
5 years ago
Mark D. Roth
bac25901d7
Fix flakiness in grpclb SingleBalancerWithClientLoadReportingTest.Vanilla test.
5 years ago
Mark D. Roth
dcdd04fcaa
Fix flakiness in grpclb_end2end_test ReresolveDeadBalancer test case.
5 years ago