Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Mark D. Roth	58a4b9c922	[reorg] move src/core/lib/gpr -> src/core/util (#36543 ) Closes #36543 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36543 from markdroth:reorg_util_gpr `ba84e186be` PiperOrigin-RevId: 634113744	7 months ago
Mark D. Roth	0944410d6c	[reorg] move test/core/util -> test/core/test_util (#36446 ) Closes #36446 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36446 from markdroth:reorg_test `5dcc85e006` PiperOrigin-RevId: 629229220	8 months ago
Tanvi Jagtap	dc848c3e05	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36405 ) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT Replacing GPR_ASSERT with absl CHECK These changes have been made using string replacement and regex. Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36405 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36405 from tanvi-jagtap:tjagtap_microbenchmarks_01 `0dcec5d852` PiperOrigin-RevId: 626522246	8 months ago
Tanvi Jagtap	3e0eeed4fa	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_AS… (#36267 ) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT Replacing GPR_ASSERT with absl CHECK Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only a few - which fit into single - line regex will be changed. This would be small in number just to reduce the load later. Replacing CHECK with CHECK_EQ , CHECK_NE etc could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36267 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36267 from tanvi-jagtap:tjagtap_grpc_assert_02 `3aed626101` PiperOrigin-RevId: 623469007	8 months ago
Craig Tiller	1dabdfbe6f	[per-cpu] Change up the cpu caching mechanism (#34421 ) Lets us sever the dependency between stats & exec ctx (finally). More work likely needs to go into the mechanism used here (I'm not a fan of the per thread index), but that's also something we can address later.	1 year ago
AJ Heller	3fb738b9b1	[EventEngine] Implement work-stealing in the EventEngine ThreadPool (#32869 ) This PR implements a work-stealing thread pool for use inside EventEngine implementations. Because of historical risks here, I've guarded the new implementation behind an experiment flag: `GRPC_EXPERIMENTS=work_stealing`. Current default behavior is the original thread pool implementation. Benchmarks look very promising: ``` bazel test \ --test_timeout=300 \ --config=opt -c opt \ --test_output=streamed \ --test_arg='--benchmark_format=csv' \ --test_arg='--benchmark_min_time=0.15' \ --test_arg='--benchmark_filter=_FanOut' \ --test_arg='--benchmark_repetitions=15' \ --test_arg='--benchmark_report_aggregates_only=true' \ test/cpp/microbenchmarks:bm_thread_pool ``` 2023-05-04: `bm_thread_pool` benchmark results on my local machine (64 core ThreadRipper PRO 3995WX, 256GB memory), comparing this PR to master: ![image](https://user-images.githubusercontent.com/295906/236315252-35ed237e-7626-486c-acfa-71a36f783d22.png) 2023-05-04: `bm_thread_pool` benchmark results in the Linux RBE environment (unsure of machine configuration, likely small), comparing this PR to master. ![image](https://user-images.githubusercontent.com/295906/236317164-2c5acbeb-fdac-4737-9b2d-4df9c41cb825.png) --------- Co-authored-by: drfloob <drfloob@users.noreply.github.com>	2 years ago
Craig Tiller	67f364e23e	[cleanup] Eliminate usage of GRPC_ASSERT(false...); (#31757 ) * crash function * progress * fix * fix * Automated change: Fix sanity tests * fix * fix * fix * fixes * Automated change: Fix sanity tests * fix * Automated change: Fix sanity tests * fix * fix * use cpp attr * Automated change: Fix sanity tests * fix * fix * fix * fix * fix * fix * add exclusion * fix * typo * fix * fmt * Update tcp_socket_utils.cc * Automated change: Fix sanity tests * fix * revert php changes * Automated change: Fix sanity tests Co-authored-by: ctiller <ctiller@users.noreply.github.com>	2 years ago
AJ Heller	8b4c4fc47d	ThreadPool benchmarks (#31419 ) * ThreadPool benchmarks These are nearly identical to the EventEngine benchmarks at the moment. We can consider removing the redundant tests from the EventEngine code and focusing on EventEngine-specific things (e.g., timer cancellation) * rm unused header * rm leak * fix: moved dependencies	2 years ago
Vignesh Babu	e8c30b487f	Invoking Poller::Work in posix event engine constructor (#31128 ) * adding Poller::Work to event engine constructor * iwyu * iwyu * cleanup * regenerate projects * fix * comments * add experiments flag * fix * newline * newline * iwyu * remove some ifdefs * fix tsan issue in bm_event_engine_run * Add a quiesce to threadpool * fix * Automated change: Fix sanity tests * disable posix_event_engine_test on windows Co-authored-by: Craig Tiller <ctiller@google.com> Co-authored-by: ctiller <ctiller@users.noreply.github.com>	2 years ago
Craig Tiller	afa3a6c890	[event_engine] Fix for the EE/iomgr shutdown ordering problem (#31265 ) * Remove ResetDefaultEventEngine Now that it is a weak_ptr, there's no need to explicitly reset it. When the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a new default EventEngine will be created. * forget existing engine with FactoryReset * init/shutdown in event engine for now * fix * fix * fix windows deadlock * Automated change: Fix sanity tests * fix * better windows fix Co-authored-by: AJ Heller <hork@google.com> Co-authored-by: ctiller <ctiller@users.noreply.github.com>	2 years ago
AJ Heller	2ee2c91c92	Reland x2: Make GetDefaultEventEngine return a shared_ptr (#30619 ) * Reland x2: Make GetDefaultEventEngine return a shared_ptr * remove thread leak from NativeDNSResolver This is not going to work for resolvers that support cancellation. * give resolvers bounded lifetimes Some resolver own EventEngines. EventEngines cannot run off the end of the process since they have unjoined threads (problematic in a small set of environments). This gives resolvers bounded lifetimes, and allows replacement of resolvers without ASAN issues of deleting resolvers in active use (occurs in tests). * fix * fix windows * fix surface init test * fix * sanitize * use after move * the test must wait for the callback to be destroyed * windows fix: delete the resolver on iomgr shutdown, not before * Make TimerManager threads non-joinable On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to detect thread leaks. This fix resolves issues I saw in end2end test shutdown in another PR, where a single timer manager thread was always alive after the test ended. The long-term solution is to integrate the new ThreadPool here, but this unblocks me for now. * backport fix * fix * shared_ptr<EventEngine> in EventEngine benchmarks	2 years ago
AJ Heller	a874b8f6ca	EventEngine::Run microbenchmarks (#30769 ) * [WIP] EventEngine::Run microbenchmarks * Add fanout impl and fix tracking of time spent doing work in threads * tune down benchmarks; fix fanout counting logic. * tune down closure fanout tests * format * odr * reviewer feedback * unify some fanout logic; add a large-AnyInvocable test lambdas that take an allocation are about 10x slower * reviewer feedback * fix invalid vector access * rm DNS * format * copy params for each lambda callback This fixes segfaults when we cannot ensure all callbacks are complete before exiting the test. * s/promise/Notification/g bm_exec_ctx * ODR and leak * fix division by zero * fix	2 years ago

8 Commits (e6494bd06f2e4a08c91eb41f420607f9568b22ac)