Yash Tibrewal
c495d2aa1f
[CSM] Stop using xDS enabled server for CSM observability tests ( #36725 )
...
Closes #36725
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36725 from yashykt:RemoveXdsEnabledServerFromCsmInterop 91f3120f07
PiperOrigin-RevId: 638313782
6 months ago
Tanvi Jagtap
986428d252
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log ( #36636 )
...
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log
In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future.
We have the following mapping
1. gpr_log(GPR_INFO,...) -> LOG(INFO)
2. gpr_log(GPR_ERROR,...) -> LOG(ERROR)
3. gpr_log(GPR_DEBUG,...) -> VLOG(2)
Reviewers need to check :
1. If the above mapping is correct.
2. The content of the log is as before.
gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected.
Closes #36636
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36636 from tanvi-jagtap:regex_test_cpp f2cac9c5a4
PiperOrigin-RevId: 634954173
7 months ago
Mark D. Roth
0944410d6c
[reorg] move test/core/util -> test/core/test_util ( #36446 )
...
Closes #36446
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36446 from markdroth:reorg_test 5dcc85e006
PiperOrigin-RevId: 629229220
7 months ago
Yash Tibrewal
2999332d64
[CSM] De-experimentalize CsmObservability API ( #35836 )
...
Closes #35836
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35836 from yashykt:DeexperimentalizeCsmObs 1711e6d9b0
PiperOrigin-RevId: 605650394
10 months ago
Yash Tibrewal
387c894117
[CSM] Remove experimental CSM PluginOption API in favor of CsmObservability API ( #35812 )
...
Also update interop tests to use `CsmObservability` API
Closes #35812
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35812 from yashykt:UpdateCsmInterop dc99764aea
PiperOrigin-RevId: 604726881
10 months ago
Yash Tibrewal
76c45b98d1
[otel] Return absl::Status as a return from BuildAndRegisterGlobal ( #35659 )
...
Just to be future-proof, I'm amending the `void` return status of `BuildAndRegisterGlobal` in `OpenTelemetryPluginBuilder` to absl::Status.
This will be backported to 1.61 as well.
Closes #35659
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35659 from yashykt:UpdateOtelApiToAddStatus 07d3f41b8a
PiperOrigin-RevId: 601458408
10 months ago
Yash Tibrewal
984daf98d7
[CSM o11y] Re-experimentalize CSM OTel Plugin Option ( #35660 )
...
We are no longer sure about this API, so re-experimentalizing it.
This PR will be backported to 1.61 as well.
Closes #35660
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35660 from yashykt:ReexperimentalizeCsmPluginOption 4f114a54d9
PiperOrigin-RevId: 601378856
10 months ago
Yash Tibrewal
4cea5d0cba
[xDS Interop] Use XdsServerBuilder when testing CSM Observability ( #35634 )
...
[prod:grpc/core/master/linux/grpc_xds_k8s_lb](https://fusion2.corp.google.com/ci/kokoro/prod:grpc%2Fcore%2Fmaster%2Flinux%2Fgrpc_xds_k8s_lb/activity/6c2577f0-965b-4f22-ac2a-5454a0f77444/log )
Closes #35634
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35634 from yashykt:CsmInteropTrial a8213cd10a
PiperOrigin-RevId: 601010836
11 months ago
Yash Tibrewal
acc1ad1b2b
[CSM] De-experimentalize CSM OTel Plugin Option ( #35526 )
...
Closes #35526
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35526 from yashykt:DeexperimentalizeCsmPluginOption 441eccb857
PiperOrigin-RevId: 597675383
11 months ago
Yash Tibrewal
d2cc24f189
[OTel] De-experimentalize API ( #35509 )
...
Closes #35509
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35509 from yashykt:DeeexperimentalizeOTelPlugin f5edf94f2c
PiperOrigin-RevId: 597613307
11 months ago
Yash Tibrewal
6741e2064d
[xds interop] Use new CSM Observability APIs ( #35508 )
...
Closes #35508
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35508 from yashykt:XdsInteropNewCsm 09d408c082
PiperOrigin-RevId: 597588033
11 months ago
Yash Tibrewal
c12a5645f7
[OTel] Experimental API for metrics ( #35348 )
...
Provide a public experimental API and bazel compatible build target for OpenTelemetry metrics.
Details -
* New `OpenTelemetryPluginBuilder` class that provides the API specified in https://github.com/grpc/proposal/blob/master/A66-otel-stats.md
* The existing `grpc::internal::OpenTelemetryPluginBuilder` class is moved to `grpc::internal::OpenTelemetryPluginBuilderImpl` for disambiguation.
* Renamed `OTel` in some instances to `OpenTelemetry` for consistency.
Closes #35348
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35348 from yashykt:OTelPublicApi e32328825e
PiperOrigin-RevId: 594271246
11 months ago
Stanley Cheung
ff2c0313e3
[PSM Interop] Add flag to enable CSM Observability in c++ image ( #34866 )
...
Roll forward of #34832 , 3rd attempt. Will run a grpc import cherry-pick
to make sure the next import is going to be clean.
1 year ago
Stanley Cheung
9303b86010
Revert "[PSM Interop] Add flag to enable CSM Observability in c++ image" ( #34858 )
...
Reverts grpc/grpc#34840
1 year ago
Stanley Cheung
a62c2607a6
[PSM Interop] Add flag to enable CSM Observability in c++ image ( #34840 )
...
Roll forward of #34832 (reverted in #34837 ).
Need #34836 to be merged first.
1 year ago
Vignesh Babu
c4b9a9a8fc
Revert "[PSM Interop] Add flag to enable CSM Observability in c++ image" ( #34837 )
...
Reverts grpc/grpc#34832 . Broke import
1 year ago
Stanley Cheung
433cfa99a5
[PSM Interop] Add flag to enable CSM Observability in c++ image ( #34832 )
...
Add the flag `enable_csm_observability` to the c++ PSM interop testing
image, such that when enabled from the PSM interop testing framework,
the C++ client/server app will enable the CSM Observability plugin.
1 year ago
Eugene Ostroukhov
490f6a3ee9
[test interop] Add HookService to the maintenence server ( #34413 )
...
This pull request adds another hook service on the maintenance server.
This will enable clients to gradually migrate from the standalone hook
server.
Changes:
1. Hook service can now be used separately.
2. Copied latest protos and updated the hook service to new API.
3. Added the hook service to the maintenance server.
1 year ago
Eugene Ostroukhov
d55431995c
[interop] Implement "hostname" for RPC behavior ( #33446 )
...
This enables outlier detection test. See #33135
1 year ago
Eugene Ostroukhov
be99673d06
[PSM interop test] implement error-code- RPC behavior ( #32810 )
...
This reverts commit 47ea5062cb
.
2 years ago
Craig Tiller
47ea5062cb
Revert "[xds interop tests] implement error-code- RPC behavior" ( #32769 )
...
Reverts grpc/grpc#32765
2 years ago
Eugene Ostroukhov
a4af6250d8
[xds interop tests] implement error-code- RPC behavior ( #32765 )
...
Implements handling for the `error-code-xx` `rcp-behavior` header.
Compare to similar implementation in
[java-server](42b4c61d5e/interop-testing/src/main/java/io/grpc/testing/integration/XdsTestServer.java (L379)
)
2 years ago
Craig Tiller
67f364e23e
[cleanup] Eliminate usage of GRPC_ASSERT(false...); ( #31757 )
...
* crash function
* progress
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* fix
* use cpp attr
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* fix
* add exclusion
* fix
* typo
* fix
* fmt
* Update tcp_socket_utils.cc
* Automated change: Fix sanity tests
* fix
* revert php changes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
Esun Kim
530b702259
Update Clang 15 ( #31518 )
...
* clang-15
* iwyu
* run clang_format_code
* Clang-Tidy config
* Fix misc-unused-using-decls
* Fixed performance-inefficient-vector-operation
* Sanity
2 years ago
Craig Tiller
eb5ae61470
Reland (again) bytestream removal ( #29987 )
...
* Revert "Revert "Reland bytestream removal (#29911 )" (#29964 )"
This reverts commit e6c6840db3
.
* initial fc fuzzer
* fixes
* add rq to fc fuzzer
* fleshing things out
* Automated change: Fix sanity tests
* cleanup
* send with payload
* ensure if no reader no flow control tokens are granted
* remove some public methods
* remove bogus benchmarks
* account for pending size
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* better logic
* Automated change: Fix sanity tests
* fix
* fixes
* fuzz pending size
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* huh
* increase too short timeout
* review feedback
* review feedback
* fix u32 overflow
* fix
* robustness fixes for channelz_servicer_test
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* dont send window updates if read closed
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
apolcyn
e6c6840db3
Revert "Reland bytestream removal ( #29911 )" ( #29964 )
...
* Revert "Reland bytestream removal (#29911 )"
This reverts commit 98dcba2807
.
* Automated change: Fix sanity tests
3 years ago
Craig Tiller
98dcba2807
Reland bytestream removal ( #29911 )
...
* Revert "Revert "Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )" (#29894 )" (#29910 )"
This reverts commit 713a1581d5
.
* fix
3 years ago
Craig Tiller
713a1581d5
Revert "Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )" ( #29910 )
...
This reverts commit 93cdc8b77e
.
3 years ago
Craig Tiller
93cdc8b77e
Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )
...
* Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )"
This reverts commit d53986657f
.
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
d53986657f
Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )
...
This reverts commit aacf0e252b
.
3 years ago
Craig Tiller
aacf0e252b
[transport] Remove ByteStream ( #29637 )
...
* A starter SliceBuffer implementation
* Add comments and fix sanity checks
* Minor fixes
* more minor fixes
* Addressing review comments and adding a slice_buffer_test
* fix sanity checks
* regenerate projects
* fixing undefined function error
* reverting changes from memory_allocator.cc and adding them to src/core/lib/slice/slice_buffer.cc to allow memory allocator lib to build correctly
* fix sanity checks
* adding an open source slice definition
* regnerate projects
* fix asan error
* Automated change: Fix sanity tests
* addressing review comments
* fix sanity checks
* regenerate projects
* update
* fix sanity checks
* Converting slice buffer to retarin ownership of the underlying ctype
* [slice_buffer] Introduce grpc_core::SliceBuffer
* add test
* Automated change: Fix sanity tests
* [byte-stream] Delete ByteStream
* progress
* progress
* missing files
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* sanity
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* iwyu
* fix
* progress
* fix
* fix
* progress
* code compiles
* fix?
* bogus assert
* Automated change: Fix sanity tests
* fix
* fix
* fix?
* fix
* fix
* better expression of function
* fix?
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* add fullstack test without retry filter
* debug
* missing files
* gc
* fix h2_full_no_retry
* remove headers
* fixes
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* progress
* x
* tear apart flow control
* continue itnegration
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* cleanup
* Automated change: Fix sanity tests
* fix
* x
* x
* Revert "debug"
This reverts commit 0120a94492
.
* undo debug
* fix
* Automated change: Fix sanity tests
* better inproc
* fixes
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix stalled streams
* properly handle non-terminal trailers
* fix test
* fix channelz test
* fix subchannel_stream_client
* fix server load reporting
* review feedback
* review feedback
* review feedback
* review feedback
* Automated change: Fix sanity tests
* remove compression test from python
* fix
* x
* Automated change: Fix sanity tests
* iwyu fix
* Revert "remove compression test from python"
This reverts commit 5fe0512077
.
* cripple python tests
* Revert "fix"
This reverts commit 6df476b22f
.
* Automated change: Fix sanity tests
* review feedback
* Automated change: Fix sanity tests
* fix
* fix
* fix
* ugh
Co-authored-by: Vignesh Babu <vigneshbabu@google.com>
Co-authored-by: Vignesh2208 <Vignesh2208@users.noreply.github.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
AJ Heller
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
Yash Tibrewal
72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API ( #26544 )
...
* De-experimentalize XdsCredentials and XdsServerCredentials API
* Use GRPC_DEPRECATED
3 years ago
Yash Tibrewal
7fd731f704
De-experimentalize XdsServerBuilder ( #27296 )
3 years ago
Craig Tiller
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
Yash Tibrewal
29d220a0ef
Re-experimentalize XdsServerBuilder ( #26892 )
...
* Re-experimentalize XdsServerBuilder
* Fix compiler issue
3 years ago
Yash Tibrewal
4daedf0233
De-experimentalize XdsServerBuilder ( #26543 )
3 years ago
Lidi Zheng
735c7047aa
[C++] Add admin and reflection to xds interop binaries ( #25964 )
...
* Add admin and reflection to xds interop binaries
* Prepare for https://github.com/grpc/grpc/pull/25978
* Remove _xds rules
4 years ago
Yash Tibrewal
23152e74ce
Enable channelz for xds_interop_client and xds_interop_server ( #25939 )
...
* Enable channelz for xds_interop_client and xds_interop_server
* Regenerate projects
4 years ago
Yash Tibrewal
8eb2e13a6e
C++ xDS interop test server changes ( #25633 )
...
* C++ xDS interop test server changes
4 years ago
Esun Kim
9bd7c4917a
Fix unused-parameter warning
4 years ago
Esun Kim
53ab235fb8
Fix google-explicit-constructor
4 years ago
capstan
131579d52d
Roll forward of commit 7883b51: Use abseil's flags in tests.
...
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493 .
This reverts commit da66b7d14e
.
NEW:
* Adds references to `absl/flags/declare.h`, new to LTS 2020923.2 imported in commit 5b43440
.
* Works around MSVC 2017 compiler error with large help text on flags by reducing the help text.
4 years ago
Nathan Herring
da66b7d14e
Revert "Abseil Flags"
4 years ago
capstan
7883b5133d
Use abseil's flags in tests.
...
This replaces gflags. Added TODOs where use of `absl::Duration` or `absl::FlagSaver` might be preferred in follow-up cleanup. Fixes #24493 .
4 years ago
Esun Kim
aae4f4cf18
Fix by misc-unused-using-decls
4 years ago
Esun Kim
e7434d385e
Fix by tidy-modernize-use-override
4 years ago
Donna Dionne
fc8923c0a3
Updating C++ interop client and server to do path matching and header
...
matching tests.
4 years ago
Eric Gribkoff
39eb1d31b8
clang tidy
5 years ago