9ff89e81c4
fix order issue in setting grpc_tcp_client_impl ( #32022 )
2 years ago
2c4d55b3a1
Revert "Revert "Revert "WindowsEventEngine Client implementation ( #31848 )" (#… ( #31974 )" ( #32018 )
...
This reverts commit aa83319695
2 years ago
aa83319695
Revert "Revert "WindowsEventEngine Client implementation ( #31848 )" (#… ( #31974 )
...
* Revert "Revert "WindowsEventEngine Client implementation (#31848 )" (#31965 )"
This reverts commit 58ad7950a0
2 years ago
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
58ad7950a0
Revert "WindowsEventEngine Client implementation ( #31848 )" ( #31965 )
...
This reverts commit bc7e155e55
2 years ago
531287b2ee
Update tcp server interface to move on_accept_cb to the create method ( #31912 )
...
* Update tcp server interface to move on_accept_cb to create method
* update
* update
2 years ago
59bbe265fb
Make http proxy fixture test more robust ( #31803 )
...
* Make http proxy fixture test more robust
* update
* modify build
2 years ago
bc7e155e55
WindowsEventEngine Client implementation ( #31848 )
...
* rename task-handle mutex
* rename TimerClosure
* tmp commit, building, not tested
* add test for client connection to a non-listening port
* fix posix EE tests
* re-fix windows test suite after posix compatibility
* (unfinished, backup): passing the suite's NonExistingListener client test
* remove redundant windows client test
* integrate IOCP worker loop
* initial commit of echo test tool; fixes
* move echo client to test_suite/tools; I do not yet like the setup, it's about time for a macro that generates all useful test/tool targets
* cleanup
* add --target arg to echo_client. requires URI
* Automated change: Fix sanity tests
* build fixes
* fix
* fix
* reviewer feedback
* warning fix
* delete logic on cancellation
* fix
* cancel connect deadlock; improved template code
* fix build failure with linux environments building windows targets
* fix
* fix
* no ++ for atomics
* remove the test changes, to be landed separately
* Automated change: Fix sanity tests
* remnants
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
49a3035d44
[iwyu] Fix CI job ( #31921 )
...
* fix-includes
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* add warning label
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
b887534111
[cleanups] Remove `include/grpc/impl/codegen/propagation_bits.h` ( #31870 )
...
* Remove `include/grpc/impl/codegen/propagation_bits.h`
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
2 years ago
ac365cadfb
Remove `include/grpc/impl/codegen/port_platform.h` ( #31778 )
2 years ago
f5d21653fc
Revert "[event_engine] Move combiner executor usage to event engine ( #31713 )" ( #31753 )
...
This reverts commit b04aa1cf92
2 years ago
694e4b8427
Add more info to metadata limit exceeded error ( #31756 )
...
* Add more info to error
* Fix tests
2 years ago
77b3972f95
Clean up the TODO item in build target `grpc_base` part `channel_args` ( #31642 )
...
* Clean up the TODO item in build target `grpc_base` part `channel_args`
* Update
* Update
* Update
* Automated change: Fix sanity tests
* update
* Automated change: Fix sanity tests
2 years ago
b04aa1cf92
[event_engine] Move combiner executor usage to event engine ( #31713 )
...
* [event_engine] Move combiner executor usage to event engine
* fix
* review feedback
* fix
* x
* fix
* fix
2 years ago
7e3ada34e6
Clean up the TODO item in build target `grpc_base` -- part `closure` ( #31001 )
...
* Clean up the TODO item in build target `grpc_base` part `closure`
* Update
* Update
* Revert "Update"
This reverts commit daf3118390
2 years ago
d44e1520a7
Fix readability-redundant-access-specifiers ( #31561 )
...
* Added readability-redundant-access-specifiers
* Fix
2 years ago
c545350633
Reland: [promises] Compression filter conversion ( #31686 )
...
* Revert "Revert "[promises] Compression filter conversion (#31204 )" (#31682 )"
This reverts commit fa31b36cb1
2 years ago
fa31b36cb1
Revert "[promises] Compression filter conversion ( #31204 )" ( #31682 )
...
This reverts commit a8c983528a
2 years ago
a8c983528a
[promises] Compression filter conversion ( #31204 )
...
* Convert compress filter
* decompress sketch
* Automated change: Fix sanity tests
* progress
* progress
* got the new filter impls compiling
* Automated change: Fix sanity tests
* declare the bits
* allocate control types
* stub in pipe accessors
* init pipes
* send-path
* working through the state machines
* [arena] pool allocator
* add tests
* Automated change: Fix sanity tests
* better sizes
* iwyu
* Automated change: Fix sanity tests
* first pass cut fragments
* fix1
* fix
* Automated change: Fix sanity tests
* fix
* iwyu
* build-deps
* fix for windows
* fix
* fixes
* better-logs
* better-logs
* callpushpush-->tryconcurrently
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* logging improvements
* logging improvements
* fixes
* Automated change: Fix sanity tests
* respect flag
* handle eos
* cancel_after_client_done
* handle failed sends
* more error handling
* Automated change: Fix sanity tests
* more stuff
* remove unnecessary conversion
* hackity hack hack
* fixes
* progress
* Automated change: Fix sanity tests
* capture metadata from promise to recieve up
* spacing
* debug,fix
* not-used
* fix
* fix
* tune
* unify compress/decompress
* fixes
* send_message/send_trailing_metadata ordering
* cleanup loop
* remove minimal stack bits
* better error generation
* fix-build
* Automated change: Fix sanity tests
* cancellation of recv message for forwarded receives
* fix
* compile fix
* fix clobbering
* fix test, convert to gtest
* fix
* Automated change: Fix sanity tests
* cleanup
* fixes
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* add test
* Automated change: Fix sanity tests
* fix
* fix
* fix
* no need to store message per filter
* Automated change: Fix sanity tests
* danke yash
* iwyu
* clang-tidy
* Automated change: Fix sanity tests
* fix
* [promise] CallPushPull -> more general TryConcurrently
* Automated change: Fix sanity tests
* [promise] Introduce map_pipe, cleanup factories
* [promise] Promise based filter changes for messages
* [log] Longer space for filenames
* [test] Add some debugability affordances to async_end2end_test
* add comment
* Automated change: Fix sanity tests
* fix-merge
* fix-merge
* fix
* [chttp2] Fix a bug whereby trailers-only is not reported
We don't report trailers-only if the trailers are parsed prior to executing recv_initial_metadata
* comments
* fix for ruby
* review feedback
* merge
* fix
* Automated change: Fix sanity tests
* fix bm?
* re-add dropped flag
* turn on some traces to try and debug ruby
* debug for ruby problem
* proposed chttp2 fix
* Revert "turn on some traces to try and debug ruby"
This reverts commit 1bf3cfd552
2 years ago
3ef817b3bf
Clean up the TODO item in build target `grpc_base` -- part `slice` ( #31003 )
...
* Clean up the TODO item in build target `grpc_base` part `slice`
* Automated change: Fix sanity tests
2 years ago
e6cb6fdd2d
try fix retry_per_attempt_recv_timeout ( #31605 )
2 years ago
eea5d11fdd
[build] Move exec_ctx headers out of grpc_base ( #31603 )
...
* [build] Move exec_ctx headers out of grpc_base
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
d410f1d0aa
[surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch ( #31554 )
...
Add a check that SEND_STATUS_FROM_SERVER and RECV_MESSAGE are not in the same batch.
This is necessary pre-work for #31204 and implements part of grpc/proposal#336 .
Also eliminates fling instead of updating it:
My expectation is nobody has looked at this corner in many years
It's not a benchmark we want: concentrating on a microbenchmark that doesn't include a binding layer caused us to favor designs that emphasized a lightweight core at the expense of a expensive bindings. We should consider the whole.
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
916a325b6c
LB policy API: make pickers ref-counted ( #31612 )
...
* LB policy API: make pickers ref-counted
* fix build
* clang-tidy
2 years ago
26bc68c4af
Added readability-duplicate-include ( #31608 )
...
* Added readability-duplicate-include
* Fix
* format
2 years ago
5b8f006ece
[build] Stop publishing iomgr/error.h from grpc_base ( #31521 )
...
* [build] Stop publishing iomgr/error.h from grpc_base
* fixes
* fix
2 years ago
50fbe51238
Fix IWYU with clang-15 ( #31556 )
...
* Fix iwyu
* iwyu fix
* more fixed
* Build fix
* more fix
* More fixes 3
2 years ago
530b702259
Update Clang 15 ( #31518 )
...
* clang-15
* iwyu
* run clang_format_code
* Clang-Tidy config
* Fix misc-unused-using-decls
* Fixed performance-inefficient-vector-operation
* Sanity
2 years ago
3b18968927
[flake] Remove destruction of event log ( #31493 )
2 years ago
2158ce7523
[cleanup] Remove unused end2end feature flags ( #31370 )
2 years ago
5f6c357e74
Move some targets from //: to //src/core: ( #31402 )
...
* temp
* temp
* temp
* top BUILD builds
* everything builds
* buildify
* temp fix_build_deps change
* fix gpr_atm
* additional changes
* fix build files
* nofixdeps
* Generate projects
* json_args
* fix context
* Generate projects
* Sprinkle some avoid_dep tags
* Run fix_build_deps
* Remove additional avoid_dep
* Revert some targets
* grpc_mock_cel
2 years ago
20d1efc38a
[stats] Move core stats to C++ ( #30936 )
...
* begin c++
* Automated change: Fix sanity tests
* progress
* progress
* missing-files
* Automated change: Fix sanity tests
* moved-from-stats
* remove old benchmark cruft, get tests compiling
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fixes
* fixes
* add needed constructor
* Automated change: Fix sanity tests
* iwyu
* fix
* fix?
* fix
* fix
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* add visibility
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: AJ Heller <hork@google.com>
2 years ago
afa3a6c890
[event_engine] Fix for the EE/iomgr shutdown ordering problem ( #31265 )
...
* Remove ResetDefaultEventEngine
Now that it is a weak_ptr, there's no need to explicitly reset it. When
the tracked shared_ptr is deleted, the weak_ptr will fail to lock, and a
new default EventEngine will be created.
* forget existing engine with FactoryReset
* init/shutdown in event engine for now
* fix
* fix
* fix windows deadlock
* Automated change: Fix sanity tests
* fix
* better windows fix
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
85794d4094
Deprecated grpc_error_std_string ( #31267 )
2 years ago
3b12efd66a
[hpack_size] Un-parallelize tests ( #31259 )
...
* [hpack_size] Un-parallelize tests
* iwyu
2 years ago
32923ac191
Removed no_error_on_hotpath ( #31225 )
2 years ago
2d00d50c59
[event_engine] Improve scaling in threadpool ( #31234 )
...
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fixes
* fixes
* fix
* fix-win
* fix iwyu
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
3c96517fc0
Simplified GRPC_ERROR_CREATE macros ( #31222 )
...
* Simplified GRPC_ERROR_CREATE macros
* Code migration
2 years ago
347bf1a1f4
Removed GRPC_ERROR_[INT|STR] macros ( #31195 )
...
* Clean-up which
* Reformat
2 years ago
66c8e098ee
[slice] Remove murmur implementation ( #31118 )
...
* [slice] Remove _internal variants of APIs
* Automated change: Fix sanity tests
* fix
* reduce bloat
* fixes
* Automated change: Fix sanity tests
* murmurings
* Automated change: Fix sanity tests
* progress
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
4bd27c524a
More changes ( #31194 )
2 years ago
beb5bdca62
[promises] Promise based grpc_call ( #29598 )
...
* Automated change: Fix sanity tests
* fix
* fixes
* fixup allocator story - we should require a context
* fixes
* doodling
* context scribbles
* [arena] Add ManagedNew(), gtest-ify test
Add a ManagedNew() method to Arena that calls the relevant destructor at Arena destruction time.
There are some cases coming up in the promise based call work where this becomes super convenient, and I expect it's likely that there are other places that's true too.
* Automated change: Fix sanity tests
* progress
* lalalal
* progress
* x
* Automated change: Fix sanity tests
* fixes
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* fix client streaming
* handle invalid flags
* Automated change: Fix sanity tests
* no logging
* progress
* progress
* channelz
* tentative fix
* fix
* lalala
* Automated change: Fix sanity tests
* more readable trace
* logging improvements, leading to bug fix in connected channel
* fix
* improve debuggability
* fix
* progress to better refcounting
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* threading
* Automated change: Fix sanity tests
* fix
* fix
* improve debuggability
* fix
* fix
* Automated change: Fix sanity tests
* fix
* make promises runtime configurable
* Automated change: Fix sanity tests
* fix
* fix build
* fix broken test
* clean up api
* deal with stats better
* peer string!
* introduce fragments
* Automated change: Fix sanity tests
* use fragments
* stuff
* [promises] Add AtomicWaker type
* Automated change: Fix sanity tests
* fix
* fix write path
* fix
* polling-entity-hell
* review feedback
* fix
* fix
* fix
* fix
* make an experiment
* [experiments] Make output more diffable/readable
* Automated change: Fix sanity tests
* buildifier sized indentations
* fix
* fix
* Automated change: Fix sanity tests
* fix?
* fix promise
* prototype
* progress
* implement new api
* Revert "fix promise"
This reverts commit ded85e7d19c2acef1958
2 years ago
6cac641c64
EventEngineFactoryReset - remove custom factory and reset default engine ( #30554 )
...
* EventEngineFactoryReset - remove custom factory and reset default engine
* fix
* Automated change: Fix sanity tests
* unused parameter
* fix
* fix
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
a23eae84c9
Revert "[flakes] Update flakiness ( #31121 )" ( #31173 )
...
This reverts commit bdc799af73
2 years ago
bdc799af73
[flakes] Update flakiness ( #31121 )
...
* update
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
631e8b2c36
[fixit] Parallelize hpack_size tests ( #30580 )
...
* [hpack_size] Parallelize tests
* Automated change: Fix sanity tests
* fix tsan race
* fix tsan race
* bleh
* windows-strerror
* ugh
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2 years ago
2ee2c91c92
Reland x2: Make GetDefaultEventEngine return a shared_ptr ( #30619 )
...
* Reland x2: Make GetDefaultEventEngine return a shared_ptr
* remove thread leak from NativeDNSResolver
This is not going to work for resolvers that support cancellation.
* give resolvers bounded lifetimes
Some resolver own EventEngines. EventEngines cannot run off the end of
the process since they have unjoined threads (problematic in a small set
of environments). This gives resolvers bounded lifetimes, and allows
replacement of resolvers without ASAN issues of deleting resolvers in
active use (occurs in tests).
* fix
* fix windows
* fix surface init test
* fix
* sanitize
* use after move
* the test must wait for the callback to be destroyed
* windows fix: delete the resolver on iomgr shutdown, not before
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* backport fix
* fix
* shared_ptr<EventEngine> in EventEngine benchmarks
2 years ago
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2 years ago
Yijie Ma
AJ Heller
Vignesh Babu
Craig Tiller
Cheng-Yu Chung
Alisha Nanda
Esun Kim
Jan Tattermusch
Mark D. Roth
Yash Tibrewal