Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Yash Tibrewal	1312ff0625	[OTel C++] Add APIs to enable/disable metrics (#36183 ) Closes #36183 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36183 from yashykt:OTelEnableDisableMetrics `948abe7235` PiperOrigin-RevId: 619696880	9 months ago
Yash Tibrewal	a1535ae615	[CSM] Cleanup and test Size() on MeshLabelsIterable (#35769 ) Adding testing for `Size()` on `MeshLabelsIterable` as promised on https://github.com/grpc/grpc/pull/35371 This method doesn't get used the OTel C++ library at present so it was untested earlier, and bugs in its implementation were noticed later. To avoid that issue in the future, adding manual testing of this method. Changes - * Moved `MeshLabelsIterable` to the header to be able to test its Size method directly. Also had to move around some internals to be able to do so. * Replaced `absl::variant<grpc_core::Slice, StructPb> metadata_` from decoding the metadata lazily to just decoding it in the constructor. I don't remember the original thinking behind this. Maybe I wanted the decoding to happen lazily, but there doesn't seem to be much gain from doing it lazily, we instead have to deal with the overhead of `variant`. Closes #35769 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35769 from yashykt:CsmMeshLabelsIterableSizeTesting `ec9033b742` PiperOrigin-RevId: 617901839	9 months ago
Yash Tibrewal	3032b5c48d	[OTel C++] Add CMake build support (#36063 ) Changes - * Add CMake build support to `grpcpp_otel_plugin`. Currently, we are only supporting the `find_package CONFIG` method for depending on `opentelemetry-cpp`. * Since, `grpcpp_otel_plugin` is an extension of gRPC, it will not be built by default. To enable building of this target, a new CMake option `gRPC_BUILD_GRPCPP_OTEL_PLUGIN` is being added. * Also add `CMakeLists.txt` to the otel example. The `otel_plugin_test` can also be built through cmake but, for the CI to work, there are some additional changes. Those will be made in an upcoming PR. Closes #36063 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36063 from yashykt:OTelCMakeSupport `3bc783823b` PiperOrigin-RevId: 613734473	9 months ago
Yash Tibrewal	20e5e0cb29	[CSM] Modify CsmObservability to CsmOpenTelemetryPluginOption internally (#35803 ) Changes - * `CsmObservability` API will now use the `CsmOpenTelemetryPluginOption` internally. After this change, `CsmObservability` will enable observability for all channels and servers. (Earlier, `CsmObservability` only enabled observability for CSM-enabled channels and servers.) CSM labels will still be added just for CSM-enabled channels and servers. * Also, we no longer need the ability to set `LabelInjector` on the `OpenTelemetryPluginBuilder` directly. Instead, we always use `PluginOption` to inject the `LabelInjector`. This simplifies the code as well. Note that `SetTargetSelector` and `SetServerSelector` APIs on the `OpenTelemetryPluginBuilderImpl` are not being deleted yet since we might need them shortly. This is also why `OpenTelemetryPluginBuilderImpl` is not being deleted right now. Closes #35803 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35803 from yashykt:CsmO11yApisUsePluginOption `cf3d65900d` PiperOrigin-RevId: 604323898	10 months ago
Yash Tibrewal	f51f14e70c	[otel] Re-structure otel_plugin_test initialization (#35631 ) Closes #35631 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35631 from yashykt:UpdateOtelPluginTest `ba1a9cecc2` PiperOrigin-RevId: 600950962	11 months ago
Yijie Ma	16b71d91d8	[CSM O11Y] Fix issue when CSM optional labels are present in server metrics (#35633 ) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35633 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35633 from yijiem:labels-injector-patch `6876243943` PiperOrigin-RevId: 600931754	11 months ago
Yash Tibrewal	8231340aef	[CSM] Add support for GCE resources (#35371 ) Add support for GCE resources in CSM Observability. Additionally, fix a bug where we were not adding the remote workload's canonical service label for unknown resource types. Also, if zone and region are both specified, zone takes precedence. Closes #35371 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35371 from yashykt:GceSupportToCsm `e3064d8c3c` PiperOrigin-RevId: 597989825	11 months ago
Yash Tibrewal	5880e05e9d	[OTel] Fix clang-tidy caused by merge fiasco (#35529 ) Closes #35529 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35529 from yashykt:FixMasterClangTidy `eb44716ffa` PiperOrigin-RevId: 597660074	11 months ago
Yijie Ma	77ad5a786e	[CSM O11Y] CSM Service Label Plumbing from LB Policies to CallAttemptTracer (#35210 ) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #35210 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35210 from yijiem:csm-service-label `6a6a7d1774` PiperOrigin-RevId: 597641393	11 months ago
Yash Tibrewal	d2cc24f189	[OTel] De-experimentalize API (#35509 ) Closes #35509 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35509 from yashykt:DeeexperimentalizeOTelPlugin `f5edf94f2c` PiperOrigin-RevId: 597613307	11 months ago
Yash Tibrewal	c12a5645f7	[OTel] Experimental API for metrics (#35348 ) Provide a public experimental API and bazel compatible build target for OpenTelemetry metrics. Details - * New `OpenTelemetryPluginBuilder` class that provides the API specified in https://github.com/grpc/proposal/blob/master/A66-otel-stats.md * The existing `grpc::internal::OpenTelemetryPluginBuilder` class is moved to `grpc::internal::OpenTelemetryPluginBuilderImpl` for disambiguation. * Renamed `OTel` in some instances to `OpenTelemetry` for consistency. Closes #35348 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35348 from yashykt:OTelPublicApi `e32328825e` PiperOrigin-RevId: 594271246	12 months ago
Yash Tibrewal	5fd09c1aff	[CSM C++] Fix behavior when peer does not send metadata (#34692 ) @stanley-cheung noticed a bug where CSM labels were not being added on metrics if the peer was not also CSM Observability enabled. This PR fixes the behavior to add in the local labels in this case, as well as add the remote workload type label with the value of unknown.	1 year ago
Yash Tibrewal	1091cc3211	[CSM] Update labels (#34412 ) Changes - * Remove `csm.remote_workload_pod_name` and `csm.remote_workload_container_name`. * Add `csm.remote_workload_name`, the value for which is sent through MetadataExchange, from the `CSM_WORKLOAD_NAME` env var. (Note that this is not added in local labels.) * Add a local `csm.canonical_service` (@markdroth, please verify the key that we want here) that is read from `CSM_CANONICAL_SERVICE_NAME` env var, and we continue to send it over via MetadataExchange	1 year ago
Yash Tibrewal	037979c0d8	[CSM] Remaining cleanup from GSM to CSM renaming (#34352 ) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->	1 year ago
Yash Tibrewal	03776a2f3e	[OTel and Csm] Cosmetic API changes (#34294 ) Changes - * OTel API - Metrics enabling/disabling is updated to reflect design changes. * GSM is renamed to CSM	1 year ago
Yash Tibrewal	938d19f63e	[GSM Observability] Add mesh_id support in injected labels (#34247 ) Changes - 1) Change local mesh labels to not be reported on 'started' metrics at all (even those that we know about) to be consistent. (Since xDS labels atleast on the server side would not be available on started metric.) 2) Add mesh_id as a local label that is populated by reading the xDS bootstrap. As part of this, also added a minimal xds bootstrap parsing logic. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->	1 year ago
Yash Tibrewal	0dd8a056b8	Revert "[GSM Observability] "Revert Metadata Exchange Implementation"" (#34234 ) Reverts grpc/grpc#34233	1 year ago
Eugene Ostroukhov	9800546913	[GSM Observability] "Revert Metadata Exchange Implementation" (#34233 ) Reverts grpc/grpc#34051 as it caused issues with import.	1 year ago
Yash Tibrewal	7c79712d13	[GSM Observability] Metadata Exchange Implementation (#34051 ) A new metadata type `x-envoy-peer-metadata` is being introduced. We don't have a better way to do this at the moment compared to just adding it in `metadata_batch.h`. The GSM Observability plugin uses this metadata to send topology information to peers in the form of serialized and base64 encoded `google::protobuf::Struct`. The individual keys being used inside the struct are subject to change. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->	1 year ago

15 Commits (d9badb171ad36830ed1389ca8c5ef6600cfad682)