Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Craig Tiller	47faab618b	Add more flexibility for internal benchmark monitoring systems PiperOrigin-RevId: 685823731	4 months ago
Craig Tiller	92c9dec6c4	[benchmarks] Enable monitoring on a swath of benchmarks (#37903 ) We'll probably disable some next week :) But I want to watch a good selection and refine criteria for acceptance. Closes #37903 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37903 from ctiller:ALL-the-things `5f829db870` PiperOrigin-RevId: 685010911	4 months ago
Craig Tiller	dbb5164ac7	[clang-format] Remove custom clang-format rules for include ordering (#37820 ) Closes #37820 PiperOrigin-RevId: 682352913	4 months ago
Mark D. Roth	f6c57b6384	[reorg] move a bunch of stuff to src/core/util (#36792 ) The following files have been moved: - src/core/lib/avl/* - src/core/lib/backoff/* - src/core/lib/debug/event_log* - src/core/lib/iomgr/gethostname* - src/core/lib/iomgr/grpc_if_nametoindex* - src/core/lib/matchers/* - src/core/lib/uri/* (renamed from uri_parser.* to uri.) - src/core/lib/gprpp/ (existing src/core/util/time.cc was renamed to gpr_time.cc to avoid conflict) Closes #36792 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36792 from markdroth:reorg_util `d4e8996f48` PiperOrigin-RevId: 676947640	5 months ago
Yash Tibrewal	656f325b53	[HealthCheck] Make status message better (#37724 ) Closes #37724 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37724 from yashykt:PickFirstHealthWatchErrorMsg `fc09a026bb` PiperOrigin-RevId: 676497230	5 months ago
Nathan Baulch	bdf52dd4ad	Fix more minor typos (#37541 ) Just thought I'd contribute some more typo fixes I've stumbled upon. This is a followup on #37450. Use the following command to get a quick and dirty summary of the specific corrections made: ```shell git diff HEAD^! --word-diff-regex='\w+' -U0 \ \| grep -E '\[\-.\-\]\{\+.\+\}' \ \| sed -r 's/.\[\-(.)\-\]\{\+(.)\+\}./\1 \2/' \ \| sort \| uniq -c \| sort -n ``` FWIW, the top typos are: * compressable (134) * existant (82) * unparseable (49) * occured (24) * replys (18) * validing (17) * writter (16) * vaidate (9) * directoty (8) * convertabl (8) * atrributes (8) * indxes (8) * transfered (7) * exchage (7) * descedent (6) * enpoint (6) * nonexistant (6) * matadata (6) * addtional (5) * callack (5) * experenced (5) * wil (5) Closes #37541 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37541 from NathanBaulch:typos `7cbfc121ed` PiperOrigin-RevId: 675772876	5 months ago
Mark D. Roth	e3f8296d3a	[xDS] move XdsConfig out of XdsDependencyManager (#37564 ) This is needed to use `XdsConfig` in an xDS HTTP filter without causing a circular dependency, which will be needed as part of gRFC A83 (https://github.com/grpc/proposal/pull/438). Closes #37564 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37564 from markdroth:xds_config_dependency_refactor `877d9afdc0` PiperOrigin-RevId: 666950471	6 months ago
Tanvi Jagtap	ba0c992006	[Gpr_To_Absl_Logging] Remove logging header from example and test/core/ folder (#37492 ) [Gpr_To_Absl_Logging] Remove logging header from example and test/core/ folder Closes #37492 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37492 from tanvi-jagtap:remove_header_test_core_misc `fbcd02ab53` PiperOrigin-RevId: 663593905	6 months ago
Craig Tiller	d51b01e7c0	[bm_picker] Fix timeout on slow builds (#37356 ) Closes #37356 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37356 from ctiller:fasta `5f34a21e66` PiperOrigin-RevId: 658531414	7 months ago
Craig Tiller	5638afba6e	[call-v3][client-channel] Add benchmarks for lb picks (#37052 ) Two new benchmarks here-in. Benchmark 1: `bm_picker` ------ Measures various load balancing policies pick performance. For now we cover `pick_first` and `weighted_round_robin` at 1, 10, 100, 1000, 10000, and 100000 backends. Today's output: ``` ------------------------------------------------------------------------------ Benchmark Time CPU Iterations ------------------------------------------------------------------------------ BM_Pick/pick_first/1 20.4 ns 20.4 ns 68285 BM_Pick/pick_first/10 20.6 ns 20.6 ns 68274 BM_Pick/pick_first/100 20.5 ns 20.5 ns 67817 BM_Pick/pick_first/1000 20.6 ns 20.6 ns 67347 BM_Pick/pick_first/10000 20.7 ns 20.7 ns 67317 BM_Pick/pick_first/100000 20.9 ns 20.9 ns 67385 BM_Pick/weighted_round_robin/1 54.7 ns 54.7 ns 26641 BM_Pick/weighted_round_robin/10 54.2 ns 54.2 ns 25828 BM_Pick/weighted_round_robin/100 55.2 ns 55.2 ns 26210 BM_Pick/weighted_round_robin/1000 54.1 ns 54.1 ns 25678 BM_Pick/weighted_round_robin/10000 77.3 ns 76.6 ns 15776 BM_Pick/weighted_round_robin/100000 148 ns 148 ns 9882 ``` Benchmark 2: `bm_load_balanced_call_destination` ----- This benchmark measures call performance when a call spine passes through a `LoadBalancedCallDestination`, and with `BM_LoadBalancedCallDestination` also the construction/destruction cost of this object. We do not consider picker performance in this benchmark as it's separately covered by `bm_picker` above. Today's output: ``` ----------------------------------------------------------------------------------------------------------------------------------------- Benchmark Time CPU Iterations ----------------------------------------------------------------------------------------------------------------------------------------- BM_UnaryWithSpawnPerEnd<UnstartedCallDestinationFixture<LoadBalancedCallDestinationTraits>> 1255 ns 1255 ns 1076 BM_UnaryWithSpawnPerOp<UnstartedCallDestinationFixture<LoadBalancedCallDestinationTraits>> 1459 ns 1459 ns 939 BM_ClientToServerStreaming<UnstartedCallDestinationFixture<LoadBalancedCallDestinationTraits>> 209 ns 209 ns 6775 BM_LoadBalancedCallDestination 92.8 ns 92.8 ns 15063 ``` Notes ------ There's some duplicated code between the benchmarks & tests -- this is ok -- as the tests evolve we'll likely want to add more checks to the fixtures, whereas as the benchmarks evolve we may well want to optimize the fixtures so that performance of the systems under test dominate more. That is, the duplicated code is expected to have different evolutionary tracks. Closes #37052 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37052 from ctiller:moar-benchy `30c7072d87` PiperOrigin-RevId: 658181731	7 months ago
Mark D. Roth	62826f5f6e	[xDS] refactor BUILD targets for resource types (#37130 ) This moves more code out of the monolithic `grpc_xds_client` BUILD target. We still need more work to split it up completely, but this is a nice step in the right direction -- and it unblocks a subsequent PR that I'm working on for xDS authority rewriting. Closes #37130 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37130 from markdroth:xds_resource_type_build_refactoring `a021d9773c` PiperOrigin-RevId: 648742472	8 months ago
Craig Tiller	83ee2cd631	[benchmark] Add an opinionated macro for gRPC benchmark targets (#37012 ) As we've learned what configuration is needed for our benchmarks the settings have been growing more and more bespoke for each binary. Try to consolidate that into some useful defaults. Also ensure we always `linkstatic=1`. `cc_binary` defaults to this, so it's reasonable to assume that's the performance our customers see. It also deeply impacts performance for small microbenchmarks, and so enabling it gives us more apples:apples, and saves chasing things that don't matter. Closes #37012 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37012 from ctiller:benchmark-bin `b84cab58c6` PiperOrigin-RevId: 645483183	8 months ago
Mark D. Roth	34a0318dbf	[LB policy API] change metadata mutation API to handle discarded picks (#36968 ) Previously, metadata mutations were made by the picker directly, which meant that they would be applied even if the channel winds up discarding the pick due to the returned subchannel having been disconnected by the time the pick result is returned. This changes the API such that pickers return metadata mutations along with the pick result, so that the mutations won't get applied unless the pick result is actually used. Closes #36968 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36968 from markdroth:lb_metadata_api `2765da6121` PiperOrigin-RevId: 645451869	8 months ago
Mark D. Roth	fe817c8ab1	[reorg] move lib/json -> util/json (#36645 ) Closes #36645 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36645 from markdroth:reorg_json `5b6434dd44` PiperOrigin-RevId: 636757495	9 months ago
Mark D. Roth	6c08d36c3b	[reorg] move telemetry code to src/core/telemetry (#36644 ) Closes #36644 PiperOrigin-RevId: 636702732	9 months ago
Tanvi Jagtap	ed5893120e	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log (#36608 ) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - gpr_log In this CL we are migrating from gRPCs own gpr logging mechanism to absl logging mechanism. The intention is to deprecate gpr_log in the future. We have the following mapping 1. gpr_log(GPR_INFO,...) -> LOG(INFO) 2. gpr_log(GPR_ERROR,...) -> LOG(ERROR) 3. gpr_log(GPR_DEBUG,...) -> VLOG(2) Reviewers need to check : 1. If the above mapping is correct. 2. The content of the log is as before. gpr_log format strings did not use string_view or std::string . absl LOG accepts these. So there will be some elimination of string_view and std::string related conversions. This is expected. Closes #36608 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36608 from tanvi-jagtap:regex_test_core_misc `e6b9481dac` PiperOrigin-RevId: 634246311	9 months ago
Tanvi Jagtap	ef322d93c4	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - BUILD (#36605 ) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - BUILD In this CL we are just editing the build and bzl files to add dependencies. This is done to prevent merge conflict and constantly having to re-make the make files using generate_projects.sh for each set of changes. Closes #36605 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36605 from tanvi-jagtap:build_test_core_misc_02 `f928eb19de` PiperOrigin-RevId: 633516934	9 months ago
Yijie Ma	bc4766381a	[metrics] Templatized Metrics API (#36449 ) This adds compile-time checking that the type of the value and the size of the labels and optional labels passed when recording a metric must match with the type and the size specified when the metric is registered. The RegistrationBuilder API idea is credited to @ctiller. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36449 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36449 from yijiem:registration-builder-api `a727810136` PiperOrigin-RevId: 632271022	9 months ago
Mark D. Roth	32e03171e7	[reorg] move xds code to src/core/xds (#36521 ) Also do some cleanup in CODEOWNERS. Closes #36521 PiperOrigin-RevId: 631137895	9 months ago
Mark D. Roth	0944410d6c	[reorg] move test/core/util -> test/core/test_util (#36446 ) Closes #36446 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36446 from markdroth:reorg_test `5dcc85e006` PiperOrigin-RevId: 629229220	10 months ago
Tanvi Jagtap	60dc14e833	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36457 ) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT Replacing GPR_ASSERT with absl CHECK. These changes have been made using string replacement and regex. Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36457 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36457 from tanvi-jagtap:tjagtap_misc_test `978d0411b8` PiperOrigin-RevId: 628949744	10 months ago
Mark D. Roth	597154c2a7	[reorg] move tests to directories that correspond to the src tree (#36424 ) Closes #36424 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36424 from markdroth:reorg_test `44c219c7ea` PiperOrigin-RevId: 627430577	10 months ago

22 Commits (cdac698f756c67a7aad6b9f39bb05ae9135b0432)