Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Harvey Tuch	5f3cfe960f	Fix read from uninitialized memory bug in GrpcBufferWriter. This commit fixes an issue in which the following sequence of operations leads to use of uninitialized memory: 1. Caller invokes GrpcBufferWriter::Next(), and then makes use of 8191 bytes in the returned buffer (which is 8192 bytes in size). 2. Caller then returns the unused single byte via GrpcBufferWriter::BackUp(). This method invokes g_core_codegen_interface->grpc_slice_split_tail(), which causes backup_slice_ to be a grpc_slice with one byte. 3. At the next invocation of GrpcBufferWriter::Next(), a reference to the single byte grpc_slice is returned to the caller. The problem here is that the returned reference is to the inlined buffer in the grpc_slice, which is resident in slice_, not the location of the buffer inside slice_buffer_ after g_core_codegen_interface->grpc_slice_buffer_add() in GrpcBufferWriter::Next(). As a result, any data the caller writes to the returned void* data is lost. The solution is to avoid inlined backup slices.	8 years ago
Vijay Pai	c0b2acb1a0	Use C++11 final and override	8 years ago
Vijay Pai	08126092e6	golden file	8 years ago
Vijay Pai	3703ece81b	a golden file	8 years ago
Vijay Pai	d05cad245a	Fix golden test	8 years ago
Vijay Pai	48c9ca2bf1	Update golden file	8 years ago
Vijay Pai	6d214bcff7	Add FCService to golden test	8 years ago
David Garcia Quintas	1399e466b0	removed codegen/time.h	8 years ago
vjpai	9959f3d0ec	Fix the golden file - why do we even have this lever?	9 years ago
yang-g	2e08941a37	Use the comments before syntax line as file comments.	9 years ago
yang-g	8282b755a2	Clarify the comments	9 years ago
yang-g	b8aa58b2cd	Add a test	9 years ago
David Garcia Quintas	3a43cc06a8	Added codegen_test_full Which makes sure target that depend on both codegen and grpc build.	9 years ago
David Garcia Quintas	b942640497	clang-format	9 years ago
David Garcia Quintas	4ac52fa6dd	WIP. Added codegen_test	9 years ago

16 Commits (ca8de5c1c3aa47bff5ab83482ed4b33c8cbc3047)