Harvey Tuch
5f3cfe960f
Fix read from uninitialized memory bug in GrpcBufferWriter.
...
This commit fixes an issue in which the following sequence of operations
leads to use of uninitialized memory:
1. Caller invokes GrpcBufferWriter::Next(), and then makes use of 8191
bytes in the returned buffer (which is 8192 bytes in size).
2. Caller then returns the unused single byte via
GrpcBufferWriter::BackUp(). This method invokes
g_core_codegen_interface->grpc_slice_split_tail(), which causes
backup_slice_ to be a grpc_slice with one byte.
3. At the next invocation of GrpcBufferWriter::Next(), a reference to
the single byte grpc_slice is returned to the caller.
The problem here is that the returned reference is to the inlined buffer
in the grpc_slice, which is resident in slice_, not the location of the
buffer inside slice_buffer_ after
g_core_codegen_interface->grpc_slice_buffer_add() in
GrpcBufferWriter::Next(). As a result, any data the caller writes to the
returned void* data is lost.
The solution is to avoid inlined backup slices.
8 years ago
Mark D. Roth
448c1f002c
Move parameters for all grpc_op types into their own sub-structs.
8 years ago
Craig Tiller
7c70b6c144
Revert "Revert "Metadata handling rewrite""
...
This reverts commit 5e01e2ac97
.
8 years ago
Craig Tiller
5e01e2ac97
Revert "Metadata handling rewrite"
8 years ago
Craig Tiller
1d77059e4b
Fix integer overflow
8 years ago
Craig Tiller
62f28bfcf0
Remove double-checking of max-message-size in C++ layers
8 years ago
Mark D. Roth
f0e17783ae
Add ChannelArguments methods for setting max send/recv message size.
8 years ago
Craig Tiller
81eceb31cc
Remove bogus assert
8 years ago
Craig Tiller
e519a03a1f
Small improvements to generated documentation
8 years ago
Craig Tiller
801c6cc548
Fix some NULL usage
8 years ago
David G. Quintas
07383e7e28
Revert "Revert "Reduce memory bloat (each server cq is very expensive)""
8 years ago
Vijay Pai
0e3f1f1e53
Support compat with old generated PB files
8 years ago
Craig Tiller
18b66a0df6
Revert "Reduce memory bloat (each server cq is very expensive)"
8 years ago
Craig Tiller
78bc54e7d9
Fix stack corruption
8 years ago
Craig Tiller
cadabdf1f3
Fix include guards
8 years ago
Craig Tiller
f658bf0e1b
Start resolving memory issues in C++ metadata
8 years ago
Vijay Pai
6510d47c81
gpr_atm isn't automatically initialized to 0. Thanks Obama.
8 years ago
Vijay Pai
bf24dd9e51
clang-format
8 years ago
Vijay Pai
cbe1599250
Track requests that could cause other requests to be created, and don't do
...
a real core shutdown of a CQ until such requests are done
8 years ago
Sree Kuchibhotla
762ce2744c
Reduce memory bloat (each server cq is very expensive in C-core layer)
8 years ago
Craig Tiller
73ee7dc559
C++ compiles
8 years ago
Craig Tiller
cca7589333
Start moving C++ to slice interfaces
8 years ago
Craig Tiller
f69369741d
Review feedback
8 years ago
Mark D. Roth
dc5d60b814
Allow setting service config via C++ API, for use in tests.
8 years ago
Mark D. Roth
4bbdda4444
Allow getting LB policy name and service config in C++ API.
8 years ago
Craig Tiller
1cb088441a
s/std::string/grpc::string/g
8 years ago
Craig Tiller
ed9132427a
Get user agent right
8 years ago
Mark D. Roth
754b2b88bc
Code review changes.
8 years ago
Vijay Pai
320ed13d3e
Deprecate grpc::thread and sync in favor of std::thread,mutex,etc
8 years ago
Vijay Pai
5c41bab92c
Remove references to NO_CHRONO option
8 years ago
Vijay Pai
e08fe4f41e
Remove separate versions of code based on presence of threading in compiler
8 years ago
Vijay Pai
713c7b87e1
clang-format
8 years ago
Vijay Pai
c0b2acb1a0
Use C++11 final and override
8 years ago
Vijay Pai
80b292709c
Stop supporting non-C++11 conformant compilers
8 years ago
Craig Tiller
28b72428a8
clang-format
8 years ago
Craig Tiller
5b676a6b1a
Fix include guards
8 years ago
Craig Tiller
618e67d655
s/GPR_SLICE/GRPC_SLICE/g
8 years ago
Craig Tiller
b37d53ebc0
Bulk update #includes
8 years ago
Craig Tiller
d41a4a720f
s/gpr_slice/grpc_slice, and move around tests, impls
8 years ago
Mark D. Roth
7190b0c651
Add ChannelArguments::SetLoadBalancingPolicyName() to C++ API.
8 years ago
Craig Tiller
1d0fce9d60
Add some endpoint pair tests
8 years ago
Sree Kuchibhotla
26ef574874
clang format issues
8 years ago
Sree Kuchibhotla
f72ec6b37b
Move thread_manager.h header from server.h to server_cc.cc
8 years ago
Vijay Pai
bcc59f425c
Remove a useless forward declaration
8 years ago
Sree Kuchibhotla
da069a506d
Rename sync_methods_ to sync_requests_
8 years ago
Sree Kuchibhotla
385c9b2f05
Address code review comments
8 years ago
Craig Tiller
2f1d8708e5
Header fixes
8 years ago
Sree Kuchibhotla
e4eb51f20c
reorder params in Server
8 years ago
Craig Tiller
20afa3d7c9
BufferPool --> ResourceQuota
8 years ago
yang-g
b0db13141e
resolve review comment
8 years ago