Craig Tiller
c64b613eb2
x
5 months ago
Thomas Klausner
1b6601bbed
[C++] Fix Directory Walker on NetBSD. ( #37700 )
...
Use the POSIX code like FreeBSD does.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37700
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37700 from 0-wiz-0:master 0846ff5ef0
PiperOrigin-RevId: 687539488
5 months ago
Yijie Ma
61be7b0070
[EventEngine] [reland] Migrate `chttp2_server` to use EE DNSResolver ( #37901 )
...
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37901
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37901 from yijiem:dns-migration-chttp2-server-2 70d29b3b6c
PiperOrigin-RevId: 687466646
5 months ago
Mark D. Roth
da4fb493de
[pick_first_new] extend experiment expiration time ( #37947 )
...
Closes #37947
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37947 from markdroth:experiment_expiration 42afcf0b15
PiperOrigin-RevId: 687321221
5 months ago
Mark D. Roth
3da4d62adc
[retry test] fix flake caused by callback ordering ( #37944 )
...
Closes #37944
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37944 from markdroth:retry_recv_initial_metadata_flake_fix 007e368ee6
PiperOrigin-RevId: 687314442
5 months ago
Yash Tibrewal
29d3e58ddd
[XdsCoreE2ETest] Use wait_for_ready on RPCs to wait for xds enabled servers to be serving ( #37942 )
...
Fix flakes where RPCs fail due to the xds enabled server not being ready.
Sample flake - https://btx.cloud.google.com/invocations/74aca4dd-d5d6-43a4-89e3-08c1aed688e0/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_core_end2end_test@poller%3Dpoll;config=f78d0de70f525043d29a05fb7a78970999e04b7f8a87d8c4e974688bf7616998/log
Closes #37942
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37942 from yashykt:FixXdsCoreE2ETet 4228e3c06b
PiperOrigin-RevId: 687006620
5 months ago
Yash Tibrewal
5c5bf14fde
[ConfigFetcher] Set HTTP2 error to NO_ERROR to do graceful GOAWAYs ( #37939 )
...
We were not doing graceful GOAWAYs earlier where we -
* send a GOAWAY with max stream ID
* send PING to wait for RTT
* Finally, send a GOAWAY with last stream max ID to make sure that the peer has seen the first GOAWAY frame, and any RPCs started before receiving the first GOAWAY frame are handled.
Without explicitly setting the HTTP2 error to "NO_ERROR", we were instead sending a final GOAWAY frame with an "UNKNOWN_ERROR".
Sample test failure : https://btx.cloud.google.com/invocations/041cafcd-334b-42dd-a797-cfd03c53048e/targets/%2F%2Ftest%2Fcpp%2Fend2end%2Fxds:xds_end2end_test@poller%3Dpoll;config=f78d0de70f525043d29a05fb7a78970999e04b7f8a87d8c4e974688bf7616998/log
Closes #37939
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37939 from yashykt:SendGoawayNoHttp2Error ba47fede1b
PiperOrigin-RevId: 686949684
5 months ago
Craig Tiller
7e06934192
[chaotic-good] Pushback on message writes until they reach serialization ( #37894 )
...
Don't complete writes of messages until they make it to the transports outbound loop. Since payloads could be large this introduces just enough pushback that, once #37868 goes in also we should be able to sense when a transport is busy writing and stop sending at higher layers.
Closes #37894
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37894 from ctiller:send-acked 0cb3d7f8ad
PiperOrigin-RevId: 686689473
5 months ago
Craig Tiller
9945066c88
[call-v3] Send flow control ( #37868 )
...
This is missing in v3 vs v2
- in v2 we had Pipe setup so that multiple Pipe stages could be chained and only complete when the last stage had passed flow control, whereas in v3 the top stage will start accepting requests as soon as the first stage in the pipeline takes the message.
Closes #37868
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37868 from ctiller:drizzling 69209da8a7
PiperOrigin-RevId: 686652402
5 months ago
AJ Heller
13efb55dbc
[benchmark] Remove redundant callback benchmarks ( #37935 )
...
In https://github.com/grpc/grpc/pull/37077 , the "different message size" benchmarks were made identical to the benchmarks defined on the lines above them.
Closes #37935
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37935 from drfloob:rm-duplicate-callback-benchmarks ad3f569414
PiperOrigin-RevId: 686647838
5 months ago
Xuan Wang
e5952ffd9e
[Python CSM] Get mesh-id from env var instead of bootstrap file ( #37837 )
...
Passed interop test:
- [x] [grpc/core/master/linux/psm-csm-python](https://source.cloud.google.com/results/invocations/b9ba256b-31a9-4002-bd59-b21817aa9978 )
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37837
PiperOrigin-RevId: 686643728
5 months ago
AJ Heller
0b13caed53
[benchmark] Measure all threads' CPU usage in callback benchmarks ( #37936 )
...
google/benchmark only measures the main thread's CPU by default, and benchmark iteration depends on CPU utilization. These benchmarks were taking a long time since the callback API uses a lot of internal threads, and the benchmarks weren't producing useful metrics. See the documentation here https://google.github.io/benchmark/user_guide.html#cpu-timers
Test command for master: `bazel test --config=opt --test_output=streamed //test/cpp/microbenchmarks:bm_callback_streaming_ping_pong --test_arg='--benchmark_min_time=0.05s' --test_arg='--benchmark_min_warmup_time=0.01' --test_arg='--benchmark_filter=.*<MinIn.*/*/1$'`
For this PR, change the filter to `--test_arg='--benchmark_filter=.*<MinIn.*/*/1/proc.*'`
Before this change (scroll right for `inf` bytes/s, and note the 10k iterations even though the specified benchmark time had been reached):
```
---------------------------------------------------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
---------------------------------------------------------------------------------------------------------------------------------------
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/0/1 38932 ns 1052 ns 10000 bytes_per_second=0/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/1/1 39002 ns 0.000 ns 10000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/8/1 39457 ns 0.000 ns 10000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/64/1 51693 ns 0.000 ns 10000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/512/1 41174 ns 0.000 ns 10000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/4096/1 45006 ns 0.000 ns 10000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/32768/1 70990 ns 0.000 ns 10000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/262144/1 302831 ns 0.000 ns 1000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/2097152/1 2202385 ns 0.000 ns 1000 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/16777216/1 30137348 ns 0.000 ns 10 bytes_per_second=inf/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/134217728/1 437821865 ns 0.000 ns 1 bytes_per_second=inf/s
...
//test/cpp/microbenchmarks:bm_callback_streaming_ping_pong PASSED in 25.7s
```
After this change:
```
--------------------------------------------------------------------------------------------------------------------------------------------------------------
Benchmark Time CPU Iterations UserCounters...
--------------------------------------------------------------------------------------------------------------------------------------------------------------
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/0/1/process_time/real_time 38233 ns 75471 ns 1768 bytes_per_second=0/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/1/1/process_time/real_time 38847 ns 76616 ns 1781 bytes_per_second=50.2778Ki/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/8/1/process_time/real_time 38848 ns 76929 ns 1758 bytes_per_second=402.21Ki/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/64/1/process_time/real_time 49873 ns 95929 ns 1685 bytes_per_second=2.44761Mi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/512/1/process_time/real_time 41606 ns 80703 ns 1431 bytes_per_second=23.4718Mi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/4096/1/process_time/real_time 45495 ns 86097 ns 1335 bytes_per_second=171.722Mi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/32768/1/process_time/real_time 71506 ns 117093 ns 806 bytes_per_second=874.048Mi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/262144/1/process_time/real_time 353012 ns 433389 ns 183 bytes_per_second=1.38319Gi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/2097152/1/process_time/real_time 3059811 ns 3215404 ns 18 bytes_per_second=1.27663Gi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/16777216/1/process_time/real_time 34951210 ns 35279138 ns 2 bytes_per_second=915.562Mi/s
BM_CallbackBidiStreaming<MinInProcess, NoOpMutator, NoOpMutator>/134217728/1/process_time/real_time 443034887 ns 444528037 ns 1 bytes_per_second=577.833Mi/s
...
//test/cpp/microbenchmarks:bm_callback_streaming_ping_pong PASSED in 5.1s
```
Closes #37936
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37936 from drfloob:bm-callback-measures-all-thread-cpu d5ba8420bd
PiperOrigin-RevId: 686640919
5 months ago
Craig Tiller
bd4792dab6
[chttp+resource_quota] Add an experiment to quickly reject requests under very high memory pressure ( #37927 )
...
Currently the destructive reclaimer single threaded cancels existing requests, but we admit new rpcs on every channel (to be eventually cancelled, probably).
We've got evidence that this (shockingly) doesn't scale and senders can easily overwhelm and oom a server.
Instead under this experiment now we'll always reject new work under very high load, and allow the reclaimer to mop up any remaining work to get back to within bounds.
Closes #37927
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37927 from ctiller:fast_reject 835726473a
PiperOrigin-RevId: 686553599
5 months ago
Benjamin Peterson
3e87a31ce0
Mark always_inline functions inline. ( #37834 )
...
You would think `always_inline` implies inline, but GCC complains loudly (`-Wattribute`) if the `always_inline` attribute is not also accompanied by the normal `inline` keyword.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37834
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37834 from benjaminp:always-inline 3ecfaa6d50
PiperOrigin-RevId: 686553476
5 months ago
Esun Kim
e033b0390d
[CI] Disallowed std::string_view ( #37930 )
...
`std::string_view` is not allowed to use per Google C++ style guide. This test will prevent us from accidentally using it after C++17 upgrade.
Closes #37930
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37930 from veblush:string-view 88f56c12ba
PiperOrigin-RevId: 686526151
5 months ago
Sreenithi Sridharan
18015f8b3a
Adding `noexcept` to void return Cython functions as required by Cython 3.x upgrade ( #37922 )
...
Follow up from #37917 to add `noexcept` to multiple Cython functions using `nogil` with a `void` return type.
Below are the performance hints that were encountered as part of the Cython translation which are solved by this PR:

The below performance hint still exists, and is not resolved.

This is because `noexcept` expects that the function doesn't raise an exception, or a raised exception is just displayed as a warning and not propagated. But `_poll` raises an `AssertionError` at `QUEUE_TIMEOUT`, and hence cannot use `noexcept` with `_poll`.
As [PR 37917](https://github.com/grpc/grpc/pull/37917 ) and this PR now solves the Cython Asyncio test timeouts caused by Cython upgrade, this PR also reverts the Bazel Cython downgrade PR #37884
### Testing for timeout
Tested using `bazel test -c dbg --runs_per_test=3000 --test_timeout=10 "//examples/python/auth:_auth_example_test"`
```
//examples/python/auth:_auth_example_test PASSED in 4.6s
Stats over 3000 runs: max = 4.6s, min = 2.6s, avg = 3.2s, dev = 0.2s
```
Closes #37922
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37922 from sreenithi:fix_bazel_cython_asyncio_timeout 2162cd28b1
PiperOrigin-RevId: 686524195
5 months ago
Esun Kim
260b41b9cd
[Apple/Build] Bumped iOS to 11, OSX to 10.14, tvOS to 13.0 ( #37931 )
...
To prepare for the upcoming upgrade to C++17, the following changes were made:
Increased minimum supported operating system versions:
- iOS: 11 (previously 10)
- macOS: 10.14 (previously 10.12)
- tvOS: 13.0 (previously 12.0)
In addition to this, version requirements across different projects were updated to use these for consistency.
Closes #37931
PiperOrigin-RevId: 686519641
5 months ago
apolcyn
f69aaf831a
[ruby] reduce INFO log for server CQ pluck registration to DEBUG ( #37633 )
...
Currently this is still causing log spam for ruby.
Though this is in core, I believe this code path is specific to ruby.
Closes #37633
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37633 from apolcyn:reduce_log ca58824fdd
PiperOrigin-RevId: 686280644
5 months ago
Nolasco Napoleão
48265637c4
Fix readme ( #37664 )
...
Corrects bazel run command in README.
It does not match the bazel command in the BUILD file.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37664
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37664 from nolasconapoleao:fix_interceptor_readme 42d828f2ec
PiperOrigin-RevId: 686223940
5 months ago
dependabot[bot]
d70bcddb27
Bump the github-actions group across 1 directory with 2 updates ( #37826 )
...
Bumps the github-actions group with 2 updates in the / directory:
[actions/setup-python](https://github.com/actions/setup-python ) and
[peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request ).
Updates `actions/setup-python` from 5.1.0 to 5.2.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/setup-python/releases ">actions/setup-python's
releases</a>.</em></p>
<blockquote>
<h2>v5.2.0</h2>
<h2>What's Changed</h2>
<h3>Bug fixes:</h3>
<ul>
<li>Add <code>.zip</code> extension to Windows package downloads for
<code>Expand-Archive</code> Compatibility by <a
href="https://github.com/priyagupta108 "><code>@priyagupta108</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/916 ">actions/setup-python#916</a>
This addresses compatibility issues on Windows self-hosted runners by
ensuring that the filenames for Python and PyPy package downloads
explicitly include the .zip extension, allowing the Expand-Archive
command to function correctly.</li>
<li>Add arch to cache key by <a
href="https://github.com/Zxilly "><code>@Zxilly</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/896 ">actions/setup-python#896</a>
This addresses issues with caching by adding the architecture (arch) to
the cache key, ensuring that cache keys are accurate to prevent
conflicts.
Note: This change may break previous cache keys as they will no longer
be compatible with the new format.</li>
</ul>
<h3>Documentation changes:</h3>
<ul>
<li>Fix display of emojis in contributors doc by <a
href="https://github.com/sciencewhiz "><code>@sciencewhiz</code></a> in
<a
href="https://redirect.github.com/actions/setup-python/pull/899 ">actions/setup-python#899</a></li>
<li>Documentation update for caching poetry dependencies by <a
href="https://github.com/gowridurgad "><code>@gowridurgad</code></a> in
<a
href="https://redirect.github.com/actions/setup-python/pull/908 ">actions/setup-python#908</a></li>
</ul>
<h3>Dependency updates:</h3>
<ul>
<li>Bump <code>@iarna/toml</code> version from 2.2.5 to 3.0.0 by <a
href="https://github.com/priya-kinthali "><code>@priya-kinthali</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/912 ">actions/setup-python#912</a></li>
<li>Bump pyinstaller from 3.6 to 5.13.1 by <a
href="https://github.com/aparnajyothi-y "><code>@aparnajyothi-y</code></a>
in <a
href="https://redirect.github.com/actions/setup-python/pull/923 ">actions/setup-python#923</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/sciencewhiz "><code>@sciencewhiz</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/899 ">actions/setup-python#899</a></li>
<li><a
href="https://github.com/priyagupta108 "><code>@priyagupta108</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/916 ">actions/setup-python#916</a></li>
<li><a href="https://github.com/Zxilly "><code>@Zxilly</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/896 ">actions/setup-python#896</a></li>
<li><a
href="https://github.com/aparnajyothi-y "><code>@aparnajyothi-y</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/923 ">actions/setup-python#923</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v5...v5.2.0 ">https://github.com/actions/setup-python/compare/v5...v5.2.0 </a></p>
<h2>v5.1.1</h2>
<h2>What's Changed</h2>
<h3>Bug fixes:</h3>
<ul>
<li>fix(ci): update all failing workflows by <a
href="https://github.com/mayeut "><code>@mayeut</code></a> in <a
href="https://redirect.github.com/actions/setup-python/pull/863 ">actions/setup-python#863</a>
This update ensures compatibility and optimal performance of workflows
on the latest macOS version.</li>
</ul>
<h3>Documentation changes:</h3>
<ul>
<li>Documentation update for cache by <a
href="https://github.com/gowridurgad "><code>@gowridurgad</code></a> in
<a
href="https://redirect.github.com/actions/setup-python/pull/873 ">actions/setup-python#873</a></li>
</ul>
<h3>Dependency updates:</h3>
<ul>
<li>Bump braces from 3.0.2 to 3.0.3 and undici from 5.28.3 to 5.28.4 by
<a href="https://github.com/dependabot "><code>@dependabot</code></a> in
<a
href="https://redirect.github.com/actions/setup-python/pull/893 ">actions/setup-python#893</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/gowridurgad "><code>@gowridurgad</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/setup-python/pull/873 ">actions/setup-python#873</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/setup-python/compare/v5...v5.1.1 ">https://github.com/actions/setup-python/compare/v5...v5.1.1 </a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="f677139bbe
"><code>f677139</code></a>
Bump pyinstaller from 3.6 to 5.13.1 in /<strong>tests</strong>/data (<a
href="https://redirect.github.com/actions/setup-python/issues/923 ">#923</a>)</li>
<li><a
href="2bd53f9a4d
"><code>2bd53f9</code></a>
Documentation update for caching poetry dependencies (<a
href="https://redirect.github.com/actions/setup-python/issues/908 ">#908</a>)</li>
<li><a
href="80b49d3ed8
"><code>80b49d3</code></a>
fix: add arch to cache key (<a
href="https://redirect.github.com/actions/setup-python/issues/896 ">#896</a>)</li>
<li><a
href="036a523674
"><code>036a523</code></a>
Fix: Add <code>.zip</code> extension to Windows package downloads for
<code>Expand-Archive</code> C...</li>
<li><a
href="04c1311429
"><code>04c1311</code></a>
Fix display of emojis in contributors doc (<a
href="https://redirect.github.com/actions/setup-python/issues/899 ">#899</a>)</li>
<li><a
href="cb68456441
"><code>cb68456</code></a>
Updated <code>@iarna/toml</code> version to 3.0.0 (<a
href="https://redirect.github.com/actions/setup-python/issues/912 ">#912</a>)</li>
<li><a
href="39cd14951b
"><code>39cd149</code></a>
Documentation update for cache (<a
href="https://redirect.github.com/actions/setup-python/issues/873 ">#873</a>)</li>
<li><a
href="a0d74c0c42
"><code>a0d74c0</code></a>
fix(ci): update all failing workflows (<a
href="https://redirect.github.com/actions/setup-python/issues/863 ">#863</a>)</li>
<li><a
href="4eb7dbcb95
"><code>4eb7dbc</code></a>
Bump braces from 3.0.2 to 3.0.3 (<a
href="https://redirect.github.com/actions/setup-python/issues/893 ">#893</a>)</li>
<li>See full diff in <a
href="82c7e631bb...f677139bbe
">compare
view</a></li>
</ul>
</details>
<br />
Updates `peter-evans/create-pull-request` from 6.1.0 to 7.0.5
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/peter-evans/create-pull-request/releases ">peter-evans/create-pull-request's
releases</a>.</em></p>
<blockquote>
<h2>Create Pull Request v7.0.5</h2>
<p>⚙️ Fixes an issue with commit signing to allow it to support
symlinks</p>
<h2>What's Changed</h2>
<ul>
<li>fix: support symlinks when commit signing by <a
href="https://github.com/peter-evans "><code>@peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3359 ">peter-evans/create-pull-request#3359</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.4...v7.0.5 </a></p>
<h2>Create Pull Request v7.0.4</h2>
<p>⚙️ Fixes an issue with commit signing to allow it to support
submodules</p>
<h2>What's Changed</h2>
<ul>
<li>docs: correct suggestion for bot setup by <a
href="https://github.com/henryiii "><code>@henryiii</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342 ">peter-evans/create-pull-request#3342</a></li>
<li>build(deps-dev): bump <code>@types/jest</code> from 29.5.12 to
29.5.13 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3343 ">peter-evans/create-pull-request#3343</a></li>
<li>build(deps-dev): bump eslint from 8.57.0 to 8.57.1 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3344 ">peter-evans/create-pull-request#3344</a></li>
<li>fix: support submodules when commit signing by <a
href="https://github.com/peter-evans "><code>@peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3354 ">peter-evans/create-pull-request#3354</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/henryiii "><code>@henryiii</code></a>
made their first contribution in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3342 ">peter-evans/create-pull-request#3342</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.3...v7.0.4 </a></p>
<h2>Create Pull Request v7.0.3</h2>
<p>⚙️ Fixes an issue with commit signing where commit SHAs have variable
lengths when abbreviated.</p>
<h2>What's Changed</h2>
<ul>
<li>fix: disable abbreviated commit shas in diff by <a
href="https://github.com/peter-evans "><code>@peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3337 ">peter-evans/create-pull-request#3337</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.2...v7.0.3 </a></p>
<h2>Create Pull Request v7.0.2</h2>
<p>⚙️ Fixes an issue with commit signing when a change was detected as
being a rename or copy.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.48 to
18.19.50 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3320 ">peter-evans/create-pull-request#3320</a></li>
<li>build(deps-dev): bump typescript from 5.5.4 to 5.6.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3319 ">peter-evans/create-pull-request#3319</a></li>
<li>fix: disable diff detection for renames and copies by <a
href="https://github.com/peter-evans "><code>@peter-evans</code></a> in
<a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3330 ">peter-evans/create-pull-request#3330</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2 ">https://github.com/peter-evans/create-pull-request/compare/v7.0.1...v7.0.2 </a></p>
<h2>Create Pull Request v7.0.1</h2>
<p>⚙️ Fixes <a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3311 ">an
issue</a> affecting one particular use case where the action fails on
<code>diff --stat</code> with <code>fatal: ambiguous
argument</code>.</p>
<h2>What's Changed</h2>
<ul>
<li>build(deps): bump peter-evans/create-pull-request from 6 to 7 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3283 ">peter-evans/create-pull-request#3283</a></li>
<li>build(deps-dev): bump <code>@types/node</code> from 18.19.46 to
18.19.48 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3288 ">peter-evans/create-pull-request#3288</a></li>
<li>build(deps-dev): bump <code>@typescript-eslint/parser</code> from
7.17.0 to 7.18.0 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/peter-evans/create-pull-request/pull/3289 ">peter-evans/create-pull-request#3289</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="5e914681df
"><code>5e91468</code></a>
fix: support symlinks when commit signing (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3359 ">#3359</a>)</li>
<li><a
href="2f38cd26bf
"><code>2f38cd2</code></a>
fix: support submodules when commit signing (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3354 ">#3354</a>)</li>
<li><a
href="7a8aeac749
"><code>7a8aeac</code></a>
build(deps-dev): bump eslint from 8.57.0 to 8.57.1 (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3344 ">#3344</a>)</li>
<li><a
href="d39d596a77
"><code>d39d596</code></a>
build(deps-dev): bump <code>@types/jest</code> from 29.5.12 to 29.5.13
(<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3343 ">#3343</a>)</li>
<li><a
href="f6f978fd3d
"><code>f6f978f</code></a>
docs: correct suggestion for bot setup (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3342 ">#3342</a>)</li>
<li><a
href="6cd32fd936
"><code>6cd32fd</code></a>
fix: disable abbreviated commit shas in diff (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3337 ">#3337</a>)</li>
<li><a
href="d121e62763
"><code>d121e62</code></a>
fix: disable diff detection for renames and copies (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3330 ">#3330</a>)</li>
<li><a
href="f4d66f4d5a
"><code>f4d66f4</code></a>
build(deps-dev): bump typescript from 5.5.4 to 5.6.2 (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3319 ">#3319</a>)</li>
<li><a
href="488c869d17
"><code>488c869</code></a>
build(deps-dev): bump <code>@types/node</code> from 18.19.48 to
18.19.50 (<a
href="https://redirect.github.com/peter-evans/create-pull-request/issues/3320 ">#3320</a>)</li>
<li><a
href="5354f85616
"><code>5354f85</code></a>
docs: update readme</li>
<li>Additional commits viewable in <a
href="c5a7806660...5e914681df
">compare
view</a></li>
</ul>
</details>
<br />
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
5 months ago
Mark D. Roth
3fd6aa9a4d
[xDS unit tests] use real xDS protos instead of our local copies ( #37896 )
...
This migrates all of the xDS unit tests except for the fuzzer, which I'll get in a subsequent PR.
This also does not include the xDS e2e tests, which I will also do separately.
Closes #37896
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37896 from markdroth:xds_tests_use_real_protos2 de568b4e53
PiperOrigin-RevId: 686197812
5 months ago
Esun Kim
78f1235831
[PHP/CI] Upgraded PHP docker images ( #37895 )
...
This aims to resolve segfaults encountered when rebuilding ARM64 PHP Docker images. This segfaults came from gcc during ARM64 builds using QEMU. To workaround this problem, the PHP Docker images have been restructured to use apt-get for installation, thereby avoiding the use of gcc. This also needed to upgrade Debian and PHP to their latest versions, aligning with our minimum supported PHP 8.
Closes #37895
PiperOrigin-RevId: 686162640
5 months ago
Nana Pang
df0b1dfed8
Add TCP tracing to chaotic good transport.
...
PiperOrigin-RevId: 685956496
5 months ago
Mark D. Roth
b02976cfbc
[doc] clarify absolute path format for unix URIs ( #37913 )
...
Closes #37913
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37913 from markdroth:uri_doc_fix 06c3372b14
PiperOrigin-RevId: 685900366
5 months ago
Ricardo Quesada
ddfaa3402f
[Build] Enable vsock support for Android ( #37733 )
...
The existing code fails to enable vsock on Android because it tries to enable vsock on Android when:
a) a certain Linux version is detected
b) and a certain libc is present.
For a), it requires that `<linux/version.h>` is included.
For b), Android does not use glibc. Instead `AF_VSOCK` is included since NDK version 14.
This commit fixes both issues by including the needed Linux header and detecting the `__NDK_MAJOR__` version.
For context, AOSP, has it always enabled:
06fb97455f
%5E%21/src/core/lib/iomgr/port.h
But this patch compiles with older NDK version, in case someone is still using them.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37733
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37733 from ricardoquesadawork:android 9b27187337
PiperOrigin-RevId: 685868655
5 months ago
Mark D. Roth
7c766e2a72
[xDS unit test] remove need for `grpc_cc_proto_library` BUILD rule ( #37902 )
...
This eliminates the need for the `grpc_cc_proto_library` bazel BUILD rule introduced in #37863 .
To make this work, I had to upgrade several bazel dependencies and apply a patch to rules_go to work around https://github.com/bazelbuild/bazel/issues/11636 .
Closes #37902
PiperOrigin-RevId: 685868647
5 months ago
Yash Tibrewal
3d63a7b106
[CSM O11y] Change how mesh_id is populated ( #37801 )
...
Instead of getting value of `csm_mesh_id` from the bootstrap file, get it from the env var `CSM_MESH_ID`
Closes #37801
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37801 from yashykt:CsmMeshIdChange d0f149e023
PiperOrigin-RevId: 685864223
5 months ago
Xuan Wang
7ea88447d9
[Cython AIO] Fix Aio tests time out issue ( #37917 )
...
### What's happening
Some of our asyncio tests began timing out following a Cython upgrade to 3.0. This issue occurs consistently across both our Bazel and setup.py test environments.
### Why the time out
After some investigation, we found that our code here:4ffcdd4ab7/src/python/grpcio/grpc/_cython/_cygrpc/aio/completion_queue.pyx.pxi (L115-L116)
Was translated to this in Cython 0.29:
```
__pyx_f_7_cython_6cygrpc__unified_socket_write(__pyx_v_self->_write_fd);
```
And it changed to this in Cython 3.0:
```
__pyx_f_7_cython_6cygrpc__unified_socket_write(__pyx_v_self->_write_fd); if (unlikely(__Pyx_ErrOccurredWithGIL())) __PYX_ERR(7, 136, __pyx_L1_error)
```
Which indicates that this `nogil` function `_unified_socket_write` now requires GIL.
### What's new in Cython 3
* Cython 3 `cdef` functions with `void` return type will default to use `except *` as exception specification.
* If function have `void` return type and defined as `nogil`, Cython will always re-acquire the GIL after the function call to check if an exception has been raised.
* In some cases, this will cause a deadlock, especially if the function was called inside another `nogil` function.
### What's the fix
* This PR changes those functions to use `noexcept` as exception specification since we don't expect them to throw any exception, and this is also the suggested workarounds in Cython documentation: https://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#error-return-values
### Test
* Tested locally by running `bazel test`, time our rate decreased from 5% to 0.3% in 3000 runs and 10s test time out.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37917
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37917 from XuanWang-Amos:fix_cython_aio 063d27aee9
PiperOrigin-RevId: 685851320
5 months ago
Craig Tiller
47faab618b
Add more flexibility for internal benchmark monitoring systems
...
PiperOrigin-RevId: 685823731
5 months ago
AJ Heller
4ffcdd4ab7
Delete gRPC C++ Binder implementation
...
PiperOrigin-RevId: 685753453
5 months ago
Gregory Cooke
3cdb133525
[Test] Increase cpp security test timeout ( #37915 )
...
There's a timeout flake when running windows tests for the Static CRL Provider, let's see if increasing the timeout helps
Closes #37915
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37915 from gtcooke94:increase_test_deadline 0386aab786
PiperOrigin-RevId: 685752852
5 months ago
Craig Tiller
6c89e3909f
[benchmarks] Remove monitoring for one more expensive benchmark ( #37906 )
...
Closes #37906
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37906 from ctiller:lol-still-nope 754696369d
PiperOrigin-RevId: 685239520
5 months ago
Craig Tiller
a9038be11e
[benchmarks] Disable monitoring on some of our larger microbenchmarks for now ( #37905 )
...
These look too large for the configured timeouts internally... will revisit later once the system is starting to be more ready.
Closes #37905
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37905 from ctiller:lol-nope 6d44e515b3
PiperOrigin-RevId: 685223450
5 months ago
Yash Tibrewal
a59f47a802
[doc] Add documentation for StartCall() on CQ based streaming async API ( #37904 )
...
Closes #37904
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37904 from yashykt:StartCallDoc 1d1bbde6dd
PiperOrigin-RevId: 685064886
5 months ago
Craig Tiller
92c9dec6c4
[benchmarks] Enable monitoring on a swath of benchmarks ( #37903 )
...
We'll probably disable some next week :)
But I want to watch a good selection and refine criteria for acceptance.
Closes #37903
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37903 from ctiller:ALL-the-things 5f829db870
PiperOrigin-RevId: 685010911
5 months ago
Craig Tiller
1a422ebc29
[latent_see] Move latent_see to be behind a build define, not a config ( #37897 )
...
This will allow latent_see to be used with different build configurations in the future (and eventually perhaps defaulted on for some CI runs to aid postmortem debugging of test failures)
Closes #37897
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37897 from ctiller:latent-peek 52cbf36ce5
PiperOrigin-RevId: 684981143
5 months ago
Craig Tiller
6bfaae4468
[call-v3] Add state machinery for flow control ( #37867 )
...
So far missing for HTTP/2 style flow control has been a primitive to query whether there's a receiver for flow control data at the other end of the message pipes.
Here I'm updating the state machine accessors to accommodate that functionality.
No new states were needed.
Whilst here, document the current member functions on `CallState`.
Closes #37867
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37867 from ctiller:like-the-river c9814c737d
PiperOrigin-RevId: 684972125
5 months ago
Mark D. Roth
7fb7d3c3b6
[xDS] xDS-based HTTP CONNECT configuration ( #37800 )
...
Implements gRFC A86 (https://github.com/grpc/proposal/pull/455 ).
Closes #37800
PiperOrigin-RevId: 684963953
5 months ago
Craig Tiller
c7eebad1c0
Configure internal benchmark monitoring systems
...
PiperOrigin-RevId: 684961980
5 months ago
Craig Tiller
b7c57b9160
[call-v3] Prevent server calls from getting leaked in request matching ( #37886 )
...
Previously if a request was cancelled whilst being matched the matcher would leak a ref to the call forever.
Note that the only change here is `s/SpawnGuarded/SpawnGuardedUntilCallCompletes` and clang-format noise.
Closes #37886
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37886 from ctiller:flake-fightas-18 edc045102b
PiperOrigin-RevId: 684955517
5 months ago
Craig Tiller
8e0e333c6c
[latent_see] Add a visibility control for this library ( #37898 )
...
We'll want to annotate some internal systems with it going forward.
Closes #37898
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37898 from ctiller:latent-vis 12e3e73c3c
PiperOrigin-RevId: 684948162
5 months ago
Yijie Ma
7bd6b2cf2f
Automated rollback of commit 8afaf833e0
.
...
PiperOrigin-RevId: 684916586
5 months ago
Yousuk Seung
12e95d472a
[experiments] Extend work_serializer_dispatch expiry ( #37883 )
...
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37883
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37883 from yousukseung:work_serializer_dispatch_extend 04c4602b73
PiperOrigin-RevId: 684887827
5 months ago
Mark D. Roth
e808d329ae
[xds_client_test] use real xDS protos instead of local copies ( #37863 )
...
This is a trial baloon to see if we can actually make this work. If it does, I'll change the remaining xDS tests to use the real xDS protos and completely remove our local copies.
Closes #37863
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37863 from markdroth:xds_tests_use_real_protos 3ad2fe12be
PiperOrigin-RevId: 684877750
5 months ago
Richard Belleville
1c82b1cbea
[Python tooling tests] Disable Python tooling tests ( #37885 )
...
CC @sourabhsinghs
5 months ago
Yijie Ma
8afaf833e0
[EventEngine] Migrate `chttp2_server` to use EE DNSResolver ( #37853 )
...
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #37853
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37853 from yijiem:dns-migration-chttp2-server b830720b20
PiperOrigin-RevId: 684631881
5 months ago
AJ Heller
efde053968
Delete `Bazel BinderTransport APK building/testing` gRPC CI test
...
PiperOrigin-RevId: 684627679
5 months ago
Nana Pang
3020e432f9
[V3 Call filter] Add a void $INTERCEPTOR_NAME(const $VALUE_TYPE&) template to support XorFilter V3 conversion.
...
PiperOrigin-RevId: 684626196
5 months ago
Craig Tiller
44bd0528c7
[chaotic-good] Don't add new streams after transport closed ( #37887 )
...
Prior to this change events could conspire such that newly read streams got added after the AbortWithError() code ran, and so those calls would be orphaned in the transport forever - continuing to hold a ref.
Closes #37887
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37887 from ctiller:flake-fightas-20 2648d7f37f
PiperOrigin-RevId: 684609806
5 months ago
Nathan Baulch
b2a05bebe0
[maintenance] Fix cpp typos ( #37755 )
...
Continuation of #37541 but focused on C++.
Closes #37755
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37755 from NathanBaulch:typos-cpp 9a7fd9d65f
PiperOrigin-RevId: 684600898
5 months ago