Mark D. Roth
335b74fea7
Revert "xDS RouteConfig: use ValidationErrors and add unit test ( #31418 )" ( #31653 )
...
This reverts commit c72a67b6da
.
2 years ago
Zhan Jiang
8984a264b8
security: Refactor some utility functions in TSI for better internal use ( #29728 )
2 years ago
Mark D. Roth
c72a67b6da
xDS RouteConfig: use ValidationErrors and add unit test ( #31418 )
...
Specific changes:
- Use absl::variant<> for HashPolicy types.
- Pull validation of resulting LB policy configs out of ClusterSpecifierPlugin registry and into RouteConfig validation.
- Don't ignore missing Any fields in HTTP filter configs if is_optional is true, since is_optional should apply only to unsupported filter types, not to malformed resource protos.
- Use ExtractXdsExtension() for HttpConnectionManager config itself.
- Minor API improvements to StatusCodeSet to make it a bit more useful in tests.
- Changed StringMatcher to return the underlying error message when a regex fails to compile.
- Fix a bug whereby a ClusterSpecifierPlugin would not be returned if it was not used in a vhost, even if it was used in another vhost.
2 years ago
Mark D. Roth
2ff54946ff
xds_client_fuzzer: fix send message on a stream that does not exist yet ( #31648 )
2 years ago
Cheng-Yu Chung
47b9a57de9
Remove `g_glip` and `class GrpcLibraryInterface` ( #30414 )
...
* Remove `g_glip` and `class GrpcLibraryInterface`
* Update
* Update
* Update
* Automated change: Fix sanity tests (#20 )
* Update
* Update
* Update
* Test
* Fix
* Revert "Test"
This reverts commit 2f5c77e98d
.
* More fix
* More fix
* More fix
* Minor fix
* Revert "Minor fix"
This reverts commit 1ee3ae4da1
.
* Revert "More fix"
This reverts commit 1fc234896b
.
* Revert "More fix"
This reverts commit 851393c0e6
.
* Revert "More fix"
This reverts commit ed342a51d0
.
* Revert "Fix"
This reverts commit 286ad8e639
.
2 years ago
Mark D. Roth
cf63689276
LB policy test framework: add helper methods and improve debuggability ( #31632 )
...
* LB policy test framework: add helper methods and improve debuggability
* add ExpectPickFail() method
* fix build
* STL magic
* clang-tidy
* more clang-tidy
* add WaitForConnectionFailed() and log unexpected pick results
* add check for proper status for the connectivity state
2 years ago
Craig Tiller
a116fa7e25
Revert "Revert "[chaotic-good] Reland basic frame serialization (#316… ( #31637 )
...
* Revert "Revert "[chaotic-good] Reland basic frame serialization (#31631 )" (#31635 )"
This reverts commit 4e2b936e88
.
* windows fix?
2 years ago
Jan Tattermusch
e6cb6fdd2d
try fix retry_per_attempt_recv_timeout ( #31605 )
2 years ago
Craig Tiller
eea5d11fdd
[build] Move exec_ctx headers out of grpc_base ( #31603 )
...
* [build] Move exec_ctx headers out of grpc_base
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
4e2b936e88
Revert "[chaotic-good] Reland basic frame serialization ( #31631 )" ( #31635 )
...
This reverts commit 571e98f6d5
.
2 years ago
aeitzman
d934aabb09
Added url validation for aws metadata endpoints in aws external account ( #31626 )
...
* Added url validation for aws metadata endpoints in aws external account
* addressing review comments
* fix error message back
* Fix broken test
2 years ago
Craig Tiller
571e98f6d5
[chaotic-good] Reland basic frame serialization ( #31631 )
...
* Revert "Revert "[chaotic-good] Basic frame serialization/deserialization (#31257 )" (#31630 )"
This reverts commit e8ac147311
.
* fix build
2 years ago
Esun Kim
250f9fc026
Revived google-readability-casting ( #31607 )
...
* Added google-readability-casting
* Fix
* Use brace init for constants
* more
* Fix
* Fix 2
* More fix
* Fixf
2 years ago
Craig Tiller
e8ac147311
Revert "[chaotic-good] Basic frame serialization/deserialization ( #31257 )" ( #31630 )
...
This reverts commit 8185a56322
.
2 years ago
Craig Tiller
d410f1d0aa
[surface] Ensure SEND_STATUS & RECV_MESSAGE do not inhabit the same batch ( #31554 )
...
Add a check that SEND_STATUS_FROM_SERVER and RECV_MESSAGE are not in the same batch.
This is necessary pre-work for #31204 and implements part of grpc/proposal#336 .
Also eliminates fling instead of updating it:
My expectation is nobody has looked at this corner in many years
It's not a benchmark we want: concentrating on a microbenchmark that doesn't include a binding layer caused us to favor designs that emphasized a lightweight core at the expense of a expensive bindings. We should consider the whole.
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
8185a56322
[chaotic-good] Basic frame serialization/deserialization ( #31257 )
...
* [chaotic-good] initial sketch of frame serialization
* Automated change: Fix sanity tests
* tinkering
* fix up
* add tests,fuzzers
* more tests
* fix
* fuzzers
* Automated change: Fix sanity tests
* fix-build
* Automated change: Fix sanity tests
* fix inf loop
* fix refcounting bug
* fixdeps
* fix
* fix continuations
* iwyu
* fix build
* fix
* build fixes
* better split
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* iwyu
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Yijie Ma
5a131bd94b
EventEngine::RunAfter: handshaker ( #31564 )
...
* EventEngine::RunAfter migration for handshaker
* Fix build and add execution contexts to the top of the timer function
stack
* Add event_engine_ member object, remove OnTimeoutFn and self.reset()
before goes out of scope
* Run iwyu and fix_build_deps.py
* fix: more cleanup
* fix: restore unrelated files
* fix: run tools/distrib/clang_format_code.sh
* re: pass EventEngine as shared_ptr to HandshakeManager
* fix: ran tools/distrib/sanitize.sh
* fix: resolve review comment to initialize event_engine_ from the channel
args passed in DoHandshake instead of passing through constructor
* sanitize
* fix: resolve comments
* fix: one more
2 years ago
Mark D. Roth
916a325b6c
LB policy API: make pickers ref-counted ( #31612 )
...
* LB policy API: make pickers ref-counted
* fix build
* clang-tidy
2 years ago
Craig Tiller
867dc6cae2
Revert "Add support for systemd socket activation ( #30485 )" ( #31617 )
...
This reverts commit a638c407bb
.
2 years ago
aeitzman
57e0806515
Adding token url validation cases for psc endpoints ( #31616 )
...
* Adding validation case for psc endpoint
* formatting fix
2 years ago
Vignesh Babu
73ea66d8ee
A http2 setting to ensure safe rollout of tcp receive buffer auto-sizing and peer-state based framing experiments ( #31404 )
...
* A http2 setting to ensure safe rollout of tcp receive buffer auto-sizing and peer-state based framing experiments
* fix comments + sanity + iwyu
* comments
* update per comments
* comments
* iwyu
* address comments
* remove if check
2 years ago
Esun Kim
26bc68c4af
Added readability-duplicate-include ( #31608 )
...
* Added readability-duplicate-include
* Fix
* format
2 years ago
Esun Kim
660a6f281e
Added readability-redundant-string-init ( #31609 )
...
* Added readability-redundant-string-init
* Fix
2 years ago
Mark D. Roth
6c56fe6326
Second attempt: XdsClient: implement fuzzer ( #31606 )
...
* Revert "Revert "XdsClient: implement fuzzer (#31560 )" (#31604 )"
This reverts commit 58b298f354
.
* avoid dependency on status.proto
2 years ago
Andres Beltran
a638c407bb
Add support for systemd socket activation ( #30485 )
...
* Add socket-activated functionality
* Fix GRPC_ERROR_NONE in tcp_server_posix_test and sanity checks
* Fix epoll1 error, sanity checks
* Use AF_INET6 in tcp_server_posix_test
Co-authored-by: Vignesh Babu <vigneshbabu@google.com>
2 years ago
Craig Tiller
58b298f354
Revert "XdsClient: implement fuzzer ( #31560 )" ( #31604 )
...
This reverts commit 5e7e332b33
.
2 years ago
Yash Tibrewal
54dd7563c2
Fix import ( #31602 )
2 years ago
Mark D. Roth
5e7e332b33
XdsClient: implement fuzzer ( #31560 )
...
* xDS client fuzzer
* add basic corpora and improve logging
* Automated change: Fix sanity tests
* fix build
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2 years ago
Mark D. Roth
ddfa85f42b
xDS: fix error message when the request does not match any route ( #31593 )
...
* improve error message when there is no matching route
* clean up ConfigSelector API
* clang-format
* fix client_lb_end2end_test
* clang-format
2 years ago
Mark D. Roth
43c8cdd2e9
xDS: fix bug when a cluster specifier plugin was not used in all vhosts ( #31583 )
2 years ago
Yash Tibrewal
829f41b733
ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability ( #31571 )
...
* ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability
* Trailing new lines
* Fix naked include
* clang-tidy
* Reviewer comments
* Reviewer comments
2 years ago
Yash Tibrewal
5dfd384655
ObservabilityConfig: Add missing test ( #31572 )
2 years ago
Craig Tiller
5b8f006ece
[build] Stop publishing iomgr/error.h from grpc_base ( #31521 )
...
* [build] Stop publishing iomgr/error.h from grpc_base
* fixes
* fix
2 years ago
Vignesh Babu
504d49dc61
A basic set of EventEngine listener tests ( #31540 )
...
* A basic set of EventEngine listener tests
* review comments
* replace expect with asserts
* review comments
2 years ago
Cheng-Yu Chung
90d8754b0e
Sanitizer auto fix ( #31582 )
2 years ago
Vignesh Babu
40ec6850d7
C++ize TracedBuffer Interface and eliminate lock contention during getsockopt operation ( #31565 )
...
* C++ize TracedBuffer Interface and fix bug to eliminate lock contention during getsockopt operation
* fix
* fix sanity
* fix sanity
* review comments
2 years ago
Jan Tattermusch
6cab039cf5
fix PHP distribtest on monterey ( #31567 )
2 years ago
Vignesh Babu
249645608e
Reland posix event engine tcp client ( #31563 )
...
* Revert "Revert "Posix event engine tcp client (#31074 )" (#31452 )"
This reverts commit d760c1fef7
.
* regenerate_projects
2 years ago
Esun Kim
50fbe51238
Fix IWYU with clang-15 ( #31556 )
...
* Fix iwyu
* iwyu fix
* more fixed
* Build fix
* more fix
* More fixes 3
2 years ago
Esun Kim
530b702259
Update Clang 15 ( #31518 )
...
* clang-15
* iwyu
* run clang_format_code
* Clang-Tidy config
* Fix misc-unused-using-decls
* Fixed performance-inefficient-vector-operation
* Sanity
2 years ago
Mark D. Roth
7c5e326798
use a different mutex for requested_connection_ than for state updates to avoid mutex deadlock ( #31546 )
2 years ago
Vignesh Babu
7eb5fb5a25
Util functions to help with posix event engine listener implementation ( #31435 )
...
* Util functions to help with posix engine listener implementation
* sanity
* update comments in posix_engine_listener_utils.h
* review comments
* iwyu
* revert prev commit
* iwyu
* update build
* regenerate projects
* minor fixes
* comments
2 years ago
Mark D. Roth
9cb916cbd8
Third attempt: XdsClient: fix behavior for does-not-exist timer and stream termination ( #31520 )
...
* Revert "Revert "Second attempt: XdsClient: fix behavior for does-not-exist timer and stream termination (#31507 )" (#31519 )"
This reverts commit b810813291
.
* fix python CSDS test
2 years ago
Xuan Wang
b810813291
Revert "Second attempt: XdsClient: fix behavior for does-not-exist timer and stream termination ( #31507 )" ( #31519 )
...
This reverts commit cc11f21ef0
.
2 years ago
Mark D. Roth
cc11f21ef0
Second attempt: XdsClient: fix behavior for does-not-exist timer and stream termination ( #31507 )
...
* Revert "Revert "XdsClient: fix behavior for does-not-exist timer and stream termination (#31446 )" (#31501 )"
This reverts commit 824049da60
.
* trigger does-not-exist timer on send_message completion instead of channel connectivity state
* reorganize and de-dup tests
2 years ago
Mark D. Roth
a0fb351023
xds_core_e2e_test: fix federation test flake ( #31487 )
2 years ago
Yash Tibrewal
a99a65b6e2
GcpObservability: Add parsing for logging config ( #31502 )
...
* GcpObservability: Add parsing for logging config
* Unused parameters
* Reviewer comments
2 years ago
Craig Tiller
824049da60
Revert "XdsClient: fix behavior for does-not-exist timer and stream termination ( #31446 )" ( #31501 )
...
This reverts commit 7cae004601
.
2 years ago
Mark D. Roth
7cae004601
XdsClient: fix behavior for does-not-exist timer and stream termination ( #31446 )
...
* XdsClient: don't run does-not-exist timer while channel is in TRANSIENT_FAILURE
* attempt to address test flakiness
* fix test cleanup
* add tests for long connection attempts
* improve comments
* add another test case
* test changes -- not all passing yet
* improve interface for connectivity state reporting
* report error on stream status only if no response seen
* iwyu
* fix test flakes
2 years ago
Mark D. Roth
49da06c3a1
Revert "Revert "service config: use new JSON API ( #30467 )" ( #31485 )" ( #31486 )
...
This reverts commit 008661a5d6
.
2 years ago