Vijay Pai
2eb25c871e
Avoid build errors
6 years ago
Vijay Pai
147c61b2a4
Exclude StartCall from starting callback counter value
6 years ago
Yuwei Huang
3cbf4f50ea
Remove extra semicolons after function definitions
...
We are planning to enable -Wextra-semi flag in our project but some
header files in gRPC have extra semicolons that violates the check and
blocks us from enabling the flag.
This change removes unnecessary semicolons in the code. Note that having
semicolon after the GRPC_ABSTRACT macro technically also violates the
check, but it's fine for us since they are not used in public headers,
and it will be confusing to have lines ending only with GRPC_ABSTRACT,
so I keep them as-is.
6 years ago
Nicolas Noble
2ad245cb0c
Revert "Folding the Channel class into the grpc_impl namespace."
6 years ago
Nicolas "Pixel" Noble
3e30c38f1c
Adressing comments.
6 years ago
Yash Tibrewal
89ee1a8b10
Improved interception docs
6 years ago
Vijay Pai
45c684f894
Allow an alarm to be set again after firing
6 years ago
Vijay Pai
8521c0394b
Address optional reviewer comments
6 years ago
Vijay Pai
e56c832c0d
Replace list of outstanding callback requests with count only
6 years ago
Yash Tibrewal
5e2e61b6e5
Note on conditions of usage
6 years ago
Yash Tibrewal
3a2cfe50ec
Rever copyright changes
6 years ago
Vijay Pai
7a164229db
Address reviewer comments
6 years ago
Yash Tibrewal
9dd8a13439
Restructure code to handle cases exposed by the callback api
6 years ago
Nicolas "Pixel" Noble
cabbd35014
Reformat.
6 years ago
Yash Tibrewal
4dcb14ec9e
Fix codegen_test_minimal
6 years ago
Yash Tibrewal
d347ec7ce0
Register for cq avalanching when interceptors are going to be run
6 years ago
Nicolas "Pixel" Noble
2fd079ff7c
Channel folding.
6 years ago
Vijay Pai
fab05d336c
Dynamic callback requesting, graceful server shutdown, and separate ExecCtx for callbacks
6 years ago
Mehrdad Afshari
b12dd1be05
Fix GrpcCodegen initialization
...
Initializing GrpcCodegen as a global static variable
is problematic because it is possible for it to get
destructed before the last instance of `GrpcLibraryCodegen`
gets destructed and leaves the program dealing with
a dangling pointer (imagine a scenario where another
thread is using gRPC resources and the main thread
tries to join it in an object's destructor after
main ends and CoreCodegen is destructed.)
In fact, Google style guide explicitly forbids
non-trivially-destructible global variables of static
storage duration for this and other reasons and the
solution in this commit is among the recommended
workarounds referenced in
https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables
6 years ago
Yash Tibrewal
73b1a918e4
Slight update to grammar. Can probably be improved more
6 years ago
Yash Tibrewal
b8a542cd23
Update Send message interception methods docs
6 years ago
Yash Tibrewal
361acdbed1
Use the WriteOptions in Client Callback API
6 years ago
Yash Tibrewal
b35b449166
Update docs according to #17630
6 years ago
Yash Tibrewal
34d77aae5e
Always nullify serializer to free memory
6 years ago
Yash Tibrewal
7d1491d64c
Address reviewer comments
6 years ago
Yash Tibrewal
9b9ef64027
Add more information on the usage of FailHijackedRecvMessage
6 years ago
Yash Tibrewal
2b4781ca52
Use Status() instead of Status::OK to avoid issues with codegen_test_minimal
6 years ago
Yash Tibrewal
7eeda22d9e
s/two/three
6 years ago
Yash Tibrewal
df49204b97
Remove unused variable
6 years ago
Yash Tibrewal
4224384d39
Modifying semantics for GetSendMessage and GetSerializedSendMessage.
...
Also adding ModifySendMessage
6 years ago
Yash Tibrewal
50c60f03ba
Rename GetSendMessage to GetSerializedSendMessage and GetOriginalSendMessage to GetSendMessage
6 years ago
Yash Tibrewal
c6261f4b91
Rename new SendMessage types to SendMessagePtr
6 years ago
Yash Tibrewal
4aeba42528
Provide GetOriginalSendMessage for some APIs
6 years ago
Vijay Pai
cfe08f35f3
Add comments explaining purpose and validity of interception API
6 years ago
Yash Tibrewal
31a775b425
Add missing argument
6 years ago
Yash Tibrewal
d590583456
Allow interceptor creators to return nullptr
6 years ago
Hope Casey-Allen
233123ae3f
Improve metadata documentation for the user
6 years ago
Vijay Pai
c52ae0d000
Give the interceptors header files in include/grpcpp/support
6 years ago
Vijay Pai
f2324e1c05
Reset the SendMessage pointer before post-interception
6 years ago
Vijay Pai
b0b4c0d9c3
Add API comments indicating that byte buffer copy is size-independent
6 years ago
Nicolas "Pixel" Noble
d550af373c
Moving ::grpc::Alarm to ::grpc_impl::Alarm.
6 years ago
Vijay Pai
e7be6223d8
Delete unwanted constructor/assignment
6 years ago
yang-g
f1f557bc43
Add a Shutdown call to HealthCheckServiceInterface
6 years ago
Vijay Pai
97de30d7b3
Allow the interceptor to know the method type
6 years ago
Vijay Pai
13a4977c23
Treat StartCall like a reserved callback since it is required
6 years ago
Vijay Pai
eb0b39df3d
Do OnDone as the actual last thing so that the reactor can be reused.
6 years ago
Vijay Pai
606177bbc8
Document that ClientContext must remain alive for duration of RPC
6 years ago
Vijay Pai
2a0c0d7ad6
Streaming API for callback servers
6 years ago
Vijay Pai
2b5d45ab38
Fix clang-tidy and golden file issues
6 years ago
Vijay Pai
28dd7981d6
clang-format
6 years ago