Tanvi Jagtap
0b30791867
[Gpr_To_Absl_Logging] Remove gpr logging header include from other headers ( #37513 )
...
[Gpr_To_Absl_Logging] Remove gpr logging header include from other headers
Some of the cc files are using gpr_log_verbosity_init() functions.
So I removed the #include <grpc/support/log.h> from all headers and put it selectively only in the cc files that used gpr_log_verbosity_init()
Closes #37513
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37513 from tanvi-jagtap:remove_gpr_headers_from_headers_01 612ca6d0f7
PiperOrigin-RevId: 663811895
4 months ago
Craig Tiller
32a0218e6e
[log] Use ABSL_ prefixed version of LOG/CHECK macros in the include/ tree ( #36819 )
...
We should separately add a lint to ensure no new usage slips in.
Closes #36819
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36819 from ctiller:absl 61207b02f4
PiperOrigin-RevId: 640572209
6 months ago
Tanvi Jagtap
3890766adf
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT ( #36452 )
...
[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT
Replacing GPR_ASSERT with absl CHECK.
These changes have been made using string replacement and regex.
Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced.
Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer.
<!--
If you know who should review your pull request, please assign it to that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the appropriate
lang label.
-->
Closes #36452
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36452 from tanvi-jagtap:tjagtap_include_grpc 08e612fccd
PiperOrigin-RevId: 628318595
7 months ago
Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
Cheng-Yu Chung
9a7e77318b
[cleanups] Remove `include/grpc/impl/codegen/grpc_types.h` ( #31835 )
...
* Remove `include/grpc/impl/codegen/grpc_types.h`
* Automated change: Fix sanity tests
* Fix typo
* Automated change: Fix sanity tests
2 years ago
Cheng-Yu Chung
f03304b963
[cleanups] Remove functions in `class CoreCodegen` ( #31837 )
...
* Clean up `assert_fail()`
* Clean up `ok()` and `cancel()`
* Automated change: Fix sanity tests
2 years ago
Cheng-Yu Chung
452d026b7d
Remove `include/grpcpp/impl/codegen/interceptor_common.h` ( #31530 )
...
* Remove `include/grpcpp/impl/codegen/interceptor_common.h`
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
2 years ago
Cheng-Yu Chung
7e736c7a6b
Remove `include/grpcpp/impl/codegen/intercepted_channel.h` ( #31529 )
2 years ago
Cheng-Yu Chung
7cb9731e4e
Remove `include/grpcpp/impl/codegen/call_op_set_interface.h` ( #30990 )
2 years ago
Craig Tiller
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
Craig Tiller
28316341bf
Annotate impl/codegen with IWYU pragmas ( #27252 )
...
* Add a tool to annotate impl/codegen with IWYU pragmas
* xx
* oops
* fmt
* x
* fix wrong direction bug
* use defaultdict
* better annotations
* better annotations
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Esun Kim
a41a206b8c
Fix readability-const-return-type,readability-delete-null-pointer,readability-simplify-boolean-expr ( #25628 )
4 years ago
Esun Kim
decc199ca8
Fix by clang-tidy
4 years ago
Esun Kim
165ee5007a
Replaced grpc::string with std::string
4 years ago
Yash Tibrewal
e714d0fcb8
Reviewer comments
5 years ago
Yash Tibrewal
edbae5d8e6
Fix interceptor batch method FailHijackedRecvMessage for async APIs
5 years ago
Christian Maurer
46dddacdf3
remove all unused-parameter warnings
5 years ago
Norman Link
3d28761029
Fixing memory leak in interceptor by removing unsued send_status_
6 years ago
Yash Tibrewal
5e2e61b6e5
Note on conditions of usage
6 years ago
Yash Tibrewal
9dd8a13439
Restructure code to handle cases exposed by the callback api
6 years ago
Yash Tibrewal
34d77aae5e
Always nullify serializer to free memory
6 years ago
Yash Tibrewal
4224384d39
Modifying semantics for GetSendMessage and GetSerializedSendMessage.
...
Also adding ModifySendMessage
6 years ago
Yash Tibrewal
50c60f03ba
Rename GetSendMessage to GetSerializedSendMessage and GetOriginalSendMessage to GetSendMessage
6 years ago
Yash Tibrewal
4aeba42528
Provide GetOriginalSendMessage for some APIs
6 years ago
Yash Tibrewal
31a775b425
Add missing argument
6 years ago
Yash Tibrewal
00c9c40004
Remove extraneous logging statements
6 years ago
Yash Tibrewal
d4ebd30eb2
Add method to get status of send message op on POST_SEND_MESSAGE
6 years ago
Yash Tibrewal
0911e489e3
Add a method to check whether the message was received successfully
6 years ago
Yash Tibrewal
5d7d6c0fbd
Add method to fail hijacked send messages
6 years ago
Yash Tibrewal
565edf5297
Add safety checks
6 years ago
Yash Tibrewal
699c10386d
Add method to fail recv msg for hijacked rpcs
6 years ago
Yash Tibrewal
ded9434e4c
Add array header for complaining compiler
6 years ago
Yash Tibrewal
382fe4b475
Add override back to GetInterceptedChannel
6 years ago
Yash Tibrewal
fd88dcaf55
Add cancellation notification
6 years ago
Yash Tibrewal
3ece34d45c
Let us clean a few things before getting started
6 years ago
Yash Tibrewal
2475744c75
Change index to size_t
6 years ago
Yash Tibrewal
005eb29298
Missed reviewer comments
6 years ago
Yash Tibrewal
1ea195b6f3
Reviewer comments except for void * fixed
6 years ago
Yash Tibrewal
6a5f39db3c
Separate out interceptorbatchmethodimpl to a different file
6 years ago