Craig Tiller
b5a2e90fbf
Revert "[EventEngine] Implement the EventEngine-driven client channel resolver." ( #32768 )
...
Reverts grpc/grpc#32632
Needs to be rolled back for #32767 to land
2 years ago
AJ Heller
7dec55de5a
[EventEngine] Implement the EventEngine-driven client channel resolver. ( #32632 )
...
This PR also centralizes the client channel resolver selection. Resolver
selection is still done using the plugin system, but when the Ares and
native client channel resolvers go away, we can consider bootstrapping
this differently.
2 years ago
Vignesh Babu
3de6b56ae5
Trace call level batch operations under a flag ( #32503 )
2 years ago
Alisha Nanda
29d4679750
Add schedule over write experiment ( #32455 )
...
Allow cancellation op to be scheduled over write (b/244176317).
2 years ago
Craig Tiller
ae969b274b
[chttp2] Eliminate legacy huffman decoder ( #32289 )
...
* [chttp2] Eliminate legacy huffman decoder
* Automated change: Fix sanity tests
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
0893fca089
[promises] Roll forward server promise calls with fixes ( #32261 )
...
* stuff
* spam-cleanup
* Revert "Revert "[promises] Server call (#31448 )" (#32260 )"
This reverts commit dbfb888e1f
.
* spam-cleanup
* Automated change: Fix sanity tests
* asserts-for-sanity
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
dbfb888e1f
Revert "[promises] Server call ( #31448 )" ( #32260 )
...
* Revert "[promises] Server call (#31448 )"
This reverts commit bbeb15006a
.
* clang-fmt
2 years ago
Craig Tiller
9378a7d262
[experiments] Reduce experiment bloat on mobile platforms ( #32253 )
...
* see if experiments can lose weight
* test
* test
* test
* test
* contra test
* contra test
* add explainer
* Automated change: Fix sanity tests
* fixes
* fix
* strict-bs
* comments
* fixes
* iwyu
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
bbeb15006a
[promises] Server call ( #31448 )
...
* add experiment
* allow instantiation
* scratchings
* scratchings
* sniffly
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* progress
* change pipe labels to enable server code to be written
* better api
* Automated change: Fix sanity tests
* progress
* [promises] Implementation of deadline for server-based-calls
* compression filter compiles again
* Automated change: Fix sanity tests
* fix
* server tracing fixes
* get client initial metadata
* progress
* progress
* server call surface progress
* Automated change: Fix sanity tests
* move payload
* server-progress
* recv-message-server-connchan
* logging
* fix context-gate
* recv fix@top
* Automated change: Fix sanity tests
* recv close on server
* top termination start
* [promises] Move Empty to be first class
* fixes
* fix
* flow control fix
* got to orphan!
* orphan
* call orphan
* spam cleanup
* fix
* new cancelation semantics
* progress
* large metadata fixes
* fix
* fix
* log
* better logs
* fix-chanz
* logging, necessaryness
* fix typo
* fixes
* fix
* fix
* fix-pipe
* cleanup logging
* fix
* build-fix
* fix
* Automated change: Fix sanity tests
* logging
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* better primitive
* Revert "better primitive"
This reverts commit 119b5ee244
.
* fix
* fix
* trrracing
* Automated change: Fix sanity tests
* get-trailing-metadata
* cancellation
* Automated change: Fix sanity tests
* add transform pipeline to pipe
* add transform pipeline to pipe
* interceptor lists
* new server initial md api into filters
* convert connected_channel
* convert call
* initial promise based filter conversion
* convert promise based filter
* build fixes
* compile fix
* fixes
* fix ordering
* fixes
* check-metadata
* revert later: debug code
* better debug
* fix metadata ordering with messages in promise based filter
* fix ordering problem between batch completion and promise completion
* properly handle failure on receive message path on client
* more debug, fix a repoll bug in pbf
* Automated change: Fix sanity tests
* fixes
* Automated change: Fix sanity tests
* cleanup logging
* fixes
* missing file
* fixes
* logging
* Automated change: Fix sanity tests
* fixes
* convert logging filter
* fix
* Automated change: Fix sanity tests
* fix bad server response test
* Revert "Disable logging test (#32049 )"
This reverts commit 5fc92eaeae
.
* fix
* Automated change: Fix sanity tests
* fix memory leaks, logging
* Automated change: Fix sanity tests
* slice refcount debugging
* asan-canaries
* leak-fix
* leak-fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* remove mistaken line
* add-comment
* fix refcounting bug
* Automated change: Fix sanity tests
* rename variable
* renames
* bleh
* carry pipe close status from bottom of pipe to top to appease
recv-close-on-server
* backport cancellation
* Revert "carry pipe close status from bottom of pipe to top to appease"
This reverts commit fa33301dcd
.
* fix
* Automated change: Fix sanity tests
* review-feedback
* comment-ordering
* monostate
* renames
* undo-review-feedback
* fix
* review-feedback
* review-feedback
* fix
* review-feedback
* drop debugloc constructor
* interceptor-list-rev-feedback
* interceptor-list-rev-feedback
* pipe test
* review-feedback
* undo-mistaken-change
* Automated change: Fix sanity tests
* pipe error state
* detect send/recv failures and report
* iwyu, build
* fix submodules
* fix
* warning
* cleanup
* Automated change: Fix sanity tests
* fix
* fix for windows
* fix
* null pointer fix
* iwyu
* gen projex
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Vignesh Babu
fa5a6c42a6
[EventEngine] Modify iomgr to allow creation of posix event engine listeners and server side endpoints ( #31928 )
...
* [WIP] EventEngine iomgr endpoint shims
* [WIP] EventEngine::Endpoint iomgr shims for the PosixEventEngine
* Util functions to help with posix engine listener implementation
* sanity
* update comments in posix_engine_listener_utils.h
* review comments
* iwyu
* revert prev commit
* iwyu
* update build
* update
* regenerate projects
* regenerate projects
* minor fixes
* update BUILD
* sanity
* update build
* regenerate projects
* fix unused parameter
* sanity
* update
* sanity
* regenerate_projects
* remove unused variable
* start
* update
* regenerate_projects
* sanity
* update
* fixes
* update
* regenerate_projects
* update
* fix sanity and msan failure
* more fixes
* build failure
* update
* fix
* sanity
* fixes
* update
* regenerate projects
* fix sanity
* review comments
* An EventEngine subclass to be implemented by all posix based event engines
* sanity
* comments
* update
* review comments
* re-word
* fix
* update
* review comments
* regenerate projects
* syntax fix
* add lock free event benchmark
* releasable mutex lock
* fix build isue
* update
* start
* regenerate projects
* update
* fix
* windows build
* update
* windows portability issue
* update
* update
* update
* update
* format
* update
* update
* start
* Update tcp server interface to move on_accept_cb to create method
* update
* start
* update
* update
* update
* update
* update
* update
* update
* update
* sanity
* update
* update
* update
* windows build
* fix msan
* fix sanity
* regenerate projects
* update
* iwyu
* Fix resolved address length related bugs in tcp_socket_utils and listener_utils
* iwyu
* cleanup
* cleanup src/core/lib/event_engine/tcp_socket_utils.cc
* iwyu
* fix
* regenerate projects
* fix sanity
* re-write endpoint shim
* more re-write
* cleanup
* update
* regenerate projects
* review comments
* build issue
* more build issue fixes plus adding event_engine_trace
* even more build issue fixes
* iwyu
* add static_cast
* fix sanity
* update
* update
* sanity
* fix
* Fix
* Review comments
* fix
* iwyu
* fix build issue
Co-authored-by: AJ Heller <hork@google.com>
2 years ago
Craig Tiller
7b02b7c253
[stats] Add experiment to use transport reported request latency whenever available ( #32168 )
...
* [stats] Add experiment to use transport reported request latency whenever available
* redux: add a new metric
* review-feedback
* Automated change: Fix sanity tests
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
356e3fd775
[tcp] Remove read-chunks experiment ( #32126 )
...
* [tcp] Remove read-chunks experiment
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Vignesh Babu
3baeab973a
Remove posix_event_engine_polling_enabled experiment ( #32037 )
...
* Remove posix_event_engine_polling_enabled experiment
* regenerate projects
2 years ago
Craig Tiller
83e3c28869
[chttp2] Enable new huffman encoder by default ( #30989 )
2 years ago
Alisha Nanda
221d6b58d8
Add global structure of allocators + experiment ( #31807 )
...
* Global allocator experiment
* Fix formatting and deps
* Update experiments files formatting
* Small fixes
* Change uint formatting
* Automated change: Fix sanity tests
* Fix formatting
* Address review comments
* Clean up logging
* Automated change: Fix sanity tests
* Fix clangtidy
* remove duplicate header
* address review
* Add more info to error
* Fix tests
* Global allocator experiment
* Fix formatting and deps
* Update experiments files formatting
* Small fixes
* Change uint formatting
* Fix formatting
* Address review comments
* Clean up logging
* Automated change: Fix sanity tests
* Fix clangtidy
* remove duplicate header
* address review
* Updated experiments
* update formatting
* resolve conflict
* Address review comments
* Remove use of rand
* Automated change: Fix sanity tests
* Fix test errors
Co-authored-by: ananda1066 <ananda1066@users.noreply.github.com>
2 years ago
Craig Tiller
1f15f21540
Revert "Revert "Revert "[experiments] Enable memory_pressure_controller for debug builds ( #31811 )" ( #31824 )" ( #31832 )" ( #31846 )
...
This reverts commit 322e85253e
.
2 years ago
Craig Tiller
322e85253e
Revert "Revert "[experiments] Enable memory_pressure_controller for debug builds ( #31811 )" ( #31824 )" ( #31832 )
...
This reverts commit 4d7df5580d
.
2 years ago
Craig Tiller
4d7df5580d
Revert "[experiments] Enable memory_pressure_controller for debug builds ( #31811 )" ( #31824 )
...
This reverts commit 244e39b86e
.
2 years ago
Craig Tiller
244e39b86e
[experiments] Enable memory_pressure_controller for debug builds ( #31811 )
...
* [experiments] Enable memory_pressure_controller by default
* fix found crash
* fixy
2 years ago
Craig Tiller
1bfc50f27e
[experiments] Enable flow_control_fixes by default ( #31810 )
2 years ago
Vignesh Babu
6eb6e00954
Enable posix_event_engine_polling experiment ( #31801 )
2 years ago
Cheng-Yu Chung
ddc5a62409
Revert "Add global structure of allocators + experiment ( #31614 )" ( #31759 )
...
This reverts commit 6754018dd1
.
2 years ago
Alisha Nanda
6754018dd1
Add global structure of allocators + experiment ( #31614 )
...
* Global allocator experiment
* Fix formatting and deps
* Update experiments files formatting
* Small fixes
* Change uint formatting
* Automated change: Fix sanity tests
* Fix formatting
* Address review comments
* Clean up logging
* Automated change: Fix sanity tests
* Fix clangtidy
* remove duplicate header
* address review
Co-authored-by: ananda1066 <ananda1066@users.noreply.github.com>
2 years ago
Craig Tiller
a1dc498356
[flow_control] Enable experiment in debug builds ( #31693 )
3 years ago
Craig Tiller
0d4000dd48
[resource_quota] Remove periodic resource quota experiment ( #31670 )
3 years ago
Craig Tiller
1b9ab18251
[experiments] Enable tcp_read_chunks by default ( #31499 )
3 years ago
Craig Tiller
141bc3b634
[experiments] Reland enabling tcp_read_chunks for debug builds ( #31420 )
...
* Revert "Revert "[experiments] Enable tcp_read_chunks for debug builds (#31374 )" (#31417 )"
This reverts commit 987b50a258
.
* Fix read failure
* fixes
3 years ago
Craig Tiller
987b50a258
Revert "[experiments] Enable tcp_read_chunks for debug builds ( #31374 )" ( #31417 )
...
This reverts commit d05830cb02
.
3 years ago
Vignesh Babu
e8c30b487f
Invoking Poller::Work in posix event engine constructor ( #31128 )
...
* adding Poller::Work to event engine constructor
* iwyu
* iwyu
* cleanup
* regenerate projects
* fix
* comments
* add experiments flag
* fix
* newline
* newline
* iwyu
* remove some ifdefs
* fix tsan issue in bm_event_engine_run
* Add a quiesce to threadpool
* fix
* Automated change: Fix sanity tests
* disable posix_event_engine_test on windows
Co-authored-by: Craig Tiller <ctiller@google.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
d05830cb02
[experiments] Enable tcp_read_chunks for debug builds ( #31374 )
...
* [experiments] Enable tcp_read_chunks by default
* [tcp] Fix bug in min_progress_size reads
* only debug
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
c7e600a31d
[resource_quota] Flag flip periodic reclamation ( #31326 )
3 years ago
Craig Tiller
beb5bdca62
[promises] Promise based grpc_call ( #29598 )
...
* Automated change: Fix sanity tests
* fix
* fixes
* fixup allocator story - we should require a context
* fixes
* doodling
* context scribbles
* [arena] Add ManagedNew(), gtest-ify test
Add a ManagedNew() method to Arena that calls the relevant destructor at Arena destruction time.
There are some cases coming up in the promise based call work where this becomes super convenient, and I expect it's likely that there are other places that's true too.
* Automated change: Fix sanity tests
* progress
* lalalal
* progress
* x
* Automated change: Fix sanity tests
* fixes
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* fix client streaming
* handle invalid flags
* Automated change: Fix sanity tests
* no logging
* progress
* progress
* channelz
* tentative fix
* fix
* lalala
* Automated change: Fix sanity tests
* more readable trace
* logging improvements, leading to bug fix in connected channel
* fix
* improve debuggability
* fix
* progress to better refcounting
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* threading
* Automated change: Fix sanity tests
* fix
* fix
* improve debuggability
* fix
* fix
* Automated change: Fix sanity tests
* fix
* make promises runtime configurable
* Automated change: Fix sanity tests
* fix
* fix build
* fix broken test
* clean up api
* deal with stats better
* peer string!
* introduce fragments
* Automated change: Fix sanity tests
* use fragments
* stuff
* [promises] Add AtomicWaker type
* Automated change: Fix sanity tests
* fix
* fix write path
* fix
* polling-entity-hell
* review feedback
* fix
* fix
* fix
* fix
* make an experiment
* [experiments] Make output more diffable/readable
* Automated change: Fix sanity tests
* buildifier sized indentations
* fix
* fix
* Automated change: Fix sanity tests
* fix?
* fix promise
* prototype
* progress
* implement new api
* Revert "fix promise"
This reverts commit ded85e7d19
.
* Revert "Revert "fix promise""
This reverts commit c2acef1958
.
* progress
* done
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* updates
* review feedback
* first pass feedback
* Automated change: Fix sanity tests
* review feedback
* naming
* better-logs
* fix test
* Automated change: Fix sanity tests
* comments
* fix
* progress
* validation
* iwyu
* fix
* ugh this needs to be any
* fix flakiness in asan
* call tracing
* cleanup unused args
* fix windows
* fix build
* ugh
* fix tsan race
* threading-fix
* bloat1
* bloat2
* bloat3
* fix
* unused-args
* sanity
* iwyu
* fix
* fix
* this is ok
* iwyu, exchange
* fix
* Automated change: Fix sanity tests
* fix ee lifetime issue
* fix
* review feedback
* Automated change: Fix sanity tests
* comment
* x
* fix tsan race
* iwyu
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
62c2260dc2
[experiments] Add a placeholder experiment to test rollout monitoring ( #31110 )
3 years ago
AJ Heller
2025ba250a
Add an experiment for EventEngine::Client usage ( #30969 )
...
* Add experiment for EventEngine::Client usage
* correct experiment tags
3 years ago
Craig Tiller
fb3c83906c
[chttp2] Enable new huffman decoder for debug builds ( #30959 )
3 years ago
Craig Tiller
92f58c18a8
Revert "Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )" ( #30962 )
...
This reverts commit bfea47093f
.
3 years ago
Craig Tiller
bfea47093f
Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )
...
This reverts commit 6c7f921f5f
.
3 years ago
Craig Tiller
6c7f921f5f
[chttp2] Improve huffman decode efficiency ( #30479 )
...
* first pass
* refinement #1
* fix
* opt
* 8
* 5
* 12
* 10
* 7
* 15
* 8n
* 15n
* 8a
* 16a
* 15a
* 5a
* 10a
* 7a
* 9a
* 12a
* 11a
* 11b
* 11b
* 7b
* 15b
* 14b
* 15i
* 12i
* 9i
* 10i
* finalizing
* fix
* tweak
* 10f
* 10r
* 7r
* 8r
* 9r
* more
* rething
* 8s
* 9s
* 12s
* 7s
* 10s
* 15snr
* 12snr
* 14snr
* 13snr
* 11snr
* 20snr
* 15snr
* 18snr
* 7snr
* 7snr
* 12-2stp
* 13-2stp
* 14-2stp
* 11-2stp
* 10-2stp
* 9-3stp
* 8-3stp
* 7-3stp
* 8-2stp
* auto-tune1
* max-depth-2
* max-depth-3
* max-depth-2
* abbreviate
* working version
* add benchmark
* fix
* fix
* fix
* ditch define
* better code layout
* static fns
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix build
* cleanup and comment
* fmt
* fix
* test
* tag
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* progress
* progress
* progress
* fixes
* cleanup
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fmt
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* add encode/decode fuzzer
* Automated change: Fix sanity tests
* fix
* fix
* fix
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
f9b866ff8b
[chttp2] Use experiments framework for peer_state_based_framing ( #30853 )
...
* [chttp2] Use experiments framework for peer_state_based_framing
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
47a43d68c9
[chttp2] Tune initial window size/max frame size setting ( #30550 )
...
* [chttp2] Tune initial window size/max frame size setting
- Only choose frame sizes and initial window sizes that are powers of two - as a more predictable function to avoid flapping.
- If window size drops below 1kb then snap to 0 to avoid frantically changing a value that needn't be
- Allow the initial window size to drop to zero (we have fuzzing in place that says this is safe)
* copy/paste fix
* fix build
* fix
* Automated change: Fix sanity tests
* fix announce bug
* cleanup
* put this change under an experiment
* more tests
* fix build
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
e705b2e3c7
[resource_quota] Move experiments to the experiments framework ( #30830 )
...
* fix
* fix tests
* fix
* Automated change: Fix sanity tests
* better expansion
* bleh
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
ca8b437613
[experiments] Single experiments flag ( #30822 )
...
* single experiments flag
* add missing files
* fix
* empty-string-fix
* fix
* Automated change: Fix sanity tests
* ensure cold path is out of line
* add log for enabled/disabled experiments
* remove bad sentence
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
8b13c0d581
[iomgr] SO_RCVLOWAT impl for grpc ( #30736 )
...
* [stats] Cleanup stats system
* clear out optionality
* fix
* might as well...
* Automated change: Fix sanity tests
* only allocate 8k or 64k blocks for tcp reads
* Automated change: Fix sanity tests
* fix
* Update tcp_posix.cc
* Automated change: Fix sanity tests
* [chttp2] Inform endpoint of min progress size
* respect target, min progress sizes
* cleaner loops
* clean out more unused stuff
* clean out more unused stuff
* Automated change: Fix sanity tests
* update
* [iomgr] SO_RCVLOWAT impl for tcp
* tsan race
* tsan race
* fix
* Automated change: Fix sanity tests
* Introduce flag
* protect with flag
* [experiments] Make output more diffable/readable
* Automated change: Fix sanity tests
* buildifier sized indentations
* add experiment
* Update tcp_posix.cc
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
903e0490ea
[iomgr] Restrict TCP read allocations to 8kb or 64kb ( #30626 )
...
* [stats] Cleanup stats system
* clear out optionality
* fix
* might as well...
* Automated change: Fix sanity tests
* only allocate 8k or 64k blocks for tcp reads
* Automated change: Fix sanity tests
* fix
* Update tcp_posix.cc
* Automated change: Fix sanity tests
* respect target, min progress sizes
* cleaner loops
* clean out more unused stuff
* clean out more unused stuff
* Automated change: Fix sanity tests
* update
* tsan race
* Automated change: Fix sanity tests
* Introduce flag
* protect with flag
* [experiments] Make output more diffable/readable
* Automated change: Fix sanity tests
* buildifier sized indentations
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
c580d0d9a7
[experiments] Add experiment framework ( #30775 )
...
* [experiments] Add experiment framework
* auto-ci-config
* fix
* fix
* Automated change: Fix sanity tests
* support different configs
* Automated change: Fix sanity tests
* cleaner generated code
* Automated change: Fix sanity tests
* enforce expiry
* make sure expiry isnt far in the future
* fix
* Automated change: Fix sanity tests
* remove specified testing
* cleaner
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* docstring
* clean up code
* Automated change: Fix sanity tests
* review feedback
* build fix
* Automated change: Fix sanity tests
* ownership
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago