2cb3831c83
fix retry code to fail batches instead of creating attempt if previously cancelled from surface ( #27217 )
...
* fix retry code to fail batches instead of creating attempt if previously cancelled from surface
* add xDS end2end tests covering the FI use-case that triggered the bug
* fix memory leak
3 years ago
cb2e7554a3
xds_end2end_test: Fix UnsupportedHttpFilter test on aws ( #27147 )
3 years ago
59fc02a94b
Enabling Ring Hash by default. ( #27111 )
3 years ago
6da9eb9f3f
xDS PSM Server Security: Nack unsupported require_sni and ocsp_staple_policy values ( #26878 )
...
* Nack unsupported require_sni and ocsp_staple_policy values
* Reviewer comments
3 years ago
0ab13090e7
Nack certain unsupported fields in CertificateValidationContext ( #26880 )
...
* Nack certain unsupported fields in CertificateValidationContext
* Regenerate projects
* Reviewer comments
3 years ago
58f8f5ced3
Add macro to define gtest death_test_style using an older syntax ( #27042 )
...
This temporarily unblocks a related gtest upgrade. The ultimate goal is
to upgraade our gtest dependencies, but I don't have the cycles to
manage a potentially messy migration until at least next week. This PR
is coordinated with an internal change.
3 years ago
9f782faa34
xds: remove env var protection for retries ( #27039 )
3 years ago
404e56b2d9
Fix XdsEnabledServerTest ( #26956 )
3 years ago
3fd01fabae
Add thread safety annotations ( #26871 )
...
This exposes a bug in clang, reported upstream as
https://bugs.llvm.org/show_bug.cgi?id=51368 .
The clang bug is mitigated using a fake scoped lock; that allows the
current code to compile while also serving as a change detector to
prevent it from going stale; if the compiler bug is fixed, the compiler
will see an overlapping locking requirement, and reject this code, which
will prompt a human being to remove this workaround.
3 years ago
29d220a0ef
Re-experimentalize XdsServerBuilder ( #26892 )
...
* Re-experimentalize XdsServerBuilder
* Fix compiler issue
3 years ago
013e67a029
Deprecate grpc{_core,::internal}::WaitUntil ( #26866 )
...
It is not possible for such a function to be implemented in a way that
is understood by annotalysis. Mark it deprecated and replace instances
of its use with direct mutex/condvar usage.
Add a bunch of missing thread safety annotations while I'm here.
3 years ago
86c9de8231
Remove `grpc_core::WaitUntilWith{Deadline,Timeout}` ( #26867 )
...
These functions are essentially unused.
3 years ago
6b71ec3704
LB policy API improvements ( #26481 )
...
* LB policy API improvements
* clang-format
* fix build
* a bit more cleanup
* use absl::variant<> for pick result
* fix retry_lb_drop test
* clang-format
* fix grpclb_end2end_test
* fix xds_end2end_test
* try to make variant code a bit cleaner
* clang-format
* fix memory leak
* fix build
* clang-format
* fix error refcount bug
* remove PickResult factory functions
* clang-format
* add ctors to structs
* clang-format
* fix clang-tidy
* update comments
* move LB recv_trailing_metadata callback instead of copying it
* use Match() instead of providing PickResult::Handle()
* don't use Match() for now, since it breaks lock annotations
* update retry_lb_fail test
3 years ago
49b5f9c420
Fix XdsServerSecurityTest ( #26817 )
3 years ago
7eaf37bce5
Adding retry policy ( #26566 )
3 years ago
3104a9964c
xds: validate that terminal filters come at the end of the filter chain ( #26742 )
...
* xds: validate that terminal filters come at the end of the filter chain
* clang-format
3 years ago
246c57829b
xds: notify watchers when NACKing resource updates ( #26757 )
...
* xds: notify watchers when NACKing resource updates
* check status of failed RPC when waiting for NACK
3 years ago
d73ec07fe7
Fix small typo in xds end2end test ( #26685 )
3 years ago
c52005c161
NACK xDS updates when certificate provider instace names are unrecognized ( #26614 )
...
* NACK xDS updates when certificate provider instace names are unrecognized
* Reviewer comments
* Reviewer comments
* Clang format
* Fix compilation error
3 years ago
b97693d572
[Roll Forward] Tighten the error tolerance requirement by 100x ( #26626 )
...
* Tighten the error tolerance requirement by 10x
* Make it 5 sigma instead of 4.5
* Rewrap comments
* Loosen the max concurrent requests in certain test cases
3 years ago
670a26caef
NACK xDS updates where transport_name is not recognized ( #26612 )
...
* NACK xDS updates where transport_name is not recognized
* Reviewer comments
3 years ago
095045b31c
NACK xds updates requiring client certificates when no validation certificate provider instance is mentioned ( #26613 )
3 years ago
8b5fbf8900
TLS Security Connector: Add an always-fail-handshaker when certificates are not ready ( #26561 )
...
* TLS Security Connector: Add an always-fail-handshaker when certificates are not ready
* Reviewer suggestion
* Add test
3 years ago
4daedf0233
De-experimentalize XdsServerBuilder ( #26543 )
3 years ago
f198fb5b41
Revert "Tighten the error tolerance requirement by 100x ( #26588 )" ( #26593 )
...
This reverts commit f835f3f97c
3 years ago
f835f3f97c
Tighten the error tolerance requirement by 100x ( #26588 )
...
* Tighten the error tolerance requirement by 10x
* Make it 5 sigma instead of 4.5
* Rewrap comments
3 years ago
34bf26357b
Change StringMatcher to not support case-insensitive regex matching. ( #26567 )
...
* Change StringMatcher to not support case-insensitive regex matching.
* clang-format
* clang-tidy
3 years ago
cf1ebf7387
Remove experimental tag from uses of the C++ callback API ( #26495 )
4 years ago
bb994526ba
Fix ExistingRpcsOnResourceDeletion flakiness ( #26419 )
4 years ago
a36199b2d5
Tighten the probability requirement from 99.99% to 99.995% ( #26408 )
...
* Tighten the probability requirement from 99.99% to 99.995%
* Update comments
4 years ago
e22fefb39a
Ring hash implementation ( #26356 )
...
* Ring hash implementation
* Fixing an error caught during import:
ipv6 addresses need small modifications when creating the ring entry.
* fixing an error
* removing debugs
* Remove unnecssary hashing
* small cleanup
4 years ago
edae7450f5
fix LOGICAL_DNS semantics ( #26147 )
...
* WIP: fix LOGICAL_DNS semantics
* fix tests and address FIXME
* clang-format
* add "dns:" prefix before creating resolver
4 years ago
2bb20d25a4
Revert "ring_hash LB policy implementation ( #26285 )" ( #26303 )
...
This reverts commit c55c7c065e
4 years ago
c55c7c065e
ring_hash LB policy implementation ( #26285 )
...
* ring_hash LB policy (#25697 )
* Ring Hash Policy implementation
* Code review comment fixing
* Fixing code review comments.
* Code review comment fixing
* Fixing reconnect logic
* adding helper method for pick
* Holding on to ref to parent
* first attempt at calling AttemptToConnect
* Fixing state change
* Fixing code review comments
* Fixing the reconnect from channel watcher code
* Fixing the BUILD to include new policy
* Fixing major code review suggestion
* Fixing code review comments
* Fixing code review suggestions
* Initial 2 tests.
* Adding channel id case.
* Fixing code review comments.
* Small change to get the spread of backends
* Add header hashing tests
* Added more tests and debugging
* Fixing Header hash
* Added more tests
* cleanup
* removing debugs
* Fixing code review comments.
* code review fixing
* combining code and match design
* fixing code review comments.
* Fixed IDLE case
* Moving tests
* Fixing code review comments
* Adding more tests according to code review comments.
* Added tests with differetn types of weights
* Adding terminal policy case
* Remove hash_func as there is only 1
* Added nack invalid hash function
* Added NACK cases
* fixing build error
* fixing build
* small warning
* adding regex test
* Adding policy tests
* fixing warning
* fixing warning
* fixing code reivew comments.
* fixing IDLE case
* Code review comments.
* fixing code review comments
* Making a helper function
* fixing reattempt case
* Added afew more tests.
* Adding more tests
* Added backward compatible test
* FIxing the reattempt test
* Clean up
* fixing clang error
* fixing clang error
* Fix logic discovered during code review
* code review comments
* code review comments
* code review comment
* clean up tests
* fixing code review comments
* clean up tests
* Separated test
* Fixing test
* fixing test
* fixing clang error
* Addressing code review suggestions
* Fixing last bit of code review comments
* Fixing flaky tests
* Fixing last bit of code review comments
* clean debugs
* Remove a verbose log
* Relaxing deadline exceeded for 1st RPC until ring is optimized.
Making Hash more efficient for random case.
4 years ago
467c0d742c
fix xds resolver to add XdsClient to channel args even on errors ( #26282 )
4 years ago
f36a31b6aa
Revert "ring_hash LB policy ( #25697 )" ( #26238 )
...
This reverts commit 2aefb26f5d
4 years ago
2aefb26f5d
ring_hash LB policy ( #25697 )
...
* Ring Hash Policy implementation
* Code review comment fixing
* Fixing code review comments.
* Code review comment fixing
* Fixing reconnect logic
* adding helper method for pick
* Holding on to ref to parent
* first attempt at calling AttemptToConnect
* Fixing state change
* Fixing code review comments
* Fixing the reconnect from channel watcher code
* Fixing the BUILD to include new policy
* Fixing major code review suggestion
* Fixing code review comments
* Fixing code review suggestions
* Initial 2 tests.
* Adding channel id case.
* Fixing code review comments.
* Small change to get the spread of backends
* Add header hashing tests
* Added more tests and debugging
* Fixing Header hash
* Added more tests
* cleanup
* removing debugs
* Fixing code review comments.
* code review fixing
* combining code and match design
* fixing code review comments.
* Fixed IDLE case
* Moving tests
* Fixing code review comments
* Adding more tests according to code review comments.
* Added tests with differetn types of weights
* Adding terminal policy case
* Remove hash_func as there is only 1
* Added nack invalid hash function
* Added NACK cases
* fixing build error
* fixing build
* small warning
* adding regex test
* Adding policy tests
* fixing warning
* fixing warning
* fixing code reivew comments.
* fixing IDLE case
* Code review comments.
* fixing code review comments
* Making a helper function
* fixing reattempt case
* Added afew more tests.
* Adding more tests
* Added backward compatible test
* FIxing the reattempt test
* Clean up
* fixing clang error
* fixing clang error
* Fix logic discovered during code review
* code review comments
* code review comments
* code review comment
* clean up tests
* fixing code review comments
* clean up tests
* Separated test
* Fixing test
* fixing test
* fixing clang error
* Addressing code review suggestions
* Fixing last bit of code review comments
* Fixing flaky tests
* Fixing last bit of code review comments
* clean debugs
* Remove a verbose log
4 years ago
4c40ee3f78
move parse_address and sockaddr_utils out of iomgr directory ( #26077 )
...
* move parse_address and sockaddr_utils out of iomgr directory
* clang-format
* fix python
* fix for import
* fix build file for import
4 years ago
1b26c897c1
Fix build failures in xds_end2end_test ( #26127 )
4 years ago
a994aad0b8
xds_end2end_test test infra: Eds Args refactoring and enhancing WaitForBackend ( #26093 )
...
* Refactoring EdsResourceArgs::Locality to have a vector of Endpoints:
port, health_status, and lb_weight.
As well, Adding RpcOption to WaitForBackend()
* Update WaitForBackend
* Modified WaitForBackend default param
* reuse SeenBackend
* Code review comments
* refactor WaitForAllBackend parameter list
* Fixing tests to ensure they are more strict;
Fixing test code according to code review comments.
* Fixing code review suggestions
* Increasing timeout for StressTest
4 years ago
13e04b4b9c
Reduce xds_end2end_test's error tolerance to 0.05 ( #25738 )
...
* WIP sync API with 1.6k threads doesn't work
* Please don't fail
* Fix the tests
* Spread to DropTest
* Code clean-up and extend delay RPC timeout
* Address comments
* Address comments
* Deflake MSAN
* Make MSAN more robust && normal runs faster
* Address comments
* Remove the clock change in fault injection filter
* Polish comments && stricten the connection timeout
4 years ago
4768210ec8
s/OnServingStatusChange/OnServingStatusUpdate ( #26010 )
...
* s/OnServingStatusChange/OnServingStatusUpdate
* Update python files
4 years ago
460898f11c
Migrated from grpc_error_string to grpc_error_std_string ( #26068 )
...
* Added grpc_error_std_string
* Migrated to grpc_error_std_string
4 years ago
ca945a58e9
Introduced grpc_error_handle ( #25902 )
...
- Define grpc_error_handle
- Replace grpc_error* with grpc_error_handle
4 years ago
89f7e53dbc
Fixing flake in AllServerUnavailbleFailFast by increasing the RPC ( #26015 )
...
timeout from 1 second to 5: this ensures there is enough time for
communication with xDS server to get established.
4 years ago
feff79abc7
add test-only channel arg to set per-channel xDS bootstrap config ( #25936 )
...
* pass XdsClient to LB policies via channel args
* add channel arg for overriding bootstrap config on a per-channel basis
* change tests to use new channel arg approach -- currently failing for server-side tests
* use the same channel args approach on the server side
* clang-format
* fix CircuitBreakingMultipleChannelsShareCallCounter test
* fix XdsEnabledServerTest test
* add TODO
* clang-format
* generate_projects
* fix clang-tidy
* fix build
* attempt to fix python
4 years ago
3a19648100
Increase RPCs in fault injection tests ( #25984 )
4 years ago
8028cc874d
Reduce XdsServerFilterChainMatchTest flakiness ( #25956 )
4 years ago
3409eddcd1
xds-end2end-test server-side LDS updates cleanup ( #25906 )
4 years ago
8eaaa3d7b6
Make ADS timeout increase from 500 to 2000 ( #25844 )
4 years ago
Mark D. Roth
Yash Tibrewal
donnadionne
AJ Heller
Tamir Duberstein
Tamir Duberstein
Alisha Nanda
Lidi Zheng
Vijay Pai
Esun Kim