815029fe2b
Revert "Move TCP Connect into its own handshaker. ( #29111 )" ( #29558 )
...
This reverts commit 0675af8511
3 years ago
0675af8511
Move TCP Connect into its own handshaker. ( #29111 )
...
Currently the tcp connect is performed in chttp2_connector before the handshaking is triggered. For
use cases where the application wants to perform business logic before
the tcp connection, this is problematic. By moving the TCP connect into
its own handshaker and registering it by default at the beginning, this
allows applications to add a new handshaker at the beginning allowing
handshaker logic before a TCP connect.
This approach has the advantage of slightly simplifying the logic in
tcp_connect_handshaker and httpcli as tcp_connect/callback can be
removed.
As the TCP connect needs parameters like resolved_addr,
interested_parties, a new struct called connection args is created as a
member for Handshaker Args.
For server handshakers most of the arguments here are not directly
useful, other than the deadline.
3 years ago
be53d2ce3f
LB policy API: add OOB backend metric API ( #29012 )
...
* WIP: add OOB backend metric API for LB policies
* fix some includes
* minor fixes
* picking this up again...
* more WIP
* health checking: cancel stream if response message fails to parse
* basic structure in place, but still have synchronization issues to address
* ORCA: implement ORCA RPC service for OOB backend metric reporting
* fix unused parameter error
* gen_upb_api
* add missing build deps
* increase test timing fudge factor
* add missing copyright header
* fix build and locking problems
* clang-format
* document API
* buildifier
* add test, but doesn't build yet
* new test working, but broke existing test, and need to fix server API
* don't register as a generic service
* update test for new orca service registration API
* fix build
* sanitize
* report interval defaults to min interval
* add channel trace event on UNIMPLEMENTED
* don't regenerate the response proto unless something changed
* add missing build dep
* fix comment
3 years ago
98fc0260e3
Bump dev version to v1.47.0-dev ( #29414 )
...
* bump version to 1.47.0-dev
* regenerate projects
3 years ago
9796969b0c
Filter content-length metadata ( #29295 )
3 years ago
33aaa55032
Filter fuzzer ( #29177 )
...
* begin
* tests
* fix
* http
* Filter fuzzer
* progress
* basics
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f6724d02d2e7307960842f48a6f224e4a1951844e8574d641c42814001b957cbd135c61043
3 years ago
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
e122c64000
Revert "Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )" ( #29182 )
...
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f6724d02d2e7307960842f48a6f224e4a1951844e8574d641c42814001b957cbd135c61043
3 years ago
ba41407ea6
Reland max_age filter -> promises ( #29127 )
...
* TrySeq fix
* Revert "Revert "Revert "Revert "Convert max_age filter to promises (#28904 )" (#28957 )" (#28958 )" (#29105 )"
This reverts commit ff14d1d7f3
3 years ago
6989129db5
xDS RLS implementation ( #29200 )
...
* Revert "Revert "Initial structure for RLS (#28750 )" (#29189 )"
This reverts commit 7ece810843
3 years ago
7ece810843
Revert "Initial structure for RLS ( #28750 )" ( #29189 )
...
This reverts commit 362e0b8706
3 years ago
362e0b8706
Initial structure for RLS ( #28750 )
...
* Initial structure for RLS
* Adding and building the proto to parse the Any proto for the plugins
* re-org
* Parsing the plugin
* Parsing more into json
* Parsed proto to json
* small cleanup
* Adding prefix
* Added new rls_experimental policy
* build files
* Fixing according to code review comments
* code review comments
* Adding sym changes
* adding action name check
* fixing code review comments.
* fixing unused var error
* clean up
* fixing code review comments
* fixing code review comments
* fixing according to code review comments.
* Remove unnecessary include
* small fix
* generate more, hard-code less
* Moving to using absl::variant
* absl::string_view and absl::variant of vector of std::string are not
playing nice together.
* fixed variant
* Using absl::variant now
* Checkint used plugins
* Refactor Parsing code and separating out Parsing of the plugin
* Fixing code review comments
* code review comments
* fixing code review comments.
* Addressing code review comments
* First end-to-end test
* generated build files
* commit generated files via tools/codegen/core/gen_upb_api.sh
* Fixing rls policy parsing tests
* Restore checks for the test server
* Refactor rls_server
* added keys to rls request
* fixing small logic error
* Complete the test using all the keys
* Separating out RLS test and rls_server thread
* sanity errors
* generated build files
* Complete the rest of the tests and sanity cleanup
* fixing code review comments: using upb_JsonEncode now!
* fixing code review comments
* fixing code review comments
* Fixing code review comments
* misisng fix
* simplifying tests
* simplify tests 2
* Linking in the correct proto for rls_config
* restore metadata check
* Add disable test
* Fixing RLS test and removing environment var that is no longer necessary
* Fixing "Wrong type" type of tests after json parsing change to accept
STRING for number
* adding json_encode.h/c to src/upb/gen_build_yaml.py and generate
necessary files.
* Fixing un-used var error
* fixing sanity errors
* Fixing the upb encoding buffer
* Fixing code review comments.
* Adding nack test for unkonwn plugin proto
* Last bit of code review comments
* fixing unused variable
3 years ago
6ee276f672
Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )
...
This reverts commit 41debbf1a7
3 years ago
41debbf1a7
HTTP Client Filter --> promises ( #29031 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* roughing out
* push/pull impl
* comment
* prove out new combinator
* Simplify naming
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* builds
* Automated change: Fix sanity tests
* progress
* tweak
* merge
* progress
* fix
* first test passes
* progress
* fix
* repair name
* fix
* small fix
* small fix
* properly stop call combiner
* fix allocation in this benchmark
* fix
* fix
* fix merge
* fix bad merge
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
766cd6b573
Remove epollex poller ( #29160 )
...
* start delete
* remove build.gn... again
* remove more
* Automated change: Fix sanity tests
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
01f333a1c1
TlsCredentials: Comparator implementation ( #28940 )
...
* TlsCredentials: Comparator implementation
* Update tests
* Redundant namespace qualifiers
* clang-tidy
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Add generator for grpc_tls_credentials_options.h
* Generator script modifications for tests
* Sanity
* Reviewer comments
* Reviewer comments
* Add a common place to look-up known types
* Formatting
* Script fix
* Reviewer comments
* Add test mode to script
* Add to sanitize.sh
* clang-tidy
* Fix
* Fix
* Reviewer comments
* Clang-format
3 years ago
ccf70cf273
Reland channel args C++ type ( #29113 )
...
* Revert "Revert "Introduce ChannelArgs C++ type (#28860 )" (#29106 )"
This reverts commit f0283aac40
3 years ago
0ea1eeb4e7
Expose channel stack type to builder ( #29088 )
...
* split builder
* expose channel stack type to builder
* Automated change: Fix sanity tests
* Update channel_stack_builder_impl.h
* Update channel_init.h
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
f0283aac40
Revert "Introduce ChannelArgs C++ type ( #28860 )" ( #29106 )
...
This reverts commit f82245555e
3 years ago
ff14d1d7f3
Revert "Revert "Revert "Convert max_age filter to promises ( #28904 )" ( #28957 )" ( #28958 )" ( #29105 )
...
This reverts commit d589f4e6ca
3 years ago
f82245555e
Introduce ChannelArgs C++ type ( #28860 )
...
* progress
* basics
* Automated change: Fix sanity tests
* fix
* fix
* backout protochange
* consistency in naming
* Make things load bearing, fix bugs
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
d589f4e6ca
Revert "Revert "Convert max_age filter to promises ( #28904 )" ( #28957 )" ( #28958 )
...
* Revert "Revert "Convert max_age filter to promises (#28904 )" (#28957 )"
This reverts commit f18e6ede04
3 years ago
0c7b37a4a3
refactor health check client to allow reuse for OOB backend metric reporting ( #29024 )
...
* refactor health check client to allow reuse for OOB backend metric reporting
* clang-format
* improve comments
3 years ago
e8c5c39143
retry: fix bug where we incorrectly replayed a completed send_message op ( #29025 )
...
* retry: fix bug where we incorrectly replayed a completed send_message op
* fix
* third time's the charm!
* clang-format
3 years ago
138c4667c9
Change main argument of call promise to be a struct ( #29019 )
...
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* Simplify naming
* tweak
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
707aad777d
resolver: refactor common code for polling-based resolvers ( #28979 )
...
* resolver: refactor common code for polling-based resolvers
* remove now-incorrect assertion
* fix cleanup bug
* add missing include guards
* portability fix
* fix some lifetime issues
* plumb tracer into PollingResolver
* fix pollset_set propagation
* increase RPC timeout in python DNSResolverTest
* add dns_resolver tracer and fix ref leak
* code review comments
* check shutdown_ in OnNextResolutionLocked()
3 years ago
99a30de9e7
Bump version to 1.46.0-dev (on master branch) ( #29064 )
...
* bump version to 1.46.0-dev
* regenerate projects
3 years ago
fe913387da
Remove idempotent/cacheable requests ( #28922 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* Modify XdsRbacTests
Co-authored-by: Yash Tibrewal <yashkt@google.com>
3 years ago
047642c5c4
Call finalization for promises ( #29008 )
...
* Call finalization for promises
* comment
* split out and test
* dont use promise_detail:: directly
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
87acbadba1
Third attempt: Convert client_auth_filter to promises ( #28968 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* Revert "Revert "Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )" (#28952 )" (#28967 )"
This reverts commit 0f73576b17
3 years ago
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
c27f8f1505
Fourth attempt: Implement transparent retries ( #28943 )
...
* Revert "Revert "Third attempt: Implement transparent retries (#28925 )" (#28942 )"
This reverts commit be70a8676c
3 years ago
c08eb4fc41
Attempt to upgrade upb to the latest ( #28685 )
...
* Update upb to 85e5c76cb7098d3ae35e575d652a40568013a149
* Update grpc_deps.bzl
* Run gen_upb_api.sh
* Run run_sed.sh
* Update gen_build_yaml.py
* Regen projects
* Reformat
* Update third_party/upb to 950cdab42fe4c83f06a2be46eeb46a068e486eed
* Update third_party/upb to c9c31241bc39922b092a81d192badd50cccaaa81
* Update src/upb/gen_build_yaml.py
* Generated projects
* Update third_party/upb to a02d92e0257a35f11d4a58b6a932506cbdbb2f29
* Patching in https://github.com/protocolbuffers/upb/pull/524
* Sed script went too far.
Co-authored-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>
3 years ago
0f73576b17
Revert "Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )" ( #28967 )
...
This reverts commit 235098de22
3 years ago
3d4433beb2
retry: always free cached send op data ( #28956 )
...
* Revert "Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation (#28945 )" (#28954 )"
This reverts commit 9498843a18
3 years ago
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
235098de22
Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )
...
* Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )"
This reverts commit 5bfe38f10f
3 years ago
f18e6ede04
Revert "Convert max_age filter to promises ( #28904 )" ( #28957 )
...
This reverts commit ae4b45d75a
3 years ago
ae4b45d75a
Convert max_age filter to promises ( #28904 )
...
* start
* stuff
* build
* Automated change: Fix sanity tests
* fix
* finish him
* fix
* better
* fix
* review feedback
* Update channel_idle_filter.cc
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
9498843a18
Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation ( #28945 )" ( #28954 )
...
This reverts commit f48c4f1f4b
3 years ago
5bfe38f10f
Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )
...
This reverts commit cadce47ebf
3 years ago
cadce47ebf
Convert client_auth_filter to promises ( #28767 )
...
* Convert client_auth_filter to promises
* outline
* x
* x
* fixes
* remove-spam
* Async sequences over iterators
* iterate
* better semantics
* fix
* clang-tidy
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* progress
* progress
* progress
* progress
* credentials_test passes
* Automated change: Fix sanity tests
* Make Activity more of an interface
Move mutex and wakeup logic into a new class between PromiseActivity<>
and Activity (so that the sharing can persist), but make Activity closer
to a pure interface, so that whilst we migrate code we can implement
better fakes without forcing allocation.
* fixes
* Automated change: Fix sanity tests
* fixes
* test the awful failure
* x
* fix typo
* fix race
* 4.9
* x
* review feedback
* review feedback
* Automated change: Fix sanity tests
* review feedback
* replace AuthMetadataContext interface with GetRequestMetadataArgs struct
* Automated change: Fix sanity tests
* fix merge
* Fixup
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
f48c4f1f4b
retry: fix memory leak due to not freeing cached send ops upon cancellation ( #28945 )
...
* retry: fix memory leak due to not freeing cached send ops upon cancellation
* clang-format
* attempt to fix proxy tests on windows
3 years ago
dd76a04b8c
Move resolver to core configuration ( #28881 )
...
* Move resolver to core configuration
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* resolver: clean up and modernize registry
* fix race
* update visibility
* fix internal error
* review feedback
* resolve backref issues
* windows
* x
* fix sockaddrs on windows?
* fix sockaddrs on windows?
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
ff87ca02b2
Revive test/core/memory_usage ( #28931 )
...
* Revert "Deprecate gpr_get/set_allocation_functions"
This reverts commit 81df105ac8
3 years ago
be70a8676c
Revert "Third attempt: Implement transparent retries ( #28925 )" ( #28942 )
...
This reverts commit 9e7453409a
3 years ago
9e7453409a
Third attempt: Implement transparent retries ( #28925 )
...
* Revert "Revert "Revert "Revert "Implement transparent retries (#28548 )" (#28888 )" (#28890 )" (#28909 )"
This reverts commit 23da14c1a7
3 years ago
25aa80966a
retry: fix memory leak if call is unreffed without starting recv_trailing_metadata ( #28913 )
...
* retry: fix memory leak if call is unreffed without starting recv_trailing_metadata
* fix test flake
3 years ago
23da14c1a7
Revert "Revert "Revert "Implement transparent retries ( #28548 )" ( #28888 )" ( #28890 )" ( #28909 )
...
This reverts commit 9f90e6d906
3 years ago
0f424ae5cc
Move client-idle-filter to promises ( #28838 )
...
* Promise based sleep
* Embrace absl::Status
* Automated change: Fix sanity tests
* Add another test, fix bug
* fix
* fix
* Move client-idle-filter to promises
* better call counting
* x
* x
* x
* review feedback
* progress
* Automated change: Fix sanity tests
* progress
* Automated change: Fix sanity tests
* fix
* channel stack refcount
* remove op from lock, refcount
* compiles
* Automated change: Fix sanity tests
* nicer api
* fix
* Automated change: Fix sanity tests
* fix
* speculative fix for windows
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
AJ Heller
Anirudh Ramachandra
Mark D. Roth
Lidi Zheng
Yash Tibrewal
Craig Tiller
donnadionne
Jan Tattermusch
Esun Kim