Yash Tibrewal
25446c468a
Support RDS updates on the server ( #27851 )
...
* Port changes from #27388
* Reviewer comments
* Fix resource timeout issue
* Cleanup
* Fix clang-tidy
* Revert benchmark
* Restructure
* clang-tidy
* Automated change: Fix sanity tests
* Partial commit
* Reviewer comments
* Fixes
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* clang-format
* Fix FaultInjection tests
* clang-tidy
Co-authored-by: yashykt <yashykt@users.noreply.github.com>
3 years ago
Mark D. Roth
fff84402ac
Second attempt: XdsClient: fix resource timeout behavior ( #28088 )
...
* Revert "Revert "XdsClient: fix resource timeout behavior (#27860 )" (#28032 )"
This reverts commit 817eed0928
.
* use the right status code enum
3 years ago
Craig Tiller
817eed0928
Revert "XdsClient: fix resource timeout behavior ( #27860 )" ( #28032 )
...
This reverts commit 7fdb40d8b8
.
3 years ago
Mark D. Roth
7fdb40d8b8
XdsClient: fix resource timeout behavior ( #27860 )
...
* XdsClient: fix resource timeout behavior
* fix clang-tidy
* more clang-tidy fixes
* yet more clang-tidy
3 years ago
ZhenLian
2e14f6fa70
Support Custom Post-handshake Verification in TlsCredentials ( #25631 )
...
* custom verification refactoring - post-handshake verification
3 years ago
Yash Tibrewal
00e8a2d085
xds_end2end_test: Only start backends when needed ( #27911 )
...
* xds_end2end_test: Fix flakiness on WaitForLdsNack
* xds_end2end_test: Only start the server when we want
* Revert WaitForNack changes
* Fixes
* Fix CsdsShortAdsTimeoutTest
* Fix sanity
3 years ago
Mark D. Roth
06b5061d35
change CSDS to populate new generic_xds_configs field ( #27794 )
3 years ago
Yash Tibrewal
9ac9a013fc
Update RDS parsing for use on servers ( #27715 )
...
* Update RDS parsing for use on servers
* Unused variable
* Reviewer comments
* Automated change: Fix sanity tests
* Fix tests
* Reviewer comments
* Reviewer comments
* clang-tidy
* Reviewer comments
* Fix test
* Reviewer comments
* Reviewer comments
Co-authored-by: yashykt <yashykt@users.noreply.github.com>
3 years ago
Mark D. Roth
d6a0c0b8b5
xds_end2end_test: allow setting Listener to use in SetRouteConfiguration() ( #27756 )
...
* xds_end2end_test: allow setting Listener to use in SetRouteConfiguration()
* clang-format
3 years ago
Mark D. Roth
6339b03ada
Revert "Revert "start splitting up xds_end2end_test ( #27702 )" ( #27725 )" ( #27726 )
...
This reverts commit 9177c5324a
.
3 years ago
Mark D. Roth
9177c5324a
Revert "start splitting up xds_end2end_test ( #27702 )" ( #27725 )
...
This reverts commit 69a978231b
.
3 years ago
Mark D. Roth
69a978231b
start splitting up xds_end2end_test ( #27702 )
...
* move test xDS server to its own library
* move xds_end2end_test to xds subdir, and refactor CountedService
* add TODO
* fix sanity
3 years ago
Lidi Zheng
9cd68439a2
Change the time-getting logic in xds test to what ExecCtx does ( #27467 )
3 years ago
donnadionne
1caff522e4
Adding a log to make logging in WaitForAllBackends and WaitForBackend ( #27365 )
...
consistent.
This helps to uncover a case where the first test in the shard seems to
encounter longer delays than the rest of the tests.
3 years ago
donnadionne
10f218030d
xDS retry policy should be considered present even if there are no supported policies in retry_on ( #27315 )
...
* Ensure that per route retry policy (even when there are no supported
retry_on statuses) still takes precedence over virtual host level retry
policy.
Added a test to guard this case.
* Taking care of code review comments and removing unnecessary block
4 years ago
Lidi Zheng
15184d30ad
Fix injected abort error not recorded after injected delay ( #27215 )
...
* Fix injected abort error not recorded after injected delay
* Add the abort after delay test case
* Make Kokoro's clang_format happy
4 years ago
Mark D. Roth
3763be8796
add APIs for creating errors from C++ strings ( #27310 )
...
* add API for creating errors from C++ strings
* add missing include
4 years ago
Yash Tibrewal
72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API ( #26544 )
...
* De-experimentalize XdsCredentials and XdsServerCredentials API
* Use GRPC_DEPRECATED
4 years ago
Yash Tibrewal
362aff3458
xDS: Remove environmental variable guard for security ( #27290 )
4 years ago
Yash Tibrewal
7fd731f704
De-experimentalize XdsServerBuilder ( #27296 )
4 years ago
Yash Tibrewal
1a009cf4e5
xDS Security: Use new way to fetch certificate provider plugin instance config ( #27264 )
...
* xDS Security: Use new way to fetch certificate provider plugin instance
config
* Reviewer comments
* Additional fields to NACK
* Move NACKing tests for tls_certificates and tls_certificate_sds_securet_configs to client-side
4 years ago
Yash Tibrewal
f26c107651
xDS server serving status: Use a struct to allow more fields to be added in the future ( #27242 )
4 years ago
Mark D. Roth
f3497eb790
implement improved xDS NACK semantics ( #27276 )
...
* refactor xDS response parsing
* fix build
* implement improved xDS NACK semantics
* fix clang-tidy
* fix test
4 years ago
Mark D. Roth
e468b00c56
refactor xDS response parsing ( #27272 )
...
* refactor xDS response parsing
* fix build
4 years ago
Mark D. Roth
2cb3831c83
fix retry code to fail batches instead of creating attempt if previously cancelled from surface ( #27217 )
...
* fix retry code to fail batches instead of creating attempt if previously cancelled from surface
* add xDS end2end tests covering the FI use-case that triggered the bug
* fix memory leak
4 years ago
Yash Tibrewal
cb2e7554a3
xds_end2end_test: Fix UnsupportedHttpFilter test on aws ( #27147 )
4 years ago
donnadionne
59fc02a94b
Enabling Ring Hash by default. ( #27111 )
4 years ago
Yash Tibrewal
6da9eb9f3f
xDS PSM Server Security: Nack unsupported require_sni and ocsp_staple_policy values ( #26878 )
...
* Nack unsupported require_sni and ocsp_staple_policy values
* Reviewer comments
4 years ago
Yash Tibrewal
0ab13090e7
Nack certain unsupported fields in CertificateValidationContext ( #26880 )
...
* Nack certain unsupported fields in CertificateValidationContext
* Regenerate projects
* Reviewer comments
4 years ago
AJ Heller
58f8f5ced3
Add macro to define gtest death_test_style using an older syntax ( #27042 )
...
This temporarily unblocks a related gtest upgrade. The ultimate goal is
to upgraade our gtest dependencies, but I don't have the cycles to
manage a potentially messy migration until at least next week. This PR
is coordinated with an internal change.
4 years ago
Mark D. Roth
9f782faa34
xds: remove env var protection for retries ( #27039 )
4 years ago
Yash Tibrewal
404e56b2d9
Fix XdsEnabledServerTest ( #26956 )
4 years ago
Tamir Duberstein
3fd01fabae
Add thread safety annotations ( #26871 )
...
This exposes a bug in clang, reported upstream as
https://bugs.llvm.org/show_bug.cgi?id=51368 .
The clang bug is mitigated using a fake scoped lock; that allows the
current code to compile while also serving as a change detector to
prevent it from going stale; if the compiler bug is fixed, the compiler
will see an overlapping locking requirement, and reject this code, which
will prompt a human being to remove this workaround.
4 years ago
Yash Tibrewal
29d220a0ef
Re-experimentalize XdsServerBuilder ( #26892 )
...
* Re-experimentalize XdsServerBuilder
* Fix compiler issue
4 years ago
Tamir Duberstein
013e67a029
Deprecate grpc{_core,::internal}::WaitUntil ( #26866 )
...
It is not possible for such a function to be implemented in a way that
is understood by annotalysis. Mark it deprecated and replace instances
of its use with direct mutex/condvar usage.
Add a bunch of missing thread safety annotations while I'm here.
4 years ago
Tamir Duberstein
86c9de8231
Remove `grpc_core::WaitUntilWith{Deadline,Timeout}` ( #26867 )
...
These functions are essentially unused.
4 years ago
Mark D. Roth
6b71ec3704
LB policy API improvements ( #26481 )
...
* LB policy API improvements
* clang-format
* fix build
* a bit more cleanup
* use absl::variant<> for pick result
* fix retry_lb_drop test
* clang-format
* fix grpclb_end2end_test
* fix xds_end2end_test
* try to make variant code a bit cleaner
* clang-format
* fix memory leak
* fix build
* clang-format
* fix error refcount bug
* remove PickResult factory functions
* clang-format
* add ctors to structs
* clang-format
* fix clang-tidy
* update comments
* move LB recv_trailing_metadata callback instead of copying it
* use Match() instead of providing PickResult::Handle()
* don't use Match() for now, since it breaks lock annotations
* update retry_lb_fail test
4 years ago
Yash Tibrewal
49b5f9c420
Fix XdsServerSecurityTest ( #26817 )
4 years ago
donnadionne
7eaf37bce5
Adding retry policy ( #26566 )
4 years ago
Mark D. Roth
3104a9964c
xds: validate that terminal filters come at the end of the filter chain ( #26742 )
...
* xds: validate that terminal filters come at the end of the filter chain
* clang-format
4 years ago
Mark D. Roth
246c57829b
xds: notify watchers when NACKing resource updates ( #26757 )
...
* xds: notify watchers when NACKing resource updates
* check status of failed RPC when waiting for NACK
4 years ago
Alisha Nanda
d73ec07fe7
Fix small typo in xds end2end test ( #26685 )
4 years ago
Yash Tibrewal
c52005c161
NACK xDS updates when certificate provider instace names are unrecognized ( #26614 )
...
* NACK xDS updates when certificate provider instace names are unrecognized
* Reviewer comments
* Reviewer comments
* Clang format
* Fix compilation error
4 years ago
Lidi Zheng
b97693d572
[Roll Forward] Tighten the error tolerance requirement by 100x ( #26626 )
...
* Tighten the error tolerance requirement by 10x
* Make it 5 sigma instead of 4.5
* Rewrap comments
* Loosen the max concurrent requests in certain test cases
4 years ago
Yash Tibrewal
670a26caef
NACK xDS updates where transport_name is not recognized ( #26612 )
...
* NACK xDS updates where transport_name is not recognized
* Reviewer comments
4 years ago
Yash Tibrewal
095045b31c
NACK xds updates requiring client certificates when no validation certificate provider instance is mentioned ( #26613 )
4 years ago
Yash Tibrewal
8b5fbf8900
TLS Security Connector: Add an always-fail-handshaker when certificates are not ready ( #26561 )
...
* TLS Security Connector: Add an always-fail-handshaker when certificates are not ready
* Reviewer suggestion
* Add test
4 years ago
Yash Tibrewal
4daedf0233
De-experimentalize XdsServerBuilder ( #26543 )
4 years ago
Lidi Zheng
f198fb5b41
Revert "Tighten the error tolerance requirement by 100x ( #26588 )" ( #26593 )
...
This reverts commit f835f3f97c
.
4 years ago
Lidi Zheng
f835f3f97c
Tighten the error tolerance requirement by 100x ( #26588 )
...
* Tighten the error tolerance requirement by 10x
* Make it 5 sigma instead of 4.5
* Rewrap comments
4 years ago