Nathan Baulch
ccd250aa70
Fix minor typos ( #37450 )
...
Just thought I'd contribute some typo fixes I stumbled upon. Nothing controversial (hopefully), just 74 simple fixes.
Use the following command to get a quick and dirty summary of the specific corrections made:
```shell
git diff HEAD^! --word-diff-regex='\w+' -U0 \
| grep -E '\[\-.*\-\]\{\+.*\+\}' \
| sed -r 's/.*\[\-(.*)\-\]\{\+(.*)\+\}.*/\1 \2/' \
| sort | uniq -c | sort -n
```
FWIW, the top typos are:
* satisifed (8)
* uncommited (7)
* tranparent (7)
* expecially (3)
* recieves (3)
* correponding (2)
* slighly (2)
* wierdly (2)
Closes #37450
PiperOrigin-RevId: 665459663
3 months ago
AJ Heller
f238e5399c
[security] Reland: Refactor credentials types to remove special handling for insecure creds ( #36242 )
...
See #36176 . The only difference is a temporary shim for Secure credentials types, which was already discussed and approved separately.
Closes #36242
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36242 from drfloob:reland/36176 f07bebe289
PiperOrigin-RevId: 621879911
8 months ago
AJ Heller
da43a61322
Automated rollback of commit 822311c0d9
.
...
PiperOrigin-RevId: 621025232
8 months ago
AJ Heller
822311c0d9
[security] Refactor credentials types to remove special handling for insecure creds ( #36176 )
...
Forked from #35957
This PR refactors the credentials types to remove Secure and Insecure Channel and Call credentials types. We standardize on a `c_creds()` accessor method for all credentials types, which can now be treated uniformly. This notably removes special-case handling of insecure credentials.
The special code-paths for insecure creds are no longer necessary in the wake of #25586 .
Closes #36176
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36176 from drfloob:fork/35957/creds-API fd64d59c23
PiperOrigin-RevId: 621008166
8 months ago
Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
Cheng-Yu Chung
1b05576aa3
[cleanups] Clean up `GrpcLibraryInitializer` ( #31894 )
...
* Clean up `GrpcLibraryInitializer`
* Update
* Automated change: Fix sanity tests
2 years ago
Cheng-Yu Chung
47b9a57de9
Remove `g_glip` and `class GrpcLibraryInterface` ( #30414 )
...
* Remove `g_glip` and `class GrpcLibraryInterface`
* Update
* Update
* Update
* Automated change: Fix sanity tests (#20 )
* Update
* Update
* Update
* Test
* Fix
* Revert "Test"
This reverts commit 2f5c77e98d
.
* More fix
* More fix
* More fix
* Minor fix
* Revert "Minor fix"
This reverts commit 1ee3ae4da1
.
* Revert "More fix"
This reverts commit 1fc234896b
.
* Revert "More fix"
This reverts commit 851393c0e6
.
* Revert "More fix"
This reverts commit ed342a51d0
.
* Revert "Fix"
This reverts commit 286ad8e639
.
2 years ago
Mark D. Roth
447a058837
xDS: remove deprecated C++ APIs in the experimental namespace ( #31451 )
2 years ago
Cheng-Yu Chung
0cb5faf8e4
Remove `include/grpcpp/impl/codegen/client_interceptor.h` ( #31054 )
...
* Remove `include/grpcpp/impl/codegen/client_interceptor.h`
* Update comment
2 years ago
Yash Tibrewal
72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API ( #26544 )
...
* De-experimentalize XdsCredentials and XdsServerCredentials API
* Use GRPC_DEPRECATED
3 years ago
yihuaz
b9a69481c2
Revert "Support user provided "scope" in JWT and GDC ( #26577 )" ( #26645 )
...
This reverts commit 6df967966b
.
3 years ago
yihuaz
6df967966b
Support user provided "scope" in JWT and GDC ( #26577 )
...
* support scope overriding in jwt and gdc
* fix formatting
* fix bazel build issue
* fix clang tidy
3 years ago
yihuaz
932dbed49d
Revert "Allow to specify user provided audience in google default credentials and JWT credentials ( #26456 )" ( #26531 )
...
This reverts commit 5a91a513fd
.
3 years ago
ZhenLian
5a91a513fd
Allow to specify user provided audience in google default credentials and JWT credentials ( #26456 )
...
* support user provided audience in gdc and jwt
4 years ago
Lidi Zheng
a3ae8e00a2
Revert "Allow to specify user provided audience in google default credentials and JWT credentials ( #26392 )" ( #26440 )
...
This reverts commit 304262e135
.
4 years ago
yihuaz
304262e135
Allow to specify user provided audience in google default credentials and JWT credentials ( #26392 )
...
* support user provided audience in gdc and jwt
* fix 1st round of comments
* fix ruby and php to use new GDC API
* fix python clang issue
* address 2nd round of comments
* fix string_view issue
* remove length param in string_view constructor
4 years ago
Bassam Ojeil
701d3cdf9a
Move third party identity C++ api out of experimental namespace
...
This PR is a continuation of:
https://github.com/grpc/grpc/pull/25304
4 years ago
Chuan Ren
06cc42eb85
Add support of implicit and explicit flows for external account creds
4 years ago
Esun Kim
decc199ca8
Fix by clang-tidy
4 years ago
ZhenLian
518ed1303c
Add Credential Loading From Static Providers For TLS Credentials
4 years ago
Yash Tibrewal
c52cb09f47
Add experimental XdsCredentials with support for insecure channel_credentials and security_connector
4 years ago
Karthik Ravi Shankar
1de0bfd9e2
Revert "Revert "Move create_channel and credentials from ::grpc_impl to ::grpc""
4 years ago
Karthik Ravi Shankar
f1bc43edf6
Revert "Move create_channel and credentials from ::grpc_impl to ::grpc"
4 years ago
Karthik Ravi Shankar
decb53ccc0
Fix build error
4 years ago
Esun Kim
165ee5007a
Replaced grpc::string with std::string
4 years ago
Karthik Ravi Shankar
7f2eaaabac
Move create_channel and credentials from ::grpc_impl to ::grpc
...
Reverts: https://github.com/grpc/grpc/pull/18374 and
https://github.com/grpc/grpc/pull/18444
Credentials and create_channel are very closely intertwined, so it is
easier to migrate them together.
4 years ago
Matthew Stevenson
ff9697acd7
Changed SPIFFE credentials naming to TLS credentials, per Jiangtao's comments.
5 years ago
Matthew Stevenson
17e1acec0c
Fixed scope issue in credentials.h
5 years ago
Matthew Stevenson
e26e2b6b8b
First Spiffe1 commit
5 years ago
Esun Kim
ded9f46c06
Refactored BUILD file to isolate cronet rules
5 years ago
Julien Boeuf
109edca971
Adding C++ API and implementation for STS credentials:
...
- marked as experimental.
- also changed the name of a field in the options struct.
5 years ago
Moiz Haidry
3ce20819cf
Modify codegen to use grpc_impl namespace and other cleanups
6 years ago
Karthik Ravi Shankar
5f6a57a4d0
Formatting issues
6 years ago
Karthik Ravi Shankar
2049b6c2bd
Fix build errors
6 years ago
Karthik Ravi Shankar
60bdeef9f4
Move Channel also to impl for now
6 years ago
Karthik Ravi Shankar
603d014f0e
Changes to fold credentials into grpc_impl from grpc
6 years ago
Karthik Ravi Shankar
76d78eb82b
Moving create_channel from grpc to grpc_impl
6 years ago
Yash Tibrewal
af2b170d8a
Comment out names of unused arguments
6 years ago
Karthik Ravi Shankar
858b5cca20
Fix clang_format_code.sh issues and move the internal calls to new name
6 years ago
Karthik Ravi Shankar
973fa6950e
Fold Channel into grpc_impl from grpc namespace
6 years ago
Karthik Ravi Shankar
dad3f34207
Revert "Revert "Revert "Folding the Channel class into the grpc_impl namespace."""
6 years ago
Karthik Ravi Shankar
4cb0d0d6b1
Fix errors from clang scripts
6 years ago
Karthik Ravi Shankar
9b42ab79e0
Make build fixes for bazel build :all
6 years ago
Karthik Ravi Shankar
6da0ca4421
Bring ChannelArguments to grpc_impl from grpc
6 years ago
Karthik Ravi Shankar
1061604a01
Fix clang_format_code.sh errors
6 years ago
Karthik Ravi Shankar
c08e5bee40
Fix make errors
6 years ago
Karthik Ravi Shankar
2772f519e6
Fix errors from presubmit scripts.
6 years ago
Karthik Ravi Shankar
4a0c3b848f
Fix broken tests
6 years ago
Nicolas Noble
91ad888497
Revert "Revert "Folding the Channel class into the grpc_impl namespace.""
6 years ago
Yuwei Huang
3cbf4f50ea
Remove extra semicolons after function definitions
...
We are planning to enable -Wextra-semi flag in our project but some
header files in gRPC have extra semicolons that violates the check and
blocks us from enabling the flag.
This change removes unnecessary semicolons in the code. Note that having
semicolon after the GRPC_ABSTRACT macro technically also violates the
check, but it's fine for us since they are not used in public headers,
and it will be confusing to have lines ending only with GRPC_ABSTRACT,
so I keep them as-is.
6 years ago