Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Mark D. Roth	24318054bc	[LB policy API] change metadata mutations to overwrite instead of append (#37075 ) Closes #37075 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/37075 from markdroth:lb_metadata_overwrite `1f56d2001e` PiperOrigin-RevId: 647761256	6 months ago
Mark D. Roth	34a0318dbf	[LB policy API] change metadata mutation API to handle discarded picks (#36968 ) Previously, metadata mutations were made by the picker directly, which meant that they would be applied even if the channel winds up discarding the pick due to the returned subchannel having been disconnected by the time the pick result is returned. This changes the API such that pickers return metadata mutations along with the pick result, so that the mutations won't get applied unless the pick result is actually used. Closes #36968 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36968 from markdroth:lb_metadata_api `2765da6121` PiperOrigin-RevId: 645451869	6 months ago
Mark D. Roth	fe817c8ab1	[reorg] move lib/json -> util/json (#36645 ) Closes #36645 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36645 from markdroth:reorg_json `5b6434dd44` PiperOrigin-RevId: 636757495	7 months ago
Tanvi Jagtap	30386413c0	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36438 ) [grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT Replacing GPR_ASSERT with absl CHECK These changes have been made using string replacement and regex. Will not be replacing all instances of CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only ones which are doable using very simple regex with least chance of failure will be replaced. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36438 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36438 from tanvi-jagtap:tjagtap_cpp `405efd63c3` PiperOrigin-RevId: 628281347	8 months ago
Tanvi Jagtap	259f0e7903	[grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging - GPR_ASSERT (#36222 ) Replacing GPR_ASSERT with absl CHECK Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. This could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 4000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36222 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36222 from tanvi-jagtap:assert_interop `adcc660e78` PiperOrigin-RevId: 623366969	8 months ago
Craig Tiller	b0cf42d86e	[clang-format] Remove requirement that port_platform.h is at the top (#36281 ) Closes #36281 PiperOrigin-RevId: 623176865	8 months ago
Mark D. Roth	148f59c15a	[reorg] move LB policy code to src/core/load_balancing (#35786 ) This new directory combines code from the following locations: - src/core/ext/filters/client_channel/lb_policy - src/core/lib/load_balancing Closes #35786 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35786 from markdroth:client_channel_resolver_reorg `98554efb98` PiperOrigin-RevId: 604351832	10 months ago
Mark D. Roth	3e785d395d	[RefCounted and friends] Fix type safety of ref-counted types. Previously, `RefCountedPtr<>` and `WeakRefCountedPtr<>` incorrectly allowed implicit casting of any type to any other type. This hadn't caused a problem until recently, but now that it has, we need to fix it. I have fixed this by changing these smart pointer types to allow type conversions only when the type used is convertible to the type of the smart pointer. This means that if `Subclass` inherits from `Base`, then we can set a `RefCountedPtr<BaseClass>` to a value of type `RefCountedPtr<Subclass>`, but we cannot do the reverse. We had been (ab)using this bug to make it more convenient to deal with down-casting in subclasses of ref-counted types. For example, because `Resolver` inherits from `InternallyRefCounted<Resolver>`, calling `Ref()` on a subclass of `Resolver` will return `RefCountedPtr<Resolver>` rather than returning the subclass's type. The ability to implicitly convert to the subclass type made this a bit easier to deal with. Now that that ability is gone, we need a different way of dealing with that problem. I considered several ways of dealing with this, but none of them are quite as ergonomic as I would ideally like. For now, I've settled on requiring callers to explicitly down-cast as needed, although I have provided some utility functions to make this slightly easier: - `RefCounted<>`, `InternallyRefCounted<>`, and `DualRefCounted<>` all provide a templated `RefAsSubclass<>()` method that will return a new ref as a subclass. The type used with `RefAsSubclass()` must be a subclass of the type passed to `RefCounted<>`, `InternallyRefCounted<>`, or `DualRefCounted<>`. - In addition, `DualRefCounted<>` provides a templated `WeakRefAsSubclass<T>()` method. This is the same as `RefAsSubclass()`, except that it returns a weak ref instead of a strong ref. - In `RefCountedPtr<>`, I have added a new `Ref()` method that takes debug tracing parameters. This can be used instead of calling `Ref()` on the underlying object in cases where the caller already has a `RefCountedPtr<>` and is calling `Ref()` only to specify the debug tracing parameters. Using this method on `RefCountedPtr<>` is more ergonomic, because the smart pointer is already using the right subclass, so no down-casting is needed. - In `WeakRefCountedPtr<>`, I have added a new `WeakRef()` method that takes debug tracing parameters. This is the same as the new `Ref()` method on `RefCountedPtr<>`. - In both `RefCountedPtr<>` and `WeakRefCountedPtr<>`, I have added a templated `TakeAsSubclass<>()` method that takes the ref out of the smart pointer and returns a new smart pointer of the down-casted type. Just as with the `RefAsSubclass()` method above, the type used with `TakeAsSubclass()` must be a subclass of the type passed to `RefCountedPtr<>` or `WeakRefCountedPtr<>`. Note that I have not provided an `AsSubclass<>()` variant of the `RefIfNonZero()` methods. Those methods are used relatively rarely, so it's not as important for them to be quite so ergonomic. Callers of these methods that need to down-cast can use `RefIfNonZero().TakeAsSubclass<>()`. PiperOrigin-RevId: 592327447	12 months ago
Eugene Ostroukhov	fc4736c1ad	[interop] Fix crash in pick_first LB policy (#33519 ) Fixes http://b/288420022	1 year ago
Mark D. Roth	d20e8d141b	[LB policies] add delegating helper classes (#33445 ) This eliminates the need to modify every parent policy whenever we add new helper methods. It should also eliminate some binary bloat.	2 years ago
Mark D. Roth	8fdfb22848	[JSON] generalize handling of RefCountedPtr<> (#33048 ) Also remove a check in the weighted_target LB policy that I somehow missed in #32932.	2 years ago
Eugene Ostroukhov	50fce40409	[PSM Interop] Add custom_lb test client (#32757 )	2 years ago

12 Commits (9b987295f6792a5f61fc1b7fe3db8a13e9111cb5)