Muxi Yan
2cb1892c77
address comments
6 years ago
Arjun Roy
7f852c553b
Merge pull request #19031 from arjunroy/md_intern_unref_v2
...
Inline more of md_unref for interned metadata.
6 years ago
Guantao Liu
ae0f989828
Merge pull request #19163 from guantaol/iomgr_timer
...
Adjust the order of IOMgr timer initialization and comment of grpc_timer::heap_index
6 years ago
Arjun Roy
14c55dea4a
Inline more of md_unref for interned metadata.
...
In the common case, unref() for interned metadata was performing some
unnecessary branches. This patch reduces the instruction count from about 19 to
12 in the case where an unref() occured but it wasn't the last reference.
This has various speedups for chttp2_hpack, metadata and fullstack pingpong
benchmarks.
As a tradeoff, static/external metadata unref regresses slightly (fraction of a
nanosecond increase in CPU time) while interned improves (roughly 5 nanoseconds
reduction in CPU time).
Examples:
Fullstack:
BM_UnaryPingPong<InProcess, NoOpMutator, NoOpMutator>/8/8 [polls/iter:0 ]
7.12µs ± 4% 6.91µs ± 3% -3.00% (p=0.000 n=20+19)
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/32768
[polls/iter:3.0001 ] 35.3µs ± 2% 34.9µs ± 0% -1.15% (p=0.048 n=8+4)
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/32768/32768
[polls/iter:3.00014 ] 49.6µs ± 1% 49.0µs ± 1% -1.15% (p=0.017 n=7+3)
HpackParser:
BM_HpackEncoderInitDestroy
274ns ± 0% 254ns ± 0% -7.12% (p=0.000 n=19+19)
BM_HpackParserParseHeader<RepresentativeClientInitialMetadata, UnrefHeader>
173ns ± 0% 140ns ± 0% -19.04% (p=0.000 n=18+16)
BM_HpackParserParseHeader<MoreRepresentativeClientInitialMetadata, UnrefHeader>
751ns ± 1% 702ns ± 2% -6.50% (p=0.000 n=20+20)
BM_HpackParserParseHeader<RepresentativeServerTrailingMetadata, UnrefHeader>
50.6ns ± 0% 46.9ns ± 0% -7.29% (p=0.000 n=14+19)
BM_HpackParserParseHeader<RepresentativeClientInitialMetadata, OnInitialHeader>
486ns ± 1% 455ns ± 0% -6.42% (p=0.000 n=20+19)
BM_HpackParserParseHeader<MoreRepresentativeClientInitialMetadata,
OnInitialHeader>
1.17µs ± 1% 1.12µs ± 1% -4.18% (p=0.000 n=18+20)
BM_HpackParserParseHeader<RepresentativeServerInitialMetadata, OnInitialHeader>
163ns ± 1% 155ns ± 0% -4.52% (p=0.000 n=18+17)
Metadata:
BM_MetadataFromInternedKeyWithBackingStore 7.32ns ± 1%
6.67ns ± 0% -8.89% (p=0.000 n=20+17)
BM_MetadataFromStaticMetadataStringsNotIndexed 77.4ns ± 2%
79.6ns ± 0% +2.86% (p=0.000 n=18+19)
BM_MetadataRefUnrefExternal 1.74ns ± 0%
1.79ns ± 0% +2.65% (p=0.000 n=20+19)
BM_MetadataRefUnrefInterned 18.5ns ± 0%
13.3ns ± 0% -28.00% (p=0.000 n=17+17)
BM_MetadataRefUnrefAllocated 18.5ns ± 0%
13.3ns ± 0% -28.00% (p=0.000 n=17+18)
6 years ago
Arjun Roy
42c93b5f45
Merge pull request #19101 from arjunroy/grpc_is_bin_hdr_v2
...
Inlined and saved some ops for grpc_is_binary_header.
6 years ago
Arjun Roy
7c8d6f6375
s/uintptr_t/intptr_t as requested
6 years ago
Muxi Yan
7ec6669481
address comments
6 years ago
Arjun Roy
a9aa8860fd
Merge pull request #19012 from arjunroy/hpack_enc_static
...
chttp2 hpack encoder: fast-pathed static md/slice ops
6 years ago
Guantao Liu
740c931e23
Adjust the order of IOMgr initialization, so as to set up a customized
...
timer correctly.
Also, change the comment of grpc_timer::heap_index.
6 years ago
Wayne Zhang
bd2756e482
Fix format
6 years ago
Arjun Roy
f13abc071c
Inlined and saved some ops for grpc_is_binary_header.
...
Various improvements for parsing/encoding:
BM_HpackEncoderEncodeDeadline 171ns ± 0% 164ns ± 0% -3.74% (p=0.000 n=20+17)
BM_HpackEncoderEncodeHeader<SingleInternedKeyElem>/0/16384 102ns ± 1% 98ns ± 0% -3.28% (p=0.000 n=20+19)
BM_HpackParserParseHeader<AddIndexedSingleStaticElem, UnrefHeader> 177ns ± 1% 165ns ± 1% -6.41% (p=0.000 n=19+18)
BM_HpackParserParseHeader<NonIndexedBinaryElem<1, true>, UnrefHeader> 212ns ± 2% 199ns ± 1% -6.28% (p=0.000 n=20+18)
6 years ago
Arjun Roy
0f83755c6e
chttp2 hpack encoder: fast-pathed static md/slice ops
6 years ago
Mark D. Roth
31ec9a74ae
More LB policy API improvements.
6 years ago
Yash Tibrewal
d43604a8b1
Merge pull request #19021 from yashykt/validatesvccfg
...
Add method to validate service config json
6 years ago
Richard Belleville
0ebeb40718
Merge pull request #19084 from gnossen/python2-deprecation-notice
...
Add python deprecation notices.
6 years ago
Yash Tibrewal
3893a6379b
Clean up
6 years ago
Richard Belleville
7f32b96e3d
Merge pull request #19157 from gnossen/master_twine_check
...
Port #19105 to master
6 years ago
Yash Tibrewal
66c7560fc4
Fix server interceptors end2end test
6 years ago
Srini Polavarapu
ec640a53c6
Merge pull request #19105 from gnossen/twine_check_artifacts
...
Produce Python Wheels with a Valid long_description field
6 years ago
Muxi Yan
e3c280d613
build fix
6 years ago
Stanley Cheung
e553590a0a
Merge pull request #19109 from stanley-cheung/php-segfault
...
Fix PHP extension segfault
6 years ago
weiyongji
bd0d6fc7b6
cancel the modification in mpscq_test.cc
6 years ago
weiyongji
a2f7ce699b
call destroy function in test_serial()
6 years ago
weiyongji
57cc401597
typo fix
6 years ago
Yash Tibrewal
6a2da31a36
Remove unused variable
6 years ago
Yash Tibrewal
e260de873c
Merge branch 'master' into interceptionfix
6 years ago
Yash Tibrewal
c58b4a3964
Clang format
6 years ago
Yash Tibrewal
67bdbbdf6f
Fix a bug where POST_RECV_MESSAGE is not being triggered
6 years ago
Yash Tibrewal
4746a8734d
Merge branch 'master' into validatesvccfg
6 years ago
yang-g
384f15ab6e
Delay calling plugin_creds callback
6 years ago
Yash Tibrewal
886dc10daa
Move validate_service_config to a new file
6 years ago
Muxi Yan
a1542b5a41
clang-format
6 years ago
Muxi Yan
155ca4be68
Polish scheme configurations
6 years ago
Eric Anderson
1b025b60e4
Swap java interop tests to openjdk8
...
Since openjdk8 is dead to us (see #19113 ), we cannot leave openjdk8 in
the list of runtimes in client_matrix.py. The list of runtimes is now
the defaults to use, which includes master, and you can specify
alternative runtimes per-release.
Fixes #19113
6 years ago
Doug Fawley
b7e726a748
Merge pull request #19106 from canguler/go_release
...
Add v1.21.0 releases of grpc-go to interop matrix
6 years ago
Muxi Yan
caa965bd1d
Address comments
6 years ago
Karthik Ravi Shankar
f4ce5fc251
Merge pull request #19132 from karthikravis/core_codegen_fix
...
IWYU in core_codegen_interface
6 years ago
Karthik Ravi Shankar
088319bc40
IWYU in core_codegen_interface
...
core_codegen_interface requires ByteBuffer in generated code and needs
to include byte_buffer.h
NO_BUG=Cleanup
6 years ago
Karthik Ravi Shankar
072fdf54ed
Merge pull request #18813 from karthikravis/callback-rpc-lock
...
Start supporting a callback-based RPC under lock
6 years ago
Karthik Ravi Shankar
b18faa6c95
Fix tsan error
6 years ago
Karthik Ravi Shankar
d2c8eb94c9
Fix microbenchmark failures
6 years ago
Muxi Yan
1bb3f72abe
clang-format
6 years ago
Muxi Yan
d7750baf99
Merge remote-tracking branch 'upstream/master' into interceptor-3
6 years ago
Arjun Roy
0a57193dec
Replaced gpr_ref with grpc_core::Atomic in call batch struct
6 years ago
rmstar
435b1ee961
Merge pull request #19080 from rmstar/flakynetwork
...
Flaky network test enhancements
6 years ago
Muxi Yan
fb1a6b1d48
clang-format
6 years ago
Muxi Yan
61e22f02bd
Merge pull request #19115 from grpc/fix-include-style
...
Correct include style
6 years ago
Stanley Cheung
7967445968
Fix PHP extension segfault
6 years ago
Juanli Shen
5ad1abe207
Merge pull request #19128 from AspirinSJL/typo
...
Fix typo
6 years ago
Prashant Jaikumar
1ac1ab7396
Flaky network test enhancements and cleanups
...
- Parameterized flaky_network_test to run with different packet sizes and
credentials.
- Cleanup debugger_macros
Parametrize flaky_network_test to run with different packet sizes and
credentials.
6 years ago