57982f0ec6
pass subchannel address separately instead of as a channel arg ( #27443 )
...
* pass subchannel address separately instead of as a channel arg
* fix bug
* fix passing address to connector
* clang-format
* fix build of bm_call_create
* revert to C-style semantics for grpc_resolved_address
* fix msan bugs
3 years ago
8a359d637c
Revert "[objc] Switch to forward declare proto & clean up ( #27444 )" ( #27473 )
...
This reverts commit 4ad495420f
3 years ago
9cd68439a2
Change the time-getting logic in xds test to what ExecCtx does ( #27467 )
3 years ago
4ad495420f
[objc] Switch to forward declare proto & clean up ( #27444 )
3 years ago
d4407b7e59
Revert "Remove dead code ( #27445 )" ( #27461 )
...
This reverts commit 693f36f91c
3 years ago
693f36f91c
Remove dead code ( #27445 )
...
* Remove dead code
* Automated change: Fix sanity tests
* build
* remove benchmark
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
47586fb36e
Revert "Revert "Added absl::Status support to error_utils ( #27358 )" ( #27418 )" ( #27429 )
...
This reverts commit 933676c56c
3 years ago
933676c56c
Revert "Added absl::Status support to error_utils ( #27358 )" ( #27418 )
...
This reverts commit 9b3f75d322
3 years ago
b669a3c521
Revert "Revert "a useful change ( #27381 )" ( #27411 )" ( #27412 )
...
This reverts commit 5db17f7350
3 years ago
9b3f75d322
Added absl::Status support to error_utils ( #27358 )
3 years ago
9872da79a1
Eliminate grpc_metadata_batch_{init,destroy,move} ( #27349 )
...
* Eliminate grpc_metadata_batch_{init,destroy,move}
* fixes
* fixes
* fixes
* fixes
* portability fixes
* fixes
* fix
* fix
* fix
* be explicit about being explicit
3 years ago
1caff522e4
Adding a log to make logging in WaitForAllBackends and WaitForBackend ( #27365 )
...
consistent.
This helps to uncover a case where the first test in the shard seems to
encounter longer delays than the rest of the tests.
3 years ago
5db17f7350
Revert "a useful change ( #27381 )" ( #27411 )
...
This reverts commit 11eb70bbed
3 years ago
11eb70bbed
a useful change ( #27381 )
...
* a useful change
* Automated change: Fix sanity tests
* fix
* fix
* QsortCompare it is!
* Automated change: Fix sanity tests
* add missing header
* clang-tidy fixes, tweak clamp to only use <
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
0a502d8f2e
Fix race between Read and ServerContext::IsCancelled in Sync API ( #27056 )
...
* Fix OOM issues in qps tests
* Add more verbose logging.
* Fix clang error
* Fix race between IsCancelled and Read
* Fix build errors from using bool in C code
3 years ago
fd233193ec
Encapsulate metadata aggregates ( #27262 )
...
* Encapsulate metadata aggregates
* Automated change: Fix sanity tests
* add const
* Automated change: Fix sanity tests
* add a comment about an awful api
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
10f218030d
xDS retry policy should be considered present even if there are no supported policies in retry_on ( #27315 )
...
* Ensure that per route retry policy (even when there are no supported
retry_on statuses) still takes precedence over virtual host level retry
policy.
Added a test to guard this case.
* Taking care of code review comments and removing unnecessary block
3 years ago
15184d30ad
Fix injected abort error not recorded after injected delay ( #27215 )
...
* Fix injected abort error not recorded after injected delay
* Add the abort after delay test case
* Make Kokoro's clang_format happy
3 years ago
3763be8796
add APIs for creating errors from C++ strings ( #27310 )
...
* add API for creating errors from C++ strings
* add missing include
3 years ago
72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API ( #26544 )
...
* De-experimentalize XdsCredentials and XdsServerCredentials API
* Use GRPC_DEPRECATED
3 years ago
362aff3458
xDS: Remove environmental variable guard for security ( #27290 )
3 years ago
7fd731f704
De-experimentalize XdsServerBuilder ( #27296 )
3 years ago
1a009cf4e5
xDS Security: Use new way to fetch certificate provider plugin instance config ( #27264 )
...
* xDS Security: Use new way to fetch certificate provider plugin instance
config
* Reviewer comments
* Additional fields to NACK
* Move NACKing tests for tls_certificates and tls_certificate_sds_securet_configs to client-side
3 years ago
f26c107651
xDS server serving status: Use a struct to allow more fields to be added in the future ( #27242 )
3 years ago
f3497eb790
implement improved xDS NACK semantics ( #27276 )
...
* refactor xDS response parsing
* fix build
* implement improved xDS NACK semantics
* fix clang-tidy
* fix test
3 years ago
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
e468b00c56
refactor xDS response parsing ( #27272 )
...
* refactor xDS response parsing
* fix build
3 years ago
dc701787e2
Convert HPACK encoder to C++ ( #27226 )
...
* Rebuild HPACK encoder table as C++
* move comment
* incguards
* build
* Automated change: Fix sanity tests
* c++ initialization ftw
* Automated change: Fix sanity tests
* Add missing header
* Add missing header
* Begin converting HPACK encoder to c++
* First pass conversion to c++
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
b062fcd5c6
Ensure consistency of include style for <grpc.* headers ( #27233 )
...
* Add a tool to ensure consistency in how grpc public headers are included
* Apply tool
* add to test suite
* isort
3 years ago
9e4c657fa3
C++ opencensus filter: Fix point of creating context for overall call ( #27221 )
3 years ago
2cb3831c83
fix retry code to fail batches instead of creating attempt if previously cancelled from surface ( #27217 )
...
* fix retry code to fail batches instead of creating attempt if previously cancelled from surface
* add xDS end2end tests covering the FI use-case that triggered the bug
* fix memory leak
3 years ago
71a9410fc7
Another workaround to fix windows SymInitialize error ( #27169 )
3 years ago
cb2e7554a3
xds_end2end_test: Fix UnsupportedHttpFilter test on aws ( #27147 )
3 years ago
7dd1da9e1d
Break after WriteLast() ( #27165 )
...
If we continue to call `Write()` after `WriteLast()` (because client is still sending us data and thus `Read()` returns `true`), the buffer might become invalid and results in assertion failures.
3 years ago
1ff1f8fd83
SDK authorization filter. ( #26468 )
...
* SDK authorization filter.
3 years ago
59fc02a94b
Enabling Ring Hash by default. ( #27111 )
3 years ago
6da9eb9f3f
xDS PSM Server Security: Nack unsupported require_sni and ocsp_staple_policy values ( #26878 )
...
* Nack unsupported require_sni and ocsp_staple_policy values
* Reviewer comments
3 years ago
6ba4a92af7
Reorder gtest/gmock headers ( #27070 )
...
Per the style guide (or spirit thereof), these should be placed with the other external/third_party headers.
3 years ago
0ab13090e7
Nack certain unsupported fields in CertificateValidationContext ( #26880 )
...
* Nack certain unsupported fields in CertificateValidationContext
* Regenerate projects
* Reviewer comments
3 years ago
d10617edb5
Move resource_user ownership into chttp2 transport/server/connector v2 ( #27032 )
...
Reintroducing PR #26643 , which was reverted in #27029
Fixed a memory leak and added a test that would have caught it (ASAN build): ca0c8c4
3 years ago
4ba3fa52b9
Clean up some instances of -Wunreachable-code-aggressive ( #27054 )
...
See https://github.com/grpc/grpc/pull/26951 for why this is not enforced
at the moment.
3 years ago
58f8f5ced3
Add macro to define gtest death_test_style using an older syntax ( #27042 )
...
This temporarily unblocks a related gtest upgrade. The ultimate goal is
to upgraade our gtest dependencies, but I don't have the cycles to
manage a potentially messy migration until at least next week. This PR
is coordinated with an internal change.
3 years ago
533f02642d
Disable xds_credentials_test on iOS ( #27043 )
3 years ago
9f782faa34
xds: remove env var protection for retries ( #27039 )
3 years ago
f5d3ed2db1
Revert "Move resource_user ownership into chttp2 transport/server/connector ( #26643 )" ( #27029 )
...
This reverts commit d1935a65a1
3 years ago
d1935a65a1
Move resource_user ownership into chttp2 transport/server/connector ( #26643 )
3 years ago
bbea27de46
Reland HPACK parsing changes ( #26997 )
...
* Revert "Revert "HPACK Table --> C++ (#26851 )" (#26995 )"
This reverts commit 840bcce9c4
3 years ago
34338e5798
Avoid undefined behavior in pthread TLS ( #26999 )
...
See code commentary for an explanation.
Add an additional constructor to allow `log_linux.cc` to compile with
GPR_PTHREAD_TLS. Without it:
```
../../third_party/grpc/src/core/lib/gpr/log_linux.cc:78:33: error: no viable conversion from 'int' to 'grpc_core::PthreadTlsImpl<long>'
static GPR_THREAD_LOCAL(long) tid = 0;
^ ~
../../third_party/grpc/src/core/lib/gpr/tls.h:64:3: note: candidate constructor not viable: no known conversion from 'int' to 'const grpc_core::PthreadTlsImpl<long> &' for 1st argument
PthreadTlsImpl(const PthreadTlsImpl&) = delete;
^
1 error generated.
```
3 years ago
840bcce9c4
Revert "HPACK Table --> C++ ( #26851 )" ( #26995 )
...
This reverts commit 83bcb0cf2e
3 years ago
00c03c55ff
Implement type safety for TLS ( #26942 )
...
* Implement type safety for TLS
This is mostly free when compiler support is available, but requires
careful templating when implemented using pthread.
Significantly slimmed the tls.h interface; it now only defines the "TLS
keyword" for each supported compiler, delegating enforcement of correct
usage (i.e. must be static) to the compiler itself.
Implemented implicit conversion for the pthread wrapper so it can be
used (mostly) the same as native support. Notable exception to this is
that static_cast<void*> is needed when printing a pointer stored in TLS
as %p.
* Use GPR_THREAD_LOCAL macros consistently
3 years ago
Mark D. Roth
Craig Tiller
Lidi Zheng
Denny C. Dai
Esun Kim
donnadionne
Alisha Nanda
Yash Tibrewal
Ta-Wei Tu
Ashitha Santhosh
AJ Heller
Tamir Duberstein