Yash Tibrewal
7af4bc7f1a
Logging: Move filter to Core ( #32467 )
...
This filter was originally written only for the C++ wrapped layer, but
we have plans to use this for Python (and maybe other wrapped languages
too in the future.)
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2 years ago
Yash Tibrewal
7b79173991
Logging: Fill status code, status message and status details ( #32464 )
...
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2 years ago
Yash Tibrewal
184d4826d4
Gcp Observability: Fix resource labels for stats and tracing ( #32460 )
...
For stats, the StackDriver/OpenCensus API allows setting the
MonitoredResource directly, so use that.
For tracing, there is no explicit MonitoredResource to use, so just
insert it into the attributes for a span.
2 years ago
Yash Tibrewal
d93d0022cd
GCP Observability: Fix constant labels support for stats when tracing is disabled ( #32451 )
...
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2 years ago
Yash Tibrewal
4b05dc88b7
GCP Observability: Plumb environment autodetection for OpenCensus stats and tracing ( #32431 )
2 years ago
Yash Tibrewal
04e3a8e73d
GCP Observability : Framework for detecting the environment ( #32294 )
...
This code is not plumbed through yet, but it provides the core
infrastructure needed to detect the proper GCP environment resources
needed to set up the labels/attributes/resources for stats, tracing and
logging.
Details on how the various environment resources are setup has been
derived by looking at java's cloud logging library and OpenTelemetry's
future plans. (Could be better explained in an offline review since some
links are internal).
Requesting @veblush for a full review and @markdroth for a structural
review.
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
2 years ago
Craig Tiller
0893fca089
[promises] Roll forward server promise calls with fixes ( #32261 )
...
* stuff
* spam-cleanup
* Revert "Revert "[promises] Server call (#31448 )" (#32260 )"
This reverts commit dbfb888e1f
.
* spam-cleanup
* Automated change: Fix sanity tests
* asserts-for-sanity
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
dbfb888e1f
Revert "[promises] Server call ( #31448 )" ( #32260 )
...
* Revert "[promises] Server call (#31448 )"
This reverts commit bbeb15006a
.
* clang-fmt
2 years ago
Craig Tiller
bbeb15006a
[promises] Server call ( #31448 )
...
* add experiment
* allow instantiation
* scratchings
* scratchings
* sniffly
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* progress
* change pipe labels to enable server code to be written
* better api
* Automated change: Fix sanity tests
* progress
* [promises] Implementation of deadline for server-based-calls
* compression filter compiles again
* Automated change: Fix sanity tests
* fix
* server tracing fixes
* get client initial metadata
* progress
* progress
* server call surface progress
* Automated change: Fix sanity tests
* move payload
* server-progress
* recv-message-server-connchan
* logging
* fix context-gate
* recv fix@top
* Automated change: Fix sanity tests
* recv close on server
* top termination start
* [promises] Move Empty to be first class
* fixes
* fix
* flow control fix
* got to orphan!
* orphan
* call orphan
* spam cleanup
* fix
* new cancelation semantics
* progress
* large metadata fixes
* fix
* fix
* log
* better logs
* fix-chanz
* logging, necessaryness
* fix typo
* fixes
* fix
* fix
* fix-pipe
* cleanup logging
* fix
* build-fix
* fix
* Automated change: Fix sanity tests
* logging
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* better primitive
* Revert "better primitive"
This reverts commit 119b5ee244
.
* fix
* fix
* trrracing
* Automated change: Fix sanity tests
* get-trailing-metadata
* cancellation
* Automated change: Fix sanity tests
* add transform pipeline to pipe
* add transform pipeline to pipe
* interceptor lists
* new server initial md api into filters
* convert connected_channel
* convert call
* initial promise based filter conversion
* convert promise based filter
* build fixes
* compile fix
* fixes
* fix ordering
* fixes
* check-metadata
* revert later: debug code
* better debug
* fix metadata ordering with messages in promise based filter
* fix ordering problem between batch completion and promise completion
* properly handle failure on receive message path on client
* more debug, fix a repoll bug in pbf
* Automated change: Fix sanity tests
* fixes
* Automated change: Fix sanity tests
* cleanup logging
* fixes
* missing file
* fixes
* logging
* Automated change: Fix sanity tests
* fixes
* convert logging filter
* fix
* Automated change: Fix sanity tests
* fix bad server response test
* Revert "Disable logging test (#32049 )"
This reverts commit 5fc92eaeae
.
* fix
* Automated change: Fix sanity tests
* fix memory leaks, logging
* Automated change: Fix sanity tests
* slice refcount debugging
* asan-canaries
* leak-fix
* leak-fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* remove mistaken line
* add-comment
* fix refcounting bug
* Automated change: Fix sanity tests
* rename variable
* renames
* bleh
* carry pipe close status from bottom of pipe to top to appease
recv-close-on-server
* backport cancellation
* Revert "carry pipe close status from bottom of pipe to top to appease"
This reverts commit fa33301dcd
.
* fix
* Automated change: Fix sanity tests
* review-feedback
* comment-ordering
* monostate
* renames
* undo-review-feedback
* fix
* review-feedback
* review-feedback
* fix
* review-feedback
* drop debugloc constructor
* interceptor-list-rev-feedback
* interceptor-list-rev-feedback
* pipe test
* review-feedback
* undo-mistaken-change
* Automated change: Fix sanity tests
* pipe error state
* detect send/recv failures and report
* iwyu, build
* fix submodules
* fix
* warning
* cleanup
* Automated change: Fix sanity tests
* fix
* fix for windows
* fix
* null pointer fix
* iwyu
* gen projex
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
7b02b7c253
[stats] Add experiment to use transport reported request latency whenever available ( #32168 )
...
* [stats] Add experiment to use transport reported request latency whenever available
* redux: add a new metric
* review-feedback
* Automated change: Fix sanity tests
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Yash Tibrewal
beffe313e5
GCP Observability Logging: Base64 Encode metadata, message and status-details ( #32184 )
...
* GCP Observability Logging: Base64 Encode metadata, message and status-details
* Use padding for message and status-details
2 years ago
Yash Tibrewal
7f7a352ccc
Fix flakiness in test/cpp/ext/filters/census/... ( #32174 )
2 years ago
Yash Tibrewal
aa11978541
Fix include guards for src/ and test/ directories ( #32167 )
...
* Fix include guards for src/ and test/ directories
* Sanity
* Update new files
2 years ago
Yash Tibrewal
21618f3aef
GCP Observability: Add labels support for logging ( #32130 )
...
* GCP Observability: Add labels support for logging
* clang format
* Reviewer comments
2 years ago
Yash Tibrewal
05491fb2f6
Gcp Observabiliy : Add constant labels support for stats and tracing ( #32128 )
...
* Gcp Observabiliy : Add constant labels support for stats and tracing
* Register GCP Observability labels
* sanity
* Fix build for CI
* TEST_TAG_KEY fix
* Remove duplicitous constant label setting
2 years ago
Yash Tibrewal
25465100fd
LoggingTest: s/GUARDED_BY/ABSL_GUARDED_BY ( #32144 )
2 years ago
Yash Tibrewal
33be15bdb6
Gcp Observability: Lazily initialize channels post-init ( #32091 )
...
* Gcp Observability: Lazily initialize channels post-init
* IWYU and fix build deps
* Run RegistryPostInit for client census filters too
* Remove unused function
2 years ago
Yash Tibrewal
d5c1dc1667
GCP Observability: Fix env var names ( #32066 )
2 years ago
Yash Tibrewal
5fc92eaeae
Disable logging test ( #32049 )
2 years ago
Yash Tibrewal
ad6f6c49e0
Logging filter ( #31755 )
...
* initial
* Intermediate
* Another try
* Try multiple necesary pulls
* Filter works other than client half close
* Fixes
* Add a cancelled RPC test
* Handle trailer only responses
* Tests for disabled logging and truncated payloads
* Fix authority and peer
* Add TODOs and asserts for half-close
* Fix tests for half-close and cancel
* 2d748fcb1cf45cac62729b8346ad15e6abc79e97
* Fix sanity checks
* Strict bazel build
* Fix package
* IWYU
* Fix cmake
* Explicit cast to string
* Size casts
* Fix Arena leak and disable macos build for now
* Reviewer comments
2 years ago
Yash Tibrewal
d3d4dd7325
StatsPluginEnd2EndTest: Add QueueOnceLoadBalancingPolicy to remove flakiness from test ( #32019 )
...
* StatsPluginEnd2EndTest: Add QueueOnceLoadBalancingPolicy to remove flakiness from test
* Unused arg
* Remove unnecessary DelegatingPicker
* Reviewer comments
* explicit constructor
* Remove unnecessary dependency
* Reviewer comments
* Sanity
* clang tidy
2 years ago
Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
Yash Tibrewal
9e7c8bff55
Tracing: Add annotations for when call is removed from resolver result queue and lb pick queue ( #31913 )
...
* Tracing: Add annotations for when call is removed from resolver result queue and lb pick queue
* Add test for pending resolver result queue as well
* Update annotation messages
2 years ago
Yash Tibrewal
15c4a98bc7
Gcp Observability Logging: Add handling for adding entry as a json payload ( #31723 )
2 years ago
Yash Tibrewal
0389940093
GcpObservability: Add config support for constant labels ( #31710 )
2 years ago
Esun Kim
0ba0c4bf74
Added googletest clang-tidy checks ( #31610 )
...
* Added google-googletest
* Autofix
* Fix test names
* Fix
2 years ago
Yash Tibrewal
7372e55ba9
Revert "Revert "Observability Logging: Interfaces and structure"" ( #31681 )
...
* Revert "Revert "Observability Logging: Interfaces and structure (#31651 )" (#31669 )"
This reverts commit 3be177223e
.
* Generate projects
2 years ago
Craig Tiller
3be177223e
Revert "Observability Logging: Interfaces and structure ( #31651 )" ( #31669 )
...
This reverts commit 2146107e25
.
2 years ago
Yash Tibrewal
2146107e25
Observability Logging: Interfaces and structure ( #31651 )
...
* Observability Logging: Interfaces and structure
* Revert unrelated changes
* Fix test build
* Add dependency on Google Apis Logging V2 service and add a dummy logging call
* Add authority
2 years ago
Yash Tibrewal
829f41b733
ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability ( #31571 )
...
* ObservabilityLogging: Add interface for logging and config parsing implementation for GCP observability
* Trailing new lines
* Fix naked include
* clang-tidy
* Reviewer comments
* Reviewer comments
2 years ago
Yash Tibrewal
5dfd384655
ObservabilityConfig: Add missing test ( #31572 )
2 years ago
Yash Tibrewal
a99a65b6e2
GcpObservability: Add parsing for logging config ( #31502 )
...
* GcpObservability: Add parsing for logging config
* Unused parameters
* Reviewer comments
2 years ago
Yash Tibrewal
3b6675c2de
OpenCensus: Move measures, views and CensusContext to include file ( #31341 )
...
* OpenCensus: Move measure and view declarations to include file
* Move CensusContext class too
* Fix IWYU
* Guard with experimental
* Formatting
* clang tidy fixes
* cleanup
* Reviewer comments
2 years ago
Yash Tibrewal
727ae8c885
GcpObservability: Add experimental public target ( #31339 )
...
* GcpObservability: Add experimental public target
* Yapf and IWYU
2 years ago
Yash Tibrewal
2ffff621a4
OpenCensusTest: Fix flakiness ( #31349 )
2 years ago
Yash Tibrewal
8cffd1044e
OpenCensus: Ability to globally disable stats and tracing ( #31252 )
...
* OpenCensus: Ability to globally disable stats and tracing
* Fix docs
2 years ago
Yash Tibrewal
6d249c0af2
Observability: Experimental arg to disable client side tracing ( #31093 )
...
* Observability: Experimental arg to disable client side tracing
* Fix IWYU
* Reviewer comments
* Reviewer comments
* Reviewer comment: Move experimental/internal arg to different file
* Fix build
* Fix IWYU
2 years ago
Yash Tibrewal
9cff4d2d28
OpenCensus Plugin: Add missing measure and views for started RPCs ( #31034 )
2 years ago
Mark D. Roth
07df5ff9c7
json_object_loader: refactor ErrorList into its own library ( #31049 )
...
* json_object_loader: refactor ErrorList into its own library
* fix observability_config_test
* generate_projects
* iwyu
2 years ago
Yash Tibrewal
5cd8ee25f8
GcpObservabilityConfig: New changes ( #31038 )
...
* GcpObservabilityConfig: New changes
* Fix IWYU
2 years ago
Yash Tibrewal
27e5b4e187
GcpObservabilityConfig: Fall-back to GCP environment variables ( #31022 )
2 years ago
Yash Tibrewal
6098202c09
GcpObservabilityTest: Cleanup ( #31023 )
2 years ago
Craig Tiller
c2ab8c99bb
Revert "Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )" ( #30988 )
...
This reverts commit 96264e07b8
.
2 years ago
Craig Tiller
96264e07b8
Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )
...
This reverts commit 74c0d6fe3f
.
2 years ago
Craig Tiller
74c0d6fe3f
[c++] Move environment functions to C++ ( #30937 )
...
* [gprpp] Move env to C++
* move headers/impl
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Update http_proxy.cc
* fix
* fix
* rename
* fix merge
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Yash Tibrewal
b3ad894e05
GcpObservability: Use the observability config ( #30932 )
...
* GcpObservability: Use the observability config
* iwyu
* Fix build
2 years ago
Yash Tibrewal
ebcda5f0c1
GcpObservabilityConfig: s/disabled/enabled ( #30905 )
2 years ago
Yash Tibrewal
f7f4c9b584
GcpObservability: Code for reading config from env var ( #30889 )
...
* GcpObservability: Code for reading config from env var
* Comments
* Fix deps
* clang-tidy
2 years ago
Yash Tibrewal
a644d8c9b4
GcpObservabilityConfig: cloud_trace.sampling_rate ( #30904 )
2 years ago
Yash Tibrewal
260a02d1ad
Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure"" ( #30894 )
...
* Revert "Revert "GcpObservabilityConfig: Add some basic field parsing structure (#30866 )" (#30892 )"
This reverts commit 37b631d1fd
.
* Add json_args deps for layering check
2 years ago