Yash Tibrewal
234d64859f
Add some additional comments
5 years ago
Yash Tibrewal
722f1e937a
Reviewer comments
5 years ago
Yash Tibrewal
f41694ad64
Add the missing reset for ping clocks to avoid mistakenly sending GOAWAY
...
frames due to 'too_many_pings'
5 years ago
Brian O'Connor
d38f7cfe5e
Fixing bug with END_STREAM if header has continuations
...
- The HEADER frame should get the END_STREAM flag per the HTTP/2 spec;
the old code put END_STREAM on the last CONTINUATION frame.
- Removing deprecated parameter, is_last_in_stream, from finish_frame();
it has been superseded by the is_end_of_stream member of the framer_state
struct.
- Adding some gRPC frame validation tests to hpack_encoder_test.cc,
and explicting checking that the END_STREAM flag is not on the
CONTINUATION frame.
fixes #21436
5 years ago
Donna Dionne
46439bcb0f
Fixing the settings_timeout_test flake by reducing pollset_work deadline
...
Intermittently (when we run the test 100 times) we see that at times
we are not notified about successful socket connection even within 1
second.
The pollset_work deadline is set to 1 second, so when our connection
timeout is also set to 1 second, we only had 1 poll. And if that poll
didn't let us know about the socket, we didn't get another chance.
Reducing the pollset_work deadline to 100ms, now the test runs faster
and pass consistently:
result for 500 runs:
https://source.cloud.google.com/results/invocations/dd1b38f4-0f28-470b-a78b-b485445e44f2/targets/%2F%2Ftest%2Fcore%2Ftransport%2Fchttp2:settings_timeout_test/tests
5 years ago
Jan Tattermusch
cbb0ef2717
try marking some offenders as flaky
5 years ago
yang-g
5bc57b64fe
InitGoogleTest before grpc_init
5 years ago
Esun Kim
74d2fb842e
Timeout for shutdown!
5 years ago
Esun Kim
9ae81e1d3f
Make test code use TestEnvironment
5 years ago
Lidi Zheng
c34bef4ca4
Format all Bazel files with buildifier
5 years ago
Vijay Pai
2477b966e2
Remove unused-parameter warnings, round 2 (17 of 19)
5 years ago
Vijay Pai
17c8c4c4f2
Remove unused parameter warning (13 of 20)
5 years ago
Jan Tattermusch
8e79705d29
disable fuzzers on windows
5 years ago
Jan Tattermusch
6ebc1c616f
set uses_polling=False for some bazel tests
5 years ago
Arjun Roy
b46e3668d3
s/branch/tail_call/ for CH2 on_hdr().
...
on_hdr() checks if a void-return function pointer is null before jumping to it.
If it is null, it returns an error; else it executes that function and returns
success.
This change converts the void-returning function to one that returns a
grpc_error* and thus saves a branch in on_hdr() (since we're branching once by
following the function pointer anyways, we're effectively coalescing these two
branches).
5 years ago
Hope Casey-Allen
59564ebd96
Fix warnings to unblock gcc8 support
5 years ago
Arjun Roy
b2cda1e185
Reduced ops for grpc_chttp2_stream_map_find().
...
Several asserts in grpc_chttp2_stream_map_find() can be converted to debug
asserts. This PR also templatizes the internal find() method to have it be
strict in the delete case (which saves some branches).
5 years ago
Yash Tibrewal
2d498d2b6c
Add a few tests for ContextList and BufferList. Also, check that
...
timestamps is non-null before modifying it.
5 years ago
Arjun Roy
b1d73a01f1
Removed duplicate static table from hpack table. Removed an or instruction for
...
every usage of static grpc metadata. Inlined hpack table lookups for static
metadata.
This leads to faster hpack parser creation:
BM_HpackParserInitDestroy 5.32µs ± 1% 0.06µs ± 1% -98.91% (p=0.000 n=18+19)
And slightly faster parsing:
BM_HpackParserParseHeader<RepresentativeClientInitialMetadata, OnInitialHeader>
456ns ± 1% 435ns ± 1% -4.74% (p=0.000 n=18+19)
BM_HpackParserParseHeader<MoreRepresentativeClientInitialMetadata,
OnInitialHeader>
1.06µs ± 2% 1.04µs ± 2% -1.82% (p=0.000 n=19+20)
It also yields a slight (0.5 - 1.0 microsecond) reduction in CPU time for
fullstack unary pingpong:
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/512
[polls/iter:3.0001 ] 23.9µs ± 2%
23.0µs ± 1% -3.63% (p=0.002 n=6+6)
BM_UnaryPingPong<TCP, NoOpMutator, NoOpMutator>/0/32768
[polls/iter:3.00015 ] 35.1µs ± 1%
34.2µs ± 1% -2.57% (p=0.036 n=5+3)
BM_UnaryPingPong<MinTCP, NoOpMutator, NoOpMutator>/8/0
[polls/iter:3.00011 ] 21.7µs ± 3%
21.2µs ± 2% -2.44% (p=0.017 n=6+5)
5 years ago
Soheil Hassas Yeganeh
18b19105f2
Implement TCP_INQ for gRPC in Linux
...
TCP_INQ is a socket option we added to Linux to report pending bytes
on the socket as a control message.
Using TCP_INQ we can accurately decide whether to continue read or not.
Add an urgent parameter, when we do not want to wait for EPOLLIN.
This commit improves the latency of 1 RPC unary (minimal benchmark)
significantly:
Before:
l_50: 61.3584984733
l_90: 94.8328711277
l_99: 126.211351174
l_999: 158.722406029
After:
l_50: 51.3546011488 (-16%)
l_90: 72.3420731581 (-23%)
l_99: 103.280218974 (-18%)
l_999: 130.905689996 (-17%)
6 years ago
Yash Tibrewal
30e1991bf9
Update context list test
6 years ago
yang-g
67742ef63f
Fix BUILD files. Manually edit bzl files
6 years ago
yang-g
e75fc243da
change tests to use the new class instead of grpc_test_init
6 years ago
Yash Tibrewal
77ba25ab72
s/int/uint32_t
6 years ago
Yash Tibrewal
9506d35674
Add a byte counter to chttp2_stream and use that for timestamps
6 years ago
Yash Tibrewal
c7e92f26eb
Reviewer comments
6 years ago
Yash Tibrewal
bab043e865
Cleanup
6 years ago
Guantao Liu
0c18293e55
Fix the test failure with callback-based polling.
6 years ago
Hope Casey-Allen
327c514fe7
Some reorganizing to respond to code review comments
6 years ago
Hope Casey-Allen
fbe594beeb
Much cleaner approach that should address code review comments as well
6 years ago
Hope Casey-Allen
97cbec1c98
WIP. Setting md_index to 0 on grpc_linked_mdelem creation
6 years ago
Hope Casey-Allen
4181c8cd37
Zero out linked_mdelem when created in test
6 years ago
Yash Tibrewal
9c5bde5e4e
More commits
6 years ago
Juanli Shen
3c3f3ad75a
Decrease GRPC_CHTTP2_HPACKC_NUM_VALUES
7 years ago
Yash Tibrewal
c0cd82faed
Remove unnecessary includes of exec_ctx.h
7 years ago
Muxi Yan
6c9a87c174
Polish infer_length_after_decode and add test cases
7 years ago
Noah Eisen
be82e64b3d
Autofix c casts to c++ casts
7 years ago
Jan Tattermusch
8376749faa
fix EventState::done() data race
7 years ago
Mark D. Roth
dbdf495f61
Split lib/support into lib/gpr and lib/gpr++.
7 years ago
Vijay Pai
9423c274cd
Need to include functional to use std::bind
7 years ago
Muxi Yan
38fcd0c6c3
clang-format
7 years ago
Yash Tibrewal
8cf1470a51
Revert "Revert "All instances of exec_ctx being passed around in src/core removed""
7 years ago
Yash Tibrewal
ad4d2dde00
Revert "All instances of exec_ctx being passed around in src/core removed"
7 years ago
Mark D. Roth
e204e5e497
Apply #13336 to v1.8.x branch.
7 years ago
Yash Tibrewal
c354269ba7
Remove _ prefixed variable names
7 years ago
Mark D. Roth
ca014e4d5e
Clean up semantics of test code.
7 years ago
Yash Tibrewal
81fc8c9c33
Fix tests to call grpc_init and grpc_shutdown before using exec_ctx
7 years ago
ncteisen
fe354eb807
Fix the fuzzers
7 years ago
Mark D. Roth
39dd9aa439
Fix BUILD file.
7 years ago
Mark D. Roth
d0f56a9997
Fix sanity problem.
7 years ago