Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
vam-google	dbe62a6e6c	Switch to `py2and3_test` rule from py_test	5 years ago
vam-google	564dc771dc	Return PyInfo provider with imports from _gen rules and pass that as deps in py_library. This allows hiding _virtual_imports include path from the surface.	5 years ago
Nicolas Noble	04d7e0d11f	Revert "Upgrade to bazel 1.0.0"	5 years ago
Jan Tattermusch	74ade125f2	toolchains no longer support machine types	5 years ago
Jan Tattermusch	396d8c07f6	update bazel toolchains to 1.0.0	5 years ago
Jan Tattermusch	0460b9bb4b	fixup	5 years ago
Jan Tattermusch	b77cb8ae7c	replace git_repository occurence by http_archive	5 years ago
Esun Kim	1743519aa9	Activate C++ stdlib	5 years ago
Jan Tattermusch	3ece581720	win RBE tests with uses_polling=True need to run as well	5 years ago
Jan Tattermusch	5b9e08d9a3	try updating bazel toolchains	5 years ago
Jan Tattermusch	6822d9a779	correctly generate tests for bazel tests that dont use polling	5 years ago
Richard Belleville	1d1aebb920	Remove unused import	5 years ago
Rafi Kamal	7c85e29076	Add protobuf_deps to python_test_repo WORKSPACE	5 years ago
Esun Kim	300077aac1	Update upb to HEAD	5 years ago
Juanli Shen	0a3b333c04	Fix internal warning	5 years ago
Richard Belleville	c11539f79e	Document kwargs	5 years ago
Richard Belleville	ecf7274aaa	Add docstring to py2and3_test	5 years ago
vam	59f909df79	address PR feedback	5 years ago
vam	461c053c37	[bazel][python] Support _virtual_imports input for py_proto_library and py_grpc_library rules `proto_library` targets are used as deps for `py_proto_library` and `py_grpc_library` rules. The `proto_library` targets can be configured using `import_prefix` and/or `strip_import_prefix` (which essentially move original location of the proto file and, as result, affects import path within proto files themselves and in the generated language-specific stubs). The biggest question to answer when generating stubs from moved protos is where to put result (this decision affects all downstream rules as well, because the location of file affects its import path). This PR tries to follow same logic as the native `cc_proto_library` (created and maintained by Bazel team). For example, if we have `firestore.proto` file, which is located under `google/firestore/v1beta1` Bazel package and want to move it under `google/cloud/firestore_v1beta1/proto` (this is axactly what happens in googleapis repository), it can be configured the following way: ```bzl proto_library( name = "firestore_moved_proto", srcs = ["firestore.proto"], import_prefix = "google/cloud/firestore_v1beta1/proto", strip_import_prefix = "google/firestore/v1beta1", ) ``` The rule above will first generate virtual `.proto` files (under new location) and only after that generate a binary descriptor from them. Specifically it will generate the following "virtual" file under `_virtual_imports` subdirectory of same package: ``` bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/common.proto ``` When supplied to `cc_proto_library`, like the following: ```bzl cc_proto_library( name = "firestore_moved_cc_proto", deps = ["firestore_moved_proto"], ) ``` The rule will generate .cc and .h files like the following: ``` bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/firestore.pb.h bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/firestore.pb.cc ``` Notice, that each generated `.cc` and `.h` file is prefixed with `_virtual_imports/<name_of_proto_library_target>`. The python rules try to do same thing, so for the following py_proto_library rule: ```bzl py_proto_library( name = "firestore_moved_py_proto", deps = [":firestore_moved_proto"], ) ``` It wil generate the following file: ``` bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/firestore_pb2.py ``` I.e in same path as cc_proto_library. This all woks, but an annoying part is that to use the generated library in some other py_library, in needs to specify the "_virtual_imports/proto_target" path as its "includes" parameter (and I can't make it better than that). Another option would be to skeep the `_virtual_imports/<name_of_proto_library_target>` the suffix for the generated python stubs, which will make the path look like the following: ``` bazel-bin/google/firestore/v1beta1/google/cloud/firestore_v1beta1/proto/firestore_pb2.py ``` That will make using generated stubs simpler and cleaner (no need to specify imports argument), but it will make it inconsistent with the other rules (like cc_proto_library) and also more susseptible to naming conflicts (if there is already something under the generated path).	5 years ago
Richard Belleville	d649880044	Add strip_prefix to python protoc plugin and py_grpc_library	5 years ago
Richard Belleville	9c4de3a983	Move reference to external workspace to OSS-specific file	5 years ago
Richard Belleville	1444cd1dd3	Revert "Revert "Merge pull request #20097 from gnossen/dual_version_python_tests"" This reverts commit `24c562dbaa`.	5 years ago
Richard Belleville	24c562dbaa	Revert "Merge pull request #20097 from gnossen/dual_version_python_tests" This reverts commit `c9c847f334`, reversing changes made to `07ba4de392`.	5 years ago
Jan Tattermusch	7357f63c09	update check_submodules.sh and grpc_deps.bzl	5 years ago
Muxi Yan	96c11d153f	Revert "Revert #19704 and #20060"	5 years ago
Muxi Yan	d1f4456dc6	Revert "Merge pull request #19704 from muxi/isolate-call-implementation-2" This reverts commit `ac5f8062dd`, reversing changes made to `8ae549431c`.	5 years ago
Richard Belleville	d3cd387e03	Bump rules_apple	5 years ago
Jan Tattermusch	abc384164a	fix kwargs syntax error	5 years ago
Richard Belleville	6dfa96524d	Fix failing CPP test	5 years ago
Jan Tattermusch	b7667478cf	bump bazel version to 0.27	5 years ago
Richard Belleville	426450cd82	Implement dual testing	5 years ago
Esun Kim	2707fd0bd4	Added GRPC_USE_CPP_STD_LIB flag	5 years ago
Hope Casey-Allen	f66f047841	Update googletest version to fix BoringSSL support	5 years ago
Richard Belleville	8ce740cfe0	Switch py_proto_library from using src to deps to conform with google3	5 years ago
Esun Kim	7ec6e8a4de	Remove nanopb from gRPC	5 years ago
Prashant Jaikumar	141c2d24d1	Add support for running C++ tests on iOS	5 years ago
Tony Lu	20b085e314	Passing kwargs	5 years ago
Richard Belleville	6c0acf7330	Swap a11r with veblush.	5 years ago
Richard Belleville	4509af86d7	Update source of truth.	5 years ago
Esun Kim	78a01a5782	Update upb to the latest	5 years ago
Tony Lu	df59df8ba2	Upgrading bazel_skylib	5 years ago
Richard Belleville	b26b25113f	Make soruce file validation exact	5 years ago
Esun Kim	f88bd06ee5	Go UPB!	5 years ago
Richard Belleville	5fd25f3c7c	Refactor rule.	5 years ago
Muxi Yan	de3131016d	update BUILD following the new style	5 years ago
Lukacs T. Berki	e2ba3aa070	Update C++ code generation to work with Bazel 0.29 . The above Bazel version changes proto compilation slightly: some proto files are put into a `_virtual_imports` directory and thus `_get_include_directory` needs to be updated accordingly. Ideally, it would use instead the `ProtoInfo` provider to tease out the proto import directories, but that's a bit more intrusive change.	5 years ago
Richard Belleville	4f13303ec4	Validate length of deps in py_grpc_library	5 years ago
Richard Belleville	a77404ae6b	Add README to bazel test	5 years ago
Richard Belleville	3638167e40	Call grpc_python_deps() from grpc_deps().	5 years ago
Richard Belleville	e89096cdf2	AAAAAAAHHHHHH	5 years ago

1 2 3 4 5 ...

296 Commits (6ca827a0088d055ef1f8dfe17e2a33ba2f26965e)