242e9185a3
[metadata] Allow non application/grpc content-type values ( #35824 )
...
Fixes #33935
The gRPC spec is not clear on how to handle headers where the "content-type" is not "application/grpc" or similar. We should be safe and not reject such headers.
Closes #35824
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35824 from yashykt:Fix33935 3d89af87ec
10 months ago
01fb4a0fe4
[experiments] Clean up some rolled out experiments ( #35195 )
...
Closes #35195
COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35195 from ctiller:cleanup-cleanup 1f22298ac9
1 year ago
bae0c705aa
[Deps] Update to Clang-16 ( #34492 )
...
<!--
If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.
If your pull request is for a specific language, please add the
appropriate
lang label.
-->
1 year ago
954b285dd2
[chttp2] Limit request count before receiving settings ack ( #34638 )
...
Previously chttp2 would allow infinite requests prior to a settings ack
- as the agreed upon limit for requests in that state is infinite.
Instead, after MAX_CONCURRENT_STREAMS requests have been attempted,
start blanket cancelling requests until the settings ack is received.
This can be done efficiently without allocating request state
structures.
1 year ago
4c7107794d
[promises] Handle the case that a rejection happens without reporting to the app ( #33782 )
...
Promises code can prevent these bad requests from even reaching the
application, which is beneficial but this test needs a minor update to
handle it.
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
1 year ago
62bb99d163
[e2e] c++-ify core e2e test fixtures ( #32550 )
...
A step toward #14016 .
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
29d8beee0a
[http2] Dont drop connections on metadata limit exceeded ( #32309 )
...
* [http] Dont drop connections on metadata limit exceeded
* remove bad test
* Automated change: Fix sanity tests
---------
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
08555c8723
Add enforcement for cpp-style comment license in check_copyright.py ( #32273 )
...
* enforce cpp style comment copyright license in check_copyright.py
also add functionality to fix(replace) c-style comment with cpp style
comment
* fix tools/codegen/core/gen_stats_data.py
* review
2 years ago
905df9dee6
Update Abseil to 20230125 ( #32139 )
...
* Update abseil to 1.20230125.0
* Fix IWYU
2 years ago
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
49a3035d44
[iwyu] Fix CI job ( #31921 )
...
* fix-includes
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* add warning label
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
8174a75079
[iwyu] Add more test directories ( #30952 )
...
* [iwyu] Add more test directories
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
2122f2dc9d
[flaky] Fix bad_client duplicate_header test ( #30577 )
2 years ago
3ec0e29bcf
[test] Convert cq verifier to C++ ( #30256 )
...
* [test] Convert cq verifier to C++
* Automated change: Fix sanity tests
* fix
* dead code
* strength reduction
* dead code
* fix
* when search/replace goes wrong
* review feedback
* review feedback
* cleanup
* fixes
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
eb5ae61470
Reland (again) bytestream removal ( #29987 )
...
* Revert "Revert "Reland bytestream removal (#29911 )" (#29964 )"
This reverts commit e6c6840db3
2 years ago
e6c6840db3
Revert "Reland bytestream removal ( #29911 )" ( #29964 )
...
* Revert "Reland bytestream removal (#29911 )"
This reverts commit 98dcba2807
3 years ago
98dcba2807
Reland bytestream removal ( #29911 )
...
* Revert "Revert "Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )" (#29894 )" (#29910 )"
This reverts commit 713a1581d5
3 years ago
713a1581d5
Revert "Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )" ( #29910 )
...
This reverts commit 93cdc8b77e
3 years ago
93cdc8b77e
Revert "Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )" ( #29894 )
...
* Revert "Revert "[transport] Remove ByteStream (#29637 )" (#29890 )"
This reverts commit d53986657f
3 years ago
d53986657f
Revert "[transport] Remove ByteStream ( #29637 )" ( #29890 )
...
This reverts commit aacf0e252b
3 years ago
aacf0e252b
[transport] Remove ByteStream ( #29637 )
...
* A starter SliceBuffer implementation
* Add comments and fix sanity checks
* Minor fixes
* more minor fixes
* Addressing review comments and adding a slice_buffer_test
* fix sanity checks
* regenerate projects
* fixing undefined function error
* reverting changes from memory_allocator.cc and adding them to src/core/lib/slice/slice_buffer.cc to allow memory allocator lib to build correctly
* fix sanity checks
* adding an open source slice definition
* regnerate projects
* fix asan error
* Automated change: Fix sanity tests
* addressing review comments
* fix sanity checks
* regenerate projects
* update
* fix sanity checks
* Converting slice buffer to retarin ownership of the underlying ctype
* [slice_buffer] Introduce grpc_core::SliceBuffer
* add test
* Automated change: Fix sanity tests
* [byte-stream] Delete ByteStream
* progress
* progress
* missing files
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* sanity
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* progress
* iwyu
* fix
* progress
* fix
* fix
* progress
* code compiles
* fix?
* bogus assert
* Automated change: Fix sanity tests
* fix
* fix
* fix?
* fix
* fix
* better expression of function
* fix?
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* add fullstack test without retry filter
* debug
* missing files
* gc
* fix h2_full_no_retry
* remove headers
* fixes
* Automated change: Fix sanity tests
* x
* fix
* fix
* fix
* progress
* x
* tear apart flow control
* continue itnegration
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* cleanup
* Automated change: Fix sanity tests
* fix
* x
* x
* Revert "debug"
This reverts commit 0120a944925fe05120776df476b22f
3 years ago
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
220cf641fa
Reland slice metadata conversion ( #28210 )
...
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
3 years ago
0bdb4d650b
Revert "Revert "use CppImplOf for grpc_server ( #28112 )" ( #28130 )" ( #28144 )
...
This reverts commit eec0ca98c1
3 years ago
eec0ca98c1
Revert "use CppImplOf for grpc_server ( #28112 )" ( #28130 )
...
This reverts commit 2ea8e50c3a
3 years ago
2ea8e50c3a
use CppImplOf for grpc_server ( #28112 )
...
* use CppImplOf for grpc_server
* fix build
* fix sanity
3 years ago
1c6634ac44
Changed grpc_error_get|set_str to use std string instead of slice ( #27466 )
...
* Changed grpc_error_get|set_str to use std string
* Fix init order in tests with gtest
* Undo gtest-tify credentials_test
3 years ago
b669a3c521
Revert "Revert "a useful change ( #27381 )" ( #27411 )" ( #27412 )
...
This reverts commit 5db17f7350
3 years ago
5db17f7350
Revert "a useful change ( #27381 )" ( #27411 )
...
This reverts commit 11eb70bbed
3 years ago
11eb70bbed
a useful change ( #27381 )
...
* a useful change
* Automated change: Fix sanity tests
* fix
* fix
* QsortCompare it is!
* Automated change: Fix sanity tests
* add missing header
* clang-tidy fixes, tweak clamp to only use <
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
613b90ba93
Revert "Buffer HPACK parsing until the end of a header boundary ( #26700 )" ( #26825 )
...
This reverts commit 8bab3e4bf4
3 years ago
8bab3e4bf4
Buffer HPACK parsing until the end of a header boundary ( #26700 )
...
HTTP2 headers are sent in (potentially) many frames, but all must be
sent sequentially with no traffic intervening.
This was not clear when I wrote the HPACK parser, and still indeed quite
contentious on the HTTP2 mailing lists.
Now that matter is well settled (years ago!) take advantage of the fact
by delaying parsing until all bytes are available.
A future change will leverage this to avoid having to store and verify
partial parse state, completely eliminating indirect calls within the
parser.
3 years ago
2ff84ed8c2
C++ cast for void*
4 years ago
f2fa95b593
Do not cancel RPC if send metadata size if larger than peer's limit
4 years ago
0b61aea1c5
Convert grpc_server to idiomatic C++.
4 years ago
3bb427195e
Revert "Merge pull request #23053 from grpc/revert-22772-gpr_strvec"
...
This reverts commit 4b7452bcdb133d0076b4
5 years ago
f46c07f3f8
Revert "Remove gpr_strvec."
5 years ago
c2ef110303
Replace gpr_strvec with absl::StrJoin().
5 years ago
78888d7861
avoid thread local unitialized problem under GRPC_PTHREAD_TLS
5 years ago
38d87137f8
Remove unused parameter warning (3 of 20)
5 years ago
41d89242ad
Remove unused parameter warning (2 of 20)
5 years ago
8a310e5063
Clang tidy
6 years ago
4fc02c6bf5
add tests for bad stream IDs
6 years ago
e60c43ff3e
Add out of bounds frame tests
6 years ago
ea427791d3
Reviewer comments
6 years ago
597a67a2b5
Covert to GTEST
6 years ago
7994ea53fc
Add detailed unknown frame type tests
6 years ago
486b1fe320
Fix bad_client_simple_request test.
...
The data of 0xffffffff is actually not illegal, the top bit should be
ingored according to the spec.
6 years ago
e75fc243da
change tests to use the new class instead of grpc_test_init
6 years ago
Yash Tibrewal
Craig Tiller
Yijie Ma
Esun Kim
Yijie Ma
apolcyn
AJ Heller
Mark D. Roth
Karthik Ravi Shankar
Jan Tattermusch
Vijay Pai
yang-g