Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Matthieu MOREL	d09edb126f	inline bounded external:protocol_compiler (#36262 ) Related to #36157 This is only focused on one binding so it is validated progressively Closes #36262 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36262 from mmorel-35:externalprotocol_compiler `f00cce8728` PiperOrigin-RevId: 639101071	6 months ago
Greg	1ddd02cd5b	Change outdated cfg = "host" to cfg = "exec" (#35258 ) Preserves future Bazel compatibility:https://github.com/bazelbuild/bazel/issues/17032 Extension of https://github.com/grpc/grpc/pull/32021 which missed review. release notes: no Closes #35258 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/35258 from gregestren:master `7379674a44` PiperOrigin-RevId: 591092923	12 months ago
Craig Tiller	4e666c740b	Internal change PiperOrigin-RevId: 590780731	12 months ago
Tanvi Jagtap	8019903a44	Internal configuration cleanup PiperOrigin-RevId: 590528536	12 months ago
Yash Tibrewal	41ec08c69a	Update third_party/protobuf to 3.21.4 (#30377 ) * Update third_party/protobuf * run tools/distrib/python/make_grpcio_tools.py * regenerate protos for ruby, php * update build_handwritten.yaml * regenerate projects * Build - Use :well_known_type_protos instead of :well_known_protos * Fix target * Update upb * Update Python for Protobuf 4.21 (#140) * Update protobuf dependency on grpcio-tools * Off by one * Drop python 3.6 support * Try upgrading pip * And in the other script * Try to figure out if we're compatible with abi3 * See what we've already got installed * Update the requirements.txt file I didn't know existed * And here too * See what's installed * Let's try that again * Remove * Try to confirm version * Let me see the generated code * Fix non-Bazel test runner * Work for all test directories * Regenerate example protos * Clean up * Generate .pyi files * Fix type checking and linting * Exclude pyi files from isort * Upgrade to 3.21.4 * Update iwyu to get around messy protobuf IWYU rules Co-authored-by: Richard Belleville <gnossen@gmail.com>	2 years ago
Richard Belleville	468768865b	Make Buildifier Sanity Test Strict (#27807 ) * Fix all lint errors in repo. * Use strict buildifier by default * Whoops. That file does not exist * Attempt fix to buildifier invocation * Add missing copyright	3 years ago
Richard Belleville	05aa736840	Fix bazel copyright notices (#26353 ) * Add copyright to Bazel files * Add check for copyright in Bazel files * Remove unintentional file	4 years ago
Yannic Bonenberger	06ecc87290	[bazel] Add fixes for --incompatible_load_proto_rules_from_bzl	5 years ago
Lidi Zheng	c34bef4ca4	Format all Bazel files with buildifier	5 years ago
vam	461c053c37	[bazel][python] Support _virtual_imports input for py_proto_library and py_grpc_library rules `proto_library` targets are used as deps for `py_proto_library` and `py_grpc_library` rules. The `proto_library` targets can be configured using `import_prefix` and/or `strip_import_prefix` (which essentially move original location of the proto file and, as result, affects import path within proto files themselves and in the generated language-specific stubs). The biggest question to answer when generating stubs from moved protos is where to put result (this decision affects all downstream rules as well, because the location of file affects its import path). This PR tries to follow same logic as the native `cc_proto_library` (created and maintained by Bazel team). For example, if we have `firestore.proto` file, which is located under `google/firestore/v1beta1` Bazel package and want to move it under `google/cloud/firestore_v1beta1/proto` (this is axactly what happens in googleapis repository), it can be configured the following way: ```bzl proto_library( name = "firestore_moved_proto", srcs = ["firestore.proto"], import_prefix = "google/cloud/firestore_v1beta1/proto", strip_import_prefix = "google/firestore/v1beta1", ) ``` The rule above will first generate virtual `.proto` files (under new location) and only after that generate a binary descriptor from them. Specifically it will generate the following "virtual" file under `_virtual_imports` subdirectory of same package: ``` bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/common.proto ``` When supplied to `cc_proto_library`, like the following: ```bzl cc_proto_library( name = "firestore_moved_cc_proto", deps = ["firestore_moved_proto"], ) ``` The rule will generate .cc and .h files like the following: ``` bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/firestore.pb.h bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/firestore.pb.cc ``` Notice, that each generated `.cc` and `.h` file is prefixed with `_virtual_imports/<name_of_proto_library_target>`. The python rules try to do same thing, so for the following py_proto_library rule: ```bzl py_proto_library( name = "firestore_moved_py_proto", deps = [":firestore_moved_proto"], ) ``` It wil generate the following file: ``` bazel-bin/google/firestore/v1beta1/_virtual_imports/firestore_moved_proto/google/cloud/firestore_v1beta1/proto/firestore_pb2.py ``` I.e in same path as cc_proto_library. This all woks, but an annoying part is that to use the generated library in some other py_library, in needs to specify the "_virtual_imports/proto_target" path as its "includes" parameter (and I can't make it better than that). Another option would be to skeep the `_virtual_imports/<name_of_proto_library_target>` the suffix for the generated python stubs, which will make the path look like the following: ``` bazel-bin/google/firestore/v1beta1/google/cloud/firestore_v1beta1/proto/firestore_pb2.py ``` That will make using generated stubs simpler and cleaner (no need to specify imports argument), but it will make it inconsistent with the other rules (like cc_proto_library) and also more susseptible to naming conflicts (if there is already something under the generated path).	5 years ago
Tony Lu	44868ae12a	Starting a new branch with same changes from https://github.com/grpc/grpc/pull/19621	5 years ago

11 Commits (4e76af9bdaeba36eb77ab128b1f99c30c682871b)