6f3d7ccdb1
Modifying slice buffer add to merge two contiguous slices sharing the same refcount object ( #29466 )
...
* Modifying slice buffer add to merge two contiguous slices sharing the same refcount object
* sanity checks
* updating test
* fixing grpc_slice_buffer_add API misuse in proto utils
* fix sanity checks
* minor fix
3 years ago
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
74a2cb6e2b
Revert "Revert "Reland slice changes ( #28601 )" ( #28615 )" ( #28624 )
...
* Revert "Revert "Reland slice changes (#28601 )" (#28615 )"
This reverts commit 939bbfc336
3 years ago
939bbfc336
Revert "Reland slice changes ( #28601 )" ( #28615 )
...
This reverts commit b33e0d40af
3 years ago
b33e0d40af
Reland slice changes ( #28601 )
...
* Revert "Revert "Eliminate slice interning (#28363 )" (#28598 )"
This reverts commit 03bf699600
3 years ago
03bf699600
Revert "Eliminate slice interning ( #28363 )" ( #28598 )
...
This reverts commit 6703186b7a
3 years ago
6703186b7a
Eliminate slice interning ( #28363 )
...
Eliminate slice interning, and structures in slices to support it.
Reduces grpc_slice_refcount from 40 bytes (+ a required 8 bytes elsewhere) to 16 bytes.
Removes a pointer dereference for every slice ref/unref.
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
4b881c5947
Remove grpc_mdelem ( #28267 )
...
* Automated change: Fix sanity tests
* content-type
* Automated change: Fix sanity tests
* clang-format
* fix
* Move colon prefixed metadata
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* try to fix windows failure
* try and scale sizes better
* ambiguity fix?
* wip metadatavalueasslice
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
3 years ago
220cf641fa
Reland slice metadata conversion ( #28210 )
...
* Fix status code for resource exhaustion
* Revert "Revert "Move a bunch of slice typed metadata to new system (#28107 )" (#28208 )"
This reverts commit 7717587063
3 years ago
7717587063
Revert "Move a bunch of slice typed metadata to new system ( #28107 )" ( #28208 )
...
This reverts commit 4d432aefc1
3 years ago
4d432aefc1
Move a bunch of slice typed metadata to new system ( #28107 )
...
* Eliminate most of grpc_message metadata handling
* Eliminate most of host metadata handling
* Remove more callouts without fixing code
* fiiixes
* typo
* Automated change: Fix sanity tests
* try-shrink
* Automated change: Fix sanity tests
* size tweaks
* less tricks
* deunique
* commonize
* commonize
* Automated change: Fix sanity tests
* size tuning, fixes
* Automated change: Fix sanity tests
* fix
* size tuning, fixes
* remove constexpr
* fix
* reuse code
* fix
* tweak code
* more tweaks
* tell no lies
* fixes
* fixes
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix?
* fix binder
* fix
* fix
* fixes
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
0794973bbb
Reland user-agent metadata work ( #28109 )
...
* Revert "Revert "user-agent metadata trait, also: grpc_core::Slice is born (#27770 )" (#28108 )"
This reverts commit 89d08dad9dd6bca8ed3d
3 years ago
89d08dad9d
Revert "user-agent metadata trait, also: grpc_core::Slice is born ( #27770 )" ( #28108 )
...
This reverts commit 7a40f50cb3
3 years ago
7a40f50cb3
user-agent metadata trait, also: grpc_core::Slice is born ( #27770 )
...
* new slice api
* storage-classes
* Automated change: Fix sanity tests
* tweaks
* refinement
* refinement
* compiles
* Automated change: Fix sanity tests
* better impl
* convert to gtest
* clean
* fixes
* tests
* Automated change: Fix sanity tests
* more-tests
* clarity
* comments
* comments
* fixes
* comment-updates
* fixes
* spam
* Automated change: Fix sanity tests
* move transport size into transport!
* mebbefix
* fix type
* x
* fix-merge
* review feedback
* review feedback
* Automated change: Fix sanity tests
* meh
* review feedback
* fix
* resolve compile issue
* Remove slice_refcount dependency on RefCounted
* update init for channel_data in http_client_filter
* Automated change: Fix sanity tests
* remove banned function
* fixes
* will it blend
* will it blend
* fix refcount init
* fix
* fix comment
* Fix typo in bloat script
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
468768865b
Make Buildifier Sanity Test Strict ( #27807 )
...
* Fix all lint errors in repo.
* Use strict buildifier by default
* Whoops. That file does not exist
* Attempt fix to buildifier invocation
* Add missing copyright
3 years ago
d1e01ac139
Add a test for a (now-illegal) build file construct ( #27602 )
...
* Add a test for a (now-illegal) build file construct
* add to test suite!
* fix
* fix
* fix syntax
3 years ago
c5172a134e
Fix build splitup for slices. ( #27452 )
...
* slice fix
* fix properlike
* Automated change: Fix sanity tests
* actually delete the code that should have been
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
66ae0d5c08
Separate slices from mdelems for static data ( #27372 )
...
* separate slice into internal and refcount, with refcount being the minimal base
* python3-ize
* Separate slices from mdelems for static data
Allows us to separate a small build target with just some slice basics
from the rest, which will help simplify the build system longer term.
Additionally exposed an opportunity to eliminate an init function.
Should also help in a month or so when it's time to jettison interned
metadata and slices entirely.
* fix compilation
* Automated change: Fix sanity tests
* fixes
* fixfixfix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
b062fcd5c6
Ensure consistency of include style for <grpc.* headers ( #27233 )
...
* Add a tool to ensure consistency in how grpc public headers are included
* Apply tool
* add to test suite
* isort
3 years ago
5dc93179eb
modernize % encoding routines ( #27018 )
...
* modernize % encoding routines
* Automated change: Fix sanity tests
* use bitset
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
8e9e895ffc
Replace grpc_shutdown_blocking with grpc_shutdown
4 years ago
c35a37d6c2
Remove TargetAuthorityTable in favor of a per-address channel arg.
4 years ago
fc6f26c89b
Remove grpc_core::StringView.
5 years ago
41cfae4234
Revert "Merge pull request #19693 from apolcyn/control_plane_creds"
...
This reverts commit 162fccdb90228e7557fa
5 years ago
dbea965b8e
Fix fuzzers to actually run.
5 years ago
a1cf1eb4bc
Fix leak when running b64_decode_fuzzer tests.
5 years ago
944e6f9ad4
Create testcase-5759629707444224.
5 years ago
bd60691d95
Fix include order for clang_format.
5 years ago
59415d0c25
Create testcase-5686577615339520
5 years ago
79c4a2f1d8
Fix leak when running b64_encode_fuzzer tests.
5 years ago
e45b60d1fe
Fix unique_ptr<char> memory allocation mismatch
5 years ago
b2b7fc9af8
Replaced grpc_core::UniquePtr with std::unique_ptr
5 years ago
2b98a9bbc8
Fuzz base64 encoding and decoding
...
Google had a company-wide FuzzIt hackathon recently, so I went digging
in gRPC and found this, which means I probably don't know what I'm doing :)
The initial corpus files I'm checking in were generated via local runs
and appear to consistently cause leaks. Please let me know if these are
actual bugs, or if they're a false positive.
5 years ago
c34bef4ca4
Format all Bazel files with buildifier
5 years ago
81df105ac8
Deprecate gpr_get/set_allocation_functions
5 years ago
c3faf1c3b8
Remove unused parameter warning (12 of 20)
5 years ago
18fb48de59
use even better workaround
5 years ago
260dc18f47
a cleaner workaround
5 years ago
932ce81228
workaround_slice_test_compiler_bug
5 years ago
8e39f76b10
work around slice_test compiler bug
5 years ago
8e79705d29
disable fuzzers on windows
5 years ago
6ebc1c616f
set uses_polling=False for some bazel tests
5 years ago
2767accc1b
Fixed init-order-fiasco for static slice table.
...
Fixes init-order bug affecting https://github.com/grpc/grpc/issues/19819 which
was first exposed by this commit:
857375a142
5 years ago
609107586a
Add a way for tests with LeakDetector to free the control plane creds map
5 years ago
5d65a9fa7b
Address comments from Vijay.
6 years ago
0d6cffd6c4
Introduce grpc_slice_from_moved_string.
...
Suggested by @markdroth to avoid extra allocation and copy when it's not
needed.
6 years ago
1f0476267b
Add a better comment and rename consume_first to remove_first.
6 years ago
4c0c2965fe
Use peek_first instead of mutable_first.
...
Use DEBUG_ASSERT instead of ASSERT.
6 years ago
fd5f787080
Introduce slice_buffer helper methods to avoid copies.
...
take_first(), grpc_undo_first(), ... are very clostly
methods that unnecessarily copy grpc_slice with extra
ref counting requirements.
Introduce alternatives to avoid copies and refs wherever
possible.
This results in 1% improvements in the benchmarks.
6 years ago
Vignesh Babu
AJ Heller
Craig Tiller
Jan Tattermusch
Richard Belleville
Esun Kim
Mark D. Roth
Ivan Posva
Samuel Lijin
Lidi Zheng
Vijay Pai
Jan Tattermusch
Arjun Roy
Alexander Polcyn
Soheil Hassas Yeganeh