Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Hannah Shi	2329b25b09	[ObjC] fix lock inversion in dns service resolver shutdown (#38010 ) In EventEngineClientChannelDNSResolver, it needs to acquire `on_resolved_mu_` lock when calling dns resolver APIs as well as in on_resolve callback. In DNSServiceResolverImpl::LookupHostname, it acquires `request_mu_` lock, so the lock order is: EventEngineClientChannelDNSResolver::on_resolved_mu_ -> DNSServiceResolverImpl::request_mu_ Upon the resolution successful or failed, DNSServiceResolverImpl calls the on_resolved callback without holding any locks, so only one lock here: EventEngineClientChannelDNSResolver::on_resolved_mu_ However when DNSServiceResolver was deleted, in DNSServiceResolverImpl::Shutdown, it calls the on_resolve callbacks while holding the `request_mu_` lock, as a result the lock order becomes: DNSServiceResolverImpl::request_mu_ -> EventEngineClientChannelDNSResolver::on_resolved_mu_ which triggers the deadlock check in absl::Mutex as these two locks are acquired in different orders. This PR release the on_resolved_mu_ first before calling on_resolve, so abls won't complain. Added a new test which fails with GPR_ABSEIL_SYNC=1 (not enabled by default) without this PR. Closes #38010 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/38010 from HannahShiSFB:fix-lock-invert-in-dns-service-resolver-shutdown `5adc8f32b3` PiperOrigin-RevId: 690781049	1 month ago
Craig Tiller	dbb5164ac7	[clang-format] Remove custom clang-format rules for include ordering (#37820 ) Closes #37820 PiperOrigin-RevId: 682352913	2 months ago
Mark D. Roth	0944410d6c	[reorg] move test/core/util -> test/core/test_util (#36446 ) Closes #36446 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36446 from markdroth:reorg_test `5dcc85e006` PiperOrigin-RevId: 629229220	7 months ago
Tanvi Jagtap	fadf1bbd9b	grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT (#36326 ) grpc][Gpr_To_Absl_Logging] Migrating from gpr to absl logging GPR_ASSERT Replacing GPR_ASSERT with absl CHECK Will not be replacing CHECK with CHECK_EQ , CHECK_NE etc because there are too many callsites. Only a few - which fit into single - line regex will be changed. This would be small in number just to reduce the load later. Replacing CHECK with CHECK_EQ , CHECK_NE etc could be done using Cider-V once these changes are submitted if we want to clean up later. Given that we have 5000+ instances of GPR_ASSERT to edit, Doing it manually is too much work for both the author and reviewer. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #36326 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/36326 from tanvi-jagtap:tjagtap_gpr_assert_event_eng `bfe99bec63` PiperOrigin-RevId: 624038836	8 months ago
Hannah Shi	e5d41f2a1f	[ObjC] cf event engine supports resolve recursively from on_resolve callback (#34385 ) If the client calls LookupHostname again within the on_resolve callback, it re-acquires the `request_mu_` before releasing it which results in deadlock. With this PR it extracts the request and releases the lock before calling on_resolve callback so it won't deadlock any more.	1 year ago
Hannah Shi	239a5fce2d	[ObjC] dns service resolver for cf event engine (#33971 ) re-submit of #33233 with refactored tests 1. split ios event engine tests to client tests (require oracle engine) and unit test 2. disable dns server setup in [dns_test.cc](https://github.com/grpc/grpc/blob/master/test/core/event_engine/test_suite/tests/dns_test.cc#L127) for ios test, this is what's caused the revert. 3. disable dns_test in cf_event_engine_test for MacOS	1 year ago
AJ Heller	48f455a9a0	Revert "[ObjC] dns service resolver for cf event engine" (#33964 ) Reverts grpc/grpc#33233. This is failing 100% of builds https://source.cloud.google.com/results/invocations/248656d3-15ac-4d42-a2f8-6bec5c411e67/targets	1 year ago
Hannah Shi	cd85d7edf2	[ObjC] dns service resolver for cf event engine (#33233 ) Implement DNS using dns service for iOS. Current limitation: 1. Using a custom name server is not supported. 2. Only supports `LookupHostname`. `LookupSRV` and `LookupTXT` are not implemented. 3. Not tested with single stack (ipv4 or ipv6) environment 4. ~Not tested with multiple ip records per stack~ manually tested with wsj.com 5. Not tested with multiple interface environment	1 year ago
Hannah Shi	ad2a5dd355	[ObjC] Cf event engine client (#33034 ) Added `//:gpr_platform` to cf_engine_test to fix build_cleaner check in the previous merge. More details in https://github.com/grpc/grpc/pull/33027	2 years ago
AJ Heller	ee0aaacbde	Revert "[ObjC] CF Stream Event Engine Client" (#33027 ) Reverts grpc/grpc#32924. This breaks the build again, unfortunately. From `test/core/event_engine/cf:cf_engine_test`: ``` error: module .../grpc/test/core/event_engine/cf:cf_engine_test does not depend on a module exporting 'grpc/support/port_platform.h' ``` @sampajano I recommend looking into CI tests to catch iOS problems before merging. We can enable EventEngine experiments in the CI generally once this PR lands, but this broken test is not one of those experiments. A normal build should have caught this. cc @HannahShiSFB	2 years ago
Hannah Shi	d0c1809840	[ObjC] CF Stream Event Engine Client (#32924 ) bazel build --config=macos --genrule_strategy=local --copt="-DGRPC_CFSTREAM=1" //test/cpp/end2end:cfstream_test succeeds Fixing failure described here: https://github.com/grpc/grpc/pull/32882#issuecomment-1512210309	2 years ago
Craig Tiller	5ac894a04f	Revert "[ObjC] CF EventEngine client" (#32882 ) Reverts grpc/grpc#32077	2 years ago
Hannah Shi	e9a592a00f	[ObjC] CF EventEngine client (#32077 ) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> @sampajano	2 years ago

13 Commits (3e60646e15ae48962b202b8d349e29855b959fc1)