apolcyn
2f041aed40
Merge pull request #13836 from apolcyn/mark_testonly
...
Mark one test binary as testonly
7 years ago
David G. Quintas
e7515e48f0
Merge pull request #13831 from dgquintas/fix_wrong_slice_unref
...
Fix wrong unreffing of slice
7 years ago
Noah Eisen
98350e96e7
Merge pull request #13824 from ncteisen/fix-trickle
...
Make benchmark tests use correct timeout
7 years ago
Noah Eisen
2ec756774e
Merge pull request #13833 from ncteisen/comments
...
Add ownership semantic comments to error.h
7 years ago
Ken Payson
16e4bc010a
Bump to 1.8.2
7 years ago
Alexander Polcyn
3a1a2f0a10
Use the same ParseCommandLineFlags for golden file test that is used in other test binaries
7 years ago
yang-g
19d1eb2228
When seeing an error in interop test, also log the debug error string.
7 years ago
kpayson64
958649e07d
Merge pull request #13665 from kpayson64/poll_spin_bug
...
Fix a Python spinlock bug
7 years ago
Alexander Polcyn
d3dbc0d07b
Mark one test binary as testonly
7 years ago
Muxi Yan
b0f821cef9
Generate more files in gRPC-Core.podspec from build.yaml
7 years ago
ncteisen
77346746aa
Add ownership semantic comments to error.h
7 years ago
ncteisen
e2612aa0e8
Use correct timeout for benchmarks
7 years ago
David Garcia Quintas
c41bbd3c33
Fix wrong unreffing of slice
7 years ago
Ken Payson
2df509fc0e
Fix a Python spinlock bug
7 years ago
Mehrdad Afshari
0dd982cf4c
Merge pull request #13823 from mehrdada/shellcheckify-runtests-slash-sanity
...
shellcheckify `tools/run_tests/sanity`
7 years ago
David G. Quintas
e9b0fd07a5
Merge pull request #13494 from dgquintas/backoff_cpp
...
C++-ize backoff
7 years ago
Jan Tattermusch
f38b1526f8
simplify top level CMakeLists.txt
7 years ago
apolcyn
1c4d410c10
Merge pull request #13720 from apolcyn/enable_golden_file_test_in_bazel
...
Fix golden file test under bazel
7 years ago
Alexander Polcyn
9f01ae0052
Get rid of references to bazel toolchains and remote_execution, since they are only present on master
7 years ago
Alexander Polcyn
0678db7e24
Move more special cases in bazel build to the .bzl files
7 years ago
Ning Ren
e8cdc2dbbf
Depends third_party/nanopb via workspace relative-path to pass bazel's dependency check.
...
Otherwise include "third_party/nanopb/pb.h" will find local ph.h rather than the one in "//external:nanopb".
7 years ago
Ning Ren
4856782510
Packs contents of WORKSPACE into a bzl function, so that it can be resued by other projects, and simplifies cares build.
7 years ago
Noah Eisen
16319654c8
Merge pull request #13822 from grpc/error-tsan
...
Fix internal TSAN bug
7 years ago
Mehrdad Afshari
5de0a1f44b
Enforce shellcheck on tools/run_tests/sanity
7 years ago
Mehrdad Afshari
d1563c37cd
Fix core_untyped_structs.sh to pass shellcheck
7 years ago
Mehrdad Afshari
237f9edcf6
Merge pull request #13816 from mehrdada/sanitytest-shellcheck
...
Add a sanity test for shellcheck
7 years ago
Mehrdad Afshari
96ccd9ae97
Fix check_unsecure.sh to pass shellcheck
7 years ago
Mehrdad Afshari
fe3ca486bc
Fix check_submodules.sh to pass shellcheck
7 years ago
Mehrdad Afshari
5f7ab9b519
Fix check_owners.sh to pass shellcheck
7 years ago
Mehrdad Afshari
11eb322204
Fix check_clang_tidy.sh to pass shellcheck
7 years ago
David Garcia Quintas
4ef4c38275
Create copy of "ac" data instead of stretching the locked section
7 years ago
Mehrdad Afshari
a2ed77db56
Add a sanity test for shellcheck
...
Start by checking the scripts in tools/run_tests/helper_scripts.
7 years ago
David Garcia Quintas
5f31f01a8c
Fix use-after-free caused by unsync'd access in tcp_client_posix.
...
tc_on_alarm() and on_writable() race, resulting in the following:
```
D1219 08:59:33.425951347 86323 tcp_client_posix.cc:143] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_writable: error="No Error"
D1219 08:59:33.426032150 86342 tcp_client_posix.cc:104] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_alarm: error="No Error"
// At this point, note that the callbacks are running on different threads.
D1219 08:59:33.426063521 86323 tcp_client_posix.cc:218] XXX on_writable ac->addr_str 0x603000008dd0 before unlock. # refs 2->1. Done 0
// on_writable() unrefs while still holding the lock. Because refs > 0, it marks its "done" as false and unlocks.
D1219 08:59:33.426125130 86342 tcp_client_posix.cc:113] XXX tc_on_alarm ac->addr_str 0x603000008dd0 before unlock. # refs 1->0. Done 1
// right after on_writable() unlocks, tc_on_alarm() acquires the lock and unrefs, this time getting to zero and marking its "done" as true.
// It then proceeds to destroy "ac", and, in particular for this failure, "ac->addr_str".
D1219 08:59:33.426139370 86323 tcp_client_posix.cc:234] XXX on_writable about to read from ac->addr_str 0x603000008dd0. Done 0, error=OS Error
// When on_writable() tries to read ac->addr_str to assemble its error details, it causes a use-after-free.
```
The problem is the lock isn't held long enough by on_writable(). Alternatively, a copy of ac->addr_str could be made in on_writable() while still holding the lock, but that seems more fragile. It doesn't seem that holding the lock longer would be a performance issue, given we are in a failure scenario.
7 years ago
David Garcia Quintas
1bedfa3963
Fix another data race in client_lb_end2end
7 years ago
Noah Eisen
ffe6e03ecd
Fix internal TSAN bug
7 years ago
David Garcia Quintas
4f4a45e97e
fix tsan issue in client_lb_end2end
7 years ago
David G. Quintas
1acca45e89
Merge pull request #13813 from dgquintas/disable_low_thread_count
...
Disabled the json_run_localhost:*_low_thread_count family of tests
7 years ago
apolcyn
795e8ebdc4
Merge pull request #13798 from apolcyn/min_max_rpc_version_constants
...
Define RPC protocol version constants
7 years ago
David Garcia Quintas
251af24c54
Disabled the json_run_localhost:*_low_thread_count family of tests
7 years ago
David Garcia Quintas
3bc0dacfe0
Removed exec_ctx from new client_lb_end2end code
7 years ago
Alexander Polcyn
15a74d3317
Define RPC protocol version constants
7 years ago
apolcyn
8ecabd987b
Merge pull request #13777 from frankyn/patch-1
...
[Ruby] Specify module init in README
7 years ago
ita9naiwa
837a47918b
minor typo : becuase -> because
7 years ago
apolcyn
f19b20f9f6
Merge pull request #13803 from apolcyn/mark_testonly
...
Mark two test binaries as testonly
7 years ago
apolcyn
7f16daf993
Merge pull request #13793 from apolcyn/fix_ruby_distrib_retry
...
Fix failing ruby distrib tests
7 years ago
Mehrdad Afshari
336bce09d4
Merge pull request #11622 from mehrdada/shellckec
...
Fix tools/run_tests/helper_scripts/*.sh to pass shellcheck
7 years ago
Noah Eisen
28839ce3a8
Merge pull request #13776 from ncteisen/executor-tsan
...
Fix shutdown executor tsan bug
7 years ago
Yang Gao
2279cd4aa9
Merge pull request #13771 from yang-g/delete
...
Mark tcp errors as UNAVAILABLE
7 years ago
Mehrdad Afshari
290bbd2111
Fix run_tests_in_workspace.sh to pass shellcheck
7 years ago
Mehrdad Afshari
af3eb69856
Fix run_grpc-node.sh to pass shellcheck
7 years ago