Mark D. Roth
c27f8f1505
Fourth attempt: Implement transparent retries ( #28943 )
...
* Revert "Revert "Third attempt: Implement transparent retries (#28925 )" (#28942 )"
This reverts commit be70a8676c
.
* fix edge case where call is cancelled while transparent retry callback is pending
3 years ago
Ben Beasley
faea518de0
Fix implicit std::string_view(nullptr) ( #28589 )
...
This fixes failure to compile on (pre-release) GCC 12 due to use of
explicitly deleted function:
3 years ago
Esun Kim
c08eb4fc41
Attempt to upgrade upb to the latest ( #28685 )
...
* Update upb to 85e5c76cb7098d3ae35e575d652a40568013a149
* Update grpc_deps.bzl
* Run gen_upb_api.sh
* Run run_sed.sh
* Update gen_build_yaml.py
* Regen projects
* Reformat
* Update third_party/upb to 950cdab42fe4c83f06a2be46eeb46a068e486eed
* Update third_party/upb to c9c31241bc39922b092a81d192badd50cccaaa81
* Update src/upb/gen_build_yaml.py
* Generated projects
* Update third_party/upb to a02d92e0257a35f11d4a58b6a932506cbdbb2f29
* Patching in https://github.com/protocolbuffers/upb/pull/524
* Sed script went too far.
Co-authored-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>
3 years ago
Craig Tiller
0f73576b17
Revert "Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )" ( #28967 )
...
This reverts commit 235098de22
.
3 years ago
Mark D. Roth
3d4433beb2
retry: always free cached send op data ( #28956 )
...
* Revert "Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation (#28945 )" (#28954 )"
This reverts commit 9498843a18
.
* retry: always free cached send op data
3 years ago
Craig Tiller
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
235098de22
Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )
...
* Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )"
This reverts commit 5bfe38f10f
.
* fix
3 years ago
Craig Tiller
f18e6ede04
Revert "Convert max_age filter to promises ( #28904 )" ( #28957 )
...
This reverts commit ae4b45d75a
.
3 years ago
Craig Tiller
ae4b45d75a
Convert max_age filter to promises ( #28904 )
...
* start
* stuff
* build
* Automated change: Fix sanity tests
* fix
* finish him
* fix
* better
* fix
* review feedback
* Update channel_idle_filter.cc
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Mark D. Roth
9498843a18
Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation ( #28945 )" ( #28954 )
...
This reverts commit f48c4f1f4b
.
3 years ago
Craig Tiller
7c74d58cbe
Disable memory_usage test on cmake builds ( #28948 )
3 years ago
Craig Tiller
5bfe38f10f
Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )
...
This reverts commit cadce47ebf
.
3 years ago
Craig Tiller
cadce47ebf
Convert client_auth_filter to promises ( #28767 )
...
* Convert client_auth_filter to promises
* outline
* x
* x
* fixes
* remove-spam
* Async sequences over iterators
* iterate
* better semantics
* fix
* clang-tidy
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* progress
* progress
* progress
* progress
* credentials_test passes
* Automated change: Fix sanity tests
* Make Activity more of an interface
Move mutex and wakeup logic into a new class between PromiseActivity<>
and Activity (so that the sharing can persist), but make Activity closer
to a pure interface, so that whilst we migrate code we can implement
better fakes without forcing allocation.
* fixes
* Automated change: Fix sanity tests
* fixes
* test the awful failure
* x
* fix typo
* fix race
* 4.9
* x
* review feedback
* review feedback
* Automated change: Fix sanity tests
* review feedback
* replace AuthMetadataContext interface with GetRequestMetadataArgs struct
* Automated change: Fix sanity tests
* fix merge
* Fixup
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
Mark D. Roth
f48c4f1f4b
retry: fix memory leak due to not freeing cached send ops upon cancellation ( #28945 )
...
* retry: fix memory leak due to not freeing cached send ops upon cancellation
* clang-format
* attempt to fix proxy tests on windows
3 years ago
Craig Tiller
dd76a04b8c
Move resolver to core configuration ( #28881 )
...
* Move resolver to core configuration
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* resolver: clean up and modernize registry
* fix race
* update visibility
* fix internal error
* review feedback
* resolve backref issues
* windows
* x
* fix sockaddrs on windows?
* fix sockaddrs on windows?
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
Craig Tiller
ff87ca02b2
Revive test/core/memory_usage ( #28931 )
...
* Revert "Deprecate gpr_get/set_allocation_functions"
This reverts commit 81df105ac8
.
* memory stats
* Hack up to get per-call numbers
* expunge memory counters
* buildgen
* Automated change: Fix sanity tests
* sanity
* fix
* Automated change: Fix sanity tests
* simplify
* better
* Automated change: Fix sanity tests
* Disable windows memory_usage
* disable mac
* disable mac
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Mark D. Roth
be70a8676c
Revert "Third attempt: Implement transparent retries ( #28925 )" ( #28942 )
...
This reverts commit 9e7453409a
.
3 years ago
Yash Tibrewal
3f19e0cc02
Revert "Revert "CompositeChannelCredentials: Comparator implementation ( #28902 )" ( #28919 )" ( #28918 )
...
* CompositeChannelCredentials: Comparator implementation retry
* Fix test
3 years ago
Mark D. Roth
9e7453409a
Third attempt: Implement transparent retries ( #28925 )
...
* Revert "Revert "Revert "Revert "Implement transparent retries (#28548 )" (#28888 )" (#28890 )" (#28909 )"
This reverts commit 23da14c1a7
.
* revert api_fuzzer change
3 years ago
AJ Heller
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
Yash Tibrewal
bbfcb7ca35
Revert CompositeChannelCreds merge fiasco ( #28930 )
3 years ago
Yash Tibrewal
778ad437b1
HttpRequestSSLCredentials: Comparator implementation ( #28900 )
...
* HttpRequestSSLCredentials: Comparator implementation
* Unused argument
* Singleton HttpRequestSSLCredentials
3 years ago
Yash Tibrewal
a72c8ebb7d
CredentialsTest: Fix TestGoogleDefaultCredsExternalAccountCredentials ( #28923 )
3 years ago
Mark D. Roth
25aa80966a
retry: fix memory leak if call is unreffed without starting recv_trailing_metadata ( #28913 )
...
* retry: fix memory leak if call is unreffed without starting recv_trailing_metadata
* fix test flake
3 years ago
Yash Tibrewal
e6a54ef372
Revert "CompositeChannelCredentials: Comparator implementation ( #28902 )" ( #28919 )
...
This reverts commit 2fdb5f90c3
.
3 years ago
AJ Heller
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
.
3 years ago
AJ Heller
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
Yash Tibrewal
2fdb5f90c3
CompositeChannelCredentials: Comparator implementation ( #28902 )
3 years ago
Mark D. Roth
23da14c1a7
Revert "Revert "Revert "Implement transparent retries ( #28548 )" ( #28888 )" ( #28890 )" ( #28909 )
...
This reverts commit 9f90e6d906
.
3 years ago
Yash Tibrewal
e178a44931
XdsCredentials: Comparator implementation ( #28903 )
3 years ago
Craig Tiller
0f424ae5cc
Move client-idle-filter to promises ( #28838 )
...
* Promise based sleep
* Embrace absl::Status
* Automated change: Fix sanity tests
* Add another test, fix bug
* fix
* fix
* Move client-idle-filter to promises
* better call counting
* x
* x
* x
* review feedback
* progress
* Automated change: Fix sanity tests
* progress
* Automated change: Fix sanity tests
* fix
* channel stack refcount
* remove op from lock, refcount
* compiles
* Automated change: Fix sanity tests
* nicer api
* fix
* Automated change: Fix sanity tests
* fix
* speculative fix for windows
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Yash Tibrewal
95c12d88c3
InsecureCredentials : Comparator implementation ( #28899 )
...
* InsecureCredentials: Update cmp_impl
* Fix tests
* Unused argument
3 years ago
Yash Tibrewal
c65a55383a
Gtestify credentials_test ( #28897 )
3 years ago
Mark D. Roth
9f90e6d906
Revert "Revert "Implement transparent retries ( #28548 )" ( #28888 )" ( #28890 )
...
* Revert "Revert "Implement transparent retries (#28548 )" (#28888 )"
This reverts commit 35708ff6b4
.
* disable retries for ALTS handshaker channel
3 years ago
AJ Heller
5ef1585070
A more granular EventEngine conformance test suite ( #28889 )
...
This allows implementers to select which subset of the conformance test
suite they wish to exercise with their implementation. This was a
request from the fuchsia team, and may be useful for partial
implementations that are composed into a complete EventEngine solution.
3 years ago
Yash Tibrewal
5f67cd07f4
Explicit method for comparing channel credentials ( #28844 )
...
* Use an explicit cmp method on grpc_channel_credentials
* Add testing
* Add TODOs to improve cmp methods
* Automated change: Fix sanity tests
* clang format
* Reviewer comments
* clang-format
* Add cmp method for grpc_call_credentials
* s/overriden/overridden
Co-authored-by: yashykt <yashykt@users.noreply.github.com>
3 years ago
Mark D. Roth
35708ff6b4
Revert "Implement transparent retries ( #28548 )" ( #28888 )
...
This reverts commit 7f8f3dc001
.
3 years ago
AJ Heller
84ed11459d
Delete custom iomgr ( #28816 )
...
* Squashed version of gnossen's gevent pR
* rm
* Automated change: Fix sanity tests
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
Ashitha Santhosh
1fee3d72be
remove SDK term from gRPC authz ( #28843 )
3 years ago
Mark D. Roth
7f8f3dc001
Implement transparent retries ( #28548 )
...
* transport: add error attributes indicating stream network state
* add missing case
* transparent retries
* don't use backoff timer for transparent retries
* fix build
* add retry_transparent_not_sent_on_wire test
* add retry_transparent_goaway test
* remove special case to short-circuit retry code if no retry policy
* clang-format
* buildifier
* simplify logic a bit
* get StreamNetworkState from metadata instead of error
* fix api_fuzzer to always start recv_trailing_metadata_ready
* clang-format
* fix test flakiness in proxy fixture
* add test with MAX_CONCURRENT_STREAMS
* don't transparently retry if we're already committed
* fix test to not reuse byte buffers
* clang-format
* disable retries for streams_not_seen_test
3 years ago
Ashitha Santhosh
55e4af1b14
Revert "Revert "Update to rbac policy struct and end2end authz test. ( #27074 )" ( #28552 )" ( #28620 )
...
This reverts commit 8ca42ec6f8
.
3 years ago
Craig Tiller
df943da2c4
Promise based sleeps ( #28722 )
...
* Promise based sleep
* Embrace absl::Status
* Automated change: Fix sanity tests
* Add another test, fix bug
* fix
* fix
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Yash Tibrewal
20aec3b2c1
Set trailing_metadata_available for recv_initial_metadata ops when generating a fake status ( #28827 )
...
* Set trailing_metadata_available for recv_initial_metadata ops when generating a fake status
* Remove log
* Fix
* Revert "Convert filter to a promise (#28815 )"
This reverts commit 361809aabb
.
* Add testing
3 years ago
Craig Tiller
9cb0747ab0
Improve promise-based-filter APIs ( #28839 )
...
* Improve promise-based-filter APIs
* review feedback
* comment
* fix
3 years ago
yihuaz
b458db9246
Eliminate gRPC insecure build ( #25586 )
...
* force submit
* fix test error
* remove is_client from local tsi and its callsites
* fix too_many_pings_test
* add missing dep
3 years ago
Yousuk Seung
172120f6b4
Move XdsChannelCreds to CoreConfiguration ( #28746 )
...
* Move XdsChannelCreds to CoreConfiguration
* move xDS channel creds files to src/core/lib/security/credentials/xds
* Change back to returning a RefCountedPtr.
* make remove "xds_" from xds_channel_* files.
* Renamed to address comments.
* clang fix
* Fix another clang error
3 years ago
Craig Tiller
4169f24dcc
Revert "Revert "Transport channel arg ( #28802 )" ( #28818 )" ( #28820 )
...
This reverts commit 2532cf5321
.
3 years ago
Craig Tiller
361809aabb
Convert filter to a promise ( #28815 )
...
* Convert filter to a promise
* copy/paste fix
* fix
3 years ago
Craig Tiller
2532cf5321
Revert "Transport channel arg ( #28802 )" ( #28818 )
...
This reverts commit 99e339136d
.
3 years ago
Craig Tiller
f55c7ebeb4
Non-encodable tweaking ( #28733 )
...
* log non-encodables
* add a place to capture errors into trailing metadata without risking encoding it
* bs
3 years ago