d8f98fb1a7
[chttp2] fix stream leak with queued flow control update and absence of writes ( #30907 )
...
fix stream leak caused by queued flow control update and absence of writes
2 years ago
120ee4c0f7
Fix comparison between signed and unsigned in `test/core/transport/chttp2/decode_huff_fuzzer.cc` ( #30983 )
2 years ago
96264e07b8
Revert "[c++] Move environment functions to C++ ( #30937 )" ( #30986 )
...
This reverts commit 74c0d6fe3f
2 years ago
61ee1656d2
xds_client_test: fix flake ( #30980 )
2 years ago
e5aadf985e
Revert "Revert "client_channel: allow LB policy to communicate update errors to resolver ( #30809 )" ( #30970 )" ( #30981 )
...
This reverts commit 1648bc08e0
2 years ago
2025ba250a
Add an experiment for EventEngine::Client usage ( #30969 )
...
* Add experiment for EventEngine::Client usage
* correct experiment tags
2 years ago
b765b06155
Remove `include/grpcpp/impl/codegen/async_stream.h` ( #30941 )
...
* Remove `include/grpcpp/impl/codegen/async_stream.h`
* Fix
* Fix
* Update
2 years ago
74c0d6fe3f
[c++] Move environment functions to C++ ( #30937 )
...
* [gprpp] Move env to C++
* move headers/impl
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* Update http_proxy.cc
* fix
* fix
* rename
* fix merge
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
fed749d100
Revert "Revert "[event_engine] Thread pool that can handle deletion in a callback"" ( #30973 )
...
* Revert "Revert "[event_engine] Thread pool that can handle deletion in a callback (#30763 )" (#30972 )"
This reverts commit ccc787a020
2 years ago
14c3839749
[event_engine] More robust ee::Promise<> implementation ( #30977 )
...
* fix promise
* iocp
* iwyu
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
ccc787a020
Revert "[event_engine] Thread pool that can handle deletion in a callback ( #30763 )" ( #30972 )
...
This reverts commit f6e1cf1dc0
2 years ago
1648bc08e0
Revert "client_channel: allow LB policy to communicate update errors to resolver ( #30809 )" ( #30970 )
...
This reverts commit 9ff943b81e
2 years ago
92f58c18a8
Revert "Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )" ( #30962 )
...
This reverts commit bfea47093f
2 years ago
f6e1cf1dc0
[event_engine] Thread pool that can handle deletion in a callback ( #30763 )
...
* [event_engine] Thread pool that can handle deletion in a callback
* missed file
* Automated change: Fix sanity tests
* simplify memory model
* review feedback
* Automated change: Fix sanity tests
* detect-stuckness
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
bfea47093f
Revert "[chttp2] Improve huffman decode efficiency ( #30479 )" ( #30961 )
...
This reverts commit 6c7f921f5f
2 years ago
6c7f921f5f
[chttp2] Improve huffman decode efficiency ( #30479 )
...
* first pass
* refinement #1
* fix
* opt
* 8
* 5
* 12
* 10
* 7
* 15
* 8n
* 15n
* 8a
* 16a
* 15a
* 5a
* 10a
* 7a
* 9a
* 12a
* 11a
* 11b
* 11b
* 7b
* 15b
* 14b
* 15i
* 12i
* 9i
* 10i
* finalizing
* fix
* tweak
* 10f
* 10r
* 7r
* 8r
* 9r
* more
* rething
* 8s
* 9s
* 12s
* 7s
* 10s
* 15snr
* 12snr
* 14snr
* 13snr
* 11snr
* 20snr
* 15snr
* 18snr
* 7snr
* 7snr
* 12-2stp
* 13-2stp
* 14-2stp
* 11-2stp
* 10-2stp
* 9-3stp
* 8-3stp
* 7-3stp
* 8-2stp
* auto-tune1
* max-depth-2
* max-depth-3
* max-depth-2
* abbreviate
* working version
* add benchmark
* fix
* fix
* fix
* ditch define
* better code layout
* static fns
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix build
* cleanup and comment
* fmt
* fix
* test
* tag
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* progress
* progress
* progress
* fixes
* cleanup
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fmt
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
* add encode/decode fuzzer
* Automated change: Fix sanity tests
* fix
* fix
* fix
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
0867393bde
Revert "Revert "Forking tcp socket utils for posix event engine endpoints"" ( #30949 )
...
* Revert "Revert "Forking tcp socket utils for posix event engine endpoints (#30383 )" (#30946 )"
This reverts commit 33b3fe89c4
2 years ago
9ff943b81e
client_channel: allow LB policy to communicate update errors to resolver ( #30809 )
...
* client_channel: allow LB policy to communicate update errors to resolver
* fix tests
* Automated change: Fix sanity tests
* fix build
* fix another "ignoring return value" warning
* fix use-after-move
* fix channel to invoke resolver callback when service config fails on initial resolution
* remove outdated TODO
* improve comments
* fix PollingResolver to defer re-resolution requests while waiting for result-health callback
* Automated change: Fix sanity tests
* absl::exchange -> std::exchange
* fix dns_resolver_cooldown_test
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2 years ago
aaec373a10
Second attempt: XdsClient: add unit test and fix watcher notification bugs ( #30943 )
...
* Revert "Revert "XdsClient: add unit test and fix watcher notification bugs (#30823 )" (#30942 )"
This reverts commit 6d2c4a8314
2 years ago
33b3fe89c4
Revert "Forking tcp socket utils for posix event engine endpoints ( #30383 )" ( #30946 )
...
This reverts commit d7cce32449
2 years ago
6d2c4a8314
Revert "XdsClient: add unit test and fix watcher notification bugs ( #30823 )" ( #30942 )
...
This reverts commit bcd8c991e6
2 years ago
d7cce32449
Forking tcp socket utils for posix event engine endpoints ( #30383 )
...
* convert tcp code to use EndpointConfig and successfully compile
* regenerate projects
* copying config options used in tcp code to create map backed endpoint configs
* fix minor build issues
* fix includes in tests
* fix some build and test issues
* modifying endpoint config definition from an abstract interface into a concrete implementation
* minor fix
* add unreachable code check
* fix some windows build issues
* fix more build issues
* adding a grpc_tcp_generic_options struct to hold data extracted from EndpointConfig
* code formatting
* simplify
* fix sanity checks
* fix windows issues
* some posix fixes
* disabling copy constructor and copy assignment operator for endpoint config
* fix sanity checks
* fix syntax error
* fix weird formatting
* fix build issue
* fix review comments
* reverting un-necessary change
* remove channel args completely from windows impl since it is unused
* remove unused headers and fix usage in endpoint_pair_windows.cc
* cleanup
* cleanup
* fix some initialization issues
* re-generate projects
* removing some files
* fix ifdef for windows
* fixing windows build issue due to improper header file include
* Automated change: Fix sanity tests
* start
* regenerate-projects
* delete some files
* Automated change: Fix sanity tests
* review comments
* add comment
* review comments
* rename GetPointer to GetVoidPointer
* cleanup
* Automated change: Fix sanity tests
* removing EndpointConfig::Get method
* Automated change: Fix sanity tests
* cleanup
* fix
* minor fix
* fix
* update
* fix BUILD
* update
* fix sanity
* minor additions to configure global tcp user timeout values
* fix build syntax
* fix build error
* Add more unit tests
* fix msan issue
* add comment
* adding rcv lowat helper to socket wrapper
* fix sanity
* sanity
* iwyu sanity
* fix macos issue
Co-authored-by: Vignesh2208 <Vignesh2208@users.noreply.github.com>
2 years ago
bcd8c991e6
XdsClient: add unit test and fix watcher notification bugs ( #30823 )
...
This adds a unit test for XdsClient and fixes several watcher-notification bugs found in the process. Specifically:
- When an ADS stream fails or an xDS channel reports a connectivity failure, report an error only to the watchers for resources being subscribed to on that particular channel, not to watchers on other channels.
- Cache the error status for the channel, so that if a new watcher is started after the channel reports the error, we can immediately report that error to the new watcher.
- If a resource is NACKed and has not been previously cached, or does not exist, report that fact to any new watcher that may be started later.
- If a resource in an ADS response is unparseable but is wrapped in a `Resource` wrapper, we do know its name, so record the validation failure in the cache and report it to the watchers.
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2 years ago
76588969c0
Second attempt: XdsClient: convert xDS bootstrap code to use new JSON parsing API ( #30925 )
...
* Revert "Revert "XdsClient: convert xDS bootstrap code to use new JSON parsing API (#30431 )" (#30924 )"
This reverts commit 3332e7e48d
2 years ago
3332e7e48d
Revert "XdsClient: convert xDS bootstrap code to use new JSON parsing API ( #30431 )" ( #30924 )
...
This reverts commit 04ddf3d0b7
2 years ago
2b46cb40d3
[config] Move certificate provider registry into core config ( #30890 )
...
* [config] Move certificate provider registry into core config
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
d47e58544f
[flaky] Increase timeout ( #30909 )
2 years ago
bf1856d2cc
A modest split of `:gpr` for mpscq support ( #30798 )
...
* A modest split of `:gpr` for mpscq support
A full split of the `gpr` target into 25 separate targets is building,
but there are some hurdles to get over with respect to ODR violations
and public API support for the gpr library.
This PR splits off a small chunk of that work.
* Automated change: Fix sanity tests
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
04ddf3d0b7
XdsClient: convert xDS bootstrap code to use new JSON parsing API ( #30431 )
...
* Declarative JSON parser
* Automated change: Fix sanity tests
* fix
* shrinking stuff a little
* static vtables
* separate fns
* simpler?
* make maps work
* windows fixes
* Automated change: Fix sanity tests
* simplify code
* Automated change: Fix sanity tests
* vtable-test
* dont always create vec/map impls for every type
* comments
* make error consistent
* move method private
* progress
* durations!
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* post-load
* Automated change: Fix sanity tests
* document JsonPostLoad() and add static_assert
* don't copy field names, to avoid length limitations
* use absl::Status
* accept either string or number for numeric values
* add test for direct data member of another struct type
* remove unused method
* add support for retaining part of the JSON wirthout processing
* update test for changes in Json::Parse() API
* add absl::optional support
* Automated change: Fix sanity tests
* add new parsing code
* use absl::optional<> parsing
* switch to new parsing code
* fix tests
* clang-format
* fix tests, improve error messages, and add overload to parse to existing object
* remove overload of LoadFromJson()
* make XdsBootstrap movable
* work around googletest bug
* Automated change: Fix sanity tests
* change special case for Json to instead use Json::Object
* use Json::Object instead of just Json
* remove copy ctor/assignment, spell out move ctor/assignment
* fix regex portability issue
* Automated change: Fix sanity tests
* fix build
* improve error structure, add missing types, and improve tests
* clang-format
* Automated change: Fix sanity tests
* fix build
* fix build
* attempt to work around gcc6 bug
* add LoadJsonObjectField(), add LoadFromJson() overload that takes an ErrorList parameter, and add tests for parsing bare top-level types
* fix msan
* Automated change: Fix sanity tests
* fix error message
* Automated change: Fix sanity tests
* add mechanism to conditionally disable individual fields
* clean up channel creds parsing
* use conditional enabling mechanism for federation-specific fields
* fix build
* Automated change: Fix sanity tests
* fix build
* Automated change: Fix sanity tests
* avoid unnecessary copies
* Automated change: Fix sanity tests
* make XdsBootstrap a clean interface
* add missing build dep
* fix xds_lb_policy_registry_test
* iwyu
* add missing build deps
Co-authored-by: Craig Tiller <craig.tiller@gmail.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Craig Tiller <ctiller@google.com>
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2 years ago
610a248059
[stats] Optimize histogram system ( #30834 )
...
* recurse
* bsearch
* bounds
* optimize stats
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
6cd33e9fd2
[experiments] Reduce test count ( #30891 )
2 years ago
ec27e98adc
[fork] Move init to once-only, remove shutdown ( #30839 )
...
* [fork] Move init to once-only, remove shutdown
* fix build
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
7ba58bb925
[build] Move certificate provider registry into its own build target ( #30836 )
...
* [build] Move cert registry into its own build target
* Automated change: Fix sanity tests
* fix
* forgot to save file
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
381976dc99
[windows] Handling for tchar type in C++ ( #30845 )
...
* [windows] Handling for tchar type in C++
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Update tchar.cc
* Update tchar.h
* Update tchar.h
* Update env_windows.cc
* Update string_util_windows.cc
* Update tmpfile_windows.cc
* Update env_windows.cc
* Update env_windows.cc
* Update subprocess_windows.cc
* Automated change: Fix sanity tests
* fix
* Update subprocess_windows.cc
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
3c720b092e
Fix flakiness in EventEngineClientTest.ConnectToNonExistentListenerTest ( #30874 )
2 years ago
b463cabeec
Update flaky tests ( #30873 )
...
* Update flaky tests list
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
2bb6097412
XdsClient: remove now-unnecessary XdsCertificateProviderPluginMapInterface ( #30854 )
...
* remove now-unnecessary XdsCertificateProviderPluginMapInterface
* code review comments
* Automated change: Fix sanity tests
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
2 years ago
47a43d68c9
[chttp2] Tune initial window size/max frame size setting ( #30550 )
...
* [chttp2] Tune initial window size/max frame size setting
- Only choose frame sizes and initial window sizes that are powers of two - as a more predictable function to avoid flapping.
- If window size drops below 1kb then snap to 0 to avoid frantically changing a value that needn't be
- Allow the initial window size to drop to zero (we have fuzzing in place that says this is safe)
* copy/paste fix
* fix build
* fix
* Automated change: Fix sanity tests
* fix announce bug
* cleanup
* put this change under an experiment
* more tests
* fix build
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
e705b2e3c7
[resource_quota] Move experiments to the experiments framework ( #30830 )
...
* fix
* fix tests
* fix
* Automated change: Fix sanity tests
* better expansion
* bleh
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
ca8b437613
[experiments] Single experiments flag ( #30822 )
...
* single experiments flag
* add missing files
* fix
* empty-string-fix
* fix
* Automated change: Fix sanity tests
* ensure cold path is out of line
* add log for enabled/disabled experiments
* remove bad sentence
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
c3c4159d24
[build] Make stats test drastically faster under tsan ( #30712 )
...
* [fixit] Make stats test drastically faster under tsan
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
70dd34b438
Revert "Revert "Modifying iomgr tcp code to use event engine EndpointConfig instead of channel_args"" ( #30509 )
...
* Revert "Revert "Modifying iomgr tcp code to use event engine EndpointConfig instead of channel_args (#30028 )" (#30495 )"
This reverts commit 0b1a8c984b
2 years ago
bf9304ef17
client_channel, client_auth: rewrite disallowed status codes from the control plane ( #30789 )
...
* client_channel: rewrite illegal status codes from control plane
* rewrite illegal status codes for call creds
* move fail_lb policy out of retry_lb_fail test so it can be reused
* test resolver and LB policy status rewrites
* add test for ConfigSelector status rewriting
* attempt to add client_auth filter unit test
* fix client_auth_filter test
* cleanup test
* fix build
* fix some memory leaks
* Automated change: Fix sanity tests
* Update client_auth_filter_test.cc
* fix build
* code review comments
* clang-tidy
Co-authored-by: markdroth <markdroth@users.noreply.github.com>
Co-authored-by: Craig Tiller <ctiller@google.com>
2 years ago
029f945504
Migrating posix event pollers to use new event poller interface ( #30419 )
...
* Migrating posix event pollers to use new event poller interface
* add inline attributes
* Automated change: Fix sanity tests
* remove ref/unref from iomgr engine closure ad add custom closure types internal to the pollers
* updating time util usage
* use unique_ptrs
* update comments
* Automated change: Fix sanity tests
* fix review comments
* review comments
* cleanup
* update comments
* fix
* cleanup
* update comments
* Automated change: Fix sanity tests
* fix misleading comments
* bug fixes
* fix
* fix
* revert some changes for bug fixes and allow spurious wakeups for poll based poller
* sanity
* fix
* review comments
* fix
* comment
* remove re-defined function
* fix review comments
* fix windows iocp build issue due to removed function
* change Milliseconds return type
* remove header
* regenerate projects
* fix sanity
* fix sanity
* Automated change: Fix sanity tests
* delete unused file
* build issue
* cleanup
Co-authored-by: Vignesh2208 <Vignesh2208@users.noreply.github.com>
2 years ago
9a81e8b243
[end2end] Move test to TLSv1.3 as advertised ( #30574 )
...
We spotted this during review of #30569 . Not wanting to make a behavior change there I left it as is, but the test advertises TLSv1.3 so it seems likely this should be changed.
2 years ago
779419505f
Replace `absl::exchange()` with `std::exchange()` ( #30802 )
...
* Replace `absl::exchange()` with `std::exchange()`
* Update `core_banned_functions.py`
2 years ago
c580d0d9a7
[experiments] Add experiment framework ( #30775 )
...
* [experiments] Add experiment framework
* auto-ci-config
* fix
* fix
* Automated change: Fix sanity tests
* support different configs
* Automated change: Fix sanity tests
* cleaner generated code
* Automated change: Fix sanity tests
* enforce expiry
* make sure expiry isnt far in the future
* fix
* Automated change: Fix sanity tests
* remove specified testing
* cleaner
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* docstring
* clean up code
* Automated change: Fix sanity tests
* review feedback
* build fix
* Automated change: Fix sanity tests
* ownership
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
622dd886e6
Update flaky tests list ( #30771 )
...
* Update flaky tests list
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
004788af3d
[cleanup] Remove profiling timers ( #30779 )
...
* [cleanup] Remove profiling timers
- nobody has used this system in years
- if we needed it, we'd probably rewrite it at this point to be something more modern
- let's remove it until that need arises
* fix
* fixes
2 years ago
0c46726229
Build Target Reorganization Part 2 ( #30570 )
...
* Clean up grpc_base
* Clean up grpc
* Clean up grpc_insecure
2 years ago
apolcyn
Cheng-Yu Chung
Craig Tiller
Mark D. Roth
AJ Heller
Richard Belleville
Vignesh Babu
Richard Belleville