Chiebot-Mirror/grpc - grpc - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Shane Loretz	385431ca4b	[Python Bazel] Allow overwriting grpc_library in python_rules.bzl (#35629 ) Continues #35412 addressing feedback in https://github.com/grpc/grpc/pull/35412#issuecomment-1875980755 I'm unable to test the workspace with the newly added py_test, so I'm hoping a CI run here will tell me if the test works. ```console ~/grpc/test/distrib/bazel/python$ bazel --nohome_rc --nosystem_rc test //... Loading: Loading: Loading: 0 packages loaded Analyzing: 37 targets (0 packages loaded, 0 targets configured) ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:266:21: @com_google_protobuf//upb_generator:protoc-gen-upb_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:305:21: @com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:338:21: @com_google_protobuf//upb_generator:protoc-gen-upbdefs_toolchain: no such attribute 'output_files' in 'proto_lang_toolchain' rule ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_google_protobuf/upb_generator/BUILD:305:21: Target '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_stage1' contains an error and its package is in error and referenced by '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain' ERROR: /usr/local/foobar/home/sloretz/.cache/bazel/_bazel_sloretz/7f83b4f00f370e7c52a5cc586445673c/external/com_github_grpc_grpc/src/proto/grpc/gcp/BUILD:19:14: every rule of type proto_library implicitly depends upon the target '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain', but this target could not be found because of: Target '@com_google_protobuf//upb_generator:protoc-gen-upb_minitable_toolchain' contains an error and its package is in error ERROR: Analysis failed ERROR: Analysis of target '//namespaced/upper/example:no_import_no_strip_py_pb2_grpc' failed; build aborted: INFO: Elapsed time: 0.171s INFO: 0 processes. FAILED: Build did NOT complete successfully (0 packages loaded, 0 targets configured) ERROR: Couldn't start the build. Unable to run tests ``` Closes #35629 PiperOrigin-RevId: 606695865	11 months ago
Esun Kim	d8fd0c0844	Fixed bazel tests for 7 (#35390 ) - Fixed the bazel distrib tests with Bazel 7 by disabling bzlmod option. - Added a new note for bzlmod to the doc. Closes #35390 PiperOrigin-RevId: 593816700	1 year ago
Adam Cozzette	016ed921ce	[deps] Upgrade protobuf version to v25.0 (#34513 ) This commit upgrades gRPC to protobuf v25.0 and makes some fixes to account for upb changes. One major change is that upb has been merged into the protobuf repo, so we can now drop the separate `@upb` dependency. Another is that `.upb.c` files no longer exist and there are new `.upb_minitable.h` and `.upb_minitable.c` files. The longer filenames exceeded a Windows restriction, so to work around that I renamed the `upb-generated` directory to just `upb-gen`, and likewise for `upbdefs-generated`.	1 year ago
Ming Lyu	c8f467aea9	[Bazel] Enable grpcio-reflection to be used via Bazel (#31013 ) The current `py_grpc_library` results in the wrong grpc proto python code path when grpc is a third-party source code in a Bazel project. This PR should fix it. fixes #31011 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> --------- Co-authored-by: Richard Belleville <rbellevi@google.com>	1 year ago
Florian Ferstl	fa32eb36b3	[bazel] Auto-generate .pyi files in py_proto_library rule (#32872 ) With some delay, this is a PR for https://github.com/grpc/grpc/issues/32564 (and previously https://github.com/grpc/grpc/pull/31791). I looked into adding a regular `py_test` for this change [as suggested](https://github.com/grpc/grpc/pull/31791#issuecomment-1423245116) but I am not aware of any effect that the presence of a .pyi stub file would have at runtime and where some sort of type-checking in a .py script would be affected. Stub files are only for use by type checkers & IDE's. I mean, something like this would work: ``` import helloworld_pb2 py_file = helloworld_pb2.__file__ pyi_file = py_file + 'i’ self.assertTrue(os.path.exists(pyi_file)) ``` But that seems really hacky to me. Instead I created a simple rule test for `py_proto_library` with Bazel Skylib which tests the declared outputs for an example `py_proto_library` target. Indirectly, this also tests that the declared output files are actually generated. Please let me know if this is sufficient.	2 years ago
Sergii Tkachenko	de6ed9ba9f	[Python] Migrate from yapf to black (#33138 ) - Switched from yapf to black - Reconfigure isort for black - Resolve black/pylint idiosyncrasies Note: I used `--experimental-string-processing` because black was producing "implicit string concatenation", similar to what described here: https://github.com/psf/black/issues/1837. While currently this feature is experimental, it will be enabled by default: https://github.com/psf/black/issues/2188. After running black with the new string processing so that the generated code merges these `"hello" " world"` strings concatenations, then I removed `--experimental-string-processing` for stability, and regenerated the code again. To the reviewer: don't even try to open "Files Changed" tab 😄 It's better to review commit-by-commit, and ignore `run black and isort`.	2 years ago
Yijie Ma	10001d16a9	[Release] Upmerge v1.55.x branch into master (#33277 ) Change was created by the release automation script. See go/grpc-release <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> --------- Co-authored-by: Yash Tibrewal <yashkt@google.com> Co-authored-by: Esun Kim <veblush@google.com> Co-authored-by: Mark D. Roth <roth@google.com> Co-authored-by: Yousuk Seung <ysseung@google.com> Co-authored-by: Craig Tiller <ctiller@google.com> Co-authored-by: Richard Belleville <rbellevi@google.com> Co-authored-by: gnossen <gnossen@users.noreply.github.com>	2 years ago
Jan Tattermusch	0f1afec5a8	[protobuf] Upgrade third_party/protobuf to 22.x (#32606 ) The very non-trivial upgrade of third_party/protobuf to 22.x This PR strives to be as small as possible and many changes that were compatible with protobuf 21.x and didn't have to be merged atomically with the upgrade were already merged. Due to the complexity of the upgrade, this PR wasn't created automatically by a tool, but manually. Subsequent upgraded of third_party/protobuf with our OSS release script should work again once this change is merged. This is best reviewed commit-by-commit, I tried to group changes in logical areas. Notable changes: - the upgrade of third_party/protobuf submodule, the bazel protobuf dependency itself - upgrade of UPB dependency to 22.x (in the past, we used to always upgrade upb to "main", but upb now has release branch as well). UPB needs to be upgraded atomically with protobuf since there's a de-facto circular dependency (new protobuf depends on new upb, which depends on new protobuf for codegen). - some protobuf and upb bazel rules are now aliases, so ` extract_metadata_from_bazel_xml.py` and `gen_upb_api_from_bazel_xml.py` had to be modified to be able to follow aliases and reach the actual aliased targets. - some protobuf public headers were renamed, so especially `src/compiler` needed to be updated to use the new headers. - protobuf and upb now both depend on utf8_range project, so since we bundle upb with grpc in some languages, we now have to bundle utf8_range as well (hence changes in build for python, PHP, objC, cmake etc). - protoc now depends on absl and utf8_range (previously protobuf had absl dependency, but not for the codegen part), so python's make_grpcio_tools.py required partial rewrite to be able to handle those dependencies in the grpcio_tools build. - many updates and fixes required for C++ distribtests (currently they all pass, but we'll probably need to follow up, make protobuf's and grpc's handling of dependencies more aligned and revisit the distribtests) - bunch of other changes mostly due to overhaul of protobuf's and upb's internal build layout. TODOs: - [DONE] make sure IWYU and clang_tidy_code pass - create a list of followups (e.g. work to reenable the few tests I had to disable and to remove workaround I had to use) - [DONE in cl/523706129] figure out problem(s) with internal import --------- Co-authored-by: Craig Tiller <ctiller@google.com>	2 years ago
Esun Kim	905df9dee6	Update Abseil to 20230125 (#32139 ) * Update abseil to 1.20230125.0 * Fix IWYU	2 years ago
Hannah Shi	d8a52a5043	build multi arc ios unit test for m1 (#31930 )	2 years ago
Esun Kim	8787af7ea1	Added .bazelrc for distrib tests (#30161 )	3 years ago
Richard Belleville	f688f5fcf2	Rehome python bazel distribtest (#29275 ) * WIP * Test multiple languages * Yapf * isort * Shellcheck * comment not provided * Fix import ordering issue. * Turn up Bazel logging	3 years ago

12 Commits (27b82ca0ef528b0286077e31bb9dc9e5a0100f39)