Craig Tiller
cdccf1e1e4
fix for import ( #31165 )
...
* fix for import
* fix
2 years ago
Mark D. Roth
951c9a860c
xds_cluster_manager LB: fix bug from #30044 ( #31164 )
...
* fix bugs
* iwyu
2 years ago
Craig Tiller
2ec220a6b1
[sanity] Fix it ( #31163 )
...
* fix sanity
* fix sanity
2 years ago
Craig Tiller
631e8b2c36
[fixit] Parallelize hpack_size tests ( #30580 )
...
* [hpack_size] Parallelize tests
* Automated change: Fix sanity tests
* fix tsan race
* fix tsan race
* bleh
* windows-strerror
* ugh
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
c62013d699
[c++] Implement DynamicThreadPool in-terms-of event engine ( #30553 )
...
* Make GetDefaultEventEngine return a shared_ptr
This works around valgrind memory leaks by giving EventEngines a fixed
lifetime.
* dynamic pointer cast + documentation
* change the default engine's shared_ptr mechanics; add test
* Integrate new shared_ptr throughout
* promise fix
* forget previous default engines after setting a new EE factory
* Automated change: Fix sanity tests
* fix the autofixer's mistake
* add EventEngine to promise based filter context
* fix fuzer time control
* fix
* add PHP valgrind suppressions for NativeDNSResolver (does not destroy)
* manual iwyu/sanitize
* fix dependency
* fix
* add EE factory reset
* Automated change: Fix sanity tests
* fix
* manual sanitize
* bdp_estimator: replace mutex with atomic
* format
* comment out unused args
* remove stowaway
* unused param
* prelude
* use-ee
* simpler
* fix
* Automated change: Fix sanity tests
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
8174a75079
[iwyu] Add more test directories ( #30952 )
...
* [iwyu] Add more test directories
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2 years ago
Craig Tiller
c1853ade88
[slice] allow inlining of slice ref/unref again ( #31158 )
...
* allow inlining of slice ref/unref again
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
github-actions[bot]
4874619947
Automated change: Fix sanity tests ( #31162 )
...
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
Allan Boll
b302281364
Visibility change to orphanable for xds_client_core ( #31161 )
2 years ago
AJ Heller
fcf8e2431c
EventEngine::RunAfter: XDS Cluster Manager ( #30044 )
...
* EventEngine::RunAfter: XDS Cluster Manager
* fix
* reviewer feedback
* sanity
2 years ago
apolcyn
71f4fa7f92
update matrix images ( #31157 )
2 years ago
Yash Tibrewal
d7266f48f4
GcpObservability: Disable observability traces for CloudOps endpoints ( #31094 )
...
* GcpObservability: Disable observability traces for CloudOps endpoints
* Fix deps and IWYU
2 years ago
Yash Tibrewal
4ccb80252b
Revert "Revert "GcpObservability: Change default views provided ( #31144 )" ( #31149 )" ( #31155 )
...
This reverts commit 6fbff9c6a9
.
2 years ago
AJ Heller
68387a4e68
[PosixEventEngine] Ensure threads are shut down before destroying other engine state ( #31152 )
...
* Add check for engine life on shutdown
This fixes a race condition where closures attempt to deregister themselves after the engine has been destroyed
* start initialized
* ensure threads are shut down before other engine state is destroyed
2 years ago
Cheng-Yu Chung
7c4b87ede5
Remove `grpc++_codegen` ( #31138 )
...
* Remove `grpc++_codegen`
* Update
* Update
2 years ago
Ashitha Santhosh
2bdec04852
Update comment on GRPC_ARG_TSI_MAX_FRAME_SIZE ( #31114 )
2 years ago
Craig Tiller
fc736183d8
[build] Remove nofixdeps for grpc++_error_details ( #30915 )
2 years ago
Craig Tiller
82254690c3
threading-fix ( #31135 )
2 years ago
AJ Heller
2ee2c91c92
Reland x2: Make GetDefaultEventEngine return a shared_ptr ( #30619 )
...
* Reland x2: Make GetDefaultEventEngine return a shared_ptr
* remove thread leak from NativeDNSResolver
This is not going to work for resolvers that support cancellation.
* give resolvers bounded lifetimes
Some resolver own EventEngines. EventEngines cannot run off the end of
the process since they have unjoined threads (problematic in a small set
of environments). This gives resolvers bounded lifetimes, and allows
replacement of resolvers without ASAN issues of deleting resolvers in
active use (occurs in tests).
* fix
* fix windows
* fix surface init test
* fix
* sanitize
* use after move
* the test must wait for the callback to be destroyed
* windows fix: delete the resolver on iomgr shutdown, not before
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* backport fix
* fix
* shared_ptr<EventEngine> in EventEngine benchmarks
2 years ago
Craig Tiller
ecd7e141cb
[build] Remove nofixdeps for error ( #30910 )
...
* [build] Remove nofixdeps for error
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
00a2b41c81
[build] Remove nofixdeps for grpc_base ( #31148 )
2 years ago
Esun Kim
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2 years ago
AJ Heller
6fbff9c6a9
Revert "GcpObservability: Change default views provided ( #31144 )" ( #31149 )
...
This reverts commit dedcc7dbf6
.
2 years ago
AJ Heller
c222a0f035
Make TimerManager threads non-joinable ( #31129 )
...
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* rm unused parameter
* Automated change: Fix sanity tests
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
Craig Tiller
f69c64b270
[sanity] Split IWYU, clang-tidy into their own jobs ( #31141 )
...
* [sanity] Split IWYU, clang-tidy into their own jobs
* fix typo
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
34407bf551
[style] GRPC macros must be prefixed with GRPC_ ( #31120 )
2 years ago
Yash Tibrewal
dedcc7dbf6
GcpObservability: Change default views provided ( #31144 )
...
* GcpObservability: Change default views provided
* Fix IWYU
* Fix deps
2 years ago
github-actions[bot]
3c8496181d
Automated change: Fix sanity tests ( #31142 )
...
Co-authored-by: dennycd <dennycd@users.noreply.github.com>
2 years ago
Mark D. Roth
a2b473ec89
address_sorting BUILD: remove license comment breaking import ( #31145 )
2 years ago
AJ Heller
a874b8f6ca
EventEngine::Run microbenchmarks ( #30769 )
...
* [WIP] EventEngine::Run microbenchmarks
* Add fanout impl and fix tracking of time spent doing work in threads
* tune down benchmarks; fix fanout counting logic.
* tune down closure fanout tests
* format
* odr
* reviewer feedback
* unify some fanout logic; add a large-AnyInvocable test
lambdas that take an allocation are about 10x slower
* reviewer feedback
* fix invalid vector access
* rm DNS
* format
* copy params for each lambda callback
This fixes segfaults when we cannot ensure all callbacks are complete
before exiting the test.
* s/promise/Notification/g bm_exec_ctx
* ODR and leak
* fix division by zero
* fix
2 years ago
Hannah Shi
96d27634a4
run ios CronetTest from bazel ( #30439 )
2 years ago
Yash Tibrewal
6d249c0af2
Observability: Experimental arg to disable client side tracing ( #31093 )
...
* Observability: Experimental arg to disable client side tracing
* Fix IWYU
* Reviewer comments
* Reviewer comments
* Reviewer comment: Move experimental/internal arg to different file
* Fix build
* Fix IWYU
2 years ago
Aaron Pham
ac585b8f7e
chore: add bazel support for M1 mac ( #31127 )
...
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
2 years ago
Jan Tattermusch
2f5d06af6b
make legacy artifact -> packages -> distribtest jobs a noop ( #31124 )
2 years ago
AJ Heller
298ace8cbf
small test cleanup ( #31137 )
2 years ago
Cheng-Yu Chung
409f558871
Revert "Revert "Remove `grpc_codegen` ( #30960 )" ( #31099 )" ( #31100 )
...
This reverts commit eada386921
.
2 years ago
Craig Tiller
5fa37322cb
Revert "Tcp endpoint implementation for posix event engine. ( #30559 )" ( #31134 )
...
This reverts commit a81391d931
.
2 years ago
Vignesh Babu
a81391d931
Tcp endpoint implementation for posix event engine. ( #30559 )
...
* convert tcp code to use EndpointConfig and successfully compile
* regenerate projects
* copying config options used in tcp code to create map backed endpoint configs
* fix minor build issues
* fix includes in tests
* fix some build and test issues
* modifying endpoint config definition from an abstract interface into a concrete implementation
* minor fix
* add unreachable code check
* fix some windows build issues
* fix more build issues
* adding a grpc_tcp_generic_options struct to hold data extracted from EndpointConfig
* code formatting
* simplify
* fix sanity checks
* fix windows issues
* some posix fixes
* disabling copy constructor and copy assignment operator for endpoint config
* fix sanity checks
* fix syntax error
* fix weird formatting
* fix build issue
* fix review comments
* reverting un-necessary change
* remove channel args completely from windows impl since it is unused
* remove unused headers and fix usage in endpoint_pair_windows.cc
* cleanup
* cleanup
* fix some initialization issues
* re-generate projects
* removing some files
* fix ifdef for windows
* fixing windows build issue due to improper header file include
* Automated change: Fix sanity tests
* start
* regenerate-projects
* delete some files
* Automated change: Fix sanity tests
* review comments
* add comment
* Migrating posix event pollers to use new event poller interface
* add inline attributes
* Automated change: Fix sanity tests
* remove ref/unref from iomgr engine closure ad add custom closure types internal to the pollers
* updating time util usage
* use unique_ptrs
* update comments
* Automated change: Fix sanity tests
* review comments
* rename GetPointer to GetVoidPointer
* cleanup
* Automated change: Fix sanity tests
* removing EndpointConfig::Get method
* Automated change: Fix sanity tests
* cleanup
* fix
* fix review comments
* review comments
* cleanup
* update comments
* fix
* cleanup
* update comments
* Automated change: Fix sanity tests
* fix misleading comments
* bug fixes
* fix
* fix
* start
* revert some changes for bug fixes and allow spurious wakeups for poll based poller
* sanity
* fix
* minor fix
* review comments
* fix
* comment
* remove re-defined function
* fix review comments
* fix windows iocp build issue due to removed function
* change Milliseconds return type
* fix
* remove header
* regenerate projects
* fix sanity
* code
* fix sanity
* Automated change: Fix sanity tests
* Forking iomgr internal_errqueue defines for posix event engine
* fix BUILD file
* start
* update
* sanity
* regenerate_projects
* Automated change: Fix sanity tests
* rename
* review comments
* update
* review comments
* Automated change: Fix sanity tests
* fix BUILD
* add no_windows tag
* update
* update
* remove debug statements
* delete unused file
* update
* fix BUILD
* regenerate projects
* update
* fix BUILD
* update
* fix sanity
* minor additions to configure global tcp user timeout values
* cleanup
* fix build syntax
* change poller interface for posix event engine
* update event_poller_posix_test
* fix build error
* Add more unit tests
* windows ee changes
* update comment
* remove unused deps
* fix msan issue
* add comment
* adding rcv lowat helper to socket wrapper
* fix sanity
* review comments
* fix build issue
* fix sanity
* sanity
* iwyu sanity
* fix build
* merge conflict
* Automated change: Fix sanity tests
* update
* update
* fix macos issue
* fix msan and ubsan issues
* fix macos build issue
* comment
* review comments
* remove unused dep
* sanity
* merge conflict
* mac build issue
* regenerate projects
* build issue
* fix typo and address review comments
* review comments
* Automated change: Fix sanity tests
* update
* merge issue
* review comments
* sanity
* fix build issue
* review comments
* add thread annotations
* MacOS fix unused variable
* add some more #endif comments
* missing semi-colon
* Automated change: Fix sanity tests
* sanity
* sanity again
* sanity try again
* sanity again
* try again with no_include pragma
Co-authored-by: Vignesh2208 <Vignesh2208@users.noreply.github.com>
2 years ago
Esun Kim
ba8af0157b
Removing GRPC_ERROR_[REF|UNREF|IS_NONE] ( #31089 )
...
* Removing GRPC_ERROR_[REF|UNREF|IS_NONE]
* Clean up unnecessary error
* Fix
* Fix2
* Remove unnecessary else
2 years ago
Jan Tattermusch
255083b724
Fix ruby builds on kokoro macos monterey images ( #31125 )
...
* cocoapods is not a ruby dependency
* fix rvm update on macos monterey images
2 years ago
Mark D. Roth
cdb7d2c93c
XdsEndpointResourceType: use ValidationErrors and add unit tests ( #31076 )
...
* simplify XdsResourceType::Decode() API
* fix xds_client_test
* xDS endpoint: use ValidationErrors to improve error messages
* fix sanity
* add xDS endpoint resource type test
* clang-format
* remove a couple of now-unnecessary end2end tests
* generate_projects
* fix xds_csds_e2e_test
* iwyu
* attempt to avoid ubsan failure
2 years ago
AmosWang
1aac7caba9
upgrade gevent version in bazel requirement ( #31115 )
2 years ago
Craig Tiller
ebc4f236b6
[slice] Remove _internal variants of APIs ( #30953 )
...
* [slice] Remove _internal variants of APIs
* Automated change: Fix sanity tests
* fix
* reduce bloat
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
93fdc99756
[init] Remove grpc_register_plugin ( #30929 )
...
* [init] Remove grpc_register_plugin
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Craig Tiller
1402e974f7
[promises] End-to-end flow control for a series of pipes ( #30994 )
...
* fix promise
* prototype
* progress
* implement new api
* Revert "fix promise"
This reverts commit ded85e7d19
.
* Revert "Revert "fix promise""
This reverts commit c2acef1958
.
* progress
* done
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* comments
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Richard Belleville
3439cc29d2
Update xds-protos package to pull in new generated code ( #31113 )
2 years ago
Craig Tiller
32b43f0168
[channel_args] Make channel_stack_init take new type ( #30841 )
...
* [channel_args] Make channel_stack_init take new type
* fix
* fix
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
Yousuk Seung
747d016397
Support --max_recv_msg_size in grpc cli ( #31106 )
...
* Support --max_recv_msg_size in grpc cli
* Comment typos fixed in tests.
2 years ago
Craig Tiller
62c2260dc2
[experiments] Add a placeholder experiment to test rollout monitoring ( #31110 )
2 years ago