203bc0dc52
xDS interop GCE framework: pin grpcio-tools to use protobuf 3.x ( #31191 )
2 years ago
a777f0eee4
Fix memory leak ( #31154 )
2 years ago
3e648e3de7
Add support to explicitly add priority for the handshakers using enums ( #30971 )
...
Currently the order of the handshakers is controlled by a single bool(at_start). This doesn't allow for more complex use cases where the handshaker has to be done before tcp connect handshaker for example.
By explicitly adding enums that specify the priority, we allow for a cleaner abstraction for registering handshakers.
2 years ago
6e15936d85
Make event engine client test more robust ( #31187 )
...
* Minor event engine related cleanup
* make client_test more robust
* cleanup
* regenerate_projects
* review comments
* iwyu
* review comments
* typo
2 years ago
59b3a03f0f
Generate experiments during sanitization ( #30966 )
...
* Generate experiments during sanitization
Also adds gen_experiments to sanity checks.
* format after gen_experiments
* add clang_format to the gen_experiments sanitize job
* fix clang_format_code whith no CHANGED_FILES
* cpu_cost: 1000
* de-parallelize generate_projects
* Make the check fail if --check is passed, otherwise just gen & format
* test
* fix file paths
2 years ago
e7ad460c7b
Event Engine related minor cleanup ( #31188 )
...
* Minor event engine related cleanup
* regenerate_projects
* fix test
* iwyu
2 years ago
92d380735d
Add comments for copybara to add proguard annotation ( #30633 )
...
These comments are added so copybara can replace these comments with
actual annotations to prevent the class from being stripped.
2 years ago
db5fe72da9
[tsan] Threadsafe strerror implementation ( #31167 )
...
* fix
* spread
* fix
* Automated change: Fix sanity tests
* fix
* remove unnecessary .c_strs
* lashes
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
d84846646d
Enable logs for error message in call_op_set.h. ( #31177 )
...
* Enable logs for error message in call_op_set.h.
The `gpr_log` was commented out from call_op_set.h at PR: https://github.com/grpc/grpc/pull/20681 , because of the undefined error. It is probably just missing the header file, so adding the `gpr_log` back.
* Automated change: Fix sanity tests (#31178 )
Co-authored-by: nanahpang <nanahpang@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: nanahpang <nanahpang@users.noreply.github.com>
2 years ago
7655858e93
Reland tcp endpoints for posix event engine ( #31150 )
...
* Revert "Revert "Tcp endpoint implementation for posix event engine. (#30559 )" (#31134 )"
This reverts commit 5fa37322cb
2 years ago
beb5bdca62
[promises] Promise based grpc_call ( #29598 )
...
* Automated change: Fix sanity tests
* fix
* fixes
* fixup allocator story - we should require a context
* fixes
* doodling
* context scribbles
* [arena] Add ManagedNew(), gtest-ify test
Add a ManagedNew() method to Arena that calls the relevant destructor at Arena destruction time.
There are some cases coming up in the promise based call work where this becomes super convenient, and I expect it's likely that there are other places that's true too.
* Automated change: Fix sanity tests
* progress
* lalalal
* progress
* x
* Automated change: Fix sanity tests
* fixes
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
* fixes
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* fix client streaming
* handle invalid flags
* Automated change: Fix sanity tests
* no logging
* progress
* progress
* channelz
* tentative fix
* fix
* lalala
* Automated change: Fix sanity tests
* more readable trace
* logging improvements, leading to bug fix in connected channel
* fix
* improve debuggability
* fix
* progress to better refcounting
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* threading
* Automated change: Fix sanity tests
* fix
* fix
* improve debuggability
* fix
* fix
* Automated change: Fix sanity tests
* fix
* make promises runtime configurable
* Automated change: Fix sanity tests
* fix
* fix build
* fix broken test
* clean up api
* deal with stats better
* peer string!
* introduce fragments
* Automated change: Fix sanity tests
* use fragments
* stuff
* [promises] Add AtomicWaker type
* Automated change: Fix sanity tests
* fix
* fix write path
* fix
* polling-entity-hell
* review feedback
* fix
* fix
* fix
* fix
* make an experiment
* [experiments] Make output more diffable/readable
* Automated change: Fix sanity tests
* buildifier sized indentations
* fix
* fix
* Automated change: Fix sanity tests
* fix?
* fix promise
* prototype
* progress
* implement new api
* Revert "fix promise"
This reverts commit ded85e7d19c2acef1958
2 years ago
e1e1f6181f
Util to load file contents into grpc_core::Slice ( #31176 )
...
* Util to load file contents into grpc_core::Slice
* Add test
* iwyu
* iwyu again
2 years ago
6cac641c64
EventEngineFactoryReset - remove custom factory and reset default engine ( #30554 )
...
* EventEngineFactoryReset - remove custom factory and reset default engine
* fix
* Automated change: Fix sanity tests
* unused parameter
* fix
* fix
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
f11282df8d
Bump dev version v1.51-dev ( #31174 )
...
* bump version to 1.51.0-dev
* regenerate projects
2 years ago
fb5d64fc03
[ObjC]fix 64 to 32 bit clang conversion warning in src/core/ext/transport ( #29873 )
...
* fix 64 to 32 bit clang conversion warning in src/core/ext/transport
* fix additional conversion warnings, use size_t in VarIntWriter
* fix CI error
2 years ago
a23eae84c9
Revert "[flakes] Update flakiness ( #31121 )" ( #31173 )
...
This reverts commit bdc799af73
2 years ago
bdc799af73
[flakes] Update flakiness ( #31121 )
...
* update
* Automated change: Fix sanity tests
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
cdccf1e1e4
fix for import ( #31165 )
...
* fix for import
* fix
2 years ago
951c9a860c
xds_cluster_manager LB: fix bug from #30044 ( #31164 )
...
* fix bugs
* iwyu
2 years ago
2ec220a6b1
[sanity] Fix it ( #31163 )
...
* fix sanity
* fix sanity
2 years ago
631e8b2c36
[fixit] Parallelize hpack_size tests ( #30580 )
...
* [hpack_size] Parallelize tests
* Automated change: Fix sanity tests
* fix tsan race
* fix tsan race
* bleh
* windows-strerror
* ugh
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
c62013d699
[c++] Implement DynamicThreadPool in-terms-of event engine ( #30553 )
...
* Make GetDefaultEventEngine return a shared_ptr
This works around valgrind memory leaks by giving EventEngines a fixed
lifetime.
* dynamic pointer cast + documentation
* change the default engine's shared_ptr mechanics; add test
* Integrate new shared_ptr throughout
* promise fix
* forget previous default engines after setting a new EE factory
* Automated change: Fix sanity tests
* fix the autofixer's mistake
* add EventEngine to promise based filter context
* fix fuzer time control
* fix
* add PHP valgrind suppressions for NativeDNSResolver (does not destroy)
* manual iwyu/sanitize
* fix dependency
* fix
* add EE factory reset
* Automated change: Fix sanity tests
* fix
* manual sanitize
* bdp_estimator: replace mutex with atomic
* format
* comment out unused args
* remove stowaway
* unused param
* prelude
* use-ee
* simpler
* fix
* Automated change: Fix sanity tests
Co-authored-by: AJ Heller <hork@google.com>
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
8174a75079
[iwyu] Add more test directories ( #30952 )
...
* [iwyu] Add more test directories
* fix
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* iwyu
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
9c98d67d7a
[c++14] absl::make_unique --> std::make_unique ( #31159 )
...
* [c++14] absl::make_unique --> std::make_unique
* fix
* fix
2 years ago
c1853ade88
[slice] allow inlining of slice ref/unref again ( #31158 )
...
* allow inlining of slice ref/unref again
* Automated change: Fix sanity tests
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
4874619947
Automated change: Fix sanity tests ( #31162 )
...
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
b302281364
Visibility change to orphanable for xds_client_core ( #31161 )
2 years ago
fcf8e2431c
EventEngine::RunAfter: XDS Cluster Manager ( #30044 )
...
* EventEngine::RunAfter: XDS Cluster Manager
* fix
* reviewer feedback
* sanity
2 years ago
71f4fa7f92
update matrix images ( #31157 )
2 years ago
d7266f48f4
GcpObservability: Disable observability traces for CloudOps endpoints ( #31094 )
...
* GcpObservability: Disable observability traces for CloudOps endpoints
* Fix deps and IWYU
2 years ago
4ccb80252b
Revert "Revert "GcpObservability: Change default views provided ( #31144 )" ( #31149 )" ( #31155 )
...
This reverts commit 6fbff9c6a9
2 years ago
68387a4e68
[PosixEventEngine] Ensure threads are shut down before destroying other engine state ( #31152 )
...
* Add check for engine life on shutdown
This fixes a race condition where closures attempt to deregister themselves after the engine has been destroyed
* start initialized
* ensure threads are shut down before other engine state is destroyed
2 years ago
7c4b87ede5
Remove `grpc++_codegen` ( #31138 )
...
* Remove `grpc++_codegen`
* Update
* Update
2 years ago
2bdec04852
Update comment on GRPC_ARG_TSI_MAX_FRAME_SIZE ( #31114 )
2 years ago
fc736183d8
[build] Remove nofixdeps for grpc++_error_details ( #30915 )
2 years ago
82254690c3
threading-fix ( #31135 )
2 years ago
2ee2c91c92
Reland x2: Make GetDefaultEventEngine return a shared_ptr ( #30619 )
...
* Reland x2: Make GetDefaultEventEngine return a shared_ptr
* remove thread leak from NativeDNSResolver
This is not going to work for resolvers that support cancellation.
* give resolvers bounded lifetimes
Some resolver own EventEngines. EventEngines cannot run off the end of
the process since they have unjoined threads (problematic in a small set
of environments). This gives resolvers bounded lifetimes, and allows
replacement of resolvers without ASAN issues of deleting resolvers in
active use (occurs in tests).
* fix
* fix windows
* fix surface init test
* fix
* sanitize
* use after move
* the test must wait for the callback to be destroyed
* windows fix: delete the resolver on iomgr shutdown, not before
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* backport fix
* fix
* shared_ptr<EventEngine> in EventEngine benchmarks
2 years ago
ecd7e141cb
[build] Remove nofixdeps for error ( #30910 )
...
* [build] Remove nofixdeps for error
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
00a2b41c81
[build] Remove nofixdeps for grpc_base ( #31148 )
2 years ago
d43511f4af
Removed GRPC_ERROR_NONE ( #31131 )
2 years ago
6fbff9c6a9
Revert "GcpObservability: Change default views provided ( #31144 )" ( #31149 )
...
This reverts commit dedcc7dbf6
2 years ago
c222a0f035
Make TimerManager threads non-joinable ( #31129 )
...
* Make TimerManager threads non-joinable
On gRPC shutdown, any unjoined TimerManager threads will cause TSAN to
detect thread leaks. This fix resolves issues I saw in end2end test
shutdown in another PR, where a single timer manager thread was always
alive after the test ended.
The long-term solution is to integrate the new ThreadPool here, but this
unblocks me for now.
* rm unused parameter
* Automated change: Fix sanity tests
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
2 years ago
f69c64b270
[sanity] Split IWYU, clang-tidy into their own jobs ( #31141 )
...
* [sanity] Split IWYU, clang-tidy into their own jobs
* fix typo
* fix
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
2 years ago
34407bf551
[style] GRPC macros must be prefixed with GRPC_ ( #31120 )
2 years ago
dedcc7dbf6
GcpObservability: Change default views provided ( #31144 )
...
* GcpObservability: Change default views provided
* Fix IWYU
* Fix deps
2 years ago
3c8496181d
Automated change: Fix sanity tests ( #31142 )
...
Co-authored-by: dennycd <dennycd@users.noreply.github.com>
2 years ago
a2b473ec89
address_sorting BUILD: remove license comment breaking import ( #31145 )
2 years ago
a874b8f6ca
EventEngine::Run microbenchmarks ( #30769 )
...
* [WIP] EventEngine::Run microbenchmarks
* Add fanout impl and fix tracking of time spent doing work in threads
* tune down benchmarks; fix fanout counting logic.
* tune down closure fanout tests
* format
* odr
* reviewer feedback
* unify some fanout logic; add a large-AnyInvocable test
lambdas that take an allocation are about 10x slower
* reviewer feedback
* fix invalid vector access
* rm DNS
* format
* copy params for each lambda callback
This fixes segfaults when we cannot ensure all callbacks are complete
before exiting the test.
* s/promise/Notification/g bm_exec_ctx
* ODR and leak
* fix division by zero
* fix
2 years ago
96d27634a4
run ios CronetTest from bazel ( #30439 )
2 years ago
6d249c0af2
Observability: Experimental arg to disable client side tracing ( #31093 )
...
* Observability: Experimental arg to disable client side tracing
* Fix IWYU
* Reviewer comments
* Reviewer comments
* Reviewer comment: Move experimental/internal arg to different file
* Fix build
* Fix IWYU
2 years ago
Sergii Tkachenko
Esun Kim
Anirudh Ramachandra
Vignesh Babu
AJ Heller
Ming-Chuan
Craig Tiller
nanahpang
Hannah Shi
Mark D. Roth
github-actions[bot]
Allan Boll
apolcyn
Yash Tibrewal
Cheng-Yu Chung
Ashitha Santhosh