Mark D. Roth
f0a0628795
centralize handling of channel's default authority ( #27544 )
...
* centralize handling of channel's default authority
* clang-format
* fix backup poller bug
3 years ago
Craig Tiller
a1ad74f7af
Revert "File watcher authorization policy provider implementation ( #26779 )" ( #27591 )
...
This reverts commit 310accd077
.
3 years ago
Craig Tiller
84d9e7e9fa
Speed up microbenchmark tests ( #27584 )
...
* Speed up microbenchmark tests
* Automated change: Fix sanity tests
* Update grpc_benchmark_config.bzl
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
ce0aba2577
Increase XDS e2e shard count ( #27582 )
...
Provides a 40% reduction in runtime for this test internally, and since
it's on our critical path for landing changes, this is significant.
3 years ago
Ashitha Santhosh
310accd077
File watcher authorization policy provider implementation ( #26779 )
...
* File watcher authorization policy provider implementation
3 years ago
Craig Tiller
b2942f601c
Modify hpack benchmark scenarios ( #27567 )
...
It used to be that we could run the hpack deserializer into an arbitrary
sink - that's about to change and the hpack deserializer will buffer
directly into a map. That being the case, it's really hard to compare
performance of the current and the new system. With this PR, I'm
updating the relevant scenario to be more similar to the eventual
scenario that we plan, so that as the new work finishes up, we can get a
clearer idea of what changes we're really making.
3 years ago
Esun Kim
1c6634ac44
Changed grpc_error_get|set_str to use std string instead of slice ( #27466 )
...
* Changed grpc_error_get|set_str to use std string
* Fix init order in tests with gtest
* Undo gtest-tify credentials_test
3 years ago
Denny C. Dai
9870583cea
Revert "[objc] Switch to forward declare proto & clean up ( #27444 )" ( #27521 )
...
This reverts commit 4ad495420f
.
3 years ago
Denny C. Dai
eda416769e
Revert "Revert "[objc] Switch to forward declare proto & clean up ( #27444 )" ( #27473 )" ( #27475 )
...
This reverts commit 8a359d637c
.
3 years ago
Craig Tiller
91a2db9bc2
Make deadline the first metadata trait ( #27468 )
3 years ago
Mark D. Roth
dbade1f5e7
Revert "Revert "pass subchannel address separately instead of as a channel arg ( #27443 )" ( #27489 )" ( #27491 )
...
This reverts commit 20cc6e7414
.
3 years ago
Craig Tiller
9b41852a5e
channel_init --> core configuration system ( #27347 )
...
* channel_init --> core configuration system
* Automated change: Fix sanity tests
* fixes
* Automated change: Fix sanity tests
* fixes
* fixes
* eliminate grpc_base_c
* fixes
* fix merge
* fix
* update visibility
* fixes
* feedback
* fix comment
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Vignesh Babu
20cc6e7414
Revert "pass subchannel address separately instead of as a channel arg ( #27443 )" ( #27489 )
...
This reverts commit 57982f0ec6
.
3 years ago
Austin Schuh
d30404868f
ARM and -Wextra fixups ( #19141 )
...
* Make generated code compile with -Wunused-parameters
-Wunused-parameters is turned on by -Werror -Wextra. gRPC code
generation creates header files with unused parameters. So let's modify
the generator to not generate code which will make -Wunused-parameters
unhappy.
* Fix unsigned vs signed comparisons and 32 bit string formats
Fix unsigned vs signed comparison warnings.
For 64 bit numbers printed in gRPC, the string formats assume that you
are running on a 64 bit machine. Use inttypes.h to make it portable.
Also, use size_t format strings for the same reason.
* Fix unaligned memory access
cost_entry_ptr has no alignment guarentees that ubsan can find. So it
fails the test with an alignment problem. Use memcopy to read the data
from the pointer to fix this.
* Fix undefined behavior with memcpy and memcmp
Passing in a 0 length piece of data and a null pointer is undefined
behavior. If the length is 0, don't pass it in. This fixes ubsan
failures.
* Clang-format
* Automated change: Fix sanity tests
3 years ago
Mark D. Roth
57982f0ec6
pass subchannel address separately instead of as a channel arg ( #27443 )
...
* pass subchannel address separately instead of as a channel arg
* fix bug
* fix passing address to connector
* clang-format
* fix build of bm_call_create
* revert to C-style semantics for grpc_resolved_address
* fix msan bugs
3 years ago
Craig Tiller
8a359d637c
Revert "[objc] Switch to forward declare proto & clean up ( #27444 )" ( #27473 )
...
This reverts commit 4ad495420f
.
3 years ago
Lidi Zheng
9cd68439a2
Change the time-getting logic in xds test to what ExecCtx does ( #27467 )
3 years ago
Denny C. Dai
4ad495420f
[objc] Switch to forward declare proto & clean up ( #27444 )
3 years ago
Craig Tiller
d4407b7e59
Revert "Remove dead code ( #27445 )" ( #27461 )
...
This reverts commit 693f36f91c
.
3 years ago
Craig Tiller
693f36f91c
Remove dead code ( #27445 )
...
* Remove dead code
* Automated change: Fix sanity tests
* build
* remove benchmark
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Esun Kim
47586fb36e
Revert "Revert "Added absl::Status support to error_utils ( #27358 )" ( #27418 )" ( #27429 )
...
This reverts commit 933676c56c
.
3 years ago
Craig Tiller
933676c56c
Revert "Added absl::Status support to error_utils ( #27358 )" ( #27418 )
...
This reverts commit 9b3f75d322
.
3 years ago
Craig Tiller
b669a3c521
Revert "Revert "a useful change ( #27381 )" ( #27411 )" ( #27412 )
...
This reverts commit 5db17f7350
.
3 years ago
Esun Kim
9b3f75d322
Added absl::Status support to error_utils ( #27358 )
3 years ago
Craig Tiller
9872da79a1
Eliminate grpc_metadata_batch_{init,destroy,move} ( #27349 )
...
* Eliminate grpc_metadata_batch_{init,destroy,move}
* fixes
* fixes
* fixes
* fixes
* portability fixes
* fixes
* fix
* fix
* fix
* be explicit about being explicit
3 years ago
donnadionne
1caff522e4
Adding a log to make logging in WaitForAllBackends and WaitForBackend ( #27365 )
...
consistent.
This helps to uncover a case where the first test in the shard seems to
encounter longer delays than the rest of the tests.
3 years ago
Craig Tiller
5db17f7350
Revert "a useful change ( #27381 )" ( #27411 )
...
This reverts commit 11eb70bbed
.
3 years ago
Craig Tiller
11eb70bbed
a useful change ( #27381 )
...
* a useful change
* Automated change: Fix sanity tests
* fix
* fix
* QsortCompare it is!
* Automated change: Fix sanity tests
* add missing header
* clang-tidy fixes, tweak clamp to only use <
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Alisha Nanda
0a502d8f2e
Fix race between Read and ServerContext::IsCancelled in Sync API ( #27056 )
...
* Fix OOM issues in qps tests
* Add more verbose logging.
* Fix clang error
* Fix race between IsCancelled and Read
* Fix build errors from using bool in C code
3 years ago
Craig Tiller
fd233193ec
Encapsulate metadata aggregates ( #27262 )
...
* Encapsulate metadata aggregates
* Automated change: Fix sanity tests
* add const
* Automated change: Fix sanity tests
* add a comment about an awful api
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
donnadionne
10f218030d
xDS retry policy should be considered present even if there are no supported policies in retry_on ( #27315 )
...
* Ensure that per route retry policy (even when there are no supported
retry_on statuses) still takes precedence over virtual host level retry
policy.
Added a test to guard this case.
* Taking care of code review comments and removing unnecessary block
3 years ago
Lidi Zheng
15184d30ad
Fix injected abort error not recorded after injected delay ( #27215 )
...
* Fix injected abort error not recorded after injected delay
* Add the abort after delay test case
* Make Kokoro's clang_format happy
3 years ago
Mark D. Roth
3763be8796
add APIs for creating errors from C++ strings ( #27310 )
...
* add API for creating errors from C++ strings
* add missing include
3 years ago
Yash Tibrewal
72171a3326
De-experimentalize XdsCredentials and XdsServerCredentials API ( #26544 )
...
* De-experimentalize XdsCredentials and XdsServerCredentials API
* Use GRPC_DEPRECATED
3 years ago
Yash Tibrewal
362aff3458
xDS: Remove environmental variable guard for security ( #27290 )
3 years ago
Yash Tibrewal
7fd731f704
De-experimentalize XdsServerBuilder ( #27296 )
3 years ago
Yash Tibrewal
1a009cf4e5
xDS Security: Use new way to fetch certificate provider plugin instance config ( #27264 )
...
* xDS Security: Use new way to fetch certificate provider plugin instance
config
* Reviewer comments
* Additional fields to NACK
* Move NACKing tests for tls_certificates and tls_certificate_sds_securet_configs to client-side
3 years ago
Yash Tibrewal
f26c107651
xDS server serving status: Use a struct to allow more fields to be added in the future ( #27242 )
3 years ago
Mark D. Roth
f3497eb790
implement improved xDS NACK semantics ( #27276 )
...
* refactor xDS response parsing
* fix build
* implement improved xDS NACK semantics
* fix clang-tidy
* fix test
3 years ago
Craig Tiller
ea389c00c2
Adjust include order per style guide ( #27175 )
...
Introduce clang-format configuration to sort includes closer to our rules.
3 years ago
Mark D. Roth
e468b00c56
refactor xDS response parsing ( #27272 )
...
* refactor xDS response parsing
* fix build
3 years ago
Craig Tiller
dc701787e2
Convert HPACK encoder to C++ ( #27226 )
...
* Rebuild HPACK encoder table as C++
* move comment
* incguards
* build
* Automated change: Fix sanity tests
* c++ initialization ftw
* Automated change: Fix sanity tests
* Add missing header
* Add missing header
* Begin converting HPACK encoder to c++
* First pass conversion to c++
* fixes
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
b062fcd5c6
Ensure consistency of include style for <grpc.* headers ( #27233 )
...
* Add a tool to ensure consistency in how grpc public headers are included
* Apply tool
* add to test suite
* isort
3 years ago
Yash Tibrewal
9e4c657fa3
C++ opencensus filter: Fix point of creating context for overall call ( #27221 )
3 years ago
Mark D. Roth
2cb3831c83
fix retry code to fail batches instead of creating attempt if previously cancelled from surface ( #27217 )
...
* fix retry code to fail batches instead of creating attempt if previously cancelled from surface
* add xDS end2end tests covering the FI use-case that triggered the bug
* fix memory leak
3 years ago
Esun Kim
71a9410fc7
Another workaround to fix windows SymInitialize error ( #27169 )
3 years ago
Yash Tibrewal
cb2e7554a3
xds_end2end_test: Fix UnsupportedHttpFilter test on aws ( #27147 )
3 years ago
Ta-Wei Tu
7dd1da9e1d
Break after WriteLast() ( #27165 )
...
If we continue to call `Write()` after `WriteLast()` (because client is still sending us data and thus `Read()` returns `true`), the buffer might become invalid and results in assertion failures.
3 years ago
Ashitha Santhosh
1ff1f8fd83
SDK authorization filter. ( #26468 )
...
* SDK authorization filter.
3 years ago
donnadionne
59fc02a94b
Enabling Ring Hash by default. ( #27111 )
3 years ago