Mehrdad Afshari
0dd982cf4c
Merge pull request #13823 from mehrdada/shellcheckify-runtests-slash-sanity
...
shellcheckify `tools/run_tests/sanity`
7 years ago
David G. Quintas
e9b0fd07a5
Merge pull request #13494 from dgquintas/backoff_cpp
...
C++-ize backoff
7 years ago
apolcyn
1c4d410c10
Merge pull request #13720 from apolcyn/enable_golden_file_test_in_bazel
...
Fix golden file test under bazel
7 years ago
Noah Eisen
16319654c8
Merge pull request #13822 from grpc/error-tsan
...
Fix internal TSAN bug
7 years ago
Mehrdad Afshari
5de0a1f44b
Enforce shellcheck on tools/run_tests/sanity
7 years ago
Mehrdad Afshari
d1563c37cd
Fix core_untyped_structs.sh to pass shellcheck
7 years ago
Mehrdad Afshari
237f9edcf6
Merge pull request #13816 from mehrdada/sanitytest-shellcheck
...
Add a sanity test for shellcheck
7 years ago
Mehrdad Afshari
96ccd9ae97
Fix check_unsecure.sh to pass shellcheck
7 years ago
Mehrdad Afshari
fe3ca486bc
Fix check_submodules.sh to pass shellcheck
7 years ago
Mehrdad Afshari
5f7ab9b519
Fix check_owners.sh to pass shellcheck
7 years ago
Mehrdad Afshari
11eb322204
Fix check_clang_tidy.sh to pass shellcheck
7 years ago
David Garcia Quintas
4ef4c38275
Create copy of "ac" data instead of stretching the locked section
7 years ago
Mehrdad Afshari
a2ed77db56
Add a sanity test for shellcheck
...
Start by checking the scripts in tools/run_tests/helper_scripts.
7 years ago
David Garcia Quintas
5f31f01a8c
Fix use-after-free caused by unsync'd access in tcp_client_posix.
...
tc_on_alarm() and on_writable() race, resulting in the following:
```
D1219 08:59:33.425951347 86323 tcp_client_posix.cc:143] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_writable: error="No Error"
D1219 08:59:33.426032150 86342 tcp_client_posix.cc:104] CLIENT_CONNECT: ipv4:127.0.0.1:27465: on_alarm: error="No Error"
// At this point, note that the callbacks are running on different threads.
D1219 08:59:33.426063521 86323 tcp_client_posix.cc:218] XXX on_writable ac->addr_str 0x603000008dd0 before unlock. # refs 2->1. Done 0
// on_writable() unrefs while still holding the lock. Because refs > 0, it marks its "done" as false and unlocks.
D1219 08:59:33.426125130 86342 tcp_client_posix.cc:113] XXX tc_on_alarm ac->addr_str 0x603000008dd0 before unlock. # refs 1->0. Done 1
// right after on_writable() unlocks, tc_on_alarm() acquires the lock and unrefs, this time getting to zero and marking its "done" as true.
// It then proceeds to destroy "ac", and, in particular for this failure, "ac->addr_str".
D1219 08:59:33.426139370 86323 tcp_client_posix.cc:234] XXX on_writable about to read from ac->addr_str 0x603000008dd0. Done 0, error=OS Error
// When on_writable() tries to read ac->addr_str to assemble its error details, it causes a use-after-free.
```
The problem is the lock isn't held long enough by on_writable(). Alternatively, a copy of ac->addr_str could be made in on_writable() while still holding the lock, but that seems more fragile. It doesn't seem that holding the lock longer would be a performance issue, given we are in a failure scenario.
7 years ago
David Garcia Quintas
1bedfa3963
Fix another data race in client_lb_end2end
7 years ago
Noah Eisen
ffe6e03ecd
Fix internal TSAN bug
7 years ago
David Garcia Quintas
4f4a45e97e
fix tsan issue in client_lb_end2end
7 years ago
David G. Quintas
1acca45e89
Merge pull request #13813 from dgquintas/disable_low_thread_count
...
Disabled the json_run_localhost:*_low_thread_count family of tests
7 years ago
apolcyn
795e8ebdc4
Merge pull request #13798 from apolcyn/min_max_rpc_version_constants
...
Define RPC protocol version constants
7 years ago
David Garcia Quintas
251af24c54
Disabled the json_run_localhost:*_low_thread_count family of tests
7 years ago
David Garcia Quintas
3bc0dacfe0
Removed exec_ctx from new client_lb_end2end code
7 years ago
Alexander Polcyn
15a74d3317
Define RPC protocol version constants
7 years ago
apolcyn
8ecabd987b
Merge pull request #13777 from frankyn/patch-1
...
[Ruby] Specify module init in README
7 years ago
apolcyn
f19b20f9f6
Merge pull request #13803 from apolcyn/mark_testonly
...
Mark two test binaries as testonly
7 years ago
apolcyn
7f16daf993
Merge pull request #13793 from apolcyn/fix_ruby_distrib_retry
...
Fix failing ruby distrib tests
7 years ago
Mehrdad Afshari
336bce09d4
Merge pull request #11622 from mehrdada/shellckec
...
Fix tools/run_tests/helper_scripts/*.sh to pass shellcheck
7 years ago
Noah Eisen
28839ce3a8
Merge pull request #13776 from ncteisen/executor-tsan
...
Fix shutdown executor tsan bug
7 years ago
Yang Gao
2279cd4aa9
Merge pull request #13771 from yang-g/delete
...
Mark tcp errors as UNAVAILABLE
7 years ago
Mehrdad Afshari
290bbd2111
Fix run_tests_in_workspace.sh to pass shellcheck
7 years ago
Mehrdad Afshari
af3eb69856
Fix run_grpc-node.sh to pass shellcheck
7 years ago
Mehrdad Afshari
4fc1317565
Fix run_ruby_end2end_tests.sh to pass shellcheck
7 years ago
Mehrdad Afshari
e0614e75ef
Fix run_ruby.sh to pass shellcheck
7 years ago
Mehrdad Afshari
3d1dc96f47
Fix run_python.sh to pass shellcheck
7 years ago
Mehrdad Afshari
4da34aa8f0
Fix run_lcov.sh to pass shellcheck
7 years ago
Mehrdad Afshari
fa98f1d086
Fix pre_build_ruby.sh to pass shellcheck
7 years ago
Mehrdad Afshari
51d6c66517
Fix pre_build_csharp.sh to pass shellcheck
7 years ago
Mehrdad Afshari
d8b9243d21
Fix pre_build_cmake.sh to pass shellcheck
7 years ago
Mehrdad Afshari
d4db0986e1
Fix post_tests_ruby.sh to pass shellcheck
7 years ago
Mehrdad Afshari
d3143cd90f
Fix post_tests_python.sh to pass shellcheck
7 years ago
Mehrdad Afshari
4ef3c92170
Fix post_tests_php.sh to pass shellcheck
7 years ago
Mehrdad Afshari
d8ef4887dd
Fix post_tests_csharp.sh to pass shellcheck
7 years ago
Mehrdad Afshari
1a0ff1edb4
Fix post_tests_c.sh to pass shellcheck
7 years ago
Mehrdad Afshari
517d298071
Fix bundle_install_wrapper.sh to pass shellcheck
7 years ago
Mehrdad Afshari
ba137985ff
Fix build_ruby.sh to pass shellcheck
7 years ago
Mehrdad Afshari
3b6dcfa3be
Fix build_python_msys2.sh to pass shellcheck
7 years ago
Mehrdad Afshari
009941ed51
Fix build_php.sh to pass shellcheck
7 years ago
Mehrdad Afshari
0ccd3af0e8
Fix build_csharp.sh to pass shellcheck
7 years ago
Mehrdad Afshari
3bfa56fcea
Fix build_python.sh to pass shellcheck
7 years ago
Alexander Polcyn
5f72c6a0f0
Mark a couple of test binaries asa testonly
7 years ago
David Garcia Quintas
9c8ea03ee3
Merge branch 'master' of github.com:grpc/grpc into backoff_cpp
7 years ago