Mark D. Roth
caacc7e3aa
xds_end2end_test: fix env var name in RLS tests ( #29291 )
...
* xds_end2end_test: fix env var name in RLS tests
* add ScopedExperimentalEnvVar to ensure env vars get unset after tests
* clang-format
3 years ago
Mark D. Roth
a6419dde06
Revert "Adding is_optional case to RLS ( #29259 )" ( #29299 )
...
This reverts commit 2fd632a4c1
.
3 years ago
Mark D. Roth
217ab2a793
xds_end2end_test: make each individual test start the number of backends it needs ( #29271 )
...
* move some code around
* remove num_backends parameter from XdsEnd2endTest
* remove use_xds_enabled_server param from XdsEnd2endTest
* remove xds_resource_does_not_exist_timeout_ms param from XdsEnd2endTest
* remove client_load_reporting_interval_seconds param from XdsEnd2endTest
* start moving CreateAndStartBackends() into individual tests
* finish moving CreateAndStartBackends() into individual tests
* remove unused variable
* fix test flake
* clang-tidy
* clang-format
3 years ago
donnadionne
2fd632a4c1
Adding is_optional case to RLS ( #29259 )
...
* Adding is_optional case to RLS
* integrated with the updated envoy data-plane
* Fixing an old bug and adding test
* Use the same plugin map for ignore
* Remove ignore set
* Fixed another test.
* addressing code review comments.
* clean up!
3 years ago
Mark D. Roth
775362a2ce
client_lb_end2end_test: fix internal build problem ( #29265 )
3 years ago
AJ Heller
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
Craig Tiller
e122c64000
Revert "Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )" ( #29182 )
...
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f672
.
* debug
* minimal reproduction
* debug
* fix state machine for c#
* Revert "minimal reproduction"
This reverts commit 4d02d2e730
.
* Revert "debug"
This reverts commit 7960842f48
.
* Revert "debug"
This reverts commit a6f224e4a1
.
* no-logging
* Revert "Revert "debug""
This reverts commit 951844e857
.
* Better int conversion
* debug
* Fix for Cronet
* Revert "debug"
This reverts commit 4d641c4281
.
* Revert "Better int conversion"
This reverts commit 4001b957cb
.
* Revert "Revert "Revert "debug"""
This reverts commit d135c61043
.
Co-authored-by: Jan Tattermusch <jtattermusch@google.com>
3 years ago
Mark D. Roth
3c4441fcdc
xds: add node ID to status messages generated by XdsClient ( #29253 )
...
* eliminate unnecessary templates
* add xDS node ID to error messages generated by XdsClient
* change test to verify that node ID is present in status message
* clang-format
3 years ago
Wanlin Du
d2aafef157
Make scenario results to include start and end time for a test scenario. ( #29207 )
...
This commit update the scenario results to include the start_timestamp
and end_timestamp. These two fields are used in prometheus range queries
to indicate the period we are pulling data for.
3 years ago
Mark D. Roth
ac8f0b690e
xds: NACK EDS resources with duplicate localities in the same priority ( #29231 )
3 years ago
Craig Tiller
44167bdfd3
Convert server load reporting to promises ( #28927 )
...
* Call finalization for promises
* Convert filter to a promise
* Call finalization for promises
* comment
* split out and test
* dont use promise_detail:: directly
* fix
* Automated change: Fix sanity tests
* fix
* ?
* fix
* finish it
* modernize
* fix-test
* fix
* Review feedback
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Mark D. Roth
23c4541392
xds_cluster_resolver: fix bug that caused us to incorrectly reuse priority child names ( #29174 )
...
* xds_cluster_resolver: fix bug that caused us to incorrectly reuse priority child names
* add debug logging
* assign child policy names within each discovery mechanism, not across all mechanisms
* clang-format
* add tests
* don't need EDS service name or LOGICAL_DNS hostname in child name
* remove unnecessary code
3 years ago
Mark D. Roth
eded3b6bc3
client channel: record call completion even if recv_trailing_metadata was not started ( #29198 )
...
* client channel: record call completion even if recv_trailing_metadata was not started
* add test
* add test for opencensus filter
* remove unnecessary code
3 years ago
donnadionne
6989129db5
xDS RLS implementation ( #29200 )
...
* Revert "Revert "Initial structure for RLS (#28750 )" (#29189 )"
This reverts commit 7ece810843
.
* fixing 1 unused using
3 years ago
donnadionne
7ece810843
Revert "Initial structure for RLS ( #28750 )" ( #29189 )
...
This reverts commit 362e0b8706
.
3 years ago
donnadionne
362e0b8706
Initial structure for RLS ( #28750 )
...
* Initial structure for RLS
* Adding and building the proto to parse the Any proto for the plugins
* re-org
* Parsing the plugin
* Parsing more into json
* Parsed proto to json
* small cleanup
* Adding prefix
* Added new rls_experimental policy
* build files
* Fixing according to code review comments
* code review comments
* Adding sym changes
* adding action name check
* fixing code review comments.
* fixing unused var error
* clean up
* fixing code review comments
* fixing code review comments
* fixing according to code review comments.
* Remove unnecessary include
* small fix
* generate more, hard-code less
* Moving to using absl::variant
* absl::string_view and absl::variant of vector of std::string are not
playing nice together.
* fixed variant
* Using absl::variant now
* Checkint used plugins
* Refactor Parsing code and separating out Parsing of the plugin
* Fixing code review comments
* code review comments
* fixing code review comments.
* Addressing code review comments
* First end-to-end test
* generated build files
* commit generated files via tools/codegen/core/gen_upb_api.sh
* Fixing rls policy parsing tests
* Restore checks for the test server
* Refactor rls_server
* added keys to rls request
* fixing small logic error
* Complete the test using all the keys
* Separating out RLS test and rls_server thread
* sanity errors
* generated build files
* Complete the rest of the tests and sanity cleanup
* fixing code review comments: using upb_JsonEncode now!
* fixing code review comments
* fixing code review comments
* Fixing code review comments
* misisng fix
* simplifying tests
* simplify tests 2
* Linking in the correct proto for rls_config
* restore metadata check
* Add disable test
* Fixing RLS test and removing environment var that is no longer necessary
* Fixing "Wrong type" type of tests after json parsing change to accept
STRING for number
* adding json_encode.h/c to src/upb/gen_build_yaml.py and generate
necessary files.
* Fixing un-used var error
* fixing sanity errors
* Fixing the upb encoding buffer
* Fixing code review comments.
* Adding nack test for unkonwn plugin proto
* Last bit of code review comments
* fixing unused variable
3 years ago
Jan Tattermusch
6ee276f672
Revert "HTTP Client Filter --> promises ( #29031 )" ( #29181 )
...
This reverts commit 41debbf1a7
.
3 years ago
Craig Tiller
41debbf1a7
HTTP Client Filter --> promises ( #29031 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* roughing out
* push/pull impl
* comment
* prove out new combinator
* Simplify naming
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* builds
* Automated change: Fix sanity tests
* progress
* tweak
* merge
* progress
* fix
* first test passes
* progress
* fix
* repair name
* fix
* small fix
* small fix
* properly stop call combiner
* fix allocation in this benchmark
* fix
* fix
* fix merge
* fix bad merge
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
apolcyn
99cbd49ef8
Simplify fallback test client and parameterize fallback deadline ( #29126 )
...
Simplify fallback test client and parameterize fallback deadline
3 years ago
Mark D. Roth
7b4a5fcba5
xds: accept resources wrapped in a Resource message ( #29090 )
...
* xds: accept resources wrapped in a Resource message
* fix v2 proto name
3 years ago
AJ Heller
1f03bbab39
Small cleanup ( #29125 )
...
The std::moves of temporaries prevented copy elision, and the functions
were unused (one with a TODO to re-enable later)
3 years ago
Yash Tibrewal
01f333a1c1
TlsCredentials: Comparator implementation ( #28940 )
...
* TlsCredentials: Comparator implementation
* Update tests
* Redundant namespace qualifiers
* clang-tidy
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Reviewer comments
* Add generator for grpc_tls_credentials_options.h
* Generator script modifications for tests
* Sanity
* Reviewer comments
* Reviewer comments
* Add a common place to look-up known types
* Formatting
* Script fix
* Reviewer comments
* Add test mode to script
* Add to sanitize.sh
* clang-tidy
* Fix
* Fix
* Reviewer comments
* Clang-format
3 years ago
Vignesh Babu
f86723d9db
Revert "Update the scenario results to include start and end time for a test scenario. ( #29034 )" ( #29122 )
...
This reverts commit 84edc034aa
.
3 years ago
Wanlin Du
84edc034aa
Update the scenario results to include start and end time for a test scenario. ( #29034 )
...
This commit add start and end timestamp to the existing scenario results.
3 years ago
Craig Tiller
0ea1eeb4e7
Expose channel stack type to builder ( #29088 )
...
* split builder
* expose channel stack type to builder
* Automated change: Fix sanity tests
* Update channel_stack_builder_impl.h
* Update channel_init.h
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
138c4667c9
Change main argument of call promise to be a struct ( #29019 )
...
* introduce call args
* bs
* x
* Automated change: Fix sanity tests
* fix
* Simplify naming
* tweak
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Yash Tibrewal
674e938de5
More tests prep for graceful goaway ( #29076 )
...
* More tests prep for graceful goaway
* clang-tidy
3 years ago
Yash Tibrewal
c9946c2183
Channelz Service Test Shutdown ( #29068 )
3 years ago
Yash Tibrewal
68d721058c
Prepare async_end2end_test for graceful goaway ( #29054 )
3 years ago
apolcyn
00d587dc56
Include ADS stream error in XDS error updates ( #29014 )
...
* include ADS stream error in XDS error updates
* Re-package XDS client errors into unavailable rather than unknown, in XDS resolver
3 years ago
Craig Tiller
fe913387da
Remove idempotent/cacheable requests ( #28922 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* Modify XdsRbacTests
Co-authored-by: Yash Tibrewal <yashkt@google.com>
3 years ago
Craig Tiller
87acbadba1
Third attempt: Convert client_auth_filter to promises ( #28968 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* Revert "Revert "Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )" (#28952 )" (#28967 )"
This reverts commit 0f73576b17
.
* fix potential memory leak
* Fix behavior if >1 pending request
* fix
* fix nullptr access
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Esun Kim
c08eb4fc41
Attempt to upgrade upb to the latest ( #28685 )
...
* Update upb to 85e5c76cb7098d3ae35e575d652a40568013a149
* Update grpc_deps.bzl
* Run gen_upb_api.sh
* Run run_sed.sh
* Update gen_build_yaml.py
* Regen projects
* Reformat
* Update third_party/upb to 950cdab42fe4c83f06a2be46eeb46a068e486eed
* Update third_party/upb to c9c31241bc39922b092a81d192badd50cccaaa81
* Update src/upb/gen_build_yaml.py
* Generated projects
* Update third_party/upb to a02d92e0257a35f11d4a58b6a932506cbdbb2f29
* Patching in https://github.com/protocolbuffers/upb/pull/524
* Sed script went too far.
Co-authored-by: Nicolas 'Pixel' Noble <nicolas@nobis-crew.org>
3 years ago
Craig Tiller
0f73576b17
Revert "Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )" ( #28967 )
...
This reverts commit 235098de22
.
3 years ago
Craig Tiller
16a3ce51ff
Service config parser to core configuration ( #28883 )
...
* Service config parser to core configuration
* x
* Automated change: Fix sanity tests
* finish
* Automated change: Fix sanity tests
* oops
* fix race
* Automated change: Fix sanity tests
* back out mutex
* refactor
* optimize
* Automated change: Fix sanity tests
* fix
* fix
* split out interface
* review feedback
* x
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
235098de22
Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )
...
* Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )"
This reverts commit 5bfe38f10f
.
* fix
3 years ago
Craig Tiller
5bfe38f10f
Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )
...
This reverts commit cadce47ebf
.
3 years ago
Craig Tiller
cadce47ebf
Convert client_auth_filter to promises ( #28767 )
...
* Convert client_auth_filter to promises
* outline
* x
* x
* fixes
* remove-spam
* Async sequences over iterators
* iterate
* better semantics
* fix
* clang-tidy
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* progress
* progress
* progress
* progress
* credentials_test passes
* Automated change: Fix sanity tests
* Make Activity more of an interface
Move mutex and wakeup logic into a new class between PromiseActivity<>
and Activity (so that the sharing can persist), but make Activity closer
to a pure interface, so that whilst we migrate code we can implement
better fakes without forcing allocation.
* fixes
* Automated change: Fix sanity tests
* fixes
* test the awful failure
* x
* fix typo
* fix race
* 4.9
* x
* review feedback
* review feedback
* Automated change: Fix sanity tests
* review feedback
* replace AuthMetadataContext interface with GetRequestMetadataArgs struct
* Automated change: Fix sanity tests
* fix merge
* Fixup
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
Craig Tiller
dd76a04b8c
Move resolver to core configuration ( #28881 )
...
* Move resolver to core configuration
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* resolver: clean up and modernize registry
* fix race
* update visibility
* fix internal error
* review feedback
* resolve backref issues
* windows
* x
* fix sockaddrs on windows?
* fix sockaddrs on windows?
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
Craig Tiller
ff87ca02b2
Revive test/core/memory_usage ( #28931 )
...
* Revert "Deprecate gpr_get/set_allocation_functions"
This reverts commit 81df105ac8
.
* memory stats
* Hack up to get per-call numbers
* expunge memory counters
* buildgen
* Automated change: Fix sanity tests
* sanity
* fix
* Automated change: Fix sanity tests
* simplify
* better
* Automated change: Fix sanity tests
* Disable windows memory_usage
* disable mac
* disable mac
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
05056e149a
eliminate bm_error ( #28944 )
3 years ago
AJ Heller
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
AJ Heller
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
.
3 years ago
AJ Heller
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
donnadionne
431d314eca
Calculate clock difference and accomodate it to deflake timeout tests ( #28868 )
...
* Calculating clock difference and accomendate it to deflake timeout
tests.
* Fixing according to code review comments.
3 years ago
Oscar Shi
e0a5c310cd
Increase number of threads in stress test ( #28821 )
...
In some configurations 100 threads is not enough to cause exhaustion failing tests.
Increase number of threads to ensure resource exhaustion
3 years ago
AJ Heller
40f2c2a4e1
Upgrade googletest ( #27287 )
3 years ago
Ashitha Santhosh
1fee3d72be
remove SDK term from gRPC authz ( #28843 )
3 years ago
donnadionne
1baca37a9e
Applying aggregate ringhash policy ( #28861 )
...
* Applying aggregate ringhash policy
* Fixing according to code review comments.
* typo
3 years ago