Harvey Tuch
5f3cfe960f
Fix read from uninitialized memory bug in GrpcBufferWriter.
...
This commit fixes an issue in which the following sequence of operations
leads to use of uninitialized memory:
1. Caller invokes GrpcBufferWriter::Next(), and then makes use of 8191
bytes in the returned buffer (which is 8192 bytes in size).
2. Caller then returns the unused single byte via
GrpcBufferWriter::BackUp(). This method invokes
g_core_codegen_interface->grpc_slice_split_tail(), which causes
backup_slice_ to be a grpc_slice with one byte.
3. At the next invocation of GrpcBufferWriter::Next(), a reference to
the single byte grpc_slice is returned to the caller.
The problem here is that the returned reference is to the inlined buffer
in the grpc_slice, which is resident in slice_, not the location of the
buffer inside slice_buffer_ after
g_core_codegen_interface->grpc_slice_buffer_add() in
GrpcBufferWriter::Next(). As a result, any data the caller writes to the
returned void* data is lost.
The solution is to avoid inlined backup slices.
8 years ago
Mark D. Roth
448c1f002c
Move parameters for all grpc_op types into their own sub-structs.
8 years ago
Craig Tiller
7c70b6c144
Revert "Revert "Metadata handling rewrite""
...
This reverts commit 5e01e2ac97
.
8 years ago
Craig Tiller
5e01e2ac97
Revert "Metadata handling rewrite"
8 years ago
Craig Tiller
1d77059e4b
Fix integer overflow
8 years ago
Craig Tiller
62f28bfcf0
Remove double-checking of max-message-size in C++ layers
8 years ago
Craig Tiller
81eceb31cc
Remove bogus assert
8 years ago
Craig Tiller
e519a03a1f
Small improvements to generated documentation
8 years ago
Vijay Pai
0e3f1f1e53
Support compat with old generated PB files
8 years ago
Craig Tiller
78bc54e7d9
Fix stack corruption
8 years ago
Craig Tiller
cadabdf1f3
Fix include guards
8 years ago
Craig Tiller
f658bf0e1b
Start resolving memory issues in C++ metadata
8 years ago
Vijay Pai
6510d47c81
gpr_atm isn't automatically initialized to 0. Thanks Obama.
8 years ago
Vijay Pai
bf24dd9e51
clang-format
8 years ago
Vijay Pai
cbe1599250
Track requests that could cause other requests to be created, and don't do
...
a real core shutdown of a CQ until such requests are done
8 years ago
Craig Tiller
73ee7dc559
C++ compiles
8 years ago
Craig Tiller
cca7589333
Start moving C++ to slice interfaces
8 years ago
Vijay Pai
320ed13d3e
Deprecate grpc::thread and sync in favor of std::thread,mutex,etc
8 years ago
Vijay Pai
5c41bab92c
Remove references to NO_CHRONO option
8 years ago
Vijay Pai
e08fe4f41e
Remove separate versions of code based on presence of threading in compiler
8 years ago
Vijay Pai
713c7b87e1
clang-format
8 years ago
Vijay Pai
c0b2acb1a0
Use C++11 final and override
8 years ago
Vijay Pai
80b292709c
Stop supporting non-C++11 conformant compilers
8 years ago
Craig Tiller
28b72428a8
clang-format
8 years ago
Craig Tiller
5b676a6b1a
Fix include guards
8 years ago
Craig Tiller
618e67d655
s/GPR_SLICE/GRPC_SLICE/g
8 years ago
Craig Tiller
d41a4a720f
s/gpr_slice/grpc_slice, and move around tests, impls
8 years ago
Vijay Pai
bcc59f425c
Remove a useless forward declaration
8 years ago
yang-g
4287998855
Add a test spouse for server context
8 years ago
Vijay Pai
96e03110db
clang-format
8 years ago
Vijay Pai
075b18e77f
Bug fix on failure condition
8 years ago
Vijay Pai
61536a7371
Making split streaming testable
8 years ago
Sree Kuchibhotla
33382d0f53
Cleanup server_cc.cc
8 years ago
Vijay Pai
db5b1cbc94
Add all plumbing and typedef's for controlled server-side streaming
8 years ago
Mark D. Roth
a40d471110
Plumb through GRPC_INITIAL_METADATA_WAIT_FOR_READY_EXPLICITLY_SET.
8 years ago
Mark D. Roth
59c9f904bf
Rename GRPC_INITIAL_METADATA_IGNORE_CONNECTIVITY to
...
GRPC_INITIAL_METADATA_WAIT_FOR_READY.
Also add a flag to indicate whether wait_for_ready was explicitly set by
the application.
8 years ago
Mark D. Roth
9477724003
Change C++ API to expose wait_for_ready instead of fail_fast.
8 years ago
Yuchen Zeng
362ac1be0c
Fix gprc
8 years ago
yang-g
d558149a5e
Add a helper to get canonical code from status
8 years ago
Makarand Dharmapurikar
2b98b77225
add cacheable option to client_context
8 years ago
Mark D. Roth
3ad6188920
Fix a few lingering references to max_message_size.
8 years ago
Mark D. Roth
6980362c4e
Allow setting max send message size via C++ ServerBuilder API.
8 years ago
Vijay Pai
5c9a3438c5
clang-format
8 years ago
Vijay Pai
84033b1f6b
Stick to StatusCode::INTERNAL when there's no service
...
response on a StreamedUnary
8 years ago
Vijay Pai
77073ce99f
clang-format
8 years ago
David Garcia Quintas
621e2b1a49
Merge with newly added/modified files
8 years ago
Yuchen Zeng
11d3c8f3d4
Add ServerBuilderPlugin::UpdateChannelArguments
8 years ago
Vijay Pai
d4d5f4cd53
clang-format
8 years ago
Vijay Pai
a9c0d7f88b
Change names to StreamedUnary, ServerUnaryStreamer, etc. Use a templated method handler since most code shared between the new StreamedUnary and the existing BidiStreaming. Eliminate the separate enum case for streamed unary. Return a status failure if a StreamedUnary method handler doesn't actually do a write (since that is
...
violating the appearance of unary-ness)
8 years ago
Julien Boeuf
2b2b345841
Addressing feedback.
8 years ago