Anirudh Ramachandra
440ae5684c
Revert "Fix grpc_sockaddr_to_uri to return URI encoded string. Also see #29323 which has a similar fix for unix abstract addresses."
3 years ago
AJ Heller
9f7311e399
Revert DNSResolver cancellation ( #29581 and #29631 ) ( #29634 )
...
This reverts commit 075e84314d
.
3 years ago
Anirudh Ramachandra
a31224fc10
Fix grpc_sockaddr_to_uri to return URI encoded string. Also see #29323 which has a similar fix for unix abstract addresses. ( #29478 )
3 years ago
AJ Heller
0a21ecdff6
Change cancellation semantics in the iomgr DNSResolver ( #29581 )
...
DNS requests were previously cancellable, but it was assumed
that the resolution callback would be called in all cases. Now, requests
provide a `bool Cancel(TaskHandle handle)` method that lets callers know
whether cancellation is successful, and if so, the callback will not be
run.
This is in accordance with EventEngine's cancellation semantics, and it
is a step towards migration from iomgr to EventEngine.
3 years ago
Craig Tiller
5918f98ecb
[iwyu] Enable nosafe_headers ( #29591 )
...
* Add flag
* sweep1
* fixes
* speedup
* fixes
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
18bec00b58
[channel-stack] Eliminate post-init in channel stack builder ( #29514 )
...
* Eliminate post-init in channel stack builder
We've had a post init function on channel stack builder for a very long
time, an it serves to run some code after initialization completes.
We need the functionality for a few things, but the function passed in
is intimately tied to the filter in use - we never vary it between
multiple functions for the same filter... which means it makes more
sense to locate this functionality as part of the filter interface.
* fix
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Vignesh Babu
b92f885756
Adding a max_frame_size argument to grpc_endpoint_write API to allow a sender to control frame sizes ( #29526 )
...
* adding a max_frame_size argument to grpc_endpoint_write API
* fix syntax error
* fix typo
3 years ago
Vignesh Babu
53e382729f
Adding a min progress size argument to grpc_endpoint_read to allow gRPC to use TCP optimizations on the read path ( #29503 )
...
* adding a min progress size argument to grpc_endpoint_read
* fix missing argument error
* adding a static_cast
* reverting changes in tcp_posix.cc
* add missing changes to CFStreamEndpointTests.mm
3 years ago
Craig Tiller
8bb45aa3a6
Convert grpc_channel to C++ ( #29266 )
...
* begin
* tests
* fix
* http
* Filter fuzzer
* progress
* basics
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f672
.
* stuff
* debug
* minimal reproduction
* progress
* progress
* create call
* progress
* recv trailing metadata
* wakeups
* corpus
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* debug
* fix state machine for c#
* Revert "minimal reproduction"
This reverts commit 4d02d2e730
.
* Revert "debug"
This reverts commit 7960842f48
.
* Revert "debug"
This reverts commit a6f224e4a1
.
* no-logging
* initial-metadata
* Revert "Revert "debug""
This reverts commit 951844e857
.
* Better int conversion
* debug
* Fix for Cronet
* Revert "debug"
This reverts commit 4d641c4281
.
* Revert "Better int conversion"
This reverts commit 4001b957cb
.
* Revert "Revert "Revert "debug"""
This reverts commit d135c61043
.
* progress
* progress
* Automated change: Fix sanity tests
* fix, c++ize
* handle transport, use objects
* enable more stuffs
* remove placeholder
* contexts
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* x
* exceptional toast
* include idle filters, time
* fix
* namespace
* fixes
* final info
* progress
* cleanup
* progress
* progress
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* progress
* Set int
* Set int
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fixes
* fixes
* fixes
* fixes
* fix
* fix race
* fix race
* mac fix
* review feedback
* getgetget
* fix ios
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Jan Tattermusch <jtattermusch@google.com>
3 years ago
Yousuk Seung
371d231b53
Support unix socket in grpc_sockaddr_to_string ( #29169 )
...
* Support unix socket in grpc_sockaddr_to_string
* make it return statusor
* clang fix
* made grpc_sockaddr_to_string() to return statusor
* Let Chttp2ServerListener::Start crash
* test failure fixed
* api_fuzzer fixed
* comments addressed.
* more comments addressed
* comments addressed
* fix other broken builds
3 years ago
Yash Tibrewal
9796969b0c
Filter content-length metadata ( #29295 )
3 years ago
Craig Tiller
33aaa55032
Filter fuzzer ( #29177 )
...
* begin
* tests
* fix
* http
* Filter fuzzer
* progress
* basics
* progress
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* Revert "Revert "HTTP Client Filter --> promises (#29031 )" (#29181 )"
This reverts commit 6ee276f672
.
* stuff
* debug
* minimal reproduction
* progress
* progress
* create call
* progress
* recv trailing metadata
* wakeups
* corpus
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* debug
* fix state machine for c#
* Revert "minimal reproduction"
This reverts commit 4d02d2e730
.
* Revert "debug"
This reverts commit 7960842f48
.
* Revert "debug"
This reverts commit a6f224e4a1
.
* no-logging
* initial-metadata
* Revert "Revert "debug""
This reverts commit 951844e857
.
* Better int conversion
* debug
* Fix for Cronet
* Revert "debug"
This reverts commit 4d641c4281
.
* Revert "Better int conversion"
This reverts commit 4001b957cb
.
* Revert "Revert "Revert "debug"""
This reverts commit d135c61043
.
* progress
* progress
* Automated change: Fix sanity tests
* fix, c++ize
* handle transport, use objects
* enable more stuffs
* remove placeholder
* contexts
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* x
* exceptional toast
* include idle filters, time
* fix
* namespace
* fixes
* final info
* progress
* Automated change: Fix sanity tests
* fix
* fix
* combine cases
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Jan Tattermusch <jtattermusch@google.com>
3 years ago
Mark D. Roth
f11d86c403
retry: fix flakiness in retry_cancel_during_delay test ( #29261 )
...
* retry: fix flakiness in retry_cancel_during_delay test
* clang-format
3 years ago
AJ Heller
18a8f6aad9
Refactor end2end tests to exercise each EventEngine ( #29202 )
...
* Refactor end2end tests to exercise each EventEngine
* fix incorrect bazel_only exclusions
* Automated change: Fix sanity tests
* microbenchmark fix
* sanitize, fix iOS flub
* Automated change: Fix sanity tests
* iOS fix
* reviewer feedback
* first pass at excluding EventEngine test expansion
Also caught a few cases where we should not test pollers, but should
test all engines. And two cases where we likely shouldn't be testing
either product.
* end2end fuzzers to be fuzzed differently via EventEngine.
* sanitize
* reviewer feedback
* remove misleading comment
* reviewer feedback: comments
* EE test_init needs to play with our build system
* fix golden file test runner
Co-authored-by: drfloob <drfloob@users.noreply.github.com>
3 years ago
Mark D. Roth
54b027d599
retry: increase perAttemptRecvTimeout in tests ( #29256 )
3 years ago
Craig Tiller
766cd6b573
Remove epollex poller ( #29160 )
...
* start delete
* remove build.gn... again
* remove more
* Automated change: Fix sanity tests
* fixes
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
0ea1eeb4e7
Expose channel stack type to builder ( #29088 )
...
* split builder
* expose channel stack type to builder
* Automated change: Fix sanity tests
* Update channel_stack_builder_impl.h
* Update channel_init.h
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Mark D. Roth
e8c5c39143
retry: fix bug where we incorrectly replayed a completed send_message op ( #29025 )
...
* retry: fix bug where we incorrectly replayed a completed send_message op
* fix
* third time's the charm!
* clang-format
3 years ago
Yash Tibrewal
0f58fa8d07
GracefulGoaway: Fix shutdown_finishes_tags test ( #29091 )
3 years ago
Yash Tibrewal
bd357f9a37
Remove shutdown_cq from grpc_end2end_test_fixture ( #29049 )
...
* Remove some shutdown_cq instances
* Remove shutdown_cq from grpc_end2end_test_fixture
3 years ago
AJ Heller
b639e09c90
Enable ipv4 end2end tests inside Google ( #29013 )
3 years ago
AJ Heller
762cde4d24
Delete end2end nosec tests ( #28946 )
...
* rm nosec tests (TODO: identify coverage differences)
* grpc::load_reporter
* delete unused nosec test files & config
* trigger build
* re-delete nosec test file (snuck in with a merge)
* revert TODO deletion
3 years ago
Craig Tiller
fe913387da
Remove idempotent/cacheable requests ( #28922 )
...
* Remove idempotent/cacheable requests
* more cleanup
* bump core version
* fix
* fix
* fix
* review feedback
* fixes
* fix
* remove more
* objc
* fix
* fix
* fix
* scrub
* Modify XdsRbacTests
Co-authored-by: Yash Tibrewal <yashkt@google.com>
3 years ago
Craig Tiller
87acbadba1
Third attempt: Convert client_auth_filter to promises ( #28968 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* Revert "Revert "Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )" (#28952 )" (#28967 )"
This reverts commit 0f73576b17
.
* fix potential memory leak
* Fix behavior if >1 pending request
* fix
* fix nullptr access
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
5fc3ff8203
grpc_millis -> Timestamp/Duration ( #28119 )
...
* wip
* Automated change: Fix sanity tests
* fixes
* progress
* progress
* grpc compiles
* Automated change: Fix sanity tests
* fixing tests
* x
* progress
* better code
* Automated change: Fix sanity tests
* progress
* progress
* windows fix
* Make Duration metadata trivial
* better message
* fix
* Automated change: Fix sanity tests
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fix
* progress
* fixes
* fix
* fix
* spam
* un-disable errantly disabled tests
* gain insight
* Automated change: Fix sanity tests
* fixes
* fixes
* fix
* debug
* tweak
* fix
* fix timeout
* fix comment
* fixes
* x
* better test
* tests
* Automated change: Fix sanity tests
* missed file
* fix
* x
* fix
* fix
* fix
* fix
* Automated change: Fix sanity tests
* fix
* merge
* Automated change: Fix sanity tests
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Mark D. Roth
c27f8f1505
Fourth attempt: Implement transparent retries ( #28943 )
...
* Revert "Revert "Third attempt: Implement transparent retries (#28925 )" (#28942 )"
This reverts commit be70a8676c
.
* fix edge case where call is cancelled while transparent retry callback is pending
3 years ago
Craig Tiller
0f73576b17
Revert "Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )" ( #28967 )
...
This reverts commit 235098de22
.
3 years ago
Mark D. Roth
3d4433beb2
retry: always free cached send op data ( #28956 )
...
* Revert "Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation (#28945 )" (#28954 )"
This reverts commit 9498843a18
.
* retry: always free cached send op data
3 years ago
Craig Tiller
235098de22
Revert "Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )" ( #28952 )
...
* Revert "Revert "Convert client_auth_filter to promises (#28767 )" (#28951 )"
This reverts commit 5bfe38f10f
.
* fix
3 years ago
Mark D. Roth
9498843a18
Revert "retry: fix memory leak due to not freeing cached send ops upon cancellation ( #28945 )" ( #28954 )
...
This reverts commit f48c4f1f4b
.
3 years ago
Craig Tiller
5bfe38f10f
Revert "Convert client_auth_filter to promises ( #28767 )" ( #28951 )
...
This reverts commit cadce47ebf
.
3 years ago
Craig Tiller
cadce47ebf
Convert client_auth_filter to promises ( #28767 )
...
* Convert client_auth_filter to promises
* outline
* x
* x
* fixes
* remove-spam
* Async sequences over iterators
* iterate
* better semantics
* fix
* clang-tidy
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* fixes
* Automated change: Fix sanity tests
* progress
* progress
* progress
* progress
* progress
* credentials_test passes
* Automated change: Fix sanity tests
* Make Activity more of an interface
Move mutex and wakeup logic into a new class between PromiseActivity<>
and Activity (so that the sharing can persist), but make Activity closer
to a pure interface, so that whilst we migrate code we can implement
better fakes without forcing allocation.
* fixes
* Automated change: Fix sanity tests
* fixes
* test the awful failure
* x
* fix typo
* fix race
* 4.9
* x
* review feedback
* review feedback
* Automated change: Fix sanity tests
* review feedback
* replace AuthMetadataContext interface with GetRequestMetadataArgs struct
* Automated change: Fix sanity tests
* fix merge
* Fixup
* fix
* fix
* fix
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
Co-authored-by: Mark D. Roth <roth@google.com>
3 years ago
Mark D. Roth
f48c4f1f4b
retry: fix memory leak due to not freeing cached send ops upon cancellation ( #28945 )
...
* retry: fix memory leak due to not freeing cached send ops upon cancellation
* clang-format
* attempt to fix proxy tests on windows
3 years ago
Mark D. Roth
be70a8676c
Revert "Third attempt: Implement transparent retries ( #28925 )" ( #28942 )
...
This reverts commit 9e7453409a
.
3 years ago
Mark D. Roth
9e7453409a
Third attempt: Implement transparent retries ( #28925 )
...
* Revert "Revert "Revert "Revert "Implement transparent retries (#28548 )" (#28888 )" (#28890 )" (#28909 )"
This reverts commit 23da14c1a7
.
* revert api_fuzzer change
3 years ago
Mark D. Roth
25aa80966a
retry: fix memory leak if call is unreffed without starting recv_trailing_metadata ( #28913 )
...
* retry: fix memory leak if call is unreffed without starting recv_trailing_metadata
* fix test flake
3 years ago
Mark D. Roth
23da14c1a7
Revert "Revert "Revert "Implement transparent retries ( #28548 )" ( #28888 )" ( #28890 )" ( #28909 )
...
This reverts commit 9f90e6d906
.
3 years ago
Mark D. Roth
9f90e6d906
Revert "Revert "Implement transparent retries ( #28548 )" ( #28888 )" ( #28890 )
...
* Revert "Revert "Implement transparent retries (#28548 )" (#28888 )"
This reverts commit 35708ff6b4
.
* disable retries for ALTS handshaker channel
3 years ago
Mark D. Roth
35708ff6b4
Revert "Implement transparent retries ( #28548 )" ( #28888 )
...
This reverts commit 7f8f3dc001
.
3 years ago
Ashitha Santhosh
1fee3d72be
remove SDK term from gRPC authz ( #28843 )
3 years ago
Mark D. Roth
7f8f3dc001
Implement transparent retries ( #28548 )
...
* transport: add error attributes indicating stream network state
* add missing case
* transparent retries
* don't use backoff timer for transparent retries
* fix build
* add retry_transparent_not_sent_on_wire test
* add retry_transparent_goaway test
* remove special case to short-circuit retry code if no retry policy
* clang-format
* buildifier
* simplify logic a bit
* get StreamNetworkState from metadata instead of error
* fix api_fuzzer to always start recv_trailing_metadata_ready
* clang-format
* fix test flakiness in proxy fixture
* add test with MAX_CONCURRENT_STREAMS
* don't transparently retry if we're already committed
* fix test to not reuse byte buffers
* clang-format
* disable retries for streams_not_seen_test
3 years ago
yihuaz
b458db9246
Eliminate gRPC insecure build ( #25586 )
...
* force submit
* fix test error
* remove is_client from local tsi and its callsites
* fix too_many_pings_test
* add missing dep
3 years ago
Vignesh Babu
9b42785db2
Removing Te metadata key-value pairs sent through initial or trailing metadata ( #28774 )
...
* Removing invalid Te metadata sent through initial or final metadata
* tidying up code to unlaterally remove Te metadata
3 years ago
Esun Kim
92738290ab
Upgrade base-builder to the latest for blaze build ( #28768 )
...
* Upgrade base-builder to the latest for blaze build
* Fix warnings.
* Added -Wno-deprecated-copy
3 years ago
Vignesh Babu
9317838084
updating ChooseLbPolicy to revert to pick_first lb_policy if an unsupported lb_policy is passed through channel_args ( #28651 )
...
* updating ChooseLbPolicy to revert to pick_first lb_policy if an unsupported lb_policy is passed through channel_args
* addressing review comments
* updating comment
* adding check to ensure policy_name is not nullptr
* initializing bool variable to avoid ubsan errors
3 years ago
Mark D. Roth
2c4ae04e06
retry: fix memory leak caused by incorrectly replaying recv_message ops ( #28718 )
3 years ago
Vignesh Babu
ff0ecd2ff4
sockaddr resolver: skip empty addresses in target URI ( #28695 )
...
* Adding constraints to the number of parsed targets in a specified URI to prevent OOMs
* removing hard limit on number of addresses in target uri
3 years ago
Craig Tiller
d02a68016e
Channel stack builder name needs to be static ( #28711 )
...
* Channel stack builder name needs to be static for stream refcount tracing
* Add test
3 years ago
Craig Tiller
e4107caf26
c++-ize channel stack builder ( #28660 )
...
* c++-ize channel stack builder
* Automated change: Fix sanity tests
* Automated change: Fix sanity tests
* fixes
* comment
* move functions out of line
* Automated change: Fix sanity tests
* review feedback
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Craig Tiller
17c6a486cd
Expose promise-ness to filter proper ( #28658 )
...
* Expose promise-ness to filter proper
* Make transports able to export promises too
* Add make promise op to transport
3 years ago