Yijie Ma
f99b8b5bc4
Convert c-style comments to C++-style comments ( #31923 )
...
* baseline
* fix clang-tidy
* manually revert these files
* manually fixup at eof
* revert 2 more files
* change check_deprecated_grpc++.py
* change end2end_defs.include template
* fix check_include_guards.py
* untrack tools/distrib/python/convert_cstyle_comments_to_cpp.py
not yet ready to be submitted
* fix
yapf check_include_guards.py
remove a space...
* fix version.cc.template
* fix version_info.h.template
2 years ago
Cheng-Yu Chung
4ba0f9afb5
Revert "Revert "Remove `include/grpcpp/impl/codegen/client_callback.h` ( #31005 )" ( #31079 )" ( #31087 )
...
This reverts commit da08fe1d6f
.
2 years ago
Craig Tiller
da08fe1d6f
Revert "Remove `include/grpcpp/impl/codegen/client_callback.h` ( #31005 )" ( #31079 )
...
This reverts commit 17f515744f
.
2 years ago
Cheng-Yu Chung
17f515744f
Remove `include/grpcpp/impl/codegen/client_callback.h` ( #31005 )
2 years ago
AJ Heller
85189b24bb
Reintroduce: Avoid fully qualifying namespaces (and add check) ( #28917 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
AJ Heller
e72a5fe5dd
Revert "Avoid fully qualifying namespaces (and add check) ( #28901 )" ( #28916 )
...
This reverts commit fc7314c701
.
3 years ago
AJ Heller
fc7314c701
Avoid fully qualifying namespaces (and add check) ( #28901 )
...
Based on a handful of https://abseil.io/tips , it's generally advised to
only fully-qualify namespaces when in a `using` statement, or when it's
otherwise required for compilation. In all other cases, the general
recommendation is to not fully-qualify.
This change fixes most `grpc.*` namespace uses. There are potential
challenges in trying to make blanket changes to non-gRPC namespace uses,
such as `::testing`, since there is also a `grpc::testing` namespace.
3 years ago
Craig Tiller
28316341bf
Annotate impl/codegen with IWYU pragmas ( #27252 )
...
* Add a tool to annotate impl/codegen with IWYU pragmas
* xx
* oops
* fmt
* x
* fix wrong direction bug
* use defaultdict
* better annotations
* better annotations
* Automated change: Fix sanity tests
Co-authored-by: ctiller <ctiller@users.noreply.github.com>
3 years ago
Vijay Pai
3e19babc1e
Remove all possible traces of grpc::experimental for callback API ( #26584 )
3 years ago
Vijay Pai
153bc67f45
Revert "Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" ( #26365 )" ( #26375 )" ( #26379 )
...
This reverts commit 259a74c0e6
.
4 years ago
Yash Tibrewal
259a74c0e6
Revert "Revert "Revert "Expose trailers-only response status through C++ callback API"" ( #26365 )" ( #26375 )
...
This reverts commit 66253c521a
.
4 years ago
Vijay Pai
66253c521a
Revert "Revert "Expose trailers-only response status through C++ callback API"" ( #26365 )
...
* Revert "Revert "Expose trailers-only response status through C++ callback API (#26249 )" (#26363 )"
This reverts commit 05c3b30ea0
.
* Move the trailers_only check from ClientContext to ClientReactor
* Remove unneeded change in client_context.cc
4 years ago
Yash Tibrewal
05c3b30ea0
Revert "Expose trailers-only response status through C++ callback API ( #26249 )" ( #26363 )
...
This reverts commit 393bae7e88
.
4 years ago
Vijay Pai
393bae7e88
Expose trailers-only response status through C++ callback API ( #26249 )
...
* Expose trailers-only response status through callback API
* Fix change-detector test
* Address reviewer comment about trailers_only headers
* Add TODO requested by markdroth
* Move variable in struct to improve space efficiency
* Don't instantiate ExecCtx in channel_args destructor unless needed
4 years ago
Vijay Pai
dae5624e47
Thread annotations for C++ callback API headers ( #25571 )
...
* Annotate headers
* clang-format
4 years ago
Vijay Pai
26e4c14b1e
Add virtual destructor to ClientReactor base class ( #25599 )
...
* Add virtual destructor
* Remove subclass empty destructors
4 years ago
Vijay Pai
909cac3866
Document reaction concurrency and reactor lifetime ( #25481 )
4 years ago
Esun Kim
decc199ca8
Fix by clang-tidy
4 years ago
Vijay Pai
476743786b
Also reduce templating for ClientUnaryReactor
4 years ago
Esun Kim
34789b2d83
Fix by clang-format-8.
4 years ago
Vijay Pai
7e72bba162
Reduce templating for unary callback client RPC
4 years ago
Karthik Ravi Shankar
67667eb7b6
Revert ...
4 years ago
Vijay Pai
62e01dd922
Add non-experimental:: versions under ifdef
5 years ago
Vijay Pai
94a8c5888a
Remove namespace experimental from namespace grpc_impl
5 years ago
Moiz Haidry
d8c0182360
Expose some of the internal codegen interfaces
5 years ago
Moiz Haidry
bf994e48d9
Move grpc async, callback and sync implementation to grpc_impl namespace
5 years ago
Moiz Haidry
1c354e7c1f
Move grpc async, callback and sync implementation to grpc_impl namespace
5 years ago
Karthik Ravi Shankar
8b91dc5fd2
Move more of usage to grpc_impl
...
1) Create server_context_impl and completion_queue_impl headers.
2) Move more of usage of ClientContext, ServerContext to grpc_impl
6 years ago
Moiz Haidry
3ce20819cf
Modify codegen to use grpc_impl namespace and other cleanups
6 years ago
Soheil Hassas Yeganeh
85f08100d4
Avoid using seq_cst atomic operations in grpcpp when unnecessary.
...
These cases are almost all in the callback API.
Also use atomic<intptr_t> insteda of atomic_int for consistency with
gpr_atm and grpc_core::Atomic.
6 years ago
Karthik Ravi Shankar
7e18e6cf3f
Fix clang errors.
6 years ago
Karthik Ravi Shankar
522ddfe273
Move ClientContext to grpc_impl
...
ClientContext is another file which needs to be moved from grpc to
grpc_impl for referencing it.
6 years ago
Karthik Ravi Shankar
03b079499c
Move CompletionQueue and Channel
6 years ago
Karthik Ravi Shankar
40210d3b8a
Move Channel to grpc_impl
6 years ago
Karthik Ravi Shankar
772a74aced
Revert changes to Channel
6 years ago
Karthik Ravi Shankar
6be0b06c69
Revert "Fold CompletionQueue and ServerCompletionQueue into grpc_impl"
6 years ago
Hope Casey-Allen
3433749d1b
Add clarification to callback API documentation
6 years ago
Vijay Pai
20c08dbc7a
Add client-side unary reactor model
6 years ago
Karthik Ravi Shankar
62fb156122
Fold CompletionQueue and ServerCompletionQueue into grpc_impl
6 years ago
Karthik Ravi Shankar
973fa6950e
Fold Channel into grpc_impl from grpc namespace
6 years ago
Karthik Ravi Shankar
dad3f34207
Revert "Revert "Revert "Folding the Channel class into the grpc_impl namespace."""
6 years ago
Karthik Ravi Shankar
891b6cf7ae
Revert "Folding CompletionQueue and ServerCompletionQueue."
6 years ago
Vijay Pai
9169159f30
Comments for all callback API methods
6 years ago
Vijay Pai
48ce4ca939
Add support for extra-reaction operations via Holds
6 years ago
Nicolas Noble
91ad888497
Revert "Revert "Folding the Channel class into the grpc_impl namespace.""
6 years ago
Vijay Pai
147c61b2a4
Exclude StartCall from starting callback counter value
6 years ago
Nicolas Noble
2ad245cb0c
Revert "Folding the Channel class into the grpc_impl namespace."
6 years ago
Nicolas "Pixel" Noble
12b0db3e57
Folding CompletionQueue and ServerCompletionQueue.
6 years ago
Nicolas "Pixel" Noble
2fd079ff7c
Channel folding.
6 years ago
Yash Tibrewal
361acdbed1
Use the WriteOptions in Client Callback API
6 years ago