From 85570890f86f7bb011fbc6934f113bd47e99a0d9 Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Fri, 20 Apr 2018 12:52:55 +0200 Subject: [PATCH 1/2] remove C# global.json files --- examples/csharp/helloworld-from-cli/global.json | 5 ----- src/csharp/global.json | 5 ----- 2 files changed, 10 deletions(-) delete mode 100644 examples/csharp/helloworld-from-cli/global.json delete mode 100644 src/csharp/global.json diff --git a/examples/csharp/helloworld-from-cli/global.json b/examples/csharp/helloworld-from-cli/global.json deleted file mode 100644 index e4b797ee8ef..00000000000 --- a/examples/csharp/helloworld-from-cli/global.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "sdk": { - "version": "1.0.0" - } -} diff --git a/src/csharp/global.json b/src/csharp/global.json deleted file mode 100644 index 815be4bfb90..00000000000 --- a/src/csharp/global.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "sdk": { - "version": "2.1.4" - } -} From f723164e3ebfd95673d03dc495ca366a2283b32d Mon Sep 17 00:00:00 2001 From: Jan Tattermusch Date: Fri, 20 Apr 2018 14:52:53 +0200 Subject: [PATCH 2/2] new mono versions on MacOS default to 64bit runtime --- src/csharp/Grpc.Core/NativeDeps.Mac.csproj.include | 8 -------- tools/run_tests/run_tests.py | 6 +++--- 2 files changed, 3 insertions(+), 11 deletions(-) diff --git a/src/csharp/Grpc.Core/NativeDeps.Mac.csproj.include b/src/csharp/Grpc.Core/NativeDeps.Mac.csproj.include index f1b85c3730e..309e33d47ed 100644 --- a/src/csharp/Grpc.Core/NativeDeps.Mac.csproj.include +++ b/src/csharp/Grpc.Core/NativeDeps.Mac.csproj.include @@ -1,13 +1,5 @@ - - - libgrpc_csharp_ext.x86.dylib - PreserveNewest - false - libgrpc_csharp_ext.x64.dylib PreserveNewest diff --git a/tools/run_tests/run_tests.py b/tools/run_tests/run_tests.py index 4146eec42df..6fb0f89381f 100755 --- a/tools/run_tests/run_tests.py +++ b/tools/run_tests/run_tests.py @@ -921,9 +921,6 @@ class CSharpLanguage(object): if self.platform == 'mac': # TODO(jtattermusch): EMBED_ZLIB=true currently breaks the mac build self._make_options = ['EMBED_OPENSSL=true'] - if self.args.compiler != 'coreclr': - # On Mac, official distribution of mono is 32bit. - self._make_options += ['ARCH_FLAGS=-m32', 'LDFLAGS=-m32'] else: self._make_options = ['EMBED_OPENSSL=true', 'EMBED_ZLIB=true'] @@ -944,6 +941,9 @@ class CSharpLanguage(object): assembly_subdir += '/net45' if self.platform == 'windows': runtime_cmd = [] + elif self.platform == 'mac': + # mono before version 5.2 on MacOS defaults to 32bit runtime + runtime_cmd = ['mono', '--arch=64'] else: runtime_cmd = ['mono']