From fe7140f2a227367a44a719451ed9362826824f2e Mon Sep 17 00:00:00 2001 From: Yash Tibrewal Date: Wed, 27 Oct 2021 12:39:40 -0700 Subject: [PATCH] grpc_server_config_fetcher cleanup (#27832) --- src/core/lib/surface/server.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/core/lib/surface/server.h b/src/core/lib/surface/server.h index e49026e43e3..3e1a4a9a0a0 100644 --- a/src/core/lib/surface/server.h +++ b/src/core/lib/surface/server.h @@ -464,12 +464,6 @@ struct grpc_server { grpc_core::OrphanablePtr core_server; }; -// TODO(roth): Eventually, will need a way to modify configuration even after -// a connection is established (e.g., to change things like L7 rate -// limiting, RBAC, and fault injection configs). One possible option -// would be to do something like ServiceConfig and ConfigSelector, but -// that might add unnecessary per-call overhead. Need to consider other -// approaches here. struct grpc_server_config_fetcher { public: class ConnectionManager : public grpc_core::RefCounted { @@ -494,7 +488,6 @@ struct grpc_server_config_fetcher { virtual ~grpc_server_config_fetcher() = default; - // Ownership of \a args is transferred. virtual void StartWatch(std::string listening_address, std::unique_ptr watcher) = 0; virtual void CancelWatch(WatcherInterface* watcher) = 0;