Comments

src/core/lib/iomgr/ev_epoll1_linux.cc

@@ -1244,5 +1244,5 @@ const grpc_event_engine_vtable* grpc_init_epoll1_linux(bool explicit_request) {
 const grpc_event_engine_vtable* grpc_init_epoll1_linux(bool explicit_request) {
   return nullptr;
 }
-#endif /* defined(GRPC_POSIX_SOCKET) */
+#endif /* defined(GRPC_POSIX_SOCKET_EV_EPOLL1) */
 #endif /* !defined(GRPC_LINUX_EPOLL) */

src/core/lib/iomgr/ev_epollex_linux.cc

@@ -1508,6 +1508,6 @@ const grpc_event_engine_vtable* grpc_init_epollex_linux(
     bool explicitly_requested) {
   return nullptr;
 }
-#endif /* defined(GRPC_POSIX_SOCKET) */
+#endif /* defined(GRPC_POSIX_SOCKET_EV_EPOLLEX) */
 
 #endif /* !defined(GRPC_LINUX_EPOLL_CREATE1) */

src/core/lib/iomgr/ev_poll_posix.cc

@@ -1761,4 +1761,4 @@ const grpc_event_engine_vtable* grpc_init_poll_cv_posix(bool explicit_request) {
   return &vtable;
 }
 
-#endif
+#endif /* GRPC_POSIX_SOCKET_EV_POLL */

src/core/lib/iomgr/polling_entity.cc

@@ -61,9 +61,12 @@ bool grpc_polling_entity_is_empty(const grpc_polling_entity* pollent) {
 void grpc_polling_entity_add_to_pollset_set(grpc_polling_entity* pollent,
                                             grpc_pollset_set* pss_dst) {
   if (pollent->tag == GRPC_POLLS_POLLSET) {
-    if (pollent->pollent.pollset != nullptr) {
+#ifdef GRPC_CFSTREAM
-      grpc_pollset_set_add_pollset(pss_dst, pollent->pollent.pollset);
+    GPR_ASSERT(pollent->pollent.pollset == nullptr);
-    }
+#else
+    GPR_ASSERT(pollent->pollent.pollset != nullptr);
+    grpc_pollset_set_add_pollset(pss_dst, pollent->pollent.pollset);
+#endif
   } else if (pollent->tag == GRPC_POLLS_POLLSET_SET) {
     GPR_ASSERT(pollent->pollent.pollset_set != nullptr);
     grpc_pollset_set_add_pollset_set(pss_dst, pollent->pollent.pollset_set);
@@ -76,9 +79,12 @@ void grpc_polling_entity_add_to_pollset_set(grpc_polling_entity* pollent,
 void grpc_polling_entity_del_from_pollset_set(grpc_polling_entity* pollent,
                                               grpc_pollset_set* pss_dst) {
   if (pollent->tag == GRPC_POLLS_POLLSET) {
-    if (pollent->pollent.pollset != nullptr) {
+#ifdef GRPC_CFSTREAM
-      grpc_pollset_set_del_pollset(pss_dst, pollent->pollent.pollset);
+    GPR_ASSERT(pollent->pollent.pollset == nullptr);
-    }
+#else
+    GPR_ASSERT(pollent->pollent.pollset != nullptr);
+    grpc_pollset_set_del_pollset(pss_dst, pollent->pollent.pollset);
+#endif
   } else if (pollent->tag == GRPC_POLLS_POLLSET_SET) {
     GPR_ASSERT(pollent->pollent.pollset_set != nullptr);
     grpc_pollset_set_del_pollset_set(pss_dst, pollent->pollent.pollset_set);

src/core/lib/iomgr/tcp_posix.cc

@@ -811,4 +811,4 @@ void grpc_tcp_destroy_and_release_fd(grpc_endpoint* ep, int* fd,
   TCP_UNREF(tcp, "destroy");
 }
 
-#endif
+#endif /* GRPC_POSIX_SOCKET_TCP */

src/core/lib/iomgr/tcp_server_posix.cc

@@ -558,4 +558,4 @@ grpc_tcp_server_vtable grpc_posix_tcp_server_vtable = {
     tcp_server_shutdown_starting_add,
     tcp_server_unref,
     tcp_server_shutdown_listeners};
-#endif
+#endif /* GRPC_POSIX_SOCKET_TCP_SERVER */

src/core/lib/iomgr/tcp_server_utils_posix_common.cc

@@ -205,4 +205,4 @@ error:
   return ret;
 }
 
-#endif /* GRPC_POSIX_SOCKET */
+#endif /* GRPC_POSIX_SOCKET_TCP_SERVER_UTILS_COMMON */

src/core/lib/transport/transport.cc

@@ -184,7 +184,11 @@ void grpc_transport_set_pops(grpc_transport* transport, grpc_stream* stream,
              nullptr) {
     transport->vtable->set_pollset_set(transport, stream, pollset_set);
   } else {
-    // No-op for empty pollset
+#ifdef GRPC_CFSTREAM
+  // No-op for empty pollset
+#else
+    abort();
+#endif
   }
 }
 

src/objective-c/GRPCClient/private/GRPCCompletionQueue.m

@@ -43,7 +43,6 @@ const grpc_completion_queue_attributes kCompletionQueueAttr = {
   if ((self = [super init])) {
     _unmanagedQueue = grpc_completion_queue_create(
         grpc_completion_queue_factory_lookup(&kCompletionQueueAttr), &kCompletionQueueAttr, NULL);
-    //_unmanagedQueue = grpc_completion_queue_create_for_next(NULL);
 
     // This is for the following block to capture the pointer by value (instead
     // of retaining self and doing self->_unmanagedQueue). This is essential