From fe4a121a05043c74474662c833e7aef968193960 Mon Sep 17 00:00:00 2001
From: Luwei Ge <lwge@google.com>
Date: Thu, 2 Nov 2023 22:21:18 +0000
Subject: [PATCH] remove invalid enum tests which are failing ubsan

---
 test/cpp/client/credentials_test.cc | 14 --------------
 test/cpp/server/credentials_test.cc | 28 ----------------------------
 2 files changed, 42 deletions(-)

diff --git a/test/cpp/client/credentials_test.cc b/test/cpp/client/credentials_test.cc
index 639076102d8..edf78b44f12 100644
--- a/test/cpp/client/credentials_test.cc
+++ b/test/cpp/client/credentials_test.cc
@@ -508,20 +508,6 @@ TEST(CredentialsTest, TlsChannelCredentialsWithGoodMinAndMaxTlsVersions) {
   EXPECT_NE(channel_credentials, nullptr);
 }
 
-TEST(CredentialsTest, TlsChannelCredentialsWithMinTlsVersions) {
-  grpc::experimental::TlsChannelCredentialsOptions options;
-  options.set_min_tls_version(static_cast<grpc_tls_version>(-1));
-  auto channel_credentials = grpc::experimental::TlsCredentials(options);
-  EXPECT_EQ(channel_credentials, nullptr);
-}
-
-TEST(CredentialsTest, TlsChannelCredentialsWithMaxTlsVersions) {
-  grpc::experimental::TlsChannelCredentialsOptions options;
-  options.set_max_tls_version(static_cast<grpc_tls_version>(2));
-  auto channel_credentials = grpc::experimental::TlsCredentials(options);
-  EXPECT_EQ(channel_credentials, nullptr);
-}
-
 TEST(CredentialsTest, TlsChannelCredentialsWithBadMinAndMaxTlsVersions) {
   grpc::experimental::TlsChannelCredentialsOptions options;
   options.set_min_tls_version(grpc_tls_version::TLS1_3);
diff --git a/test/cpp/server/credentials_test.cc b/test/cpp/server/credentials_test.cc
index d5754634aa0..69a9a8f46dd 100644
--- a/test/cpp/server/credentials_test.cc
+++ b/test/cpp/server/credentials_test.cc
@@ -294,34 +294,6 @@ TEST(
   EXPECT_NE(server_credentials, nullptr);
 }
 
-TEST(CredentialsTest, TlsServerCredentialsWithMinTlsVersions) {
-  experimental::IdentityKeyCertPair key_cert_pair;
-  key_cert_pair.private_key = kIdentityCertPrivateKey;
-  key_cert_pair.certificate_chain = kIdentityCertContents;
-  std::vector<experimental::IdentityKeyCertPair> identity_key_cert_pairs;
-  identity_key_cert_pairs.emplace_back(key_cert_pair);
-  auto certificate_provider = std::make_shared<StaticDataCertificateProvider>(
-      kRootCertContents, identity_key_cert_pairs);
-  grpc::experimental::TlsServerCredentialsOptions options(certificate_provider);
-  options.set_min_tls_version(static_cast<grpc_tls_version>(-1));
-  auto server_credentials = grpc::experimental::TlsServerCredentials(options);
-  EXPECT_EQ(server_credentials, nullptr);
-}
-
-TEST(CredentialsTest, TlsServerCredentialsWithMaxTlsVersions) {
-  experimental::IdentityKeyCertPair key_cert_pair;
-  key_cert_pair.private_key = kIdentityCertPrivateKey;
-  key_cert_pair.certificate_chain = kIdentityCertContents;
-  std::vector<experimental::IdentityKeyCertPair> identity_key_cert_pairs;
-  identity_key_cert_pairs.emplace_back(key_cert_pair);
-  auto certificate_provider = std::make_shared<StaticDataCertificateProvider>(
-      kRootCertContents, identity_key_cert_pairs);
-  grpc::experimental::TlsServerCredentialsOptions options(certificate_provider);
-  options.set_max_tls_version(static_cast<grpc_tls_version>(2));
-  auto server_credentials = grpc::experimental::TlsServerCredentials(options);
-  EXPECT_EQ(server_credentials, nullptr);
-}
-
 TEST(
     CredentialsTest,
     TlsChannelCredentialsWithStaticDataCertificateProviderAndBadMinMaxTlsVersions) {