From fe3ca486bc3f65d32db91de4c06a7ba4d7e07df0 Mon Sep 17 00:00:00 2001 From: Mehrdad Afshari Date: Tue, 19 Dec 2017 09:16:26 -0800 Subject: [PATCH] Fix check_submodules.sh to pass shellcheck --- tools/run_tests/sanity/check_submodules.sh | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/run_tests/sanity/check_submodules.sh b/tools/run_tests/sanity/check_submodules.sh index b573d21f4fd..ca604c6e528 100755 --- a/tools/run_tests/sanity/check_submodules.sh +++ b/tools/run_tests/sanity/check_submodules.sh @@ -19,13 +19,13 @@ set -e export TEST=true -cd `dirname $0`/../../.. +cd "$(dirname "$0")/../../.." -submodules=`mktemp /tmp/submXXXXXX` -want_submodules=`mktemp /tmp/submXXXXXX` +submodules=$(mktemp /tmp/submXXXXXX) +want_submodules=$(mktemp /tmp/submXXXXXX) -git submodule | awk '{ print $1 }' | sort > $submodules -cat << EOF | awk '{ print $1 }' | sort > $want_submodules +git submodule | awk '{ print $1 }' | sort > "$submodules" +cat << EOF | awk '{ print $1 }' | sort > "$want_submodules" 5b7683f49e1e9223cf9927b24f6fd3d6bd82e3f8 third_party/benchmark (v1.2.0) be2ee342d3781ddb954f91f8a7e660c6f59e87e5 third_party/boringssl (heads/chromium-stable) 886e7d75368e3f4fab3f4d0d3584e4abfc557755 third_party/boringssl-with-bazel (version_for_cocoapods_7.0-857-g886e7d7) @@ -38,6 +38,6 @@ cat << EOF | awk '{ print $1 }' | sort > $want_submodules cc4bed2d74f7c8717e31f9579214ab52a9c9c610 third_party/abseil-cpp EOF -diff -u $submodules $want_submodules +diff -u "$submodules" "$want_submodules" -rm $submodules $want_submodules +rm "$submodules" "$want_submodules"