Merge pull request #10556 from murgatroid99/node_windows_warning_fix

Fix Windows warning in binding.gyp for Win10 console
8 years ago · f883021bbd
parent e3683cadd3 025f110ed2
commit f883021bbd
2 changed files with 6 additions and 4 deletions
--- a/binding.gyp
+++ b/binding.gyp
@ -519,9 +519,10 @@
          # the OpenSSL headers, from the downloaded Node development package,
          # which is typically located in `.node-gyp` in your home directory.
          'target_name': 'WINDOWS_BUILD_WARNING',
-          'actions': [
+          'rules': [
            {
-              'action_name': 'WINDOWS_BUILD_WARNING',
+              'rule_name': 'WINDOWS_BUILD_WARNING',
+              'extension': 'S',
              'inputs': [
                'package.json'
              ],
--- a/templates/binding.gyp.template
+++ b/templates/binding.gyp.template
@ -217,9 +217,10 @@
            # the OpenSSL headers, from the downloaded Node development package,
            # which is typically located in `.node-gyp` in your home directory.
            'target_name': 'WINDOWS_BUILD_WARNING',
-            'actions': [
+            'rules': [
              {
-                'action_name': 'WINDOWS_BUILD_WARNING',
+                'rule_name': 'WINDOWS_BUILD_WARNING',
+                'extension': 'S',
                'inputs': [
                  'package.json'
                ],